@linxin666/dsh-client-ui-task-board 0.4.5 → 0.4.7

package/src/client/board/TaskDetail.tsx

@@ -9,13 +9,13 @@ import type { BoardController, ControllerSnapshot } from '../../core/controller.
 import type { TaskBoardExtensionActionRequest, TaskBoardExtensionDispatch } from '../../core/extension.ts'
 import { useTaskBoardSeats } from '../seats.tsx'
 import { isValidCron } from '../../core/schedule.ts'
-import { MANUAL_STATUSES, TASK_PERMISSIONS, canMoveTask, hasOpenExecution, tagTone, type ExecutionRecord, type TaskPermission, type TaskRecord } from '../../core/tasks.ts'
+import { MANUAL_STATUSES, TASK_PERMISSIONS, canMoveTask, hasOpenExecution, tagTone, type ExecutionRecord, type ScheduleMode, type TaskPermission, type TaskRecord } from '../../core/tasks.ts'
 import { canEditTaskContent } from '../../core/use-cases/task-update.ts'
 import { requiresPermissionConfirmation } from '../../core/handover.ts'
-import { DEFAULT_SUBTASK_DEPTH, directSubtasks, taskDepth } from '../../core/subtask.ts'
+import { DEFAULT_SUBTASK_DEPTH, directSubtasks, joinsCascadeRun, taskDepth } from '../../core/subtask.ts'
 import { t, type TaskBoardKey } from '../locales.ts'
 import { SCHEDULE_PRESETS } from '../schedule-presets.ts'
-import { nextRunLabel, zoneChoices } from '../schedule-zone.ts'
+import { budgetLabel, defaultZonedInputValue, endedLabel, nextRunLabel, parseZonedInput, runCapOption, skippedLabel, zonedInputValue, zoneChoices } from '../schedule-zone.ts'
 import css from '../board.module.css'
 import { ConfirmDialog } from './ConfirmDialog.tsx'
 import { EditTaskModal, EditTagsModal } from './EditTaskModal.tsx'
@@ -24,6 +24,8 @@ import { LinkSubtaskModal } from './LinkSubtaskModal.tsx'
 import { NewTaskModal } from './NewTaskModal.tsx'
 import { useDialog, usePresence, type OverlayPhase } from './overlay.tsx'
 import { inheritPresetLabel, presetLabel } from './preset-label.ts'
+import { ReasoningEffortField } from './ReasoningEffortField.tsx'
+import { reconcileReasoningEffort } from './model-options.ts'
 import { formatHostTimestamp, formatTime } from './TaskCard.tsx'
 import { STATUS_KEY } from './status-key.ts'
 import { VerificationReport } from './VerificationReport.tsx'
@@ -39,8 +41,12 @@ const RESULT_KEY: Record<NonNullable<ExecutionRecord['result']>, TaskBoardKey> =
 /** One execution-history row. */
 function ExecutionRow({ execution, timeZone, onOpen }: { execution: ExecutionRecord; timeZone?: string; onOpen: (sessionId: string) => void }) {
   const result = execution.result
+  // An external record is one the Host never observed running: no session, no
+  // spinner, and a named outside agent instead of the initiating session. The
+  // data attribute keeps the distinction machine-readable too.
+  const external = execution.external === true
   return (
-    <li className={css.executionRow} data-result={result}>
+    <li className={css.executionRow} data-result={result} data-external={external ? 'true' : undefined}>
       <span className={css.executionBadge} data-result={result}>
         {result === undefined ? t('detail.result.running') : t(RESULT_KEY[result])}
       </span>
@@ -48,7 +54,12 @@ function ExecutionRow({ execution, timeZone, onOpen }: { execution: ExecutionRec
         {t('detail.executionStarted')} {formatTime(execution.startedAt, timeZone)}
         {execution.endedAt !== undefined && ` · ${t('detail.executionEnded')} ${formatTime(execution.endedAt, timeZone)}`}
       </span>
-      {execution.initiatedBy !== undefined && (
+      {external && execution.initiatedBy !== undefined && (
+        <span className={css.executionTimes} title={execution.initiatedBy}>
+          {t('detail.execution.external', { agent: execution.initiatedBy })}
+        </span>
+      )}
+      {!external && execution.initiatedBy !== undefined && (
         <span className={css.executionTimes} title={execution.initiatedBy}>
           {t('detail.execution.initiator', { session: execution.initiatedBy })}
         </span>
@@ -73,7 +84,7 @@ function ExecutionRow({ execution, timeZone, onOpen }: { execution: ExecutionRec
 }
 
 /** The execution-target editor: workspace / mode / permission pickers. */
-function ExecutionSettingsSection({ controller, task, pending, executionOptions, teamRunAvailable }: {
+function ExecutionSettingsSection({ controller, task, pending, executionOptions, teamRunAvailable, goalRunEnabled }: {
   controller: BoardController
   task: TaskRecord
   pending: boolean
@@ -81,18 +92,26 @@ function ExecutionSettingsSection({ controller, task, pending, executionOptions,
   executionOptions: ControllerSnapshot['executionOptions']
   /** Whether this deployment serves the Agent Teams service. */
   teamRunAvailable: boolean
+  /**
+   * Live GLOBAL native-/goal switch. It only decides whether the card's own
+   * preference takes effect: the option stays operable while it is off, the
+   * stored value is never rewritten by it, and the explanation below says so.
+   */
+  goalRunEnabled: boolean
 }) {
   const options = executionOptions
+  const models = options.models ?? []
   const workspaceId = task.workspaceId ?? ''
   const mode = task.mode ?? ''
   const permission = task.permission ?? ''
   const model = task.model ?? ''
+  const reasoningEffort = task.reasoningEffort ?? ''
   // A pinned target may disappear from the runtime (workspace deleted,
   // preset removed); keep it selectable as a stale row instead of silently
   // dropping it, so the user sees exactly what the task will ask for.
   const workspaceKnown = workspaceId === '' || options.workspaces.some(item => item.workspaceId === workspaceId)
   const modeKnown = mode === '' || options.presets.some(item => item.id === mode)
-  const modelKnown = model === '' || (options.models ?? []).some(item => item.id === model)
+  const modelKnown = model === '' || models.some(item => item.id === model)
   return (
     <section className={css.detailSection}>
       <h4>{t('detail.executionSettings')}</h4>
@@ -151,15 +170,35 @@ function ExecutionSettingsSection({ controller, task, pending, executionOptions,
           className={css.select}
           value={model}
           disabled={pending}
-          onChange={event => { controller.updateTask(task.id, { model: event.target.value === '' ? undefined : event.target.value }) }}
+          onChange={event => {
+            // The effort is part of this pin: switching to a model that cannot
+            // honor the stored level clears it in the same action instead of
+            // leaving a value the next run would have to reject. The empty
+            // string carries a clear across the JSON transport, where an
+            // `undefined` value would lose the key entirely; the ledger
+            // normalizes blank targets back to "pinned nothing".
+            const next = event.target.value
+            const effort = reconcileReasoningEffort(models, next, reasoningEffort)
+            controller.updateTask(task.id, {
+              model: next,
+              ...(effort === reasoningEffort ? {} : { reasoningEffort: effort }),
+            })
+          }}
         >
           <option value="">{t('exec.model.default')}</option>
           {!modelKnown && <option value={model}>{model}{t('exec.model.unknown')}</option>}
-          {options.models?.map(item => (
+          {models.map(item => (
             <option key={item.id} value={item.id}>{item.name ?? item.id}</option>
           ))}
         </select>
       </label>
+      <ReasoningEffortField
+        models={models}
+        modelId={model}
+        value={reasoningEffort}
+        pending={pending}
+        onChange={effort => { controller.updateTask(task.id, { reasoningEffort: effort }) }}
+      />
       <label className={css.scheduleToggle}>
         <input
           type="checkbox"
@@ -173,13 +212,17 @@ function ExecutionSettingsSection({ controller, task, pending, executionOptions,
       <label className={css.scheduleToggle}>
         <input
           type="checkbox"
-          checked={task.goalRun !== false}
+          checked={task.goalRun === true}
+          // Always operable (only a pending execution locks it): the global
+          // switch decides whether the preference takes effect, never whether
+          // the user may state it, and it never rewrites what is stored here.
           disabled={pending}
           onChange={event => { controller.updateTask(task.id, { goalRun: event.target.checked }) }}
         />
         <span>{t('exec.goalRun')}</span>
       </label>
       <p className={css.detailText}>{t('exec.goalRunHint')}</p>
+      {!goalRunEnabled && <p className={css.detailText}>{t('settings.goalRunGlobalDisabledTaskOption')}</p>}
       <label className={css.scheduleToggle}>
         <input
           type="checkbox"
@@ -204,31 +247,49 @@ function ExecutionSettingsSection({ controller, task, pending, executionOptions,
   )
 }
 
-/** The scheduled-runs editor: enable toggle, cron input + presets, zone, next-run info. */
+/**
+ * The scheduled-runs editor. A one-shot has one planned instant; a recurring
+ * rule has a cron expression, an optional run cap, and a zone. The editor
+ * shows the rule's own state (next target, run counter, stop/skip record) and
+ * can cancel a future plan.
+ */
 function ScheduleSection({ controller, task, pending }: { controller: BoardController; task: TaskRecord; pending: boolean }) {
   const schedule = task.schedule
+  const hostTimeZone = controller.getSnapshot().host?.scheduler.timeZone
+  // The rule's own zone; '' means "follow the Host zone" (no stored zone).
+  const [zone, setZone] = useState<string>(schedule?.timeZone ?? '')
+  const [mode, setMode] = useState<ScheduleMode>(schedule?.mode ?? 'cron')
   const [cron, setCron] = useState(schedule?.cron ?? '0 9 * * *')
+  const [atText, setAtText] = useState<string>(() => schedule?.at === undefined
+    ? defaultZonedInputValue(Date.now(), schedule?.timeZone ?? hostTimeZone)
+    : zonedInputValue(schedule.at, schedule?.timeZone ?? hostTimeZone))
+  const [maxRunsChoice, setMaxRunsChoice] = useState<string>(() => runCapOption(schedule?.maxRuns))
+  const [maxRunsText, setMaxRunsText] = useState<string>(schedule?.maxRuns === undefined ? '' : String(schedule.maxRuns))
   const [enabled, setEnabled] = useState(schedule?.enabled ?? false)
   const [nextRunAt, setNextRunAt] = useState<number | undefined>(schedule?.nextRunAt)
   const [lastTriggeredAt, setLastTriggeredAt] = useState<number | undefined>(schedule?.lastTriggeredAt)
   const [error, setError] = useState<string | undefined>(undefined)
-  const hostTimeZone = controller.getSnapshot().host?.scheduler.timeZone
-  // The rule's own zone; '' means "follow the Host zone" (no stored zone).
-  const [zone, setZone] = useState<string>(schedule?.timeZone ?? '')
   // One clock reading per render pass, so the absolute and relative halves of
   // the label always describe the same instant.
   const now = Date.now()
 
   // Keep the editor in sync when the task record changes underneath (the
-  // schedule rolls forward as runs trigger).
+  // schedule rolls forward as runs trigger, ends at its budget, or is edited
+  // elsewhere).
   useEffect(() => {
+    setMode(schedule?.mode ?? 'cron')
     setCron(schedule?.cron ?? '0 9 * * *')
+    setZone(schedule?.timeZone ?? '')
+    setAtText(schedule?.at === undefined
+      ? defaultZonedInputValue(Date.now(), schedule?.timeZone ?? hostTimeZone)
+      : zonedInputValue(schedule.at, schedule?.timeZone ?? hostTimeZone))
+    setMaxRunsChoice(runCapOption(schedule?.maxRuns))
+    setMaxRunsText(schedule?.maxRuns === undefined ? '' : String(schedule.maxRuns))
     setEnabled(schedule?.enabled ?? false)
     setNextRunAt(schedule?.nextRunAt)
     setLastTriggeredAt(schedule?.lastTriggeredAt)
-    setZone(schedule?.timeZone ?? '')
     setError(undefined)
-  }, [task.id, schedule?.enabled, schedule?.cron, schedule?.timeZone, schedule?.nextRunAt, schedule?.lastTriggeredAt])
+  }, [task.id, hostTimeZone, schedule?.mode, schedule?.enabled, schedule?.cron, schedule?.at, schedule?.timeZone, schedule?.nextRunAt, schedule?.lastTriggeredAt, schedule?.maxRuns])
 
   /** Validate + persist the current cron text (Enter or blur). */
   const saveCron = (value: string): void => {
@@ -239,21 +300,101 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
       return
     }
     setError(undefined)
-    controller.setSchedule(task.id, { cron: trimmed })
+    controller.setSchedule(task.id, { mode: 'cron', cron: trimmed })
+  }
+
+  /** Validate + persist the one-shot's planned instant. */
+  const saveAt = (value: string): void => {
+    setAtText(value)
+    const at = parseZonedInput(value, effectiveZone)
+    if (at === undefined || at <= now) {
+      setError(t('detail.schedule.atInvalid'))
+      return
+    }
+    setError(undefined)
+    controller.setSchedule(task.id, { mode: 'once', at })
+  }
+
+  /** Switch the kind of plan, persisting a usable target for the new kind. */
+  const changeMode = (next: ScheduleMode): void => {
+    if (next === 'once') {
+      const at = parseZonedInput(atText, effectiveZone)
+      if (at === undefined || at <= now) {
+        setError(t('detail.schedule.atInvalid'))
+        return
+      }
+      setMode('once')
+      setError(undefined)
+      controller.setSchedule(task.id, { mode: 'once', at })
+      return
+    }
+    const trimmed = cron.trim()
+    if (trimmed === '' || !isValidCron(trimmed)) {
+      setError(t('detail.schedule.invalid'))
+      return
+    }
+    setMode('cron')
+    setError(undefined)
+    controller.setSchedule(task.id, { mode: 'cron', cron: trimmed })
   }
 
   /**
    * Change the rule's zone. `''` clears the stored zone, which is how a user
-   * returns a rule to following the Host zone.
+   * returns a rule to following the Host zone. A one-shot's instant is
+   * absolute, so only its rendered wall clock follows the new zone; a cron
+   * rule's wall clock itself moves with the zone.
    */
   const changeZone = (value: string): void => {
     setZone(value)
     setError(undefined)
+    if (mode === 'once' && schedule?.at !== undefined) {
+      setAtText(zonedInputValue(schedule.at, value === '' ? hostTimeZone : value))
+      controller.setSchedule(task.id, { mode: 'once', timeZone: value === '' ? null : value })
+      return
+    }
     controller.setSchedule(task.id, { timeZone: value === '' ? null : value })
   }
 
-  /** Arm/disarm the schedule (arming first persists the edited cron). */
+  /** Change the recurring rule's run cap (unlimited, a preset, or a custom value). */
+  const applyMaxRuns = (choice: string): void => {
+    setMaxRunsChoice(choice)
+    setError(undefined)
+    if (choice === 'unlimited') {
+      controller.setSchedule(task.id, { maxRuns: null })
+      return
+    }
+    if (choice === 'custom') {
+      setMaxRunsText(schedule?.maxRuns === undefined ? '' : String(schedule.maxRuns))
+      return
+    }
+    controller.setSchedule(task.id, { maxRuns: Number(choice) })
+  }
+
+  /** Persist a custom run cap; a non-positive or fractional value is refused. */
+  const saveCustomMaxRuns = (value: string): void => {
+    setMaxRunsText(value)
+    const parsed = Number(value.trim())
+    if (value.trim() === '' || !Number.isInteger(parsed) || parsed < 1) {
+      setError(t('detail.schedule.maxRunsInvalid'))
+      return
+    }
+    setError(undefined)
+    controller.setSchedule(task.id, { maxRuns: parsed })
+  }
+
+  /** Arm/disarm the schedule (arming first persists the edited plan). */
   const toggleEnabled = (next: boolean): void => {
+    if (next && mode === 'once') {
+      const at = parseZonedInput(atText, effectiveZone)
+      if (at === undefined || at <= now) {
+        setError(t('detail.schedule.atInvalid'))
+        return
+      }
+      setError(undefined)
+      const submitted = controller.setSchedule(task.id, { mode: 'once', at, enabled: true })
+      if (submitted && !controller.isHostBacked()) setEnabled(true)
+      return
+    }
     const trimmed = cron.trim()
     if (next && (trimmed === '' || !isValidCron(trimmed))) {
       setError(t('detail.schedule.invalid'))
@@ -267,11 +408,19 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
     if (submitted && !controller.isHostBacked()) setEnabled(next)
   }
 
+  /** Drop every future trigger without touching the card's execution history. */
+  const cancelSchedule = (): void => {
+    setError(undefined)
+    const submitted = controller.setSchedule(task.id, { enabled: false })
+    if (submitted && !controller.isHostBacked()) setEnabled(false)
+  }
+
   const applyPreset = (preset: string): void => {
     if (preset === '') return
     setCron(preset)
+    setMode('cron')
     setError(undefined)
-    controller.setSchedule(task.id, { cron: preset })
+    controller.setSchedule(task.id, { mode: 'cron', cron: preset })
   }
 
   // The zone the rule's wall clock is actually read in: its own when set,
@@ -286,6 +435,11 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
   // The rule's own stored zone rides the list even when this runtime's
   // inventory does not carry it, so opening the editor cannot rewrite it.
   const zones = zoneChoices(hostTimeZone, schedule?.timeZone)
+  // The ledger's own view of the budget and stop record: derived here rather
+  // than tracked in local state, so the display cannot drift from the Host.
+  const budget = schedule === undefined ? undefined : budgetLabel(schedule)
+  const ended = schedule === undefined ? undefined : endedLabel(schedule)
+  const skipped = schedule === undefined ? undefined : skippedLabel(schedule)
 
   return (
     <section className={css.detailSection}>
@@ -299,6 +453,35 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
         />
         <span>{t('detail.schedule.enable')}</span>
       </label>
+      <label className={css.scheduleZone}>
+        <span>{t('detail.schedule.mode')}</span>
+        <select
+          className={css.schedulePreset}
+          value={mode}
+          disabled={pending}
+          aria-label={t('detail.schedule.mode')}
+          onChange={event => { changeMode(event.target.value as ScheduleMode) }}
+        >
+          <option value="cron">{t('detail.schedule.mode.cron')}</option>
+          <option value="once">{t('detail.schedule.mode.once')}</option>
+        </select>
+      </label>
+      {mode === 'once' ? (
+        <label className={css.scheduleZone}>
+          <span>{t('detail.schedule.at')}</span>
+          <input
+            className={css.input}
+            type="datetime-local"
+            value={atText}
+            disabled={pending}
+            aria-label={t('detail.schedule.at')}
+            title={t('detail.schedule.atHint')}
+            onChange={event => { setAtText(event.target.value); setError(undefined) }}
+            onBlur={() => { saveAt(atText) }}
+          />
+        </label>
+      ) : (
+        <>
       <div className={css.scheduleRow}>
         <input
           className={`${css.input} ${css.scheduleInput}${error !== undefined ? ` ${css.scheduleInputInvalid}` : ''}`}
@@ -324,6 +507,39 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
           ))}
         </select>
       </div>
+          <label className={css.scheduleZone}>
+            <span>{t('detail.schedule.maxRuns')}</span>
+            <select
+              className={css.schedulePreset}
+              value={maxRunsChoice}
+              disabled={pending}
+              aria-label={t('detail.schedule.maxRuns')}
+              onChange={event => { applyMaxRuns(event.target.value) }}
+            >
+              <option value="unlimited">{t('detail.schedule.maxRunsUnlimited')}</option>
+              <option value="1">{t('detail.schedule.maxRunsValue', { count: '1' })}</option>
+              <option value="2">{t('detail.schedule.maxRunsValue', { count: '2' })}</option>
+              <option value="custom">{t('detail.schedule.maxRunsCustom')}</option>
+            </select>
+          </label>
+          {maxRunsChoice === 'custom' && (
+            <label className={css.scheduleZone}>
+              <span>{t('detail.schedule.maxRuns')}</span>
+              <input
+                className={css.input}
+                type="number"
+                min={1}
+                step={1}
+                value={maxRunsText}
+                disabled={pending}
+                aria-label={t('detail.schedule.maxRuns')}
+                onChange={event => { setMaxRunsText(event.target.value) }}
+                onBlur={() => { saveCustomMaxRuns(maxRunsText) }}
+              />
+            </label>
+          )}
+        </>
+      )}
       {/* A list is used instead of a free-text field so only zones the Host can
           also resolve are offered; the Host zone entry clears the stored value. */}
       <label className={css.scheduleZone}>
@@ -333,7 +549,7 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
           value={zone}
           disabled={pending}
           aria-label={t('detail.schedule.timeZone')}
-          title={t('detail.schedule.timeZoneHint')}
+          title={mode === 'once' ? t('detail.schedule.zoneOnceHint') : t('detail.schedule.timeZoneHint')}
           onChange={event => { changeZone(event.target.value) }}
         >
           {zones.map(choice => (
@@ -346,10 +562,30 @@ function ScheduleSection({ controller, task, pending }: { controller: BoardContr
         {t('detail.schedule.nextRun')} {nextLabel}
         {' · '}{t('detail.schedule.lastTriggered')} {lastLabel}
       </p>
+      {budget !== undefined && <p className={css.scheduleMeta}>{budget}</p>}
+      {ended !== undefined && <p className={css.scheduleMeta}>{ended}</p>}
+      {ended === undefined && skipped !== undefined && <p className={css.scheduleMeta}>{skipped}</p>}
+      {enabled && (
+        <button type="button" className={css.ghostButton} disabled={pending} onClick={cancelSchedule}>
+          {t('detail.schedule.cancel')}
+        </button>
+      )}
     </section>
   )
 }
 
+/**
+ * The run hint of one card: how many subtasks a run opens, counting the same
+ * members the Host will launch (`joinsCascadeRun` leaves a finished subtask
+ * alone), or why it opens none even though the card has subtasks.
+ */
+function subtaskRunHint(parentId: string, children: readonly TaskRecord[]): string {
+  const runnable = children.filter(child => joinsCascadeRun(child, parentId))
+  return runnable.length > 0
+    ? t('detail.subtasks.runHint', { count: String(runnable.length) })
+    : t('detail.subtasks.runHintSettled')
+}
+
 /**
  * The subtask block: the parent link, the direct subtasks with their status,
  * and the actions that grow or prune the tree. Every gate here mirrors the
@@ -420,7 +656,7 @@ function SubtaskSection({ controller, task, pending, archived, snapshot }: {
           </ul>
         )}
       {children.length > 0 && (
-        <p className={css.detailText}>{t('detail.subtasks.runHint', { count: String(children.length) })}</p>
+        <p className={css.detailText}>{subtaskRunHint(task.id, children)}</p>
       )}
       {!archived && (canAddChild
         ? (controller.isHostBacked()
@@ -611,6 +847,7 @@ export function TaskDetail({ controller, task, phase = 'open' }: { controller: B
                 pending={pending}
                 executionOptions={snapshot.executionOptions}
                 teamRunAvailable={snapshot.host?.teamRunAvailable === true}
+                goalRunEnabled={snapshot.host?.goalRunEnabled === true}
               />
               <ScheduleSection controller={controller} task={current} pending={pending} />
             </>
@@ -693,7 +930,7 @@ export function TaskDetail({ controller, task, phase = 'open' }: { controller: B
               className={css.primaryButton}
               disabled={busy || pending}
               title={subtaskChildren.length > 0
-                ? t('detail.subtasks.runHint', { count: String(subtaskChildren.length) })
+                ? subtaskRunHint(current.id, subtaskChildren)
                 : undefined}
               onClick={() => {
                 void controller.rerunTask(current.id).then(() => {