@linktr.ee/messaging-react 3.29.1-rc-1785477229 → 3.29.1

package/dist/index.d.ts

@@ -404,9 +404,9 @@ export declare interface ChannelViewProps {
      */
     onBroadcastClick?: BroadcastClickHandler;
     /**
-     * Resolves the current campaign name for a broadcast label. The host may
-     * keep this resolver stable when its backing cache changes; ChannelView
-     * re-invokes it on render and publishes changed names to memoized rows. The
+     * Resolves the current campaign name for a broadcast label. The host must
+     * provide a new resolver reference when a returned name changes so
+     * ChannelView re-renders and publishes the new value to memoized rows. The
      * stamped message name remains the fallback until this returns a name.
      */
     resolveBroadcastName?: BroadcastNameResolver;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linktr.ee/messaging-react",
-  "version": "3.29.1-rc-1785477229",
+  "version": "3.29.1",
   "description": "React messaging components built on messaging-core for web applications",
   "type": "module",
   "main": "dist/index.cjs",
@@ -50,7 +50,7 @@
   },
   "dependencies": {
     "@linktr.ee/component-library": "11.8.6",
-    "@linktr.ee/messaging-core": "2.3.0-rc-1785477229",
+    "@linktr.ee/messaging-core": "^2.2.0",
     "@linktr.ee/messaging-taxonomy": "^0.5.0",
     "@phosphor-icons/react": "^2.1.10",
     "culori": "^4.0.2"

package/src/components/ChannelView.broadcast-name.integration.test.tsx

@@ -113,69 +113,4 @@ describe('ChannelView broadcast-name resolution', () => {
     expect(mounts).toHaveBeenCalledOnce()
     expect(unmounts).not.toHaveBeenCalled()
   })
-
-  it('re-reads a stable resolver when ChannelView re-renders after the cache fills', async () => {
-    const { channel, client } = createChannel()
-    const resolvedName: { current?: string } = {}
-    const resolveBroadcastName = () => resolvedName.current
-    const mounts = vi.fn()
-    const unmounts = vi.fn()
-
-    const RowProbe = ({ children }: { children: React.ReactNode }) => {
-      useEffect(() => {
-        mounts()
-        return unmounts
-      }, [])
-      return <>{children}</>
-    }
-    const renderMessage = (messageNode: React.ReactElement) => (
-      <RowProbe>{messageNode}</RowProbe>
-    )
-
-    let rerender!: ReturnType<typeof render>['rerender']
-    await act(async () => {
-      rerender = render(
-        <Chat client={client}>
-          <Channel channel={channel as StreamChannel}>
-            <ChannelView
-              channel={channel as StreamChannel}
-              resolveBroadcastName={resolveBroadcastName}
-              renderMessage={renderMessage}
-              showStarButton={false}
-            />
-          </Channel>
-        </Chat>
-      ).rerender
-    })
-
-    expect(
-      screen.getByTestId('sent-message-broadcast-status')
-    ).toHaveTextContent('July 9th Class attendees')
-    expect(mounts).toHaveBeenCalledOnce()
-
-    resolvedName.current = 'July 9th Class absentee'
-
-    // ChannelView is memoized on props; flip an unrelated prop so the tree
-    // re-renders and re-invokes the same stable resolver against the live ref.
-    act(() => {
-      rerender(
-        <Chat client={client}>
-          <Channel channel={channel as StreamChannel}>
-            <ChannelView
-              channel={channel as StreamChannel}
-              resolveBroadcastName={resolveBroadcastName}
-              renderMessage={renderMessage}
-              showStarButton={true}
-            />
-          </Channel>
-        </Chat>
-      )
-    })
-
-    expect(
-      screen.getByTestId('sent-message-broadcast-status')
-    ).toHaveTextContent('July 9th Class absentee')
-    expect(mounts).toHaveBeenCalledOnce()
-    expect(unmounts).not.toHaveBeenCalled()
-  })
 })

package/src/components/ChannelView.tsx

@@ -16,7 +16,10 @@ import type { ChannelViewProps } from '../types'
 import { ChannelHeaderRedesign } from './ChannelHeaderRedesign'
 import { CustomDateSeparator } from './CustomDateSeparator'
 import { CustomMessage } from './CustomMessage'
-import { BroadcastNameContext, useBroadcastNamesById } from './CustomMessage/BroadcastNameContext'
+import {
+  BroadcastNameContext,
+  useBroadcastNamesById,
+} from './CustomMessage/BroadcastNameContext'
 import { CustomMessageActions } from './CustomMessage/CustomMessageActions'
 import { CustomMessageInput } from './CustomMessageInput'
 import { CustomSystemMessage } from './CustomSystemMessage'
@@ -102,8 +105,8 @@ const ChannelViewInner: React.FC<{
   const messageBroadcastClick = onBroadcastClick
     ? stableOnBroadcastClick
     : undefined
-  // Resolve outside memoized Stream rows so a stable host resolver backed by a
-  // live cache still publishes new campaign names when this tree re-renders.
+  // Resolve outside memoized Stream rows so new campaign names publish without
+  // remounting the rows.
   const broadcastNamesById = useBroadcastNamesById(
     messages,
     resolveBroadcastName

package/src/components/CustomMessage/BroadcastNameContext.ts

@@ -19,9 +19,8 @@ const broadcastIdFromMessage = (message: {
 /**
  * Resolve campaign names for the messages currently in view.
  *
- * Built outside memoized Stream rows so a host can keep `resolveBroadcastName`
- * referentially stable (ref/cache-backed) and still publish new strings when
- * ChannelView re-renders after the cache fills in.
+ * Built outside memoized Stream rows so a new resolver reference can publish
+ * new campaign names without remounting the Stream message rows.
  */
 export const buildBroadcastNamesById = (
   messages: readonly { metadata?: { broadcast_id?: unknown } }[] | undefined,
@@ -74,18 +73,18 @@ const areBroadcastNamesEqual = (
 }
 
 /**
- * Re-invokes a (possibly stable) resolver on every render, but only returns a
- * new object when the resolved strings actually change — so context consumers
- * update for late-arriving campaign names without thrashing on unrelated
- * ChannelViewInner renders.
+ * Re-invokes the resolver on every render, but only returns a new object when
+ * the resolved strings actually change — so context consumers update for
+ * late-arriving campaign names without thrashing on unrelated renders.
  */
 export const useBroadcastNamesById = (
   messages: readonly { metadata?: { broadcast_id?: unknown } }[] | undefined,
   resolveBroadcastName: BroadcastNameResolver | undefined
 ): BroadcastNamesById | undefined => {
   const names = buildBroadcastNamesById(messages, resolveBroadcastName)
-  const [publishedNames, setPublishedNames] =
-    useState<BroadcastNamesById | undefined>(names)
+  const [publishedNames, setPublishedNames] = useState<
+    BroadcastNamesById | undefined
+  >(names)
 
   if (!areBroadcastNamesEqual(publishedNames, names)) {
     setPublishedNames(names)

package/src/types.ts

@@ -376,9 +376,9 @@ export interface ChannelViewProps {
   onBroadcastClick?: BroadcastClickHandler
 
   /**
-   * Resolves the current campaign name for a broadcast label. The host may
-   * keep this resolver stable when its backing cache changes; ChannelView
-   * re-invokes it on render and publishes changed names to memoized rows. The
+   * Resolves the current campaign name for a broadcast label. The host must
+   * provide a new resolver reference when a returned name changes so
+   * ChannelView re-renders and publishes the new value to memoized rows. The
    * stamped message name remains the fallback until this returns a name.
    */
   resolveBroadcastName?: BroadcastNameResolver