@link-assistant/web-capture 1.7.24 → 1.7.25

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/web-capture
 
+## 1.7.25
+
+### Patch Changes
+
+- 024cb45: Fix `extractAndSaveImages` / `extractBase64ToBuffers` silently dropping base64 images when the markdown image is followed by a title attribute (e.g. `![](data:image/png;base64,... "")`). The base64 payload regex used `[^)]+`, which greedily included the trailing ` ""` and made `Buffer.from()` produce a decoded buffer that no longer matched the original image. The pattern now restricts the payload to base64 alphabet characters and matches the optional trailing markdown title separately so the title cannot leak into the payload.
+
 ## 1.7.24
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/web-capture",
-  "version": "1.7.24",
+  "version": "1.7.25",
   "description": "CLI and microservice to render web pages as HTML, Markdown, or PNG",
   "main": "src/index.js",
   "bin": {

package/src/extract-images.js

@@ -2,8 +2,11 @@ import { createHash } from 'crypto';
 import fs from 'fs';
 import path from 'path';
 
+// Capture groups: alt text, mime subtype, base64 payload. A trailing
+// markdown title attribute (e.g. `![](src "")`) is matched but discarded so
+// the empty title cannot leak into the base64 payload.
 const BASE64_IMAGE_REGEX =
-  /!\[([^\]]*)\]\(data:image\/(png|jpeg|jpg|gif|webp|svg\+xml);base64,([^)]+)\)/gi;
+  /!\[([^\]]*)\]\(data:image\/(png|jpeg|jpg|gif|webp|svg\+xml);base64,([A-Za-z0-9+/=]+)(?:\s+"[^"]*")?\)/gi;
 
 /**
  * @param {string} markdown - Markdown content with data URI images

package/tests/unit/extract-images.test.js

@@ -130,6 +130,26 @@ describe('extract-images module', () => {
       );
     });
 
+    it('extracts a base64 image even when followed by an empty markdown title', () => {
+      // Google Docs HTML exports embed `<img title="" alt="" src="...">`, and
+      // the html2md pipeline can render that as `![](src "")`. The base64
+      // extractor must still pull the image out cleanly so the rendered
+      // markdown does not carry multi-megabyte data URIs.
+      const md = `Hello.\n\n![](data:image/png;base64,${TINY_PNG} "")\n\nEnd.\n`;
+      const result = extractAndSaveImages(md, tmpDir);
+      expect(result.extracted).toBe(1);
+      expect(result.markdown).toMatch(/images\/image-[a-f0-9]+\.png/);
+      expect(result.markdown).not.toContain('data:image');
+    });
+
+    it('extracts a base64 image with a non-empty markdown title', () => {
+      const md = `Hello.\n\n![alt](data:image/png;base64,${TINY_PNG} "caption")\n\nEnd.\n`;
+      const result = extractAndSaveImages(md, tmpDir);
+      expect(result.extracted).toBe(1);
+      expect(result.markdown).toMatch(/images\/image-[a-f0-9]+\.png/);
+      expect(result.markdown).not.toContain('data:image');
+    });
+
     it('handles SVG data URIs', () => {
       const svgContent =
         '<svg xmlns="http://www.w3.org/2000/svg" width="1" height="1"><rect fill="red" width="1" height="1"/></svg>';