@link-assistant/web-capture 1.7.2 → 1.7.3

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/web-capture
 
+## 1.7.3
+
+### Patch Changes
+
+- 237afeb: Fix the JavaScript CLI so strict argument parsing accepts positional capture URLs while still rejecting unknown options.
+
 ## 1.7.2
 
 ### Patch Changes

package/bin/web-capture.js

@@ -16,6 +16,12 @@ const config = makeConfig({
       .usage(
         'web-capture - Capture web pages as HTML, Markdown, or PNG\n\nUsage:\n  web-capture --serve [--port <port>]       Start as API server\n  web-capture <url> [options]               Capture a URL to file/stdout'
       )
+      .command('$0 [url]', 'Capture a URL or start the API server', (yargs) =>
+        yargs.positional('url', {
+          type: 'string',
+          description: 'URL to capture',
+        })
+      )
       .option('serve', {
         alias: 's',
         type: 'boolean',
@@ -77,6 +83,7 @@ const config = makeConfig({
       .option('output', {
         alias: 'o',
         type: 'string',
+        nargs: 1,
         description:
           'Output file path (default: stdout for text, auto-generated for images)',
       })
@@ -232,6 +239,19 @@ const config = makeConfig({
   },
 });
 
+function getUrlArgument() {
+  if (typeof config.url === 'string' && config.url.length > 0) {
+    return config.url;
+  }
+
+  const separatorIndex = process.argv.indexOf('--');
+  if (separatorIndex !== -1 && separatorIndex < process.argv.length - 1) {
+    return process.argv[separatorIndex + 1];
+  }
+
+  return null;
+}
+
 async function startServer(port) {
   // Import the Express app
   const { app } = await import('../src/index.js');
@@ -824,8 +844,7 @@ async function captureUrl(url, options) {
 }
 
 async function main() {
-  // Get positional arguments (non-option arguments)
-  const url = config._ && config._.length > 0 ? config._[0] : null;
+  const url = getUrlArgument();
 
   if (config.serve) {
     // Server mode

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/web-capture",
-  "version": "1.7.2",
+  "version": "1.7.3",
   "description": "CLI and microservice to render web pages as HTML, Markdown, or PNG",
   "main": "src/index.js",
   "bin": {

package/tests/unit/cli.test.js

@@ -1,5 +1,6 @@
 // Unit tests for CLI argument parsing and functionality
 import { spawn } from 'child_process';
+import http from 'node:http';
 import { fileURLToPath } from 'url';
 import { dirname, resolve } from 'path';
 
@@ -33,6 +34,38 @@ function runCli(args, options = {}) {
   });
 }
 
+function startFixtureServer() {
+  return new Promise((resolve, reject) => {
+    const server = http.createServer((req, res) => {
+      res.writeHead(200, { 'Content-Type': 'text/html; charset=utf-8' });
+      res.end(
+        '<!doctype html><html><body><h1>Issue 68</h1><p>Captured from positional URL.</p></body></html>'
+      );
+    });
+
+    server.on('error', reject);
+    server.listen(0, '127.0.0.1', () => {
+      const { port } = server.address();
+      resolve({
+        server,
+        url: `http://127.0.0.1:${port}/article`,
+      });
+    });
+  });
+}
+
+function stopFixtureServer(server) {
+  return new Promise((resolve, reject) => {
+    server.close((err) => {
+      if (err) {
+        reject(err);
+        return;
+      }
+      resolve();
+    });
+  });
+}
+
 describe('CLI', () => {
   describe('--help', () => {
     test('shows help message with --help flag', async () => {
@@ -78,12 +111,63 @@ describe('CLI', () => {
   });
 
   describe('URL validation', () => {
+    test('accepts a URL as a positional argument', async () => {
+      const { server, url } = await startFixtureServer();
+
+      try {
+        const result = await runCli([
+          url,
+          '--format',
+          'markdown',
+          '--output',
+          '-',
+        ]);
+
+        expect(result.code).toBe(0);
+        expect(result.stderr).not.toContain('Unknown argument');
+        expect(result.stdout).toContain('Issue 68');
+        expect(result.stdout).toContain('Captured from positional URL.');
+      } finally {
+        await stopFixtureServer(server);
+      }
+    }, 15000);
+
+    test('accepts a URL after the -- argument separator', async () => {
+      const { server, url } = await startFixtureServer();
+
+      try {
+        const result = await runCli([
+          '--format',
+          'markdown',
+          '--output',
+          '-',
+          '--',
+          url,
+        ]);
+
+        expect(result.code).toBe(0);
+        expect(result.stderr).not.toContain('Missing URL');
+        expect(result.stdout).toContain('Issue 68');
+      } finally {
+        await stopFixtureServer(server);
+      }
+    }, 15000);
+
+    test('rejects unknown options', async () => {
+      const result = await runCli([
+        '--unknown-option-for-issue-68',
+        'https://example.com',
+      ]);
+
+      expect(result.code).toBe(1);
+      expect(result.stderr).toContain('Unknown argument');
+    });
+
     test('rejects invalid URL', async () => {
-      const result = await runCli(['not-a-valid-url-without-dots']);
-      // Should fail with invalid URL or show help due to strict mode
+      const result = await runCli(['http://[invalid-url']);
+      // Should fail before trying to capture.
       expect(result.code).toBe(1);
-      // Either an error message or help output (from yargs strict mode)
-      expect(result.stdout.length + result.stderr.length).toBeGreaterThan(0);
+      expect(result.stderr).toContain('Invalid URL');
     }, 15000);
   });