@link-assistant/hive-mind 2.8.3 → 2.8.5

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @link-assistant/hive-mind
 
+## 2.8.5
+
+### Patch Changes
+
+- 9a1cbf4: Fix false positives and false negatives in CI/CD (issue #2082). Release and Helm scripts now fail on non-zero exit codes instead of silently continuing, npm publish verification retries registry propagation without republishing, version bumps retry a rejected push on top of the new remote HEAD, shell test assertions fail the build, every workflow job declares a timeout, and jobs use `!cancelled()` so concurrency cancellation is respected. Releases on main now queue rather than cancel, so a run cannot be interrupted between publishing to npm and pushing the version bump.
+
+  Linting now also covers the `tests/` tree, which `npm run lint` and `eslint.config.mjs` both excluded — the lint job reported success while never reading the largest source tree in the repository. Enabling it surfaced real defects across 59 files, including `assert.match` regexes with unescaped literal indentation that made assertions pass for the wrong reason.
+
+  Stops leaking `CLAUDE_CODE_EFFORT_LEVEL` from the parent shell into the Claude process. `getClaudeEnv()` builds the child environment from `process.env` and sanitised an inherited `MAX_THINKING_TOKENS`, but not the effort level, so any path that computed no level passed the parent's value through — giving `haiku` an effort level it does not support, and `--think off` one despite thinking being disabled. Since Claude Code exports this variable, the leak applied whenever hive-mind ran under it. The emitted effort level is now a function of the selected model and think level only.
+
+## 2.8.4
+
+### Patch Changes
+
+- 4373bc8: Stop treating JSON Schema, structured-data values, and package selectors as required Codex capabilities while preserving explicit skill and catalog plugin discovery.
+
 ## 2.8.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "2.8.3",
+  "version": "2.8.5",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -21,8 +21,8 @@
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",
-    "lint": "eslint 'src/**/*.{js,mjs,cjs}' 'scripts/**/*.{js,mjs,cjs}' 'eslint-rules/**/*.{js,mjs,cjs}'",
-    "lint:fix": "eslint 'src/**/*.{js,mjs,cjs}' 'scripts/**/*.{js,mjs,cjs}' 'eslint-rules/**/*.{js,mjs,cjs}' --fix",
+    "lint": "eslint 'src/**/*.{js,mjs,cjs}' 'scripts/**/*.{js,mjs,cjs}' 'eslint-rules/**/*.{js,mjs,cjs}' 'tests/**/*.{js,mjs,cjs}'",
+    "lint:fix": "eslint 'src/**/*.{js,mjs,cjs}' 'scripts/**/*.{js,mjs,cjs}' 'eslint-rules/**/*.{js,mjs,cjs}' 'tests/**/*.{js,mjs,cjs}' --fix",
     "check:duplication": "jscpd .",
     "format": "prettier --write \"**/*.{js,mjs,json,md}\" --ignore-path .prettierignore",
     "format:check": "prettier --check \"**/*.{js,mjs,json,md}\" --ignore-path .prettierignore",

package/src/codex-capability-preflight.lib.mjs

@@ -21,6 +21,9 @@ const NEGATED_REQUIREMENT = /\b(?:does\s+not\s+require|not\s+required|optional)\
 const PLUGIN_SELECTOR = /\b([a-z0-9][a-z0-9-]*@[a-z0-9][a-z0-9-]*(?:-remote)?)\b(?!\.[a-z])/gi;
 const NAMESPACED_SKILL = /\b([a-z0-9][a-z0-9-]*:[a-z0-9][a-z0-9-]*)\b/gi;
 const EXPLICIT_BARE_SKILL = /\$([a-z0-9][a-z0-9-]*)|`([a-z0-9][a-z0-9-]*)`\s+(?:agent\s+)?skill/gi;
+const CAPABILITY_PREFIX = /\b(?:depend(?:s|ed)?\s+on|install|invoke|must\s+(?:install|invoke|use)|need(?:ed|s)?(?:\s+to)?(?:\s+(?:install|invoke|use))?|require(?:d|s)?(?:\s+to)?(?:\s+(?:install|invoke|use))?|use)\s+(?:(?:the|an?)\s+)?(?:(?:agent\s+)?skill\s+)?(?:named\s+)?[`$]?$/i;
+const CAPABILITY_SUFFIX = /^`?\s+(?:agent\s+)?(?:skill|capability)\b/i;
+const STRUCTURED_DATA_VALUES = new Set(['array', 'boolean', 'false', 'integer', 'null', 'number', 'object', 'string', 'true']);
 
 // Issue #2077: a capability name must contain at least one letter.
 //
@@ -44,6 +47,21 @@ const PROSE_TOKENS = new Set(['agent', 'caution', 'codex', 'default', 'error', '
 
 const isCapabilityToken = value => CAPABILITY_TOKEN.test(value) && !PROSE_TOKENS.has(value);
 
+const hasExplicitCapabilityContext = (line, match) => {
+  const before = line.slice(0, match.index);
+  const after = line.slice(match.index + match[0].length);
+  if (CAPABILITY_SUFFIX.test(after) || before.endsWith('$')) return true;
+  const value = match[1].slice(match[1].indexOf(':') + 1).toLowerCase();
+  return !STRUCTURED_DATA_VALUES.has(value) && CAPABILITY_PREFIX.test(before);
+};
+
+const hasExplicitPluginContext = (line, match) => {
+  const before = line.slice(0, match.index);
+  const after = line.slice(match.index + match[0].length);
+  const marketplace = match[1].slice(match[1].indexOf('@') + 1);
+  return /(?:^|-)(?:bundled|curated|marketplace|remote)(?:-|$)/iu.test(marketplace) || /\bplugin\s+[`$]?$/iu.test(before) || /^`?\s+plugin\b/iu.test(after);
+};
+
 export function isCapabilityName(value) {
   const token = String(value || '').toLowerCase();
   const separator = /[:@]/u.exec(token);
@@ -90,8 +108,16 @@ export function detectRequiredCodexCapabilities(text) {
     const line = rawLine.trim();
     if (!line || !REQUIREMENT_WORDS.test(line) || NEGATED_REQUIREMENT.test(line)) continue;
 
-    for (const match of line.matchAll(PLUGIN_SELECTOR)) accept(plugins, normalizePluginSelector(match[1]), line);
-    for (const match of line.matchAll(NAMESPACED_SKILL)) accept(skills, match[1].toLowerCase(), line);
+    for (const match of line.matchAll(PLUGIN_SELECTOR)) {
+      const selector = normalizePluginSelector(match[1]);
+      if (hasExplicitPluginContext(line, match)) accept(plugins, selector, line);
+      else rejected.push({ capability: selector, line });
+    }
+    for (const match of line.matchAll(NAMESPACED_SKILL)) {
+      const skill = match[1].toLowerCase();
+      if (hasExplicitCapabilityContext(line, match)) accept(skills, skill, line);
+      else rejected.push({ capability: skill, line });
+    }
     for (const match of line.matchAll(EXPLICIT_BARE_SKILL)) accept(skills, (match[1] || match[2]).toLowerCase(), line);
   }
 
@@ -310,6 +336,9 @@ async function provisionCodexCapabilities({ owner, repo, issueNumber, projectDir
   const baseCatalog = parseJsonCommand(baseCatalogResult, 'Codex plugin catalog discovery');
   const skillDirectories = [path.join(os.homedir(), '.agents', 'skills'), projectDir && path.join(projectDir, '.agents', 'skills')].filter(Boolean);
   const plugins = await resolveRequiredPlugins({ requirements, catalog: baseCatalog, skillDirectories });
+  for (const plugin of plugins) {
+    await log(`   ✅ Verified ${plugin} in the Codex plugin catalog`, { verbose: true });
+  }
   if (plugins.length === 0) {
     await log('   ✅ Required Agent Skills are already available from standard skill directories');
     return { required: true, plugins, skills: requirements.skills, codexHome: null, baseCodexHome };

package/src/config.lib.mjs

@@ -627,6 +627,16 @@ export const getClaudeEnv = (options = {}) => {
     env.MAX_THINKING_TOKENS = String(options.thinkingBudget ?? 0);
   }
 
+  // Remove any inherited CLAUDE_CODE_EFFORT_LEVEL from process.env, mirroring the
+  // MAX_THINKING_TOKENS sanitisation above (Issue #2082). Without this, an effort
+  // level exported by the parent shell survives into the child whenever the logic
+  // below does not compute one — e.g. a model that supports no effort levels at all
+  // (haiku), or --think off. hive-mind's own agents run under Claude Code, which
+  // exports this variable, so the leak fired in exactly the common case: `haiku
+  // --think high` inherited effort=max from the parent. The value below must be a
+  // function of the selected model and think level, never of the ambient shell.
+  delete env.CLAUDE_CODE_EFFORT_LEVEL;
+
   // Set CLAUDE_CODE_EFFORT_LEVEL for models that support it (Issue #1238, Issue #1620)
   if (options.model && supportsEffortLevel(options.model)) {
     const effortOptions = {