@link-assistant/hive-mind 2.15.0 → 2.15.2

package/src/solve.session.lib.mjs

@@ -159,12 +159,21 @@ export async function startWorkSession({ isContinueMode, prNumber, argv, log, fo
 }
 
 export async function endWorkSession({ isContinueMode, prNumber, argv, log, formatAligned, $, logsAttached = false }) {
-  // Post end work session comment and convert PR back to ready if in continue mode.
+  // Post end work session comment and convert PR back to ready for review.
+  //
   // Issue #2123: the ready conversion mirrors startWorkSession's draft conversion, so it must
   // run for every continue-mode session, not only for --watch/--auto-continue ones.
-  if (isContinueMode && prNumber) {
+  //
+  // Issue #2182: the `isContinueMode` gate is deliberately gone from the ready conversion.
+  // A session that created the pull request itself (isContinueMode === false) can still leave
+  // it in draft — either because the AI opened it as a draft, or because an auto-restart
+  // iteration converted it — and hive-mind, not the AI, owns putting it back. In the reported
+  // run isContinueMode was false for the whole process, so this function did nothing and the
+  // PR stayed a draft while --auto-merge retried the merge 2692 times over 4d 12h.
+  // Session *comments* stay gated: they are about --watch/--auto-continue reporting, not state.
+  if (prNumber) {
     const workEndTime = new Date();
-    const shouldPostSessionComment = argv.watch || argv.autoContinue;
+    const shouldPostSessionComment = isContinueMode && (argv.watch || argv.autoContinue);
     await log(`\n${formatAligned('🏁', 'Ending work session:', workEndTime.toISOString())}`);
 
     // Only post end comment if logs were NOT already attached
@@ -194,7 +203,9 @@ export async function endWorkSession({ isContinueMode, prNumber, argv, log, form
       await log(formatAligned('ℹ️', 'Skipping:', 'End comment (logs already attached with session end message)', 2));
     }
 
-    // Convert PR back to ready for review (issue #2123: shared implementation)
+    // Convert PR back to ready for review (issue #2123: shared implementation).
+    // This is the invariant of the whole draft/ready state machine: a finished working
+    // session never leaves a pull request in draft (issue #2182).
     const { reportError } = await import('./sentry.lib.mjs');
     await ensurePullRequestIsReady({
       owner: global.owner,

package/src/telegram-merge-queue.lib.mjs

@@ -460,7 +460,9 @@ export class MergeQueueProcessor {
         }
         const waitForReadyResult = await this.waitForPRReady(item, mergeableCheck);
         if (!waitForReadyResult.success) {
-          if (waitForReadyResult.status === 'cancelled' || waitForReadyResult.status === 'conflict') {
+          // Issue #2182: 'draft' joins cancel/conflict as a skip, not a failure —
+          // the pull request author has to mark it ready for review first.
+          if (waitForReadyResult.status === 'cancelled' || waitForReadyResult.status === 'conflict' || waitForReadyResult.status === 'draft') {
             item.status = MergeItemStatus.SKIPPED;
             item.error = waitForReadyResult.error;
             this.stats.skipped++;

package/src/telegram-merge-wait.lib.mjs

@@ -45,6 +45,13 @@ export async function waitForPRReady(processor, item, initialCheck, options) {
       return { success: true, status: 'ready', error: null };
     }
 
+    // Issue #2182: a draft pull request never becomes mergeable on its own —
+    // waiting for the full CI timeout only delays the queue. Skip it right away
+    // with the real reason instead of a generic "did not become mergeable".
+    if (latestCheck?.isDraft) {
+      return { success: false, status: 'draft', error: `PR #${item.pr.number} is a draft — mark it ready for review before merging` };
+    }
+
     if (latestCheck?.reason === conflictSkipReason) {
       return { success: false, status: 'conflict', error: conflictSkipReason };
     }

package/src/transient-errors.lib.mjs

@@ -75,11 +75,25 @@ export const GITHUB_SERVER_TRANSIENT_PATTERNS = Object.freeze([
  */
 export const GIT_TRANSIENT_PATTERNS = Object.freeze(['unexpected disconnect', 'sideband', 'early eof', 'the remote end hung up', 'remote end hung up unexpectedly', 'rpc failed', 'fetch-pack', 'index-pack failed', 'transfer closed', 'unable to access', 'could not read from remote repository', 'failed to connect to github.com', 'operation timed out after', 'gnutls_handshake() failed', 'the requested url returned error: 5']);
 
+/**
+ * GitHub throttling *anonymous* git downloads (issue #2192):
+ *
+ *   fatal: remote error: GitHub is temporarily limiting some unauthenticated
+ *   downloads to protect the stability of the platform. Please retry later or
+ *   authenticate.
+ *
+ * Retryable — GitHub itself says "retry later" — but the *real* fix is to
+ * authenticate, which `src/git-auth-transport.lib.mjs` does before retrying.
+ * Kept as its own category so a run that hits this is never diagnosed as a
+ * generic network fault (the failing run reported "Unknown error" three times).
+ */
+export const ANONYMOUS_DOWNLOAD_LIMIT_PATTERNS = Object.freeze(['temporarily limiting some unauthenticated downloads', 'limiting some unauthenticated downloads', 'please retry later or authenticate', 'retry later or authenticate']);
+
 /**
  * Union used by the general-purpose `isTransientNetworkError` helpers. Kept as
  * a single flat list so a caller cannot accidentally miss a category.
  */
-export const ALL_TRANSIENT_PATTERNS = Object.freeze([...NETWORK_TRANSIENT_PATTERNS, ...GITHUB_SERVER_TRANSIENT_PATTERNS, ...GIT_TRANSIENT_PATTERNS]);
+export const ALL_TRANSIENT_PATTERNS = Object.freeze([...NETWORK_TRANSIENT_PATTERNS, ...GITHUB_SERVER_TRANSIENT_PATTERNS, ...GIT_TRANSIENT_PATTERNS, ...ANONYMOUS_DOWNLOAD_LIMIT_PATTERNS]);
 
 /**
  * Pull every plausible string out of an error-ish value so pattern matches
@@ -126,6 +140,15 @@ const matchPattern = (error, patterns) => {
  */
 export const isTransientNetworkError = error => matchPattern(error, ALL_TRANSIENT_PATTERNS) !== null;
 
+/**
+ * True when `error` is GitHub refusing an *unauthenticated* git download.
+ * The remedy is to authenticate the transport, not merely to wait.
+ *
+ * @param {unknown} error
+ * @returns {boolean}
+ */
+export const isAnonymousDownloadLimit = error => matchPattern(error, ANONYMOUS_DOWNLOAD_LIMIT_PATTERNS) !== null;
+
 /**
  * True when `error` is a GitHub server-side fault (5xx or GraphQL internal).
  * Narrower than `isTransientNetworkError` — used for logging/classification.
@@ -174,7 +197,7 @@ export const parseGitHubRequestId = error => {
  * Full classification of a failure, for retry decisions *and* for diagnostics.
  *
  * @param {unknown} error
- * @returns {{transient: boolean, category: 'network'|'github-server'|'git-transport'|null, matchedPattern: string|null, requestId: string|null, text: string}}
+ * @returns {{transient: boolean, category: 'network'|'github-server'|'git-transport'|'github-anonymous-rate-limit'|null, matchedPattern: string|null, requestId: string|null, text: string}}
  */
 export const describeTransientError = error => {
   const text = collectErrorText(error);
@@ -184,10 +207,16 @@ export const describeTransientError = error => {
   const networkPattern = find(NETWORK_TRANSIENT_PATTERNS);
   const serverPattern = find(GITHUB_SERVER_TRANSIENT_PATTERNS);
   const gitPattern = find(GIT_TRANSIENT_PATTERNS);
+  const anonymousPattern = find(ANONYMOUS_DOWNLOAD_LIMIT_PATTERNS);
 
   let category = null;
   let matchedPattern = null;
-  if (networkPattern) {
+  if (anonymousPattern) {
+    // Checked first: this failure has a specific remedy (authenticate) and its
+    // text also mentions timeouts/retries that the other lists could match.
+    category = 'github-anonymous-rate-limit';
+    matchedPattern = anonymousPattern;
+  } else if (networkPattern) {
     category = 'network';
     matchedPattern = networkPattern;
   } else if (serverPattern) {
@@ -224,11 +253,13 @@ export const formatTransientDiagnostics = description => {
 };
 
 export default {
+  ANONYMOUS_DOWNLOAD_LIMIT_PATTERNS,
   NETWORK_TRANSIENT_PATTERNS,
   GITHUB_SERVER_TRANSIENT_PATTERNS,
   GIT_TRANSIENT_PATTERNS,
   ALL_TRANSIENT_PATTERNS,
   collectErrorText,
+  isAnonymousDownloadLimit,
   isTransientNetworkError,
   isGitHubServerError,
   matchTransientPattern,