@link-assistant/hive-mind 2.13.3 → 2.13.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 2.13.4
+
+### Patch Changes
+
+- 36b0ff9: Stop `solve` from crashing with `TypeError: A GitHub pull request URL requires owner, repo, and a positive integer number` when `--auto-continue` resumes an `issue-<n>-<hash>` branch that has no pull request yet. Continue mode has always had two shapes — resume an existing pull request, or reuse a leftover branch from an interrupted run (`prNumber: null`) — and since #2158 the "Your prepared Pull Request" URL was built from `prNumber` unconditionally, so the second shape aborted the run right after branch checkout, one step before `handleAutoPrCreation()` would have created the missing pull request. The URL is now built through a nullable `buildGitHubPullRequestUrlOrNull()` helper, the run logs that the pull request is still pending, and the strict builder reports the values it received so a bare stack trace is actionable. Full analysis in `docs/case-studies/issue-2170/`.
+
 ## 2.13.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "2.13.3",
+  "version": "2.13.4",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/github-url-parser.lib.mjs

@@ -270,10 +270,40 @@ export function canonicalizeGitHubUrl(url) {
 /** Build the canonical web URL for a pull request already identified by GitHub. */
 export function buildGitHubPullRequestUrl({ owner, repo, number } = {}) {
   if (!owner || !repo || !Number.isInteger(Number(number)) || Number(number) <= 0) {
-    throw new TypeError('A GitHub pull request URL requires owner, repo, and a positive integer number');
+    // Issue #2170: the bare message left no way to tell which of the three
+    // parts was missing from a stack trace alone, so name the received values.
+    throw new TypeError(`A GitHub pull request URL requires owner, repo, and a positive integer number (received owner=${describeUrlPart(owner)}, repo=${describeUrlPart(repo)}, number=${describeUrlPart(number)})`);
   }
   return `https://github.com/${owner}/${repo}/pull/${Number(number)}`;
 }
+
+/** Render a value for the diagnostic above without hiding null/undefined/''. */
+function describeUrlPart(value) {
+  if (value === null) return 'null';
+  if (value === undefined) return 'undefined';
+  if (typeof value === 'string') return JSON.stringify(value);
+  return String(value);
+}
+
+/**
+ * Build a pull request URL when the pull request is already identified, and
+ * return `null` when it is not (for example, `--auto-continue` resumed a
+ * leftover branch whose pull request has not been created yet).
+ *
+ * Callers that legitimately run before a pull request exists must use this
+ * instead of `buildGitHubPullRequestUrl`, whose throw aborts the whole run.
+ *
+ * @see https://github.com/link-assistant/hive-mind/issues/2170
+ * @param {{owner?: string, repo?: string, number?: number|string|null}} [params]
+ * @returns {string|null}
+ */
+export function buildGitHubPullRequestUrlOrNull(params = {}) {
+  try {
+    return buildGitHubPullRequestUrl(params);
+  } catch {
+    return null;
+  }
+}
 /**
  * Check if a URL is a valid GitHub URL of a specific type
  * @param {string} url - The URL to check

package/src/github.lib.mjs

@@ -20,8 +20,8 @@ export { buildCostInfoString };
 // #1756: route gh exec calls through transient + rate-limit retry wrapper
 import { execGhWithRetry } from './github-rate-limit.lib.mjs';
 import { QUIET_PROBE } from './quiet-probe.lib.mjs'; // issues #2130, #2135: keep read-only probe payloads out of the attached log
-import { buildGitHubPullRequestUrl, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl } from './github-url-parser.lib.mjs';
-export { buildGitHubPullRequestUrl, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl };
+import { buildGitHubPullRequestUrl, buildGitHubPullRequestUrlOrNull, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl } from './github-url-parser.lib.mjs';
+export { buildGitHubPullRequestUrl, buildGitHubPullRequestUrlOrNull, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl };
 // Issue #1625: Named marker constants (single source of truth) + in-memory tracking for tool-posted comments. See tool-comments.lib.mjs for design.
 import { SOLUTION_DRAFT_LOG_MARKER, SOLUTION_DRAFT_FAILED_MARKER, SOLUTION_DRAFT_FINISHED_WITH_ERRORS_MARKER, USAGE_LIMIT_REACHED_MARKER, NOW_WORKING_SESSION_IS_ENDED_MARKER, postTrackedComment, postTrackedCommentFromFile } from './tool-comments.lib.mjs';
 export const maskGitHubToken = maskToken; // Alias for backward compatibility
@@ -1171,6 +1171,7 @@ export default {
   isRateLimitError,
   batchCheckPullRequestsForIssues,
   buildGitHubPullRequestUrl,
+  buildGitHubPullRequestUrlOrNull,
   parseGitHubUrl,
   normalizeGitHubUrl,
   isGitHubUrlType,

package/src/solve.mjs

@@ -553,8 +553,18 @@ try {
     // Issue #2158: auto-continue can discover a PR while the input remains an
     // issue URL. Passing that issue URL as "Your prepared Pull Request" sent
     // the first Formal AI attempt to the wrong GitHub entity.
-    prUrl = githubLib.buildGitHubPullRequestUrl({ owner, repo, number: prNumber });
-    // prNumber is already set from earlier when we parsed the PR
+    //
+    // Issue #2170: continue mode does not imply a PR exists. --auto-continue
+    // also resumes a leftover `issue-<n>-<hash>` branch that never got a PR,
+    // and then prNumber is null. Building the URL unconditionally threw
+    // "A GitHub pull request URL requires owner, repo, and a positive integer
+    // number" and killed the run right after checkout. The PR is created a few
+    // lines below by handleAutoPrCreation, which sets both prUrl and prNumber.
+    prUrl = githubLib.buildGitHubPullRequestUrlOrNull({ owner, repo, number: prNumber });
+    if (!prUrl) {
+      await log(formatAligned('ℹ️', 'Continue mode:', 'Resuming an existing branch that has no pull request yet'));
+      await log(formatAligned('', 'Pull request:', 'Will be created before the tool session starts', 2));
+    }
   }
   // Handle auto PR creation using the new module
   const autoPrResult = await handleAutoPrCreation({