@link-assistant/hive-mind 2.12.4 → 2.12.5

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 2.12.5
+
+### Patch Changes
+
+- 77ed9bc: Keep Formal AI repository requests bounded, target the discovered pull request URL, and stop retrying explicit `planned_not_executed` results as successful work.
+
 ## 2.12.4
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "2.12.4",
+  "version": "2.12.5",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/agent.prompts.lib.mjs

@@ -9,6 +9,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for Agent
@@ -16,6 +18,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, forkActionsUrl, owner, repo, argv } = params;
 
   const promptLines = [];
@@ -92,6 +97,13 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: Formal AI's deterministic intent router considers the whole
+  // provider request, including this caller-owned workflow prompt. Command
+  // examples such as `sudo` and `pwd` were consequently executed as if the
+  // issue requested them. The compact user prompt remains the repository
+  // objective; Formal AI supplies its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   // When in fork mode, screenshots are pushed to the fork, not the original repo
   const screenshotRepoPath = argv?.fork && forkedRepo ? forkedRepo : `${owner}/${repo}`;
 

package/src/claude.prompts.lib.mjs

@@ -11,6 +11,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for Claude
@@ -18,6 +20,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, owner, repo, argv, contributingGuidelines, claudeVersion } = params;
 
   if (argv?.minimalRestartContext && argv.resume) {
@@ -105,6 +110,10 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: keep caller workflow instructions out of Formal AI's task
+  // classifier. Formal AI provides its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   if (argv?.minimalRestartContext && argv.resume) {
     return '';
   }

package/src/codex.prompts.lib.mjs

@@ -10,6 +10,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for Codex
@@ -17,6 +19,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, forkActionsUrl, owner, repo, argv } = params;
 
   const promptLines = [];
@@ -93,6 +98,10 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: keep caller workflow instructions out of Formal AI's task
+  // classifier. Formal AI provides its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   // When in fork mode, screenshots are pushed to the fork, not the original repo
   const screenshotRepoPath = argv?.fork && forkedRepo ? forkedRepo : `${owner}/${repo}`;
 

package/src/formal-ai-prompt.lib.mjs

@@ -0,0 +1,29 @@
+/**
+ * Build the small repository objective sent through native CLIs to Formal AI.
+ *
+ * Formal AI owns the agent policy for its model. Repeating Hive Mind's native
+ * provider policy in the request both wastes context and exposes incidental
+ * shell-language cues to Formal AI's deterministic intent router (#2158).
+ */
+
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
+
+export const buildFormalAiRepositoryPrompt = params => {
+  if (!isFormalAiModel(params?.argv?.model)) return null;
+
+  const { issueUrl, issueNumber, prNumber, prUrl, branchName, isContinueMode, feedbackLines, owner, repo } = params;
+  const issueReference = isContinueMode && issueNumber && owner && repo ? `https://github.com/${owner}/${repo}/issues/${issueNumber}` : issueUrl || `the issue linked to pull request ${prNumber}`;
+  const lines = [`Resolve the GitHub issue at ${issueReference} in this repository.`];
+
+  if (branchName) lines.push(`Keep the solution on branch ${branchName}.`);
+  if (prUrl) lines.push(`Update the pull request at ${prUrl}.`);
+  // The review text is caller-controlled and can contain command snippets.
+  // Point Formal AI to the canonical PR instead of copying those snippets into
+  // the intent-classification request.
+  if (feedbackLines?.length && prUrl) lines.push('Review and address all feedback recorded on that pull request.');
+
+  lines.push('', 'Implement and verify the solution before reporting completion.', isContinueMode ? 'Continue.' : 'Proceed.');
+  return `${lines.join('\n')}\n`;
+};
+
+export default { buildFormalAiRepositoryPrompt };

package/src/formal-ai.lib.mjs

@@ -217,6 +217,36 @@ export const createPreparedToolResult = preparedCommand => ({
   errorDuringExecution: false,
 });
 
+const FORMAL_AI_NON_EXECUTION_PATTERNS = [/^\s*planned,\s*not executed\b/im, /^\s*planned_not_executed\s*$/im, /^\s*terminal_state\s+["']?planned_not_executed\b/im];
+
+/**
+ * Turn Formal AI's explicit non-execution terminal state into a failed tool
+ * result (issue #2158).
+ *
+ * Formal AI 0.339.1 truthfully reports repository work as
+ * `planned_not_executed`, but each native CLI exits zero. Treating that process
+ * exit as a successful solve made `--auto-restart-until-mergeable` repeat the
+ * same deterministic plan five times. Keep the model's summary for evidence,
+ * while giving Hive Mind an actionable terminal failure.
+ */
+export const classifyFormalAiToolResult = ({ model, toolResult } = {}) => {
+  if (!toolResult || !isFormalAiModel(model) || toolResult.success === false) return toolResult;
+
+  const evidence = [toolResult.resultSummary, toolResult.result, toolResult.lastMessage, toolResult.output].filter(value => typeof value === 'string').join('\n');
+  if (!FORMAL_AI_NON_EXECUTION_PATTERNS.some(pattern => pattern.test(evidence))) return toolResult;
+
+  return {
+    ...toolResult,
+    success: false,
+    errorDuringExecution: true,
+    formalAiNonExecution: true,
+    errorInfo: {
+      code: 'FORMAL_AI_PLANNED_NOT_EXECUTED',
+      message: "Formal AI did not execute repository work; it returned the terminal state planned_not_executed. Fix or upgrade Formal AI's repository-work executor before retrying.",
+    },
+  };
+};
+
 export const logPreparedToolCommand = async ({ argv, fullCommand, log, formatAligned }) => {
   await log(`\n${formatAligned('📝', 'Raw command:', '')}`);
   await log(fullCommand);

package/src/gemini.prompts.lib.mjs

@@ -9,6 +9,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for Gemini
@@ -16,6 +18,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, forkActionsUrl, owner, repo, argv } = params;
 
   const promptLines = [];
@@ -81,6 +86,10 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: keep caller workflow instructions out of Formal AI's task
+  // classifier. Formal AI provides its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   const screenshotRepoPath = argv?.fork && forkedRepo ? forkedRepo : `${owner}/${repo}`;
 
   let workspaceInstructions = '';

package/src/github-url-parser.lib.mjs

@@ -241,6 +241,14 @@ export function normalizeGitHubUrl(url) {
   const parsed = parseGitHubUrl(url);
   return parsed.valid ? parsed.normalized : null;
 }
+
+/** Build the canonical web URL for a pull request already identified by GitHub. */
+export function buildGitHubPullRequestUrl({ owner, repo, number } = {}) {
+  if (!owner || !repo || !Number.isInteger(Number(number)) || Number(number) <= 0) {
+    throw new TypeError('A GitHub pull request URL requires owner, repo, and a positive integer number');
+  }
+  return `https://github.com/${owner}/${repo}/pull/${Number(number)}`;
+}
 /**
  * Check if a URL is a valid GitHub URL of a specific type
  * @param {string} url - The URL to check

package/src/github.lib.mjs

@@ -20,8 +20,8 @@ export { buildCostInfoString };
 // #1756: route gh exec calls through transient + rate-limit retry wrapper
 import { execGhWithRetry } from './github-rate-limit.lib.mjs';
 import { QUIET_PROBE } from './quiet-probe.lib.mjs'; // issues #2130, #2135: keep read-only probe payloads out of the attached log
-import { isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl } from './github-url-parser.lib.mjs';
-export { isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl };
+import { buildGitHubPullRequestUrl, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl } from './github-url-parser.lib.mjs';
+export { buildGitHubPullRequestUrl, isGitHubUrlType, normalizeGitHubUrl, parseGitHubUrl };
 // Issue #1625: Named marker constants (single source of truth) + in-memory tracking for tool-posted comments. See tool-comments.lib.mjs for design.
 import { SOLUTION_DRAFT_LOG_MARKER, SOLUTION_DRAFT_FAILED_MARKER, SOLUTION_DRAFT_FINISHED_WITH_ERRORS_MARKER, USAGE_LIMIT_REACHED_MARKER, NOW_WORKING_SESSION_IS_ENDED_MARKER, postTrackedComment, postTrackedCommentFromFile } from './tool-comments.lib.mjs';
 export const maskGitHubToken = maskToken; // Alias for backward compatibility
@@ -1168,6 +1168,7 @@ export default {
   fetchProjectIssues,
   isRateLimitError,
   batchCheckPullRequestsForIssues,
+  buildGitHubPullRequestUrl,
   parseGitHubUrl,
   normalizeGitHubUrl,
   isGitHubUrlType,

package/src/opencode.prompts.lib.mjs

@@ -9,6 +9,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for OpenCode
@@ -16,6 +18,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, forkActionsUrl, owner, repo, argv } = params;
 
   const promptLines = [];
@@ -92,6 +97,10 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: keep caller workflow instructions out of Formal AI's task
+  // classifier. Formal AI provides its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   // When in fork mode, screenshots are pushed to the fork, not the original repo
   const screenshotRepoPath = argv?.fork && forkedRepo ? forkedRepo : `${owner}/${repo}`;
 

package/src/qwen.prompts.lib.mjs

@@ -9,6 +9,8 @@ import { getThinkingPromptInstruction } from './thinking-prompt.lib.mjs';
 import { buildWorkLanguageDirective } from './work-language.prompts.lib.mjs';
 import { buildRequestedBaseBranchDirective } from './solve-option-contract.prompts.lib.mjs';
 import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
+import { buildFormalAiRepositoryPrompt } from './formal-ai-prompt.lib.mjs';
+import { isFormalAiModel } from './formal-ai-model.lib.mjs';
 
 /**
  * Build the user prompt for Qwen Code
@@ -16,6 +18,9 @@ import { buildIssueResearchPrompt } from './deep-analysis.lib.mjs';
  * @returns {string} The formatted user prompt
  */
 export const buildUserPrompt = params => {
+  const formalAiPrompt = buildFormalAiRepositoryPrompt(params);
+  if (formalAiPrompt !== null) return formalAiPrompt;
+
   const { issueUrl, issueNumber, prNumber, prUrl, branchName, tempDir, workspaceTmpDir, isContinueMode, forkedRepo, feedbackLines, forkActionsUrl, owner, repo, argv, tool = 'qwen' } = params;
 
   const promptLines = [];
@@ -81,6 +86,10 @@ export const buildUserPrompt = params => {
 export const buildSystemPrompt = params => {
   const { owner, repo, issueNumber, prNumber, branchName, workspaceTmpDir, argv, modelSupportsVision, forkedRepo } = params;
 
+  // Issue #2158: keep caller workflow instructions out of Formal AI's task
+  // classifier. Formal AI provides its own execution policy.
+  if (isFormalAiModel(argv?.model)) return '';
+
   const screenshotRepoPath = argv?.fork && forkedRepo ? forkedRepo : `${owner}/${repo}`;
 
   let workspaceInstructions = '';

package/src/solve.mjs

@@ -69,6 +69,7 @@ const { validateAndExitOnInvalidClaudeSubAgentModel, validateAndExitOnInvalidMod
 const { autoAcceptInviteForRepo } = await import('./solve.accept-invite.lib.mjs');
 const { handleAutoForkOption, handleMaintainerForkAccess } = await import('./solve.fork-detection.lib.mjs');
 const { resolveUncommittedChangesTool } = await import('./solve.tool-uncommitted.lib.mjs');
+const { classifyFormalAiToolResult } = await import('./formal-ai.lib.mjs');
 const logFile = await initializeLogFile(null);
 const versionInfo = await getVersionInfo();
 const rawCommand = await logSolveStartup(versionInfo);
@@ -535,7 +536,10 @@ try {
   let prUrl = null;
   // In continue mode, we already have the PR details
   if (isContinueMode) {
-    prUrl = issueUrl; // The input URL is the PR URL
+    // Issue #2158: auto-continue can discover a PR while the input remains an
+    // issue URL. Passing that issue URL as "Your prepared Pull Request" sent
+    // the first Formal AI attempt to the wrong GitHub entity.
+    prUrl = githubLib.buildGitHubPullRequestUrl({ owner, repo, number: prNumber });
     // prNumber is already set from earlier when we parsed the PR
   }
   // Handle auto PR creation using the new module
@@ -757,6 +761,11 @@ try {
     });
     toolResult = claudeResult;
   }
+  toolResult = classifyFormalAiToolResult({ model: argv.model, toolResult });
+  if (toolResult?.formalAiNonExecution) {
+    await log(`❌ ${toolResult.errorInfo.message}`, { level: 'error' });
+    await log('   The deterministic terminal response will not be retried as a mergeability problem.', { level: 'error' });
+  }
   try {
     await recordAfterAgentSize({ tempDir, beforeBytes: cleanupContext.diskDiagnostics?.beforeBytes ?? null, log });
   } catch (diskError) {

package/src/solve.restart-shared.lib.mjs

@@ -34,6 +34,7 @@ const { log, formatAligned, extractToolErrorCore } = lib;
 const { ensurePullRequestBaseBranch } = await import('./solve.pr-base-guard.lib.mjs');
 const { ensureAiToolScratchIgnored, filterAiToolScratchFromStatus } = await import('./ai-tool-scratch.lib.mjs');
 const { RESOURCE_PHASE_RESTART_AFTER, RESOURCE_PHASE_RESTART_BEFORE, recordResourceSnapshot } = await import('./solve.resource-diagnostics.lib.mjs');
+const { classifyFormalAiToolResult } = await import('./formal-ai.lib.mjs');
 // Issue #2123: shared draft/ready transitions for working sessions.
 const { ensurePullRequestIsDraft } = await import('./pr-draft-state.lib.mjs');
 
@@ -492,6 +493,11 @@ export const executeToolIteration = async params => {
     });
   }
 
+  toolResult = classifyFormalAiToolResult({ model: argv.model, toolResult });
+  if (toolResult?.formalAiNonExecution) {
+    await log(`❌ ${toolResult.errorInfo.message}`, { level: 'error' });
+  }
+
   await ensurePullRequestBaseBranch({ owner, repo, prNumber, argv, log, formatAligned, $ });
   await recordResourceSnapshot({
     phase: RESOURCE_PHASE_RESTART_AFTER,