@link-assistant/hive-mind 2.11.8 → 2.11.10

package/src/solve.keep-working.lib.mjs

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+import { QUIET_PROBE } from './quiet-probe.lib.mjs';
 import { ensureUseM } from './use-m-bootstrap.lib.mjs';
 
 /**
@@ -68,7 +69,8 @@ export const collectDeferredWorkSources = async ({ owner, repo, prNumber, result
 
   // 1. Pull request description
   try {
-    const prResult = await $`gh api repos/${owner}/${repo}/pulls/${prNumber} --jq '.body // ""'`;
+    // Issue #2135: `mirror: false` - the description is scanned here, not shown.
+    const prResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/pulls/${prNumber} --jq '.body // ""'`;
     if (prResult.code === 0) {
       const body = prResult.stdout.toString();
       if (body && body.trim()) {
@@ -86,7 +88,10 @@ export const collectDeferredWorkSources = async ({ owner, repo, prNumber, result
 
   // 3. Changed markdown documents (scan only added lines from the diff)
   try {
-    const filesResult = await $`gh api repos/${owner}/${repo}/pulls/${prNumber}/files --paginate`;
+    // Issue #2135: `mirror: false`. Every entry carries the file's patch, so
+    // this answer is as large as the pull request's diff - and it was being
+    // echoed into the log that gets attached to that same pull request.
+    const filesResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/pulls/${prNumber}/files --paginate`;
     if (filesResult.code === 0) {
       const files = JSON.parse(filesResult.stdout.toString() || '[]');
       for (const file of files) {

package/src/solve.minimal-restart-prompt.lib.mjs

@@ -9,6 +9,8 @@
  * @see case-studies/issue-661-session-resume-cost-optimization/
  */
 
+import { QUIET_PROBE } from './quiet-probe.lib.mjs';
+
 // Note: This module does not import $ directly
 // Functions receive $ as a parameter from the calling module
 // This ensures consistent command executor usage across the codebase
@@ -28,9 +30,11 @@ export const generateMinimalRestartPrompt = async (tempDir, $) => {
   const uncommittedFiles = gitStatus.stdout.toString().trim();
 
   // Get brief diff summaries (not full diffs to keep the prompt minimal)
-  const gitDiffStat = await $({ cwd: tempDir })`git diff --stat`;
+  // Issue #2135: `mirror: false` - the summaries go into the prompt below, so
+  // echoing them into the log only duplicates them into the attached log file.
+  const gitDiffStat = await $({ cwd: tempDir, ...QUIET_PROBE })`git diff --stat`;
   const unstagedDiffSummary = gitDiffStat.stdout.toString().trim();
-  const gitCachedDiffStat = await $({ cwd: tempDir })`git diff --cached --stat`;
+  const gitCachedDiffStat = await $({ cwd: tempDir, ...QUIET_PROBE })`git diff --cached --stat`;
   const stagedDiffSummary = gitCachedDiffStat.stdout.toString().trim();
   const summarySections = [];
   if (unstagedDiffSummary) summarySections.push(`Unstaged changes:\n${unstagedDiffSummary}`);
@@ -69,7 +73,11 @@ export const generateFullRestartPrompt = async (issueUrl, issueBody, prNumber, f
   const gitStatus = await $({ cwd: tempDir })`git status --porcelain`;
   const uncommittedFiles = gitStatus.stdout.toString().trim();
 
-  const gitDiff = await $({ cwd: tempDir })`git diff`;
+  // Issue #2135: `mirror: false`. This is the working tree's whole diff and it
+  // is embedded in the prompt below; mirroring it wrote a second copy into the
+  // session log, which is attached to the pull request and (with
+  // --development-log) committed into the branch the diff is taken from.
+  const gitDiff = await $({ cwd: tempDir, ...QUIET_PROBE })`git diff`;
   const fullDiff = gitDiff.stdout.toString();
 
   let prompt = `

package/src/solve.preparation.lib.mjs

@@ -4,6 +4,7 @@
  */
 
 import { wrapDollarWithGhRetry as _wrapDollarWithGhRetry } from './github-rate-limit.lib.mjs'; // rate-limit marker (#1726): gh API calls flow through $ wrapped by caller
+import { quietProbe } from './quiet-probe.lib.mjs';
 // Import feedback detection functionality
 const feedback = await import('./solve.feedback.lib.mjs');
 const { detectAndCountFeedback } = feedback;
@@ -45,7 +46,10 @@ export async function prepareFeedbackAndTimestamps({ tempDir = null, prNumber, b
 
     // Get the last comment's timestamp (if any)
     // Use --paginate to get all comments - GitHub API returns max 30 per page by default
-    const commentsResult = await $`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
+    // Issue #2135: `mirror: false`. Only the last comment's timestamp is read
+    // from this answer, but the answer itself is every comment body on the
+    // issue - tens of kilobytes echoed into the log on every run.
+    const commentsResult = await quietProbe($)`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
 
     if (commentsResult.code !== 0) {
       await log(`Warning: Failed to get comments: ${commentsResult.stderr ? commentsResult.stderr.toString() : 'Unknown error'}`, { level: 'warning' });

package/src/solve.progress-monitoring.lib.mjs

@@ -30,6 +30,7 @@ import { LIVE_PROGRESS_SECTION_START_MARKER, LIVE_PROGRESS_SECTION_END_MARKER, p
 import { writeSanitizedPublicationFile } from './token-sanitization.lib.mjs';
 
 import { wrapDollarWithGhRetry as _wrapDollarWithGhRetry } from './github-rate-limit.lib.mjs'; // rate-limit marker (#1726): gh API calls flow through $ wrapped by caller
+import { quietProbe } from './quiet-probe.lib.mjs'; // issue #2135: keep large read-only probe payloads out of the attached log
 /**
  * Configuration constants for progress monitoring
  */
@@ -280,7 +281,10 @@ export const createProgressMonitor = ({ owner, repo, prNumber, $, log, verbose =
       state.currentTodos = todos;
 
       // Fetch current PR description
-      const prData = await $`gh pr view ${prNumber} --repo ${owner}/${repo} --json body`;
+      // Issue #2135: `mirror: false`. This runs on every progress update and
+      // the answer is the whole pull-request description, which by then holds
+      // the progress section itself.
+      const prData = await quietProbe($)`gh pr view ${prNumber} --repo ${owner}/${repo} --json body`;
       const prInfo = JSON.parse(prData.stdout);
       let currentBody = prInfo.body || '';
 

package/src/solve.repository.lib.mjs

@@ -65,7 +65,8 @@ export const checkExistingForkOfRoot = async rootRepo => {
     // not to the shell, and command-stream quotes interpolated values itself - so
     // interpolating inside the quotes would leak shell quotes into the comparison.
     const forkFilter = `.[] | select(.owner.login == ${JSON.stringify(currentUser)}) | .full_name`;
-    const forksResult = await lib.ghCmdRetry(() => $`gh api repos/${rootRepo}/forks --paginate --jq ${forkFilter}`, { label: `check forks of ${rootRepo}` });
+    // Issue #2135: `mirror: false` - see the fork-name lookup below.
+    const forksResult = await lib.ghCmdRetry(() => $(QUIET_PROBE)`gh api repos/${rootRepo}/forks --paginate --jq ${forkFilter}`, { label: `check forks of ${rootRepo}` });
     if (forksResult.code !== 0) return null;
 
     const forks = forksResult.stdout
@@ -1225,7 +1226,9 @@ export const setupPrForkRemote = async (tempDir, argv, prForkOwner, repo, isCont
     // Issue #2119: the double quotes here are jq syntax, so the expression is
     // built in JS and interpolated as one already-escaped argument.
     const forkNameFilter = `.[] | select(.owner.login == ${JSON.stringify(prForkOwner)}) | .name`;
-    const forksResult = await $`gh api repos/${owner}/${repo}/forks --paginate --jq ${forkNameFilter}`;
+    // Issue #2135: `mirror: false` - a popular repository has thousands of
+    // forks, and only the matching name is used.
+    const forksResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/forks --paginate --jq ${forkNameFilter}`;
     if (forksResult.code === 0 && forksResult.stdout) {
       const forkName = forksResult.stdout.toString().trim().split('\n')[0]; // Take first match
       if (forkName) {

package/src/solve.results.lib.mjs

@@ -407,7 +407,9 @@ export const cleanupClaudeFile = async (tempDir, branchName, claudeCommitHash =
     // APPROACH 3: Check for modifications before reverting (proactive detection)
     // This is the main strategy - detect if the file was modified after initial commit
     await log(`   Checking if ${fileName} was modified since initial commit...`, { verbose: true });
-    const diffResult = await $({ cwd: tempDir })`git diff ${commitToRevert} HEAD -- ${fileName} 2>&1`;
+    // Issue #2135: `mirror: false`. Only "is it non-empty" is asked here, and
+    // the answer is a file's whole diff.
+    const diffResult = await $({ cwd: tempDir, ...QUIET_PROBE })`git diff ${commitToRevert} HEAD -- ${fileName} 2>&1`;
 
     if (diffResult.stdout && diffResult.stdout.trim()) {
       // File was modified after initial commit - use manual approach to avoid conflicts
@@ -746,7 +748,8 @@ export const verifyResults = async (owner, repo, branchName, issueNumber, prNumb
     // First, get all PRs from our branch
     // IMPORTANT: Use --state all to find PRs that may have been merged during the session (Issue #1008)
     // Without --state all, gh pr list only returns OPEN PRs, missing merged ones
-    const allBranchPrsResult = await $`gh pr list --repo ${owner}/${repo} --head ${branchName} --state all --json number,url,createdAt,headRefName,title,state,updatedAt,isDraft`;
+    // Issue #2135: `mirror: false` - the pull requests found are named below.
+    const allBranchPrsResult = await $(QUIET_PROBE)`gh pr list --repo ${owner}/${repo} --head ${branchName} --state all --json number,url,createdAt,headRefName,title,state,updatedAt,isDraft`;
 
     if (allBranchPrsResult.code !== 0) {
       await log('  ⚠️  Failed to check pull requests');
@@ -819,7 +822,7 @@ export const verifyResults = async (owner, repo, branchName, issueNumber, prNumb
             // "1 file(s) modified, 1 line(s) added" for a pull request that
             // changed nothing, because the stats were never checked for being
             // empty.
-            const changeStats = await getPullRequestChangeStats({ owner, repo, prNumber: pr.number, $ });
+            const changeStats = await getPullRequestChangeStats({ owner, repo, prNumber: pr.number, $, log });
             if (!changeStats.hasChanges) {
               await log(`  ⚠️  PR #${pr.number} has an empty diff - the description will say so instead of claiming changes`, { level: 'warning' });
             }
@@ -948,7 +951,9 @@ Fixes ${issueRef}
 
     // Get all comments and filter them
     // Use --paginate to get all comments - GitHub API returns max 30 per page by default
-    const allCommentsResult = await $`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
+    // Issue #2135: `mirror: false` - the counts below are the report; the raw
+    // answer is every comment body on the issue.
+    const allCommentsResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
 
     if (allCommentsResult.code !== 0) {
       await log('  ⚠️  Failed to check comments');
@@ -1209,7 +1214,7 @@ export const checkForAiCreatedComments = async (sessionStartTime, owner, repo, p
     // Check comments on the PR first (if we have a PR)
     if (prNumber) {
       // Check PR conversation comments
-      const prCommentsResult = await $`gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate`;
+      const prCommentsResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate`;
       if (prCommentsResult.code === 0) {
         const prComments = JSON.parse(prCommentsResult.stdout.toString().trim() || '[]');
         const newPrComments = filterNewAiComments(prComments, 'pr');
@@ -1220,7 +1225,7 @@ export const checkForAiCreatedComments = async (sessionStartTime, owner, repo, p
       }
 
       // Check PR review comments (inline code comments)
-      const reviewCommentsResult = await $`gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate`;
+      const reviewCommentsResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate`;
       if (reviewCommentsResult.code === 0) {
         const reviewComments = JSON.parse(reviewCommentsResult.stdout.toString().trim() || '[]');
         const newReviewComments = filterNewAiComments(reviewComments, 'review');
@@ -1233,7 +1238,7 @@ export const checkForAiCreatedComments = async (sessionStartTime, owner, repo, p
 
     // Check issue comments (if different from PR number or no PR)
     if (issueNumber && issueNumber !== prNumber) {
-      const issueCommentsResult = await $`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
+      const issueCommentsResult = await $(QUIET_PROBE)`gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate`;
       if (issueCommentsResult.code === 0) {
         const issueComments = JSON.parse(issueCommentsResult.stdout.toString().trim() || '[]');
         const newIssueComments = filterNewAiComments(issueComments, 'issue');
@@ -1413,7 +1418,7 @@ export const maybeAttachWorkingSessionSummary = async ({ argv, resultSummary, wo
       : null);
   // Issue #2119: a summary posted on a pull request that changed nothing must
   // say so, instead of reading as a report of completed work.
-  const changeStats = prNumber ? await getPullRequestChangeStats({ owner, repo, prNumber, $ }) : null;
+  const changeStats = prNumber ? await getPullRequestChangeStats({ owner, repo, prNumber, $, log }) : null;
 
   // Issue #2132: the summary carries no cost/budget block. `resolvedBudgetStatsData`
   // is computed only so the caller can reuse it for this session's log comment.

package/src/task.mjs

@@ -3,6 +3,7 @@
 import crypto from 'crypto';
 import path from 'path';
 import { spawn } from 'child_process';
+import { describeChildExit } from './child-exit.lib.mjs';
 import { promises as fs } from 'fs';
 import { buildStartAgentArgs, resolveStartAgentCommand } from './task.agent-command.lib.mjs';
 import { getDefaultTaskModel, parseTaskArguments } from './task.config.lib.mjs';
@@ -112,8 +113,8 @@ function runCommand(command, args, options = {}) {
     child.on('error', error => {
       resolve({ code: 1, stdout, stderr: stderr || error.message });
     });
-    child.on('close', code => {
-      resolve({ code, stdout, stderr });
+    child.on('close', (code, signal) => {
+      resolve({ code, stdout, stderr, signal });
     });
   });
 }
@@ -122,7 +123,8 @@ async function commandOutput(command, args, options = {}) {
   const result = await runCommand(command, args, options);
   if (result.code !== 0) {
     const output = `${result.stderr || ''}${result.stdout || ''}`.trim();
-    throw new Error(output || `${command} exited with code ${result.code}`);
+    // Issue #2135: `describeChildExit` names a signal instead of "code null".
+    throw new Error(output || describeChildExit({ command, code: result.code, signal: result.signal }));
   }
   return result.stdout.trim();
 }

package/src/telegram-command-execution.lib.mjs

@@ -1,4 +1,5 @@
 import { spawn } from 'child_process';
+import { describeChildExit } from './child-exit.lib.mjs';
 import { promisify } from 'util';
 import { exec as execCallback } from 'child_process';
 import { t } from './i18n.lib.mjs';
@@ -57,7 +58,7 @@ function executeWithCommand(startScreenCmd, command, args, verbose = false) {
       });
     });
 
-    child.on('close', code => {
+    child.on('close', (code, signal) => {
       if (code === 0) {
         resolve({
           success: true,
@@ -67,7 +68,9 @@ function executeWithCommand(startScreenCmd, command, args, verbose = false) {
         resolve({
           success: false,
           output: stdout,
-          error: stderr || `Command exited with code ${code}`,
+          // Issue #2135: name the signal, so an out-of-memory abort is not
+          // reported as "code null".
+          error: stderr || describeChildExit({ command: 'Command', code, signal }),
         });
       }
     });