@link-assistant/hive-mind 2.11.6 → 2.11.7

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @link-assistant/hive-mind
 
+## 2.11.7
+
+### Patch Changes
+
+- 815a63c: Keep context/cost budget statistics out of the working session summary (issue #2132).
+
+  Cost estimation and token/context usage are now published only in the working
+  session log comment, and only when `--attach-logs` is enabled — previously every
+  session posted the identical blocks twice, and the summary could publish them even
+  with log attachment disabled. The per-session budget stats derivation used by the
+  top-level run, watch iterations and auto-restart-until-mergeable iterations is now
+  a single shared implementation.
+
 ## 2.11.6
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "2.11.6",
+  "version": "2.11.7",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/budget-stats-policy.lib.mjs

@@ -0,0 +1,31 @@
+#!/usr/bin/env node
+
+/**
+ * Issue #2132: single source of truth for *where* context/cost budget statistics
+ * may be published.
+ *
+ * Rules encoded here:
+ *   1. Budget stats belong to the working session **log** comment only. The
+ *      "Working session summary" comment reports what the AI did, never how many
+ *      tokens or dollars it took (see `attachSolutionSummary`).
+ *   2. `--attach-logs` disabled ⇒ no log comment ⇒ no published budget stats.
+ *      `--tokens-budget-stats` alone is not enough to publish them to GitHub; it
+ *      only controls the local terminal rendering of the same facts.
+ *
+ * Keeping this in one module means the top-level run, the watch loop and the
+ * auto-restart-until-mergeable loop cannot drift apart again.
+ *
+ * @see https://github.com/link-assistant/hive-mind/issues/2132
+ */
+
+/** Whether `--attach-logs` is enabled (both camelCase and kebab-case forms). */
+export const isAttachLogsEnabled = argv => !!(argv && (argv.attachLogs || argv['attach-logs']));
+
+/** Whether `--tokens-budget-stats` is enabled (both camelCase and kebab-case forms). */
+export const isTokensBudgetStatsEnabled = argv => !!(argv && (argv.tokensBudgetStats || argv['tokens-budget-stats']));
+
+/**
+ * Whether context/cost budget statistics may be published to GitHub for this run.
+ * Requires BOTH `--tokens-budget-stats` and `--attach-logs`.
+ */
+export const shouldPublishBudgetStats = argv => isTokensBudgetStatsEnabled(argv) && isAttachLogsEnabled(argv);

package/src/solve.auto-merge.lib.mjs

@@ -1052,19 +1052,20 @@ Once the billing issue is resolved, you can re-run the CI checks or push a new c
             latestAnthropicCost = toolResult.anthropicTotalCostUSD;
           }
 
-          // Issue #1508: Compute budget stats for auto-restart-until-mergeable log comment
-          let autoMergeBudgetStatsData = null;
-          if (argv.tokensBudgetStats && latestSessionId && tempDir) {
-            try {
-              const { calculateSessionTokens } = await import('./claude.lib.mjs');
-              const tokenUsage = await calculateSessionTokens(latestSessionId, tempDir, toolResult.resultModelUsage);
-              if (tokenUsage) {
-                autoMergeBudgetStatsData = { tokenUsage, streamTokenUsage: toolResult.streamTokenUsage || null };
-              }
-            } catch (budgetError) {
-              if (argv.verbose) await log(`  ⚠️  Could not calculate budget stats: ${budgetError.message}`, { verbose: true });
-            }
-          }
+          // Issue #1508: Compute budget stats for auto-restart-until-mergeable log comment.
+          // Issue #2132: shared with the top-level run and the watch loop via
+          // buildSessionBudgetStatsData, so every working session derives its own
+          // stats the same way (and skips them when `--attach-logs` is disabled).
+          const { buildSessionBudgetStatsData } = await import('./solve.results.lib.mjs');
+          const autoMergeBudgetStatsData = await buildSessionBudgetStatsData({
+            argv,
+            sessionId: latestSessionId,
+            tempDir,
+            resultModelUsage: toolResult.resultModelUsage,
+            streamTokenUsage: toolResult.streamTokenUsage || null,
+            subAgentCalls: toolResult.subAgentCalls || null,
+            pricingInfo: toolResult.pricingInfo || null,
+          });
 
           // Issue #1761: Post the working session **summary** BEFORE uploading
           // the working session **log** so the summary always appears above
@@ -1090,8 +1091,6 @@ Once the billing issue is resolved, you can re-run the CI checks or push a new c
               prNumber,
               issueNumber,
               success: true,
-              publicPricingEstimate: toolResult.publicPricingEstimate,
-              anthropicTotalCostUSD: latestAnthropicCost,
               pricingInfo: toolResult.pricingInfo,
               budgetStatsData: autoMergeBudgetStatsData,
             });

package/src/solve.config.lib.mjs

@@ -136,7 +136,7 @@ export const SOLVE_OPTION_DEFINITIONS = {
   },
   'attach-logs': {
     type: 'boolean',
-    description: 'Upload the solution draft log file to the Pull Request on completion (⚠️ WARNING: May expose sensitive data)',
+    description: "Upload the solution draft log file to the Pull Request on completion, together with that working session's cost estimation and context/token budget statistics (⚠️ WARNING: May expose sensitive data). Disabled means no log comment and no published budget statistics.",
     default: false,
   },
   'dangerously-skip-output-sanitization': {
@@ -505,7 +505,7 @@ export const SOLVE_OPTION_DEFINITIONS = {
   },
   'tokens-budget-stats': {
     type: 'boolean',
-    description: 'Show detailed token budget statistics including context window usage and ratios (enabled by default, use --no-tokens-budget-stats to disable). Supported for --tool claude, --tool codex, and any tool that returns detailed token usage.',
+    description: 'Show detailed token budget statistics including context window usage and ratios (enabled by default, use --no-tokens-budget-stats to disable). Shown in the terminal; publishing them to the pull request additionally requires --attach-logs, and they appear only in the working session log comment (never in the working session summary). Supported for --tool claude, --tool codex, and any tool that returns detailed token usage.',
     default: true,
   },
   'prompt-issue-reporting': {

package/src/solve.mjs

@@ -1238,8 +1238,6 @@ try {
     prNumber,
     issueNumber,
     success,
-    publicPricingEstimate,
-    anthropicTotalCostUSD,
     pricingInfo,
     sessionUsage: { sessionId, tempDir, resultModelUsage, streamTokenUsage, subAgentCalls },
   });

package/src/solve.results.lib.mjs

@@ -29,8 +29,6 @@ import { safeExit } from './exit-handler.lib.mjs';
 // Import GitHub-related functions
 const githubLib = await import('./github.lib.mjs');
 const { sanitizeLogContent, attachLogToGitHub } = githubLib;
-const { buildCostInfoString } = await import('./github-cost-info.lib.mjs');
-const { buildBudgetStatsString } = await import('./claude.budget-stats.lib.mjs');
 
 // Issue #1745: process-wide sanitization counters used to print a one-line
 // "we masked N secrets" summary at the end of each run.
@@ -674,7 +672,18 @@ export const showSessionSummary = async (sessionId, limitReached, argv, issueUrl
 // same observed facts (working-session summary and attached log alike).
 export const buildSessionBudgetStatsData = async ({ argv, sessionId = null, tempDir = null, resultModelUsage = null, streamTokenUsage = null, subAgentCalls = null, pricingInfo = null }) => {
   let budgetStatsData = null;
-  if (argv.tokensBudgetStats && sessionId && tempDir) {
+  // Issue #2132: budget stats are a property of the working session **log**.
+  // With `--attach-logs` disabled there is no log comment, so they must not be
+  // computed or published anywhere.
+  const { shouldPublishBudgetStats, isAttachLogsEnabled, isTokensBudgetStatsEnabled } = await import('./budget-stats-policy.lib.mjs');
+  if (!shouldPublishBudgetStats(argv)) {
+    if (argv?.verbose) {
+      const reason = !isTokensBudgetStatsEnabled(argv) ? '--no-tokens-budget-stats' : !isAttachLogsEnabled(argv) ? '--attach-logs is disabled' : 'unknown';
+      await log(`  ℹ️  Skipping context/cost budget stats publication (${reason})`, { verbose: true });
+    }
+    return null;
+  }
+  if (sessionId && tempDir) {
     try {
       const { calculateSessionTokens } = await import('./claude.lib.mjs');
       const tokenUsage = await calculateSessionTokens(sessionId, tempDir, resultModelUsage);
@@ -686,7 +695,7 @@ export const buildSessionBudgetStatsData = async ({ argv, sessionId = null, temp
     }
   }
   // Issue #1526: Build budget stats from Agent CLI token/context data when no JSONL session available
-  if (!budgetStatsData && argv.tokensBudgetStats && pricingInfo?.tokenUsage) {
+  if (!budgetStatsData && pricingInfo?.tokenUsage) {
     try {
       const { buildAgentBudgetStats } = await import('./claude.budget-stats.lib.mjs');
       const agentBudgetData = buildAgentBudgetStats(pricingInfo.tokenUsage, pricingInfo);
@@ -1264,15 +1273,19 @@ export const checkForAiCreatedComments = async (sessionStartTime, owner, repo, p
  * @param {string} options.repo - Repository name
  * @returns {Promise<boolean>} - True if comment was posted successfully
  */
-export const buildWorkingSessionSummaryDetails = ({ publicPricingEstimate = null, anthropicTotalCostUSD = null, pricingInfo = null, budgetStatsData = null } = {}) => {
-  const costInfo = buildCostInfoString(publicPricingEstimate, anthropicTotalCostUSD, pricingInfo, {
-    includeTokenUsage: false,
-  });
-  const budgetStats = budgetStatsData ? buildBudgetStatsString(budgetStatsData.tokenUsage, budgetStatsData.subAgentCalls) : '';
-  return `${costInfo}${budgetStats}`.trim();
-};
+/**
+ * Issue #2132: the working session summary must describe *what the AI did* and
+ * nothing else. Cost estimation and context/token budget statistics belong to
+ * the working session log comment (`--attach-logs`), where they are already
+ * published once per working session. Rendering them in the summary as well
+ * duplicated the very same block in two consecutive comments.
+ *
+ * Kept as an exported function returning an empty string so the invariant is
+ * directly testable and any future caller cannot silently re-add the block.
+ */
+export const buildWorkingSessionSummaryDetails = () => '';
 
-export const attachSolutionSummary = async ({ resultSummary, prNumber, issueNumber, owner, repo, publicPricingEstimate = null, anthropicTotalCostUSD = null, pricingInfo = null, budgetStatsData = null, changeStats = null }) => {
+export const attachSolutionSummary = async ({ resultSummary, prNumber, issueNumber, owner, repo, changeStats = null }) => {
   if (!resultSummary || typeof resultSummary !== 'string') {
     await log('⚠️  No working session summary available to attach', { verbose: true });
     return false;
@@ -1287,12 +1300,6 @@ export const attachSolutionSummary = async ({ resultSummary, prNumber, issueNumb
   }
 
   try {
-    const usageDetails = buildWorkingSessionSummaryDetails({
-      publicPricingEstimate,
-      anthropicTotalCostUSD,
-      pricingInfo,
-      budgetStatsData,
-    });
     // Issue #2119: publish what the session actually produced. The reported
     // summary said "The `pwd` command completed" and printed the solver's own
     // /tmp workspace, on a pull request that was still empty.
@@ -1302,7 +1309,7 @@ export const attachSolutionSummary = async ({ resultSummary, prNumber, issueNumb
     const comment = `${toolComments.WORKING_SESSION_SUMMARY_AUTOMATION_MARKER}
 ## ${toolComments.WORKING_SESSION_SUMMARY_MARKER}
 
-${summaryBody}${noChangesNotice ? `\n\n${noChangesNotice}` : ''}${usageDetails ? `\n\n${usageDetails}` : ''}
+${summaryBody}${noChangesNotice ? `\n\n${noChangesNotice}` : ''}
 
 ---
 *${toolComments.WORKING_SESSION_SUMMARY_AUTOMATED_FOOTER}*`;
@@ -1359,7 +1366,7 @@ ${summaryBody}${noChangesNotice ? `\n\n${noChangesNotice}` : ''}${usageDetails ?
  * @param {boolean} [options.success=true] - skip attachment for failed iterations
  * @returns {Promise<{attached: boolean, reason: string}>}
  */
-export const maybeAttachWorkingSessionSummary = async ({ argv, resultSummary, workStartTime, owner, repo, prNumber, issueNumber, success = true, publicPricingEstimate = null, anthropicTotalCostUSD = null, pricingInfo = null, budgetStatsData = null, sessionUsage = null }) => {
+export const maybeAttachWorkingSessionSummary = async ({ argv, resultSummary, workStartTime, owner, repo, prNumber, issueNumber, success = true, pricingInfo = null, budgetStatsData = null, sessionUsage = null }) => {
   if (!success) {
     return { attached: false, reason: 'iteration_failed' };
   }
@@ -1408,16 +1415,14 @@ export const maybeAttachWorkingSessionSummary = async ({ argv, resultSummary, wo
   // say so, instead of reading as a report of completed work.
   const changeStats = prNumber ? await getPullRequestChangeStats({ owner, repo, prNumber, $ }) : null;
 
+  // Issue #2132: the summary carries no cost/budget block. `resolvedBudgetStatsData`
+  // is computed only so the caller can reuse it for this session's log comment.
   const ok = await attachSolutionSummary({
     resultSummary,
     prNumber,
     issueNumber,
     owner,
     repo,
-    publicPricingEstimate,
-    anthropicTotalCostUSD,
-    pricingInfo,
-    budgetStatsData: resolvedBudgetStatsData,
     changeStats,
   });
   return { attached: !!ok, reason: ok ? 'attached' : 'post_failed', budgetStatsData: resolvedBudgetStatsData };

package/src/solve.watch.lib.mjs

@@ -567,19 +567,21 @@ export const watchForFeedback = async params => {
             latestResultModelUsage = toolResult.resultModelUsage;
           }
 
-          // Issue #1508: Compute budget stats for auto-restart log comment
-          let autoRestartBudgetStatsData = null;
-          if (argv.tokensBudgetStats && latestSessionId && tempDir) {
-            try {
-              const { calculateSessionTokens } = await import('./claude.lib.mjs');
-              const tokenUsage = await calculateSessionTokens(latestSessionId, tempDir, toolResult.resultModelUsage);
-              if (tokenUsage) {
-                autoRestartBudgetStatsData = { tokenUsage, streamTokenUsage: toolResult.streamTokenUsage || null, subAgentCalls: toolResult.subAgentCalls || null };
-              }
-            } catch (budgetError) {
-              if (argv.verbose) await log(`  ⚠️  Could not calculate budget stats: ${budgetError.message}`, { verbose: true });
-            }
-          }
+          // Issue #1508: Compute budget stats for auto-restart log comment.
+          // Issue #2132: shared with the top-level run and the
+          // auto-restart-until-mergeable loop via buildSessionBudgetStatsData,
+          // so every working session derives its own stats the same way (and
+          // skips them entirely when `--attach-logs` is disabled).
+          const { buildSessionBudgetStatsData } = await import('./solve.results.lib.mjs');
+          const autoRestartBudgetStatsData = await buildSessionBudgetStatsData({
+            argv,
+            sessionId: latestSessionId,
+            tempDir,
+            resultModelUsage: toolResult.resultModelUsage,
+            streamTokenUsage: toolResult.streamTokenUsage || null,
+            subAgentCalls: toolResult.subAgentCalls || null,
+            pricingInfo: toolResult.pricingInfo || null,
+          });
 
           // Issue #1761: Post the working session **summary** BEFORE uploading
           // the working session **log** so the summary always appears above
@@ -604,8 +606,6 @@ export const watchForFeedback = async params => {
               prNumber,
               issueNumber,
               success: true,
-              publicPricingEstimate: toolResult.publicPricingEstimate,
-              anthropicTotalCostUSD: latestAnthropicCost,
               pricingInfo: toolResult.pricingInfo,
               budgetStatsData: autoRestartBudgetStatsData,
             });