@link-assistant/hive-mind 2.0.23 → 2.0.25

package/src/tool-run-health.lib.mjs

@@ -0,0 +1,64 @@
+// Tool-agnostic run-health analysis (Issue #1990).
+//
+// Background: under docker isolation two long-running `solve --tool codex` tasks
+// reported SUCCESS (Exit Code: 0) while their containers had run out of disk —
+// the AI session was cut off mid-run, no commits were produced, yet the process
+// exited 0. Reporting that as success also discarded the container filesystem we
+// needed to inspect and retry from.
+//
+// codex.lib.mjs gets a bespoke gate (paired turn.started/turn.completed lifecycle
+// — see codex-health.lib.mjs) and claude.lib.mjs already requires its final
+// `result` event (shouldFailClaudeStreamWithoutResult). This module provides the
+// equivalent gate for the tools whose stream-json output (adopted from the Claude
+// Agent SDK schema) ends with a single terminal `result` event: gemini-cli and
+// qwen-code. An exit-0 run that clearly began work but never emitted that
+// terminal event was interrupted and must NOT be reported as success.
+//
+// opencode is deliberately NOT gated here. Its `run --format json` output has no
+// single terminal completion event we have verified is always emitted before a
+// clean exit — opencode.lib.mjs treats several event types ('text', 'assistant',
+// 'message', 'result', 'step_finish') as best-effort and decides success purely
+// on the exit code. Gating opencode on a terminal event without first confirming
+// upstream that it is reliably flushed would risk converting genuine successes
+// into failures, so it is left as follow-up. See docs/case-studies/issue-1990.
+//
+// Disk-exhaustion strings ("No space left on device", ENOSPC) are surfaced only
+// as supporting *diagnostics* — never an independent failure gate — to avoid the
+// issue #1955 class of false positive where a tool echoes a command's stdout that
+// merely mentions the phrase.
+
+import { isENOSPC } from './lib.mjs';
+
+export const getTerminalEventCompletionHealth = ({ eventCounts = {}, terminalEventTypes = ['result'], hadActivity = false, diskEvidenceTexts = [] } = {}) => {
+  const terminalCount = terminalEventTypes.reduce((sum, type) => sum + (eventCounts[type] || 0), 0);
+
+  // Only flag a run that did work but never reached its terminal event. A run
+  // with no activity at all is handled separately by each tool (e.g. gemini's
+  // emittedNoEvents check) and must not be double-counted here.
+  const incompleteSession = hadActivity && terminalCount === 0;
+
+  const diskEvidence = [];
+  for (const { source, text } of diskEvidenceTexts) {
+    if (text && isENOSPC(text)) {
+      diskEvidence.push({ source, text: String(text).replace(/\s+/g, ' ').trim().slice(0, 300) });
+    }
+  }
+  const diskPressureDetected = diskEvidence.length > 0;
+
+  const reasons = [];
+  if (incompleteSession) {
+    reasons.push(`The tool exited 0 but never emitted its terminal completion event (${terminalEventTypes.join('/')}); the session was cut off mid-run.`);
+    if (diskPressureDetected) {
+      reasons.push(`Disk-exhaustion signals were present in ${diskEvidence.length} location(s) (e.g. "No space left on device") — the likely cause of the interrupted session.`);
+    }
+  }
+
+  return {
+    healthy: !incompleteSession,
+    incompleteSession,
+    diskPressureDetected,
+    diskEvidence,
+    terminalCount,
+    reasons,
+  };
+};

package/src/use-m-bootstrap.lib.mjs

@@ -24,7 +24,7 @@ export const fetchUseMCodeFromCdn = async ({ fetcher = fetch } = {}) => {
   try {
     return await fetchUseMCodeFromUrl(USE_M_BOOTSTRAP_FALLBACK_URL, fetcher);
   } catch (fallbackError) {
-    throw new Error(`Failed to load use-m bootstrap from primary and fallback URLs: ${primaryError.message}; ${fallbackError.message}`);
+    throw new Error(`Failed to load use-m bootstrap from primary and fallback URLs: ${primaryError.message}; ${fallbackError.message}`, { cause: fallbackError });
   }
 };
 

package/src/useless-tools.lib.mjs

@@ -154,7 +154,7 @@ export const resolveClaudeSessionToolFlags = async ({ argv, log, fallbackBuildMc
 export const ensureDisallowedToolsInSettings = async ({ settingsPath, log } = {}) => {
   const resolvedPath = settingsPath || path.join(os.homedir(), '.claude', 'settings.json');
   const toBlock = buildDisallowedToolsList();
-  let settings = {};
+  let settings;
   try {
     const content = await fs.readFile(resolvedPath, 'utf-8');
     settings = JSON.parse(content);

package/src/youtrack/solve.youtrack.lib.mjs

@@ -15,8 +15,8 @@ const { parseYouTrackIssueId, updateYouTrackIssueStage, addYouTrackComment, crea
  * @returns {Object} Validation result with YouTrack info
  */
 export async function validateYouTrackUrl(issueUrl) {
-  let isYouTrackUrl = null;
-  let youTrackIssueId = null;
+  let isYouTrackUrl;
+  let youTrackIssueId;
   let youTrackConfig = null;
 
   if (!issueUrl) {

package/src/youtrack/youtrack.lib.mjs

@@ -128,7 +128,7 @@ async function makeYouTrackRequest(endpoint, config, options = {}) {
     return await response.json();
   } catch (error) {
     if (error.message.includes('fetch')) {
-      throw new Error(`Failed to connect to YouTrack at ${config.url}: ${error.message}`);
+      throw new Error(`Failed to connect to YouTrack at ${config.url}: ${error.message}`, { cause: error });
     }
     throw error;
   }