@link-assistant/hive-mind 2.0.11 → 2.0.12

package/CHANGELOG.md

@@ -1,5 +1,45 @@
 # @link-assistant/hive-mind
 
+## 2.0.12
+
+### Patch Changes
+
+- f17bac4: fix(clone): detect interrupted clones that exit 0, retry them, and explain the failure instead of the bare "Failed to get current branch" (#1957)
+
+  A `/solve` run crashed with the unactionable message `Failed to get current branch`.
+  Root cause: `gh repo clone` (and the `git clone` it wraps) **exited 0 even though the
+  transfer was interrupted** mid-stream (`fetch-pack: unexpected disconnect while reading
+sideband packet`), leaving **no `.git` directory** (`size=0 B`). The solver trusted the
+  exit code, logged `✅ Cloned to:`, then every subsequent git command failed with
+  `fatal: not a git repository`; the first to propagate it (`git branch --show-current` in
+  `verifyDefaultBranchAndStatus`) threw the bare error with no clue about what went wrong
+  or how to recover.
+
+  Defense-in-depth fix applied across the codebase:
+  - `cloneRepository()` (`src/solve.repository.lib.mjs`) no longer trusts the exit code:
+    after `gh repo clone` it validates the result with `git rev-parse --is-inside-work-tree`
+    and only treats the clone as successful when the exit code is 0 **and** a real working
+    tree exists. In `--verbose` mode it logs why a 0-exit clone was rejected.
+  - New exported helper `cleanPartialClone()` empties the target directory before each
+    retry so a partial clone does not make `gh repo clone <dir>` fail with "directory
+    exists and is not empty".
+  - `classifyCloneError()` now classifies the interrupted-transfer vocabulary
+    (`unexpected disconnect`, `sideband`, `early eof`, `the remote end hung up`,
+    `rpc failed`, `fetch-pack`, `index-pack failed`, `transfer closed`) as a retryable
+    `NETWORK` error, so the existing 3× exponential-backoff retry loop recovers from it.
+    404 / ENOSPC / auth failures stay non-retryable.
+  - `isTransientNetworkError()` (`src/lib.mjs`, shared by many gh/git retry call sites)
+    gains the same vocabulary, so the fix propagates everywhere — not just the clone path.
+  - Both failure points now print concrete, root-cause-obvious guidance: the clone-failure
+    path adds NETWORK causes/fixes, and `verifyDefaultBranchAndStatus()`
+    (`src/solve.repo-setup.lib.mjs`) detects `not a git repository` and logs an
+    `INCOMPLETE CLONE DETECTED` block (What happened / Error details / How to fix:
+    check network·VPN·proxy, re-run — clones auto-retry, verify access, check GitHub
+    status) instead of the bare message.
+
+  Adds `tests/test-issue-1957-incomplete-clone.mjs` (26 assertions) and a deep case study
+  in `docs/case-studies/issue-1957/`.
+
 ## 2.0.11
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "2.0.11",
+  "version": "2.0.12",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/lib.mjs

@@ -471,7 +471,10 @@ export const isTransientNetworkError = error => {
   const combined = msg + ' ' + output;
 
   // Issue #1536: added 'unexpected eof' — seen in gh CLI when connection drops mid-response
-  const transientPatterns = ['i/o timeout', 'dial tcp', 'connection refused', 'connection reset', 'econnreset', 'etimedout', 'enotfound', 'ehostunreach', 'enetunreach', 'network is unreachable', 'temporary failure', 'http 502', 'http 503', 'http 504', 'bad gateway', 'service unavailable', 'gateway timeout', 'tls handshake timeout', 'ssl_error', 'socket hang up', 'unexpected eof'];
+  // Issue #1957: added git fetch-pack/sideband disconnect patterns — seen when a
+  // `gh repo clone` / `git clone` connection drops mid-transfer, leaving an incomplete
+  // (or missing) working tree even though the wrapper can exit 0.
+  const transientPatterns = ['i/o timeout', 'dial tcp', 'connection refused', 'connection reset', 'econnreset', 'etimedout', 'enotfound', 'ehostunreach', 'enetunreach', 'network is unreachable', 'temporary failure', 'http 502', 'http 503', 'http 504', 'bad gateway', 'service unavailable', 'gateway timeout', 'tls handshake timeout', 'ssl_error', 'socket hang up', 'unexpected eof', 'unexpected disconnect', 'sideband', 'early eof', 'the remote end hung up', 'rpc failed', 'fetch-pack', 'index-pack failed', 'remote end hung up unexpectedly', 'transfer closed'];
 
   return transientPatterns.some(pattern => combined.includes(pattern));
 };

package/src/solve.repo-setup.lib.mjs

@@ -65,9 +65,44 @@ export async function verifyDefaultBranchAndStatus({ tempDir, log, formatAligned
   const defaultBranchResult = await $({ cwd: tempDir })`git branch --show-current`;
 
   if (defaultBranchResult.code !== 0) {
+    // Issue #1957: the most common cause of this failure is an interrupted/incomplete
+    // clone — `git` reports "fatal: not a git repository" because there is no `.git`
+    // directory. The previous message ("Failed to get current branch") gave the user
+    // no idea what happened or what to do. Detect the incomplete-clone case and give
+    // concrete, actionable instructions instead.
+    const branchErr = ((defaultBranchResult.stderr?.toString() || '') + (defaultBranchResult.stdout?.toString() || '')).trim();
+    const isNotAGitRepo = /not a git repository/i.test(branchErr);
+
+    await log('');
+    await log(`${formatAligned('❌', isNotAGitRepo ? 'INCOMPLETE CLONE DETECTED' : 'FAILED TO READ CURRENT BRANCH', '')}`, { level: 'error' });
+    await log('');
+    await log('  🔍 What happened:');
+    if (isNotAGitRepo) {
+      await log(`     The working directory is not a valid git repository: ${tempDir}`);
+      await log('     This almost always means the clone was interrupted before it finished');
+      await log('     (e.g. "fetch-pack: unexpected disconnect while reading sideband packet"),');
+      await log('     so no .git directory was created.');
+    } else {
+      await log(`     Could not determine the current branch in: ${tempDir}`);
+    }
+    await log('');
+    await log('  📦 Error details:');
+    for (const line of (branchErr || 'Unknown error').split('\n')) {
+      if (line.trim()) await log(`     ${line}`);
+    }
+    await log('');
+    await log('  🔧 How to fix:');
+    await log('     1. Check your network connection / VPN / proxy (interrupted transfers are usually transient)');
+    await log('     2. Re-run the command — the solver retries clones automatically and a fresh run usually succeeds');
+    if (owner && repo) await log(`     3. Verify access to the repository: gh repo view ${owner}/${repo}`);
+    await log(`     ${owner && repo ? '4' : '3'}. Check GitHub status if it keeps failing: https://www.githubstatus.com`);
+    await log('');
+    await log('  ℹ️  If this is reproducible, ask a Hive Mind administrator to inspect the solver terminal log for the clone error.');
+    await log('');
+
     await log('Error: Failed to get current branch');
-    await log(defaultBranchResult.stderr ? defaultBranchResult.stderr.toString() : 'Unknown error');
-    throw new Error('Failed to get current branch');
+    if (branchErr) await log(branchErr);
+    throw new Error(isNotAGitRepo ? 'Failed to get current branch - working directory is not a git repository (incomplete clone)' : 'Failed to get current branch');
   }
 
   let defaultBranch = defaultBranchResult.stdout.toString().trim();

package/src/solve.repository.lib.mjs

@@ -922,8 +922,12 @@ export const classifyCloneError = errorOutput => {
   }
 
   // Network-related errors - typically retryable
-  if (output.includes('connection refused') || output.includes('connection timed out') || output.includes('connection reset') || output.includes('unable to connect') || output.includes('network is unreachable') || output.includes('ssl error')) {
-    return { type: 'NETWORK', retryable: true, description: 'Network connectivity issue' };
+  // Issue #1957: git fetch-pack/sideband disconnects (e.g.
+  // "fetch-pack: unexpected disconnect while reading sideband packet",
+  // "early EOF", "the remote end hung up unexpectedly", "RPC failed",
+  // "index-pack failed") leave an incomplete or missing clone but are transient.
+  if (output.includes('connection refused') || output.includes('connection timed out') || output.includes('connection reset') || output.includes('unable to connect') || output.includes('network is unreachable') || output.includes('ssl error') || output.includes('unexpected disconnect') || output.includes('sideband') || output.includes('early eof') || output.includes('remote end hung up') || output.includes('rpc failed') || output.includes('fetch-pack') || output.includes('index-pack failed') || output.includes('transfer closed')) {
+    return { type: 'NETWORK', retryable: true, description: 'Network connectivity issue (interrupted transfer)' };
   }
 
   // Authentication/permission errors - not retryable
@@ -945,6 +949,24 @@ export const classifyCloneError = errorOutput => {
   return { type: 'UNKNOWN', retryable: true, description: 'Unknown error' };
 };
 
+// Issue #1957: remove leftovers from an interrupted clone so a retry can start clean.
+// We empty the directory in place (rather than removing it) because the path was
+// created up-front by setupTempDirectory and may be the configured working directory.
+export const cleanPartialClone = async tempDir => {
+  try {
+    const entries = await fs.readdir(tempDir);
+    for (const entry of entries) {
+      await fs.rm(path.join(tempDir, entry), { recursive: true, force: true });
+    }
+  } catch (error) {
+    // Directory may not exist yet, or be unreadable — non-fatal; the retry/clone
+    // will surface any real problem with a clearer message.
+    if (error?.code !== 'ENOENT') {
+      reportError(error, { context: 'clean_partial_clone', tempDir, operation: 'empty_directory' });
+    }
+  }
+};
+
 // Clone repository and set up remotes with retry mechanism
 export const cloneRepository = async (repoToClone, tempDir, argv, owner, repo) => {
   const maxRetries = 3;
@@ -959,9 +981,25 @@ export const cloneRepository = async (repoToClone, tempDir, argv, owner, repo) =
 
     // Use 2>&1 to capture all output and filter "Cloning into" message
     const cloneResult = await $`gh repo clone ${repoToClone} ${tempDir} 2>&1`;
-
-    // Verify clone was successful
+    const cloneOutput = (cloneResult.stdout || cloneResult.stderr || '').toString().trim();
+
+    // Issue #1957: `gh repo clone` (and the `git clone` it wraps) can exit 0 even when
+    // the underlying transfer was interrupted — e.g. "fetch-pack: unexpected disconnect
+    // while reading sideband packet" — leaving an incomplete or completely missing
+    // working tree (no `.git`). Trusting the exit code alone made the solver report
+    // "✅ Cloned to:" and then crash much later with the unhelpful "Failed to get
+    // current branch". Verify the clone actually produced a usable git repository.
+    let repoIsValid = false;
     if (cloneResult.code === 0) {
+      const validityCheck = await $({ cwd: tempDir })`git rev-parse --is-inside-work-tree 2>&1`;
+      repoIsValid = validityCheck.code === 0 && validityCheck.stdout.toString().trim() === 'true';
+      if (!repoIsValid && argv.verbose) {
+        await log(`${formatAligned('🔧', 'Clone validation:', `git rev-parse failed despite exit 0 — ${(validityCheck.stdout || validityCheck.stderr || '').toString().trim().split('\n')[0]}`)}`);
+      }
+    }
+
+    // Verify clone was successful (exit code 0 AND a valid working tree exists)
+    if (cloneResult.code === 0 && repoIsValid) {
       await log(`${formatAligned('✅', 'Cloned to:', tempDir)}`);
 
       // Verify and fix remote configuration
@@ -975,7 +1013,15 @@ export const cloneRepository = async (repoToClone, tempDir, argv, owner, repo) =
     }
 
     // Clone failed - analyze error and determine if retry is appropriate
-    const errorOutput = (cloneResult.stderr || cloneResult.stdout || 'Unknown error').toString().trim();
+    // Issue #1957: when the wrapper exited 0 but left no valid repo, surface the
+    // interrupted-transfer output (which carries the real "unexpected disconnect"
+    // reason) so it is classified as a retryable network error rather than UNKNOWN.
+    const errorOutput = cloneResult.code === 0 && !repoIsValid ? cloneOutput || 'Clone exited 0 but no valid git repository was created (interrupted transfer / incomplete clone)' : (cloneResult.stderr || cloneResult.stdout || 'Unknown error').toString().trim();
+
+    // Issue #1957: a partial clone can leave stray files behind that make a retry of
+    // `gh repo clone <dir>` fail with "directory exists and is not empty". Clean the
+    // target directory before classifying/retrying so the next attempt starts fresh.
+    await cleanPartialClone(tempDir);
 
     const errorClassification = classifyCloneError(errorOutput);
 
@@ -1015,6 +1061,9 @@ export const cloneRepository = async (repoToClone, tempDir, argv, owner, repo) =
         await log('     • Network connectivity issues');
         if (errorClassification.type === 'TRANSIENT') await log('     • GitHub server issues (temporary)');
         if (errorClassification.type === 'RATE_LIMIT') await log('     • API rate limiting exceeded');
+        // Issue #1957: the transfer started but was interrupted (e.g. the connection
+        // dropped while reading the pack). The retries above were already exhausted.
+        if (errorClassification.type === 'NETWORK') await log('     • Connection dropped mid-transfer (the clone was interrupted before completing)');
         if (argv.fork) await log('     • Fork not ready yet (try again in a moment)');
         await log('');
         await log('  🔧 How to fix:');
@@ -1024,6 +1073,11 @@ export const cloneRepository = async (repoToClone, tempDir, argv, owner, repo) =
         if (argv.fork) await log(`     4. Check fork: gh repo view ${repoToClone}`);
         if (errorClassification.type === 'TRANSIENT') await log('     5. Wait and retry / check: https://www.githubstatus.com');
         if (errorClassification.type === 'RATE_LIMIT') await log('     5. Wait for rate limit to reset or use --token with different token');
+        if (errorClassification.type === 'NETWORK') {
+          await log('     5. Check your network connection / VPN / proxy, then re-run the command');
+          await log('     6. On slow or unstable links, a shallower history transfers faster and is less');
+          await log('        likely to be interrupted; ask a Hive Mind administrator if clone tuning is available');
+        }
         await log('');
       }
       await safeExit(1, 'Repository setup failed');