@link-assistant/hive-mind 1.78.1 → 1.78.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @link-assistant/hive-mind
 
+## 1.78.3
+
+### Patch Changes
+
+- b346808: Use the latest gh-upload-log package for attached log uploads and rely on its default auto mode/shared repository fallback instead of passing explicit strategy flags.
+
+## 1.78.2
+
+### Patch Changes
+
+- 70db26f: Ensure Telegram work-session completion messages recover pull request links from completed solve logs when linked-issue lookup does not return a PR.
+
 ## 1.78.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.78.1",
+  "version": "1.78.3",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/github.lib.mjs

@@ -631,7 +631,7 @@ ${logContent}
         // Use the original sanitized content for upload since it's a plain text file
         await fs.writeFile(tempLogFile, await sanitizeLogContent(rawLogContent));
 
-        // Use gh-upload-log to upload the log file
+        // Use gh-upload-log default auto mode and shared repository fallback.
         const uploadDescription = `Solution draft log for https://github.com/${owner}/${repo}/${targetType === 'pr' ? 'pull' : 'issues'}/${targetNumber}`;
         const uploadResult = await uploadLogWithGhUploadLog({
           logFile: tempLogFile,

package/src/log-upload.lib.mjs

@@ -28,6 +28,63 @@ const summarizeCommandOutput = value => {
   return text.length > 500 ? `${text.slice(0, 500)}... [truncated ${text.length - 500} chars]` : text;
 };
 
+export const buildGhUploadLogArgs = ({ logFile, isPublic, description, verbose = false }) => {
+  if (!logFile) {
+    throw new Error('logFile is required for gh-upload-log');
+  }
+
+  const args = [logFile, isPublic ? '--public' : '--private'];
+
+  if (description) {
+    args.push('--description', description);
+  }
+  if (verbose) {
+    args.push('--verbose');
+  }
+
+  return args;
+};
+
+const quoteShellArg = value => {
+  const text = String(value);
+  if (/^[A-Za-z0-9_./:=@+-]+$/u.test(text)) return text;
+  return `"${text.replace(/(["\\$`])/gu, '\\$1')}"`;
+};
+
+const formatGhUploadLogCommand = args => `gh-upload-log ${args.map(quoteShellArg).join(' ')}`;
+
+const runGhUploadLogCommand = async args => {
+  const { spawn } = await use('child_process');
+
+  return new Promise(resolve => {
+    const child = spawn('gh-upload-log', args, { stdio: ['ignore', 'pipe', 'pipe'] });
+    let stdout = '';
+    let stderr = '';
+    let settled = false;
+
+    const settle = value => {
+      if (!settled) {
+        settled = true;
+        resolve(value);
+      }
+    };
+
+    child.stdout?.on('data', chunk => {
+      stdout += chunk.toString();
+    });
+    child.stderr?.on('data', chunk => {
+      stderr += chunk.toString();
+    });
+    child.on('error', error => {
+      const errorText = stderr ? `${stderr}\n${error.message}` : error.message;
+      settle({ code: error.code === 'ENOENT' ? 127 : 1, stdout, stderr: errorText });
+    });
+    child.on('close', code => {
+      settle({ code: code ?? 1, stdout, stderr });
+    });
+  });
+};
+
 export const parseGhUploadLogOutput = outputValue => {
   const output = outputValue?.toString?.() || '';
   const parsed = {
@@ -89,30 +146,18 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
   const result = { success: false, url: null, rawUrl: null, type: null, chunks: 1 };
 
   try {
-    // Build command flags
-    // IMPORTANT: When using command-stream's $ template tag, each ${} interpolation is treated
-    // as a single argument. DO NOT use commandArgs.join(' ') as it will make all flags part
-    // of the first positional argument, causing "File does not exist" errors.
-    // See case study: docs/case-studies/issue-1096/README.md
-    const publicFlag = isPublic ? '--public' : '--private';
+    const commandArgs = buildGhUploadLogArgs({
+      logFile,
+      isPublic,
+      description,
+      verbose,
+    });
 
     if (verbose) {
-      const descDisplay = description ? ` --description "${description}"` : '';
-      await log(`  📤 Running: gh-upload-log "${logFile}" ${publicFlag}${descDisplay} --verbose`, { verbose: true });
+      await log(`  📤 Running: ${formatGhUploadLogCommand(commandArgs)}`, { verbose: true });
     }
 
-    // Execute command with separate interpolations for each argument
-    // Each ${} is properly passed as a separate argument to the shell
-    let uploadResult;
-    if (description && verbose) {
-      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --description ${description} --verbose`;
-    } else if (description) {
-      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --description ${description}`;
-    } else if (verbose) {
-      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --verbose`;
-    } else {
-      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag}`;
-    }
+    const uploadResult = await runGhUploadLogCommand(commandArgs);
     const output = (uploadResult.stdout?.toString() || '') + (uploadResult.stderr?.toString() || '');
 
     if (uploadResult.code !== 0) {
@@ -252,5 +297,6 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
 // Export all functions as default object too
 export default {
   parseGhUploadLogOutput,
+  buildGhUploadLogArgs,
   uploadLogWithGhUploadLog,
 };

package/src/session-monitor.lib.mjs

@@ -15,8 +15,9 @@
  * @see https://github.com/link-assistant/hive-mind/issues/380
  */
 
-import { promisify } from 'util';
 import { exec as execCallback } from 'child_process';
+import fs from 'fs/promises';
+import { promisify } from 'util';
 import { formatSessionCompletionMessage, getSessionCompletionExitCode } from './work-session-formatting.lib.mjs';
 import { notifySubscribers, getSubscriberCount } from './telegram-subscribers.lib.mjs';
 
@@ -157,6 +158,45 @@ function normalizeSessionUrl(url) {
   return url.replace(/#.*$/, '').replace(/\/+$/, '').toLowerCase();
 }
 
+const GITHUB_PULL_REQUEST_URL_RE = /https:\/\/github\.com\/([A-Za-z0-9_.-]+)\/([A-Za-z0-9_.-]+)\/pull\/([0-9]+)/g;
+
+export function extractPullRequestUrlFromText(text, { owner = null, repo = null } = {}) {
+  if (!text) return null;
+
+  const expectedOwner = owner ? String(owner).toLowerCase() : null;
+  const expectedRepo = repo ? String(repo).toLowerCase() : null;
+  const value = String(text);
+  GITHUB_PULL_REQUEST_URL_RE.lastIndex = 0;
+
+  let match;
+  while ((match = GITHUB_PULL_REQUEST_URL_RE.exec(value)) !== null) {
+    const [, matchOwner, matchRepo, pullNumber] = match;
+    if (expectedOwner && matchOwner.toLowerCase() !== expectedOwner) continue;
+    if (expectedRepo && matchRepo.toLowerCase() !== expectedRepo) continue;
+    return `https://github.com/${matchOwner}/${matchRepo}/pull/${pullNumber}`;
+  }
+
+  return null;
+}
+
+async function resolvePullRequestUrlFromSessionLog(logPath, ctx, { verbose = false, readFile = fs.readFile } = {}) {
+  if (!logPath) return null;
+
+  try {
+    const logText = await readFile(logPath, 'utf8');
+    const pullRequestUrl = extractPullRequestUrlFromText(logText, { owner: ctx.owner, repo: ctx.repo });
+    if (pullRequestUrl && verbose) {
+      console.log(`[VERBOSE] Found PR ${pullRequestUrl} in completed session log ${logPath}`);
+    }
+    return pullRequestUrl;
+  } catch (error) {
+    if (verbose) {
+      console.log(`[VERBOSE] Could not inspect session log ${logPath} for PR URL: ${error?.message || error}`);
+    }
+    return null;
+  }
+}
+
 function isNonIsolationSessionActive(sessionName, sessionInfo, verbose = false) {
   const startTime = sessionInfo.startTime instanceof Date ? sessionInfo.startTime : new Date(sessionInfo.startTime);
   const elapsed = Date.now() - startTime.getTime();
@@ -272,13 +312,19 @@ export async function monitorSessions(bot, verbose = false, options = {}) {
       try {
         const finalExitCode = getSessionCompletionExitCode({ exitCode, statusResult });
 
-        // Issue #1688: When the original /solve URL was an issue, look up the
-        //   linked PR so the completion message can include both an `Issue:` and
-        //   a `Pull request:` line. Failures are logged and ignored — the
-        //   notification still goes out without the PR line.
+        // Issue #1688/#1905: When the original /solve URL was an issue, look up
+        //   the created PR so the completion message can include both an
+        //   `Issue:` and a `Pull request:` line. The linked-issue API can lag
+        //   behind the solver's own verification log, so we also inspect the
+        //   completed session log before giving up.
         let pullRequestUrl = null;
         try {
-          pullRequestUrl = await resolvePullRequestUrlForSession(sessionInfo, { verbose, lookupLinkedPullRequest: options.lookupLinkedPullRequest });
+          pullRequestUrl = await resolvePullRequestUrlForSession(sessionInfo, {
+            verbose,
+            lookupLinkedPullRequest: options.lookupLinkedPullRequest,
+            statusResult,
+            readFile: options.readFile,
+          });
         } catch (lookupError) {
           if (verbose) {
             console.log(`[VERBOSE] Pull request lookup failed for ${sessionName}: ${lookupError?.message || lookupError}`);
@@ -395,36 +441,50 @@ export async function monitorSessions(bot, verbose = false, options = {}) {
  * @param {Object} [options]
  * @param {boolean} [options.verbose]
  * @param {Function} [options.lookupLinkedPullRequest] - Optional override `(ctx) => Promise<string|null>`
+ * @param {Object} [options.statusResult] - Completed start-command status payload, including logPath
+ * @param {Function} [options.readFile] - Optional test override for reading session logs
  * @returns {Promise<string|null>} PR URL or null
  *
  * @see https://github.com/link-assistant/hive-mind/issues/1688
+ * @see https://github.com/link-assistant/hive-mind/issues/1905
  */
-async function resolvePullRequestUrlForSession(sessionInfo, { verbose = false, lookupLinkedPullRequest = null } = {}) {
+async function resolvePullRequestUrlForSession(sessionInfo, { verbose = false, lookupLinkedPullRequest = null, statusResult = null, readFile = fs.readFile } = {}) {
   const ctx = sessionInfo?.urlContext;
   if (!ctx || ctx.type !== 'issue' || !ctx.owner || !ctx.repo || !ctx.number) {
     return null;
   }
 
   if (typeof lookupLinkedPullRequest === 'function') {
-    return await lookupLinkedPullRequest(ctx);
-  }
-
-  try {
-    const { batchCheckPullRequestsForIssues } = await import('./github.lib.mjs');
-    const result = await batchCheckPullRequestsForIssues(ctx.owner, ctx.repo, [ctx.number]);
-    const linkedPRs = result?.[ctx.number]?.linkedPRs || [];
-    if (linkedPRs.length > 0 && linkedPRs[0].url) {
+    const linkedPullRequestUrl = await lookupLinkedPullRequest(ctx);
+    if (linkedPullRequestUrl) return linkedPullRequestUrl;
+  } else {
+    try {
+      const { batchCheckPullRequestsForIssues } = await import('./github.lib.mjs');
+      const result = await batchCheckPullRequestsForIssues(ctx.owner, ctx.repo, [ctx.number]);
+      const linkedPRs = result?.[ctx.number]?.linkedPRs || [];
+      if (linkedPRs.length > 0 && linkedPRs[0].url) {
+        if (verbose) {
+          console.log(`[VERBOSE] Found linked PR ${linkedPRs[0].url} for issue ${ctx.owner}/${ctx.repo}#${ctx.number}`);
+        }
+        return linkedPRs[0].url;
+      }
+    } catch (error) {
       if (verbose) {
-        console.log(`[VERBOSE] Found linked PR ${linkedPRs[0].url} for issue ${ctx.owner}/${ctx.repo}#${ctx.number}`);
+        console.log(`[VERBOSE] batchCheckPullRequestsForIssues failed for ${ctx.owner}/${ctx.repo}#${ctx.number}: ${error?.message || error}`);
       }
-      return linkedPRs[0].url;
-    }
-  } catch (error) {
-    if (verbose) {
-      console.log(`[VERBOSE] batchCheckPullRequestsForIssues failed for ${ctx.owner}/${ctx.repo}#${ctx.number}: ${error?.message || error}`);
     }
-    throw error;
   }
+
+  const logPath = statusResult?.logPath || sessionInfo?.logPath || null;
+  const pullRequestUrlFromLog = await resolvePullRequestUrlFromSessionLog(logPath, ctx, { verbose, readFile });
+  if (pullRequestUrlFromLog) return pullRequestUrlFromLog;
+
+  if (verbose && logPath) {
+    console.log(`[VERBOSE] No PR URL found for issue ${ctx.owner}/${ctx.repo}#${ctx.number} in session log ${logPath}`);
+  } else if (verbose) {
+    console.log(`[VERBOSE] No session log path available for PR URL fallback for issue ${ctx.owner}/${ctx.repo}#${ctx.number}`);
+  }
+
   return null;
 }