@link-assistant/hive-mind 1.69.15 → 1.69.16

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 1.69.16
+
+### Patch Changes
+
+- ca0d938: Fix Telegram work-session completion failing with "Bad Request: can't parse entities" when the discovered Pull request URL contained Markdown-significant characters (`_`, `*`, `` ` ``, `[`). `appendPullRequestLine` (issue #1688) inserted the raw URL into a Markdown message even though the surrounding `Issue:` line was already escaped by `buildTelegramInfoBlock`, so a repo slug like `save_visiogetbb/pull/8` opened an italic entity at byte offset 318 that never closed. The appended `Pull request:` line is now passed through `escapeMarkdown`, and `safeReply`/`safeEditMessageText`/`installTelegramFormattingFallback` now log the offending byte-offset window and the plain-text fallback under `--verbose` so future parse errors point straight to the unescaped character. Resolves #1801.
+
 ## 1.69.15
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.69.15",
+  "version": "1.69.16",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/telegram-safe-reply.lib.mjs

@@ -49,11 +49,30 @@ export function buildTelegramFormattingFallbackText(text, options = {}) {
   return `${getFormattingFallbackWarning(locale)}\n\n${stripTelegramMarkdown(text)}`;
 }
 
-function logFormattingFailure(scope, error, text, verbose = false) {
+function logFormattingFailure(scope, error, text, verbose = false, fallbackText = null) {
   const message = error?.description || error?.message || String(error || '');
   console.error(`[telegram-bot] ${scope}: formatted Telegram message failed: ${message}`);
   if (verbose) {
-    console.error(`[telegram-bot] ${scope}: Failing message (${Buffer.byteLength(String(text ?? ''), 'utf-8')} bytes): ${text}`);
+    const originalBytes = Buffer.byteLength(String(text ?? ''), 'utf-8');
+    console.error(`[telegram-bot] ${scope}: Failing message (${originalBytes} bytes): ${text}`);
+    // Issue #1801: when the parser rejects an entity, surface the byte offset
+    //   from the error along with a small window of the message around it to
+    //   make pinpointing the offending character trivial on the next iteration.
+    const offsetMatch = /byte offset (\d+)/i.exec(message);
+    if (offsetMatch) {
+      const offset = Number(offsetMatch[1]);
+      const buf = Buffer.from(String(text ?? ''), 'utf-8');
+      const start = Math.max(0, offset - 32);
+      const end = Math.min(buf.length, offset + 32);
+      // Decode the window; replacement character is used for bytes that fall
+      // mid-codepoint so we still print *something* useful.
+      const window = buf.slice(start, end).toString('utf-8');
+      console.error(`[telegram-bot] ${scope}: Byte offset ${offset} context [${start}..${end}]: ${JSON.stringify(window)}`);
+    }
+    if (fallbackText !== null) {
+      const fallbackBytes = Buffer.byteLength(String(fallbackText ?? ''), 'utf-8');
+      console.error(`[telegram-bot] ${scope}: Fallback message (${fallbackBytes} bytes): ${fallbackText}`);
+    }
   }
 }
 
@@ -65,8 +84,8 @@ export async function safeReply(ctx, text, options = {}) {
     return await ctx.reply(text, firstOptions);
   } catch (error) {
     if (!isTelegramFormattingError(error)) throw error;
-    logFormattingFailure('safeReply', error, text, verbose);
     const fallbackText = buildTelegramFormattingFallbackText(text, { fallbackLocale });
+    logFormattingFailure('safeReply', error, text, verbose, fallbackText);
     return await ctx.reply(fallbackText, { ...telegramOptions, parse_mode: undefined });
   }
 }
@@ -78,8 +97,8 @@ export async function safeEditMessageText(telegram, chatId, messageId, inlineMes
     return await telegram.editMessageText(chatId, messageId, inlineMessageId, text, firstOptions);
   } catch (error) {
     if (!isTelegramFormattingError(error)) throw error;
-    logFormattingFailure('safeEditMessageText', error, text, verbose);
     const fallbackText = buildTelegramFormattingFallbackText(text, { fallbackLocale });
+    logFormattingFailure('safeEditMessageText', error, text, verbose, fallbackText);
     return await telegram.editMessageText(chatId, messageId, inlineMessageId, fallbackText, { ...telegramOptions, parse_mode: undefined });
   }
 }
@@ -98,9 +117,10 @@ function wrapTelegramMethod(telegram, methodName, textIndex, optionsIndex, defau
       return await original.apply(this, args);
     } catch (error) {
       if (!isTelegramFormattingError(error) || typeof text !== 'string') throw error;
-      logFormattingFailure(methodName, error, text, verbose || defaults.verbose);
+      const fallbackText = buildTelegramFormattingFallbackText(text, { fallbackLocale: fallbackLocale || defaults.fallbackLocale });
+      logFormattingFailure(methodName, error, text, verbose || defaults.verbose, fallbackText);
       const retryArgs = [...args];
-      retryArgs[textIndex] = buildTelegramFormattingFallbackText(text, { fallbackLocale: fallbackLocale || defaults.fallbackLocale });
+      retryArgs[textIndex] = fallbackText;
       retryArgs[optionsIndex] = { ...telegramOptions, parse_mode: undefined };
       return await original.apply(this, retryArgs);
     }

package/src/work-session-formatting.lib.mjs

@@ -1,4 +1,5 @@
 import { t } from './i18n.lib.mjs';
+import { escapeMarkdown } from './telegram-markdown.lib.mjs';
 
 const FAILURE_STATUSES = new Set(['failed', 'cancelled', 'canceled', 'error']);
 
@@ -74,7 +75,7 @@ export function formatExecutingWorkSessionMessage({ sessionName = 'unknown', iso
  */
 export function appendPullRequestLine(infoBlock, pullRequestUrl, { locale = null } = {}) {
   if (!pullRequestUrl || !infoBlock) return infoBlock || '';
-  if (infoBlock.includes(pullRequestUrl)) return infoBlock;
+  if (infoBlock.includes(pullRequestUrl) || infoBlock.includes(escapeMarkdown(pullRequestUrl))) return infoBlock;
 
   const lines = infoBlock.split('\n');
   let lastUrlLineIdx = -1;
@@ -89,7 +90,10 @@ export function appendPullRequestLine(infoBlock, pullRequestUrl, { locale = null
       lastUrlLineIdx = i;
     }
   }
-  const prLine = `${text(locale, 'telegram.info_pull_request_label', 'Pull request')}: ${pullRequestUrl}`;
+  // Issue #1801: escape underscores/asterisks so Markdown parser doesn't open
+  //   an entity on URLs like .../save_visiogetbb/pull/8 that the Issue: line
+  //   above already had escaped at buildTelegramInfoBlock time.
+  const prLine = `${text(locale, 'telegram.info_pull_request_label', 'Pull request')}: ${escapeMarkdown(pullRequestUrl)}`;
   if (lastUrlLineIdx === -1) {
     return `${infoBlock}\n${prLine}`;
   }