@link-assistant/hive-mind 1.67.1 → 1.68.0

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @link-assistant/hive-mind
 
+## 1.68.0
+
+### Minor Changes
+
+- cbc7033: Switch the test runner to folder-based discovery and deprecate `start-screen` in favour of `--isolated screen` (issue #1758).
+  - `scripts/run-tests.mjs` now discovers every `*.mjs` / `*.test.mjs` / `*.test.js` file under `tests/` automatically. The hard-coded `LEGACY_DEFAULT_TESTS` allow-list is gone, so new test files no longer need a runner update to be picked up.
+  - New markers complement the existing `@hive-mind-test-suite <name>` marker:
+    - `@hive-mind-integration` — skip the file in the default suite; opt in via `--suite integration` or `HIVE_MIND_RUN_INTEGRATION=1`.
+    - `@hive-mind-test-skip` — exclude helper / fixture modules from every suite.
+  - `tests/integration-guard.mjs` exposes `skipUnlessIntegration(import.meta.url)` for token- or network-heavy tests.
+  - `src/start-screen.mjs` and `src/telegram-command-execution.lib.mjs::executeStartScreen` print a one-shot deprecation banner to stderr (suppressible with `HIVE_MIND_SUPPRESS_DEPRECATIONS=1`) recommending `--isolated screen`, which is already the default for `hive`/`solve` invocations through the Telegram bot.
+  - Adds regression tests `tests/test-issue-1758-runner-discovery.mjs`, `tests/test-issue-1758-start-screen-deprecation.mjs`, and `tests/test-issue-1758-integration-guard.mjs`.
+  - Documents the analysis under `docs/case-studies/issue-1758/`.
+
+## 1.67.2
+
+### Patch Changes
+
+- 240231e: Verify the pull request still links to the issue after every work session inside `--watch`, `--auto-restart-until-mergeable`, and `--finalize`, so that an iteration that turns out to be the last one cannot leave the PR un-linked when the AI rewrote the description without a closing keyword.
+
 ## 1.67.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.67.1",
+  "version": "1.68.0",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.auto-ensure.lib.mjs

@@ -23,12 +23,21 @@ const { wrapDollarWithGhRetry } = await import('./github-rate-limit.lib.mjs');
 const $ = wrapDollarWithGhRetry(__rawDollar$);
 // Import shared library functions
 const lib = await import('./lib.mjs');
-const { log } = lib;
+const { log, cleanErrorMessage } = lib;
 
 // Import shared restart utilities
 const restartShared = await import('./solve.restart-shared.lib.mjs');
 const { executeToolIteration } = restartShared;
 
+// Issue #1763: Re-verify PR ↔ issue link after every finalize iteration so a
+// PR body that the AI rewrote without a closing keyword does not survive past
+// the last requirements-check.
+const resultsLib = await import('./solve.results.lib.mjs');
+const { ensurePullRequestIssueLink } = resultsLib;
+
+const sentryLib = await import('./sentry.lib.mjs');
+const { reportError } = sentryLib;
+
 /**
  * Runs finalize requirements-check iterations after the main solve.
  *
@@ -116,6 +125,34 @@ export const runAutoEnsureRequirements = async ({ issueUrl, owner, repo, issueNu
       if (ensureResult.pricingInfo) pricingInfo = ensureResult.pricingInfo;
     }
 
+    // Issue #1763: Re-verify the PR body contains a closing keyword for the
+    // issue after every finalize iteration. The AI agent can rewrite the PR
+    // description mid-session and any iteration may end up being the last
+    // one, so this check cannot be deferred to the top-level verifyResults
+    // path.
+    if (prNumber && issueNumber && owner && repo) {
+      try {
+        await log('🔗 Verifying PR issue link after finalize iteration...');
+        await ensurePullRequestIssueLink({
+          prNumber,
+          issueNumber,
+          owner,
+          repo,
+          argv,
+        });
+      } catch (issueLinkError) {
+        reportError(issueLinkError, {
+          context: 'ensure_pr_issue_link_finalize_iteration',
+          prNumber,
+          owner,
+          repo,
+          ensureIteration,
+          operation: 'ensure_pr_issue_link',
+        });
+        await log(`⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, { level: 'warning' });
+      }
+    }
+
     await log(`✅ FINALIZE iteration ${ensureIteration}/${finalizeCount} complete`);
     await log('');
   }

package/src/solve.auto-merge.lib.mjs

@@ -60,8 +60,10 @@ const toolComments = await import('./tool-comments.lib.mjs');
 const { READY_TO_MERGE_MARKER, AUTO_RESTART_MARKER, AUTO_MERGED_MARKER, postTrackedComment } = toolComments;
 
 // Issue #1728: Per-iteration working session summary attachment helper
+// Issue #1763: Per-iteration PR ↔ issue link verification (so a clobbered
+// PR body is restored before the next stop condition fires).
 const resultsLib = await import('./solve.results.lib.mjs');
-const { maybeAttachWorkingSessionSummary } = resultsLib;
+const { maybeAttachWorkingSessionSummary, ensurePullRequestIssueLink } = resultsLib;
 
 // Issue #1574: Interruptible sleep so CTRL+C is never blocked by a lingering timer
 const { interruptibleSleep } = await import('./interruptible-sleep.lib.mjs');
@@ -942,6 +944,35 @@ No further AI sessions will be started automatically for this run. Please review
             }
           }
 
+          // Issue #1763: Re-verify the PR body contains a closing keyword for
+          // the issue after every auto-restart-until-mergeable iteration. The
+          // AI agent can rewrite the PR description mid-session and any
+          // iteration may end up being the last one (mergeable, max-iters,
+          // billing limit, etc.), so this check cannot be deferred to the
+          // top-level verifyResults path.
+          if (prNumber && issueNumber && owner && repo) {
+            try {
+              await log(formatAligned('🔗', 'Verifying PR issue link after iteration...', '', 2));
+              await ensurePullRequestIssueLink({
+                prNumber,
+                issueNumber,
+                owner,
+                repo,
+                argv,
+              });
+            } catch (issueLinkError) {
+              reportError(issueLinkError, {
+                context: 'ensure_pr_issue_link_auto_restart_iteration',
+                prNumber,
+                owner,
+                repo,
+                iteration,
+                operation: 'ensure_pr_issue_link',
+              });
+              await log(formatAligned('', `⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, '', 2));
+            }
+          }
+
           await log('');
           await log(formatAligned('✅', `${argv.tool.toUpperCase()} execution completed:`, 'Checking if PR is now mergeable...'));
         }

package/src/solve.watch.lib.mjs

@@ -47,8 +47,11 @@ const toolComments = await import('./tool-comments.lib.mjs');
 const { AUTO_RESTART_MARKER, postTrackedComment } = toolComments;
 
 // Issue #1728: Per-iteration working session summary attachment helper
+// Issue #1763: Per-iteration PR ↔ issue link verification (in case the AI
+// agent overwrites the PR body without a closing keyword and the iteration
+// ends up being the last one).
 const resultsLib = await import('./solve.results.lib.mjs');
-const { maybeAttachWorkingSessionSummary } = resultsLib;
+const { maybeAttachWorkingSessionSummary, ensurePullRequestIssueLink } = resultsLib;
 
 /**
  * Monitor for feedback in a loop and trigger restart when detected
@@ -514,6 +517,34 @@ export const watchForFeedback = async params => {
             }
           }
 
+          // Issue #1763: Re-verify the PR body contains a closing keyword for
+          // the issue after every iteration. The AI agent can rewrite the PR
+          // description mid-session and any iteration may turn out to be the
+          // last one (interrupt, hit iteration cap, billing limit, etc.), so
+          // we cannot rely on a single end-of-run check.
+          if (prNumber && issueNumber && owner && repo) {
+            try {
+              await log(formatAligned('🔗', 'Verifying PR issue link after iteration...', '', 2));
+              await ensurePullRequestIssueLink({
+                prNumber,
+                issueNumber,
+                owner,
+                repo,
+                argv,
+              });
+            } catch (issueLinkError) {
+              reportError(issueLinkError, {
+                context: 'ensure_pr_issue_link_watch_iteration',
+                prNumber,
+                owner,
+                repo,
+                autoRestartCount,
+                operation: 'ensure_pr_issue_link',
+              });
+              await log(formatAligned('', `⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, '', 2));
+            }
+          }
+
           await log('');
           if (isTemporaryWatch) {
             await log(formatAligned('✅', `${argv.tool.toUpperCase()} execution completed:`, 'Checking for remaining changes...'));

package/src/start-screen.mjs

@@ -19,6 +19,24 @@ const printUsage = (log = console.error) => {
   }
 };
 
+/**
+ * Print a single-line deprecation notice to stderr the first time it is
+ * called per process. Suppressed when `HIVE_MIND_SUPPRESS_DEPRECATIONS=1`.
+ *
+ * Tracked via a module-scope flag (`deprecationWarned`) so a long-running
+ * process emits the banner only once even if `main()` is invoked multiple
+ * times in tests.
+ *
+ * @see https://github.com/link-assistant/hive-mind/issues/1758
+ */
+let deprecationWarned = false;
+const printDeprecationBanner = () => {
+  if (deprecationWarned) return;
+  if (process.env.HIVE_MIND_SUPPRESS_DEPRECATIONS === '1') return;
+  deprecationWarned = true;
+  console.error('⚠️  start-screen is deprecated; prefer `--isolated screen` (the default in newer hive/solve CLIs). Set HIVE_MIND_SUPPRESS_DEPRECATIONS=1 to silence this warning.');
+};
+
 const createStartScreenYargsConfig = yargsInstance =>
   yargsInstance
     .usage(START_SCREEN_USAGE[0])
@@ -288,6 +306,8 @@ async function createOrEnterScreen(sessionName, command, args, autoTerminate = f
 async function main() {
   const args = process.argv.slice(2);
 
+  printDeprecationBanner();
+
   if (args.includes('--help') || args.includes('-h')) {
     printUsage(console.log);
     process.exit(0);

package/src/telegram-command-execution.lib.mjs

@@ -4,6 +4,14 @@ import { exec as execCallback } from 'child_process';
 
 const exec = promisify(execCallback);
 
+let deprecationWarned = false;
+function warnStartScreenDeprecated() {
+  if (deprecationWarned) return;
+  if (process.env.HIVE_MIND_SUPPRESS_DEPRECATIONS === '1') return;
+  deprecationWarned = true;
+  console.warn('⚠️  executeStartScreen is deprecated; prefer the `--isolated screen` workflow exposed by hive/solve directly. Set HIVE_MIND_SUPPRESS_DEPRECATIONS=1 to silence this warning.');
+}
+
 async function findStartScreenCommand() {
   try {
     const { stdout } = await exec('which start-screen');
@@ -68,6 +76,8 @@ function executeWithCommand(startScreenCmd, command, args, verbose = false) {
 export async function executeStartScreen(command, args, options = {}) {
   const { verbose = false } = options;
 
+  warnStartScreenDeprecated();
+
   try {
     const whichPath = await findStartScreenCommand();