@link-assistant/hive-mind 1.67.0 → 1.67.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @link-assistant/hive-mind
 
+## 1.67.2
+
+### Patch Changes
+
+- 240231e: Verify the pull request still links to the issue after every work session inside `--watch`, `--auto-restart-until-mergeable`, and `--finalize`, so that an iteration that turns out to be the last one cannot leave the PR un-linked when the AI rewrote the description without a closing keyword.
+
+## 1.67.1
+
+### Patch Changes
+
+- d37f752: Working session summary now always appears before the working session log on every PR comment thread. The per-iteration code in auto-restart-until-mergeable mode and watch / temporary auto-restart mode now posts the summary comment before uploading the log, matching the existing top-level flow.
+
 ## 1.67.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.67.0",
+  "version": "1.67.2",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.auto-ensure.lib.mjs

@@ -23,12 +23,21 @@ const { wrapDollarWithGhRetry } = await import('./github-rate-limit.lib.mjs');
 const $ = wrapDollarWithGhRetry(__rawDollar$);
 // Import shared library functions
 const lib = await import('./lib.mjs');
-const { log } = lib;
+const { log, cleanErrorMessage } = lib;
 
 // Import shared restart utilities
 const restartShared = await import('./solve.restart-shared.lib.mjs');
 const { executeToolIteration } = restartShared;
 
+// Issue #1763: Re-verify PR ↔ issue link after every finalize iteration so a
+// PR body that the AI rewrote without a closing keyword does not survive past
+// the last requirements-check.
+const resultsLib = await import('./solve.results.lib.mjs');
+const { ensurePullRequestIssueLink } = resultsLib;
+
+const sentryLib = await import('./sentry.lib.mjs');
+const { reportError } = sentryLib;
+
 /**
  * Runs finalize requirements-check iterations after the main solve.
  *
@@ -116,6 +125,34 @@ export const runAutoEnsureRequirements = async ({ issueUrl, owner, repo, issueNu
       if (ensureResult.pricingInfo) pricingInfo = ensureResult.pricingInfo;
     }
 
+    // Issue #1763: Re-verify the PR body contains a closing keyword for the
+    // issue after every finalize iteration. The AI agent can rewrite the PR
+    // description mid-session and any iteration may end up being the last
+    // one, so this check cannot be deferred to the top-level verifyResults
+    // path.
+    if (prNumber && issueNumber && owner && repo) {
+      try {
+        await log('🔗 Verifying PR issue link after finalize iteration...');
+        await ensurePullRequestIssueLink({
+          prNumber,
+          issueNumber,
+          owner,
+          repo,
+          argv,
+        });
+      } catch (issueLinkError) {
+        reportError(issueLinkError, {
+          context: 'ensure_pr_issue_link_finalize_iteration',
+          prNumber,
+          owner,
+          repo,
+          ensureIteration,
+          operation: 'ensure_pr_issue_link',
+        });
+        await log(`⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, { level: 'warning' });
+      }
+    }
+
     await log(`✅ FINALIZE iteration ${ensureIteration}/${finalizeCount} complete`);
     await log('');
   }

package/src/solve.auto-merge.lib.mjs

@@ -60,8 +60,10 @@ const toolComments = await import('./tool-comments.lib.mjs');
 const { READY_TO_MERGE_MARKER, AUTO_RESTART_MARKER, AUTO_MERGED_MARKER, postTrackedComment } = toolComments;
 
 // Issue #1728: Per-iteration working session summary attachment helper
+// Issue #1763: Per-iteration PR ↔ issue link verification (so a clobbered
+// PR body is restored before the next stop condition fires).
 const resultsLib = await import('./solve.results.lib.mjs');
-const { maybeAttachWorkingSessionSummary } = resultsLib;
+const { maybeAttachWorkingSessionSummary, ensurePullRequestIssueLink } = resultsLib;
 
 // Issue #1574: Interruptible sleep so CTRL+C is never blocked by a lingering timer
 const { interruptibleSleep } = await import('./interruptible-sleep.lib.mjs');
@@ -857,6 +859,43 @@ No further AI sessions will be started automatically for this run. Please review
             }
           }
 
+          // Issue #1761: Post the working session **summary** BEFORE uploading
+          // the working session **log** so the summary always appears above
+          // the log in PR comment chronological order. The summary acts as a
+          // human-readable header for the (potentially very long) log that
+          // follows, and reordering matches the top-level flow in
+          // src/solve.mjs (which calls maybeAttachWorkingSessionSummary
+          // before verifyResults / attachLogToGitHub).
+          //
+          // Issue #1728: Attach a "Working session summary" comment for this
+          // iteration if the AI didn't post any comments of its own (and
+          // --auto-attach-solution-summary is enabled, which it is by default).
+          // Before this fix, only the top-level solve.mjs flow honoured this
+          // flag, so iterations inside auto-restart-until-mergeable silently
+          // dropped the AI's last message — see #1728.
+          try {
+            await maybeAttachWorkingSessionSummary({
+              argv,
+              resultSummary: toolResult.resultSummary,
+              workStartTime: iterationStartTime,
+              owner,
+              repo,
+              prNumber,
+              issueNumber,
+              success: true,
+            });
+          } catch (summaryError) {
+            reportError(summaryError, {
+              context: 'attach_auto_restart_working_session_summary',
+              prNumber,
+              owner,
+              repo,
+              iteration,
+              operation: 'attach_working_session_summary',
+            });
+            await log(formatAligned('', `⚠️  Working session summary error: ${cleanErrorMessage(summaryError)}`, '', 2));
+          }
+
           // Attach log if enabled
           const shouldAttachLogs = argv.attachLogs || argv['attach-logs'];
           if (prNumber && shouldAttachLogs) {
@@ -905,33 +944,33 @@ No further AI sessions will be started automatically for this run. Please review
             }
           }
 
-          // Issue #1728: Attach a "Working session summary" comment for this
-          // iteration if the AI didn't post any comments of its own (and
-          // --auto-attach-solution-summary is enabled, which it is by default).
-          // Before this fix, only the top-level solve.mjs flow honoured this
-          // flag, so iterations inside auto-restart-until-mergeable silently
-          // dropped the AI's last message — see #1728.
-          try {
-            await maybeAttachWorkingSessionSummary({
-              argv,
-              resultSummary: toolResult.resultSummary,
-              workStartTime: iterationStartTime,
-              owner,
-              repo,
-              prNumber,
-              issueNumber,
-              success: true,
-            });
-          } catch (summaryError) {
-            reportError(summaryError, {
-              context: 'attach_auto_restart_working_session_summary',
-              prNumber,
-              owner,
-              repo,
-              iteration,
-              operation: 'attach_working_session_summary',
-            });
-            await log(formatAligned('', `⚠️  Working session summary error: ${cleanErrorMessage(summaryError)}`, '', 2));
+          // Issue #1763: Re-verify the PR body contains a closing keyword for
+          // the issue after every auto-restart-until-mergeable iteration. The
+          // AI agent can rewrite the PR description mid-session and any
+          // iteration may end up being the last one (mergeable, max-iters,
+          // billing limit, etc.), so this check cannot be deferred to the
+          // top-level verifyResults path.
+          if (prNumber && issueNumber && owner && repo) {
+            try {
+              await log(formatAligned('🔗', 'Verifying PR issue link after iteration...', '', 2));
+              await ensurePullRequestIssueLink({
+                prNumber,
+                issueNumber,
+                owner,
+                repo,
+                argv,
+              });
+            } catch (issueLinkError) {
+              reportError(issueLinkError, {
+                context: 'ensure_pr_issue_link_auto_restart_iteration',
+                prNumber,
+                owner,
+                repo,
+                iteration,
+                operation: 'ensure_pr_issue_link',
+              });
+              await log(formatAligned('', `⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, '', 2));
+            }
           }
 
           await log('');

package/src/solve.watch.lib.mjs

@@ -47,8 +47,11 @@ const toolComments = await import('./tool-comments.lib.mjs');
 const { AUTO_RESTART_MARKER, postTrackedComment } = toolComments;
 
 // Issue #1728: Per-iteration working session summary attachment helper
+// Issue #1763: Per-iteration PR ↔ issue link verification (in case the AI
+// agent overwrites the PR body without a closing keyword and the iteration
+// ends up being the last one).
 const resultsLib = await import('./solve.results.lib.mjs');
-const { maybeAttachWorkingSessionSummary } = resultsLib;
+const { maybeAttachWorkingSessionSummary, ensurePullRequestIssueLink } = resultsLib;
 
 /**
  * Monitor for feedback in a loop and trigger restart when detected
@@ -421,6 +424,42 @@ export const watchForFeedback = async params => {
             }
           }
 
+          // Issue #1761: Post the working session **summary** BEFORE uploading
+          // the working session **log** so the summary always appears above
+          // the log in PR comment chronological order. The summary acts as a
+          // human-readable header for the (potentially very long) log that
+          // follows, and reordering matches the top-level flow in
+          // src/solve.mjs (which calls maybeAttachWorkingSessionSummary
+          // before verifyResults / attachLogToGitHub).
+          //
+          // Issue #1728: Attach a "Working session summary" comment for this
+          // iteration if the AI didn't post any comments of its own (and
+          // --auto-attach-solution-summary is enabled, which it is by default).
+          // Same fix as in solve.auto-merge.lib.mjs — every working session,
+          // not just the top-level run, should honour the auto-attach flag.
+          try {
+            await maybeAttachWorkingSessionSummary({
+              argv,
+              resultSummary: toolResult.resultSummary,
+              workStartTime: iterationStartTime,
+              owner,
+              repo,
+              prNumber,
+              issueNumber,
+              success: true,
+            });
+          } catch (summaryError) {
+            reportError(summaryError, {
+              context: 'attach_watch_working_session_summary',
+              prNumber,
+              owner,
+              repo,
+              autoRestartCount,
+              operation: 'attach_working_session_summary',
+            });
+            await log(formatAligned('', `⚠️  Working session summary error: ${cleanErrorMessage(summaryError)}`, '', 2));
+          }
+
           // Issue #1107: Attach log after each auto-restart session with its own cost estimation
           // This ensures each restart has its own log comment instead of one combined log at the end
           const shouldAttachLogs = argv.attachLogs || argv['attach-logs'];
@@ -478,32 +517,32 @@ export const watchForFeedback = async params => {
             }
           }
 
-          // Issue #1728: Attach a "Working session summary" comment for this
-          // iteration if the AI didn't post any comments of its own (and
-          // --auto-attach-solution-summary is enabled, which it is by default).
-          // Same fix as in solve.auto-merge.lib.mjs — every working session,
-          // not just the top-level run, should honour the auto-attach flag.
-          try {
-            await maybeAttachWorkingSessionSummary({
-              argv,
-              resultSummary: toolResult.resultSummary,
-              workStartTime: iterationStartTime,
-              owner,
-              repo,
-              prNumber,
-              issueNumber,
-              success: true,
-            });
-          } catch (summaryError) {
-            reportError(summaryError, {
-              context: 'attach_watch_working_session_summary',
-              prNumber,
-              owner,
-              repo,
-              autoRestartCount,
-              operation: 'attach_working_session_summary',
-            });
-            await log(formatAligned('', `⚠️  Working session summary error: ${cleanErrorMessage(summaryError)}`, '', 2));
+          // Issue #1763: Re-verify the PR body contains a closing keyword for
+          // the issue after every iteration. The AI agent can rewrite the PR
+          // description mid-session and any iteration may turn out to be the
+          // last one (interrupt, hit iteration cap, billing limit, etc.), so
+          // we cannot rely on a single end-of-run check.
+          if (prNumber && issueNumber && owner && repo) {
+            try {
+              await log(formatAligned('🔗', 'Verifying PR issue link after iteration...', '', 2));
+              await ensurePullRequestIssueLink({
+                prNumber,
+                issueNumber,
+                owner,
+                repo,
+                argv,
+              });
+            } catch (issueLinkError) {
+              reportError(issueLinkError, {
+                context: 'ensure_pr_issue_link_watch_iteration',
+                prNumber,
+                owner,
+                repo,
+                autoRestartCount,
+                operation: 'ensure_pr_issue_link',
+              });
+              await log(formatAligned('', `⚠️  PR issue link check error: ${cleanErrorMessage(issueLinkError)}`, '', 2));
+            }
           }
 
           await log('');