@link-assistant/hive-mind 1.59.3 → 1.59.4

package/CHANGELOG.md

@@ -1,5 +1,87 @@
 # @link-assistant/hive-mind
 
+## 1.59.4
+
+### Patch Changes
+
+- b2e0d12: Fix `/terminal_watch` uploading the full session log file when the watch
+  completes — addresses issue
+  [#1720](https://github.com/link-assistant/hive-mind/issues/1720).
+
+  Before this fix, `/terminal_watch` finished by calling
+  `bot.telegram.sendDocument(chatId, ...)` to attach the `<uuid>.log` file. That
+  had two unwanted effects:
+  - It duplicated work that the dedicated `/log` command already does.
+  - The bare `bot.telegram.sendDocument(chatId, ...)` call did not carry
+    `message_thread_id`, so in forum-enabled supergroups the document landed in
+    the **General** topic instead of the topic where `/terminal_watch` was
+    invoked, and it was not threaded as a reply.
+
+  `/terminal_watch` now only updates the live "✅ Terminal watch complete"
+  message at the end of the session. To download the log, use
+  `/log <uuid>` — it correctly replies in the originating topic via
+  `ctx.replyWithDocument`, which Telegraf annotates with `message_thread_id`
+  automatically.
+
+  A new regression test (`tests/test-issue-1720-terminal-watch-no-log.mjs`)
+  guards both behaviours, and `tests/test-issue-467-terminal-watch.mjs` was
+  updated to assert that no document is uploaded by the watcher.
+
+- 5c87a38: Fix `hive` to (a) stop forwarding `false` for solve options whose `type` is
+  `'string'` but whose `default` is `false`, and (b) exit non-zero when any
+  worker fails — issue #1718.
+
+  Previously, when a user ran `/hive` against several issues, every spawned
+  `solve` worker crashed with:
+
+  ```
+  Invalid --working-session-live-progress value: "false". Expected "comment" or "pr".
+  ```
+
+  …and `hive` itself still exited with code `0`, so the Telegram bot rendered a
+  green "Work session finished successfully" envelope even though zero PRs had
+  been created.
+
+  Two independent root causes:
+  1. **Auto-forwarder leaked `false` as a string.** In
+     [`src/hive.mjs`](./src/hive.mjs), the auto-forward block read:
+
+     ```js
+     } else if ((def.type === 'string' || def.type === 'number') && value !== undefined) {
+       args.push(`--${optionName}`, String(value));
+     }
+     ```
+
+     For `working-session-live-progress`, `solve.config.lib.mjs` declares
+     `type: 'string', default: false`. yargs preserves the boolean `false`
+     verbatim, so hive forwarded `--working-session-live-progress false`,
+     which `solve` rejects. The fix adds `&& value !== false` to the
+     predicate. Other `type:'string'` options whose `default` is `false`
+     are now also protected by a single defense-in-depth check.
+
+  2. **No non-zero exit on worker failures.** After `monitorWithSentry()`
+     resolved, hive returned without consulting `issueQueue.getStats()`. The
+     fix queries `finalStats = issueQueue.getStats()` and calls
+     `safeExit(1, …)` when `finalStats.failed > 0`, mirroring the exit
+     semantics solve already uses. Wrappers like `start-command`, the Telegram
+     bot, and CI now correctly observe the failure.
+
+  `--isolation screen` (R3 of the issue) was already wired through correctly;
+  no change required there. The verbose forwarder dump
+  (`📋 Command: ${solveCommand} ${args.join(' ')}`) — which is what allowed us
+  to diagnose this run in the first place — is preserved.
+
+  Tests: [`tests/test-issue-1718-hive-passthrough-false.mjs`](./tests/test-issue-1718-hive-passthrough-false.mjs)
+  locks the option shape, asserts both fixes are present in `src/hive.mjs`,
+  replays the forwarder logic on synthetic argv, and adds a defense-in-depth
+  sweep that no `type:'string'` / `default:false` option ever produces
+  `--<flag> false`.
+
+  Documentation: [`docs/case-studies/issue-1718/`](./docs/case-studies/issue-1718/README.md)
+  contains the timeline reconstructed from the user's `screen` log, the
+  distilled facts, the per-symptom root-cause analysis, the solution plan, and
+  notes confirming no upstream report (yargs / start-command) is required.
+
 ## 1.59.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.59.3",
+  "version": "1.59.4",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/hive.mjs

@@ -798,8 +798,8 @@ if (isRunningDirectly) {
                 for (const entry of value) {
                   args.push(`--${optionName}`, String(entry));
                 }
-              } else if ((def.type === 'string' || def.type === 'number') && value !== undefined) {
-                args.push(`--${optionName}`, String(value));
+              } else if ((def.type === 'string' || def.type === 'number') && value !== undefined && value !== false) {
+                args.push(`--${optionName}`, String(value)); // Issue #1718: skip false (some string options have default:false)
               }
             }
             // Log the actual command being executed so users can investigate/reproduce
@@ -1483,6 +1483,9 @@ if (isRunningDirectly) {
       await log(`   📁 Full log file: ${absoluteLogPath}`, { level: 'error' });
       await safeExit(1, 'Error occurred');
     }
+
+    const finalStats = issueQueue.getStats(); // Issue #1718: surface worker failures via exit code
+    if (finalStats.failed > 0) await safeExit(1, `${finalStats.failed} task(s) failed (completed: ${finalStats.completed})`);
   } catch (fatalError) {
     // Handle fatal errors during initialization or execution
     console.error('\n❌ Fatal error occurred during hive initialization or execution');

package/src/telegram-terminal-watch-command.lib.mjs

@@ -6,15 +6,12 @@
  */
 
 import fs from 'fs/promises';
-import path from 'path';
-import { constants as fsConstants } from 'fs';
 import { extractSessionIdFromText, decideLogDestination, resolveLogPath } from './telegram-log-command.lib.mjs';
 
 const DEFAULT_WIDTH = 120;
 const DEFAULT_HEIGHT = 25;
 const DEFAULT_INTERVAL_MS = 2500;
 const DEFAULT_MAX_CHARS = 3400;
-const TELEGRAM_DOCUMENT_MAX_BYTES = 50 * 1024 * 1024;
 const GITHUB_URL_RE = /https:\/\/github\.com\/[^\s"'`<>]+/i;
 const activeWatches = new Map();
 
@@ -135,23 +132,6 @@ export function formatTerminalWatchMessage({ sessionId, statusResult = null, log
   return lines.join('\n');
 }
 
-async function fileExists(filePath) {
-  try {
-    await fs.access(filePath, fsConstants.R_OK);
-    return true;
-  } catch {
-    return false;
-  }
-}
-
-async function fileSize(filePath) {
-  try {
-    return (await fs.stat(filePath)).size;
-  } catch {
-    return null;
-  }
-}
-
 async function readLogFile(logPath) {
   try {
     return await fs.readFile(logPath, 'utf8');
@@ -182,16 +162,6 @@ export async function resolveTerminalWatchRepository({ sessionInfo = null, statu
   }
 }
 
-async function sendLogDocument({ bot, chatId, logPath, sessionId, statusResult }) {
-  if (!(await fileExists(logPath))) return;
-  const size = await fileSize(logPath);
-  if (size !== null && size > TELEGRAM_DOCUMENT_MAX_BYTES) {
-    await bot.telegram.sendMessage(chatId, `⚠️ Full log for \`${sessionId}\` is ${(size / (1024 * 1024)).toFixed(1)} MB, above Telegram's 50 MB upload limit.`, { parse_mode: 'Markdown' });
-    return;
-  }
-  await bot.telegram.sendDocument(chatId, { source: logPath, filename: path.basename(logPath) }, { caption: `📄 Full log for session \`${sessionId}\`${statusResult?.status ? `\nStatus: \`${statusResult.status}\`` : ''}`, parse_mode: 'Markdown' });
-}
-
 async function querySessionStatusWithRetry(querySessionStatus, sessionId, verbose, attempts = 3) {
   for (let attempt = 1; attempt <= attempts; attempt++) {
     const statusResult = await querySessionStatus(sessionId, verbose);
@@ -201,7 +171,9 @@ async function querySessionStatusWithRetry(querySessionStatus, sessionId, verbos
   return null;
 }
 
-export function watchTerminalLogSession({ bot, chatId, messageId, sessionId, logPath, querySessionStatus, isTerminalSessionStatus, options = {}, repoDescription = null, verbose = false, attachLogOnComplete = true }) {
+// Note: /terminal_watch never uploads the full session log itself (issue #1720).
+// Use /log <uuid> if you want the log file delivered as a document.
+export function watchTerminalLogSession({ bot, chatId, messageId, sessionId, logPath, querySessionStatus, isTerminalSessionStatus, options = {}, repoDescription = null, verbose = false }) {
   const key = `${chatId}:${messageId}:${sessionId}`;
   activeWatches.get(key)?.stop();
 
@@ -225,7 +197,6 @@ export function watchTerminalLogSession({ bot, chatId, messageId, sessionId, log
       if (completed) {
         stopped = true;
         activeWatches.delete(key);
-        if (attachLogOnComplete) await sendLogDocument({ bot, chatId, logPath, sessionId, statusResult });
         return;
       }
     } catch (error) {
@@ -409,6 +380,5 @@ export const __INTERNAL_FOR_TESTS__ = {
   DEFAULT_HEIGHT,
   DEFAULT_INTERVAL_MS,
   DEFAULT_MAX_CHARS,
-  TELEGRAM_DOCUMENT_MAX_BYTES,
   GITHUB_URL_RE,
 };