@link-assistant/hive-mind 1.57.1 → 1.57.3

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @link-assistant/hive-mind
 
+## 1.57.3
+
+### Patch Changes
+
+- 5c65c29: Fix /log and /terminal_watch falsely rejecting real `$` isolation sessions (issue #1700)
+
+  `parseSessionStatusOutput` looked for the isolation backend at `data.isolation`
+  or `data.options.isolation`, but the published `link-foundation/start` 0.25.x
+  CLI reports it at `options.isolated` in both JSON and the default
+  `links-notation` output. As a result, replying `/log` (or `/terminal_watch`) to
+  a `Work session finished` message rejected every screen / tmux / docker session
+  with `❌ This command currently supports only sessions launched with $
+isolation`. The parser now reads `options.isolated` first and keeps the legacy
+  field names as fallbacks. The rejection site additionally emits a `[VERBOSE]`
+  diagnostic line so future contract drifts can be triaged from a single bot log
+  entry. Regression test in `tests/test-issue-1700-isolation-parsing.mjs`.
+
+## 1.57.2
+
+### Patch Changes
+
+- aff6d1d: Add a stable test runner and suite markers to avoid package.json test-script conflicts.
+
 ## 1.57.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.57.1",
+  "version": "1.57.3",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -15,7 +15,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-log-upload-output-1682.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-467-terminal-watch.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-issue-1680-session-monitoring.mjs && node tests/test-issue-1684-message-formatting.mjs && node tests/test-issue-1686-log-command.mjs && node tests/test-issue-1688-subscribe-and-pr-link.mjs && node tests/test-issue-1694-stabilized-defaults.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node scripts/run-tests.mjs --suite default",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",
@@ -64,7 +64,8 @@
     "husky": "^9.1.7",
     "jscpd": "^4.0.5",
     "lint-staged": "^16.2.7",
-    "prettier": "^3.6.2"
+    "prettier": "^3.6.2",
+    "test-anywhere": "^0.9.1"
   },
   "dependencies": {
     "@secretlint/core": "^11.2.5",

package/src/isolation-runner.lib.mjs

@@ -52,7 +52,12 @@ export function parseSessionStatusOutput(output) {
   try {
     const parsed = JSON.parse(raw);
     const data = Array.isArray(parsed) ? parsed[0] : parsed;
-    const isolationFromOptions = typeof data?.options?.isolation === 'string' ? data.options.isolation.toLowerCase() : null;
+    // start-command (link-foundation/start) reports the isolation backend at
+    // `options.isolated` in both JSON and links-notation output. Older
+    // hypothetical layouts used `options.isolation` or a top-level `isolation`
+    // field — keep accepting all three so we are tolerant of future renames.
+    // See https://github.com/link-assistant/hive-mind/issues/1700.
+    const isolationCandidate = (typeof data?.isolation === 'string' && data.isolation) || (typeof data?.options?.isolated === 'string' && data.options.isolated) || (typeof data?.options?.isolation === 'string' && data.options.isolation) || null;
     return {
       exists: true,
       uuid: data?.uuid || null,
@@ -63,7 +68,7 @@ export function parseSessionStatusOutput(output) {
       currentTime: data?.currentTime || null,
       logPath: data?.logPath || null,
       command: data?.command || null,
-      isolation: typeof data?.isolation === 'string' ? data.isolation.toLowerCase() : isolationFromOptions,
+      isolation: isolationCandidate ? isolationCandidate.toLowerCase() : null,
       workingDirectory: data?.workingDirectory || null,
       raw,
     };
@@ -83,6 +88,13 @@ export function parseSessionStatusOutput(output) {
 
   const status = readField('status')?.toLowerCase() || null;
   const exitCodeText = readField('exitCode');
+  // `start-command` links-notation output nests the isolation backend under
+  // `options` as `isolated <backend>` (not `isolation`). The leading indent
+  // varies by depth, but `readField` is anchored with `^\s*` which already
+  // matches indented lines. Older code only looked for `isolation`, which
+  // returned null for every real session and made /log + /terminal_watch
+  // reject screen/tmux/docker sessions. See issue #1700.
+  const isolationText = readField('isolated') || readField('isolation');
 
   return {
     exists: Boolean(status || firstLine),
@@ -94,7 +106,7 @@ export function parseSessionStatusOutput(output) {
     currentTime: readField('currentTime'),
     logPath: readField('logPath'),
     command: readField('command'),
-    isolation: readField('isolation')?.toLowerCase() || null,
+    isolation: isolationText?.toLowerCase() || null,
     workingDirectory: readField('workingDirectory'),
     raw,
   };

package/src/telegram-log-command.lib.mjs

@@ -260,6 +260,9 @@ export async function registerLogCommand(bot, options) {
     // 4. Decide the destination.
     const decision = decideLogDestination({ statusResult, sessionInfo, repoVisibility, chatType });
     if (decision.destination === 'reject') {
+      // Surface enough state to diagnose false-rejections like issue #1700,
+      // where the parser missed the isolation field name reported by the host.
+      VERBOSE && console.log(`[VERBOSE] /log rejected session ${sessionId}: reason="${decision.reason}" parsedIsolation=${JSON.stringify(statusResult?.isolation)} sessionInfoBackend=${JSON.stringify(sessionInfo?.isolationBackend)} rawHead=${JSON.stringify((statusResult?.raw || '').slice(0, 240))}`);
       await ctx.reply(`❌ ${decision.reason}`, { reply_to_message_id: message.message_id });
       return;
     }

package/src/telegram-terminal-watch-command.lib.mjs

@@ -382,6 +382,8 @@ export async function registerTerminalWatchCommand(bot, options) {
     const { repoVisibility, repoDescription } = await resolveTerminalWatchRepository({ sessionInfo, statusResult, parseGitHubUrl, detectRepositoryVisibility });
     const decision = decideLogDestination({ statusResult, sessionInfo, repoVisibility, chatType: chat.type });
     if (decision.destination === 'reject') {
+      // Surface enough state to diagnose false-rejections like issue #1700.
+      VERBOSE && console.log(`[VERBOSE] /terminal_watch rejected session ${sessionId}: reason="${decision.reason}" parsedIsolation=${JSON.stringify(statusResult?.isolation)} sessionInfoBackend=${JSON.stringify(sessionInfo?.isolationBackend)} rawHead=${JSON.stringify((statusResult?.raw || '').slice(0, 240))}`);
       await ctx.reply(`❌ ${decision.reason}`, { reply_to_message_id: message.message_id });
       return;
     }