@link-assistant/hive-mind 1.56.3 → 1.56.5

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @link-assistant/hive-mind
 
+## 1.56.5
+
+### Patch Changes
+
+- 0447110: Treat structured Codex error events as failed tool executions even when the Codex process exits with code 0.
+
+## 1.56.4
+
+### Patch Changes
+
+- 2d6d405: Fix Telegram bot LINO configuration parsing for parenthesized option/value links such as `(--isolation screen)`.
+
 ## 1.56.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.56.3",
+  "version": "1.56.5",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -15,7 +15,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-telegram-bot-launcher.mjs",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",

package/src/codex.lib.mjs

@@ -183,6 +183,57 @@ const upsertCodexItemError = (itemErrors, item) => {
   });
 };
 
+const unwrapCodexErrorMessage = value => {
+  if (!value) return '';
+  if (typeof value !== 'string') {
+    if (typeof value?.error?.message === 'string') return unwrapCodexErrorMessage(value.error.message);
+    if (typeof value?.message === 'string') return unwrapCodexErrorMessage(value.message);
+    return String(value);
+  }
+
+  let text = value.trim();
+  for (let i = 0; i < 3; i++) {
+    if (!text.startsWith('{') && !text.startsWith('[')) break;
+    try {
+      const parsed = JSON.parse(text);
+      if (typeof parsed?.error?.message === 'string') return unwrapCodexErrorMessage(parsed.error.message);
+      if (typeof parsed?.message === 'string') {
+        text = parsed.message.trim();
+        continue;
+      }
+      return JSON.stringify(parsed);
+    } catch {
+      break;
+    }
+  }
+  return text;
+};
+
+export const getCodexErrorEventSummary = codexJsonState => {
+  const events = [];
+  const addEvents = (type, items = []) => {
+    for (const item of items) {
+      const message = unwrapCodexErrorMessage(item?.message);
+      events.push({ type, message: message || 'Codex emitted an error event' });
+    }
+  };
+
+  addEvents('item', codexJsonState?.itemErrors);
+  addEvents('turn', codexJsonState?.turnFailures);
+  addEvents('stream', codexJsonState?.streamErrors);
+
+  return {
+    hasError: events.length > 0,
+    message: events[0]?.message || null,
+    events,
+    counts: {
+      item: codexJsonState?.itemErrors?.length || 0,
+      turn: codexJsonState?.turnFailures?.length || 0,
+      stream: codexJsonState?.streamErrors?.length || 0,
+    },
+  };
+};
+
 export const parseCodexExecJsonOutput = (output, state = {}, requestedModelId = null) => {
   const nextState = {
     sessionId: state.sessionId || null,
@@ -597,7 +648,7 @@ export const executeCodex = async params => {
 };
 
 export const executeCodexCommand = async params => {
-  const { tempDir, branchName, prompt, systemPrompt, argv, log, formatAligned, getResourceSnapshot, forkedRepo, feedbackLines, codexPath, $, owner, repo, prNumber } = params;
+  const { tempDir, branchName, prompt, systemPrompt, argv, log, formatAligned, getResourceSnapshot, forkedRepo, feedbackLines, codexPath, $, owner, repo, prNumber, calculatePricing = calculateCodexPricing } = params;
 
   const shellQuote = value => `"${String(value).replaceAll('\\', '\\\\').replaceAll('"', '\\"')}"`;
 
@@ -852,7 +903,7 @@ export const executeCodexCommand = async params => {
       }
 
       const firstActualModelId = mappedModel;
-      const pricingInfo = firstActualModelId ? await calculateCodexPricing(firstActualModelId, codexJsonState.tokenUsage.stepCount > 0 ? codexJsonState.tokenUsage : null) : null;
+      const pricingInfo = firstActualModelId ? await calculatePricing(firstActualModelId, codexJsonState.tokenUsage.stepCount > 0 ? codexJsonState.tokenUsage : null) : null;
       if (pricingInfo?.totalCostUSD !== null && pricingInfo?.totalCostUSD !== undefined) {
         await log(`💰 Codex public pricing estimate: $${new Decimal(pricingInfo.totalCostUSD).toFixed(6)}`, { verbose: true });
         if (pricingInfo.usesLongContextPricing) {
@@ -876,6 +927,49 @@ export const executeCodexCommand = async params => {
         throw error;
       }
 
+      const codexErrorSummary = getCodexErrorEventSummary(codexJsonState);
+      if (codexErrorSummary.hasError) {
+        const limitInfo = detectUsageLimit(codexErrorSummary.message || lastMessage);
+        if (limitInfo.isUsageLimit) {
+          limitReached = true;
+          limitResetTime = limitInfo.resetTime;
+
+          const messageLines = formatUsageLimitMessage({
+            tool: 'OpenAI Codex',
+            resetTime: limitInfo.resetTime,
+            sessionId,
+            resumeCommand: sessionId ? `${process.argv[0]} ${process.argv[1]} ${argv.url} --resume ${sessionId}` : null,
+          });
+
+          for (const line of messageLines) {
+            await log(line, { level: 'warning' });
+          }
+        } else {
+          await log(`\n\n❌ Codex emitted error event: ${codexErrorSummary.message}`, { level: 'error' });
+          await log(`   Error events: item=${codexErrorSummary.counts.item}, turn=${codexErrorSummary.counts.turn}, stream=${codexErrorSummary.counts.stream}`, { level: 'error' });
+        }
+
+        const resourcesAfter = await getResourceSnapshot();
+        await log('\n📈 System resources after execution:', { verbose: true });
+        await log(`   Memory: ${resourcesAfter.memory.split('\n')[1]}`, { verbose: true });
+        await log(`   Load: ${resourcesAfter.load}`, { verbose: true });
+
+        return {
+          success: false,
+          sessionId,
+          limitReached,
+          limitResetTime,
+          pricingInfo,
+          publicPricingEstimate: pricingInfo?.totalCostUSD ?? null,
+          resultModelUsage,
+          subAgentCalls: codexJsonState.subAgentCalls.length > 0 ? codexJsonState.subAgentCalls : null,
+          codexJsonDetails: codexJsonState,
+          errorInfo: codexErrorSummary,
+          result: codexErrorSummary.message,
+          resultSummary: lastTextContent || null, // Issue #1263: Use last text content from JSON output stream
+        };
+      }
+
       if (exitCode !== 0) {
         // Check for usage limit errors first (more specific)
         const limitInfo = detectUsageLimit(lastMessage);
@@ -915,6 +1009,7 @@ export const executeCodexCommand = async params => {
           resultModelUsage,
           subAgentCalls: codexJsonState.subAgentCalls.length > 0 ? codexJsonState.subAgentCalls : null,
           codexJsonDetails: codexJsonState,
+          errorInfo: getCodexErrorEventSummary(codexJsonState),
           resultSummary: lastTextContent || null, // Issue #1263: Use last text content from JSON output stream
         };
       }
@@ -965,6 +1060,8 @@ export const executeCodexCommand = async params => {
         limitResetTime: null,
         pricingInfo: null,
         publicPricingEstimate: null,
+        errorInfo: { hasError: true, message: error.message, events: [{ type: 'exception', message: error.message }], counts: { item: 0, turn: 0, stream: 0 } },
+        result: error.message,
         resultSummary: null, // Issue #1263: No result summary available on error
       };
     } finally {

package/src/lenv-reader.lib.mjs

@@ -38,6 +38,43 @@ const LinoParser = linoModule.Parser || linoModule.default?.Parser;
 
 const fs = await import('fs');
 
+function isCliOptionToken(value) {
+  return /^--[a-zA-Z0-9][a-zA-Z0-9=_.-]*$/.test(value) || /^-[a-zA-Z]$/.test(value);
+}
+
+function collectStringValues(value, result = []) {
+  if (value && typeof value === 'object' && Array.isArray(value.values)) {
+    if (value.id !== null && value.id !== undefined) {
+      result.push(String(value.id));
+    }
+    for (const child of value.values) {
+      collectStringValues(child, result);
+    }
+  } else if (value !== null && value !== undefined) {
+    result.push(String(value));
+  }
+  return result;
+}
+
+function validateNoBareSameLineOptions(content) {
+  let currentVar = 'configuration';
+
+  for (const line of content.split(/\r?\n/)) {
+    const trimmed = line.trim();
+    if (!trimmed || trimmed === '(' || trimmed === ')') continue;
+
+    const topLevelMatch = !/^\s/.test(line) ? trimmed.match(/^([A-Za-z_][A-Za-z0-9_]*):(?:\s*(.*))?$/) : null;
+    const valueText = topLevelMatch ? (topLevelMatch[2] || '').trim() : trimmed;
+    if (topLevelMatch) currentVar = topLevelMatch[1];
+    if (!valueText || valueText === '(' || valueText === ')' || valueText.startsWith('(')) continue;
+
+    const parts = valueText.split(/\s+/).filter(Boolean);
+    if (parts.length > 1 && isCliOptionToken(parts[0])) {
+      throw new Error(`Invalid LINO format in "${currentVar}": Multiple values on the same line are not supported.\n` + `Found: "${parts.join(' ')}"\n` + `Each value must be on its own line with proper indentation, or grouped explicitly as a parenthesized link.`);
+    }
+  }
+}
+
 /**
  * LenvReader - Reads and parses .lenv files using LINO notation
  */
@@ -59,6 +96,8 @@ export class LenvReader {
     const result = {};
 
     try {
+      validateNoBareSameLineOptions(content);
+
       // Parse the entire content as LINO
       const parsed = this.parser.parse(content);
 
@@ -77,36 +116,9 @@ export class LenvReader {
 
         // The values are the variable value
         if (link.values && link.values.length > 0) {
-          // Check for nested structures (multiple items on same line) - reject with error
-          // A nested tuple with id=null that appears amongst other direct values indicates
-          // same-line grouping (e.g., "--option1  --option2" on same line)
-          // However, if the entire list is a SINGLE nested tuple (e.g., "VAR: (\n  1\n  2\n)"),
-          // that's valid parenthesized syntax
-          const hasDirectValues = link.values.some(v => v && typeof v === 'object' && v.id !== null);
-          const hasNestedTuples = link.values.some(v => v && typeof v === 'object' && v.id === null && v.values && v.values.length > 0);
-
-          if (hasDirectValues && hasNestedTuples) {
-            // Mixed direct values and nested tuples indicates same-line grouping
-            for (const v of link.values) {
-              if (v && typeof v === 'object' && v.id === null && v.values && v.values.length > 0) {
-                const nestedItems = v.values.map(nested => nested.id || nested).join(' ');
-                throw new Error(`Invalid LINO format in "${varName}": Multiple values on the same line are not supported.\n` + `Found: "${nestedItems}"\n` + `Each value must be on its own line with proper indentation.`);
-              }
-            }
-          }
-
-          // Determine which values to validate for invalid characters
-          // If it's a single nested tuple (parenthesized list), unwrap it for validation
-          let valuesToValidate = link.values;
-          if (link.values.length === 1 && link.values[0] && typeof link.values[0] === 'object' && link.values[0].id === null && link.values[0].values) {
-            // Single parenthesized list - use inner values
-            valuesToValidate = link.values[0].values;
-          }
-
           // Check for invalid characters in option-like values
-          for (const v of valuesToValidate) {
+          for (const valueStr of link.values.flatMap(v => collectStringValues(v))) {
             // Options should match pattern: --option-name or -o (with optional =value)
-            const valueStr = v.id || v;
             if (typeof valueStr === 'string' && valueStr.startsWith('-')) {
               // This looks like a command-line option, validate it
               // Valid option pattern: -x, --option-name, --option-name=value
@@ -119,7 +131,7 @@ export class LenvReader {
           }
 
           // If there are multiple values, format them as LINO notation
-          const values = link.values.map(v => v.id || v);
+          const values = link.values.flatMap(v => collectStringValues(v));
 
           // If it's a single value, just use it as-is
           if (values.length === 1) {

package/src/lino.lib.mjs

@@ -9,6 +9,20 @@ const fs = await import('fs');
 const path = await import('path');
 const os = await import('os');
 
+function collectStringValues(value, result = []) {
+  if (value && typeof value === 'object' && Array.isArray(value.values)) {
+    if (value.id !== null && value.id !== undefined) {
+      result.push(String(value.id));
+    }
+    for (const child of value.values) {
+      collectStringValues(child, result);
+    }
+  } else if (value !== null && value !== undefined) {
+    result.push(String(value));
+  }
+  return result;
+}
+
 export class LinksNotationManager {
   constructor() {
     this.parser = new LinoParser();
@@ -26,8 +40,7 @@ export class LinksNotationManager {
 
       if (link.values && link.values.length > 0) {
         for (const value of link.values) {
-          const val = value.id || value;
-          values.push(val);
+          values.push(...collectStringValues(value));
         }
       } else if (link.id) {
         values.push(link.id);
@@ -50,9 +63,11 @@ export class LinksNotationManager {
 
       if (link.values && link.values.length > 0) {
         for (const value of link.values) {
-          const num = parseInt(value.id || value);
-          if (!isNaN(num)) {
-            ids.push(num);
+          for (const linkValue of collectStringValues(value)) {
+            const num = parseInt(linkValue);
+            if (!isNaN(num)) {
+              ids.push(num);
+            }
           }
         }
       } else if (link.id) {
@@ -79,8 +94,7 @@ export class LinksNotationManager {
 
       if (link.values && link.values.length > 0) {
         for (const value of link.values) {
-          const linkStr = value.id || value;
-          if (typeof linkStr === 'string') {
+          for (const linkStr of collectStringValues(value)) {
             links.push(linkStr);
           }
         }

package/src/telegram-bot.mjs

@@ -28,7 +28,7 @@ const getenv = typeof getenvModule === 'function' ? getenvModule : getenvModule.
 
 // Load .env/.lenv configuration (issue #1318)
 dotenvx.config({ quiet: true, ignore: ['MISSING_ENV_FILE'] });
-loadLenvConfig({ override: true, quiet: true });
+await loadLenvConfig({ override: true, quiet: true });
 
 const yargsModule = await use('yargs@17.7.2');
 const yargs = yargsModule.default || yargsModule;
@@ -123,7 +123,7 @@ const config = yargs(hideBin(process.argv))
 
 // Configuration priority: CLI option > --configuration LINO > .lenv > .env
 if (config.configuration) {
-  loadLenvConfig({ configuration: config.configuration, override: true, quiet: true });
+  await loadLenvConfig({ configuration: config.configuration, override: true, quiet: true });
 }
 
 const BOT_TOKEN = config.token || getenv('TELEGRAM_BOT_TOKEN', '');
@@ -173,8 +173,12 @@ if (ISOLATION_BACKEND) {
 if (solveEnabled && solveOverrides.length > 0) {
   console.log('Validating solve overrides...');
   try {
+    const { backend: solveOverrideIsolation, filteredArgs: solveOverridesForValidation } = extractIsolationFromArgs(solveOverrides);
+    if (solveOverrideIsolation && !isValidPerCommandIsolation(solveOverrideIsolation)) {
+      throw new Error(`Invalid --isolation value '${solveOverrideIsolation}'. Must be: screen, tmux, or docker`);
+    }
     // Add a dummy URL as the first argument (required positional for solve)
-    const testArgs = ['https://github.com/test/test/issues/1', ...solveOverrides];
+    const testArgs = ['https://github.com/test/test/issues/1', ...solveOverridesForValidation];
 
     // Temporarily suppress stderr to avoid yargs error output during validation
     const originalStderrWrite = process.stderr.write;
@@ -197,7 +201,7 @@ if (solveEnabled && solveOverrides.length > 0) {
         });
       await testYargs.parse(testArgs);
       // Issue #1482: Validate --base-branch in overrides early
-      const overrideBranchError = validateBranchInArgs(solveOverrides);
+      const overrideBranchError = validateBranchInArgs(solveOverridesForValidation);
       if (overrideBranchError) throw new Error(overrideBranchError);
       console.log('✅ Solve overrides validated successfully');
     } finally {
@@ -216,8 +220,12 @@ if (solveEnabled && solveOverrides.length > 0) {
 if (hiveEnabled && hiveOverrides.length > 0) {
   console.log('Validating hive overrides...');
   try {
+    const { backend: hiveOverrideIsolation, filteredArgs: hiveOverridesForValidation } = extractIsolationFromArgs(hiveOverrides);
+    if (hiveOverrideIsolation && !isValidPerCommandIsolation(hiveOverrideIsolation)) {
+      throw new Error(`Invalid --isolation value '${hiveOverrideIsolation}'. Must be: screen, tmux, or docker`);
+    }
     // Add a dummy URL as the first argument (required positional for hive)
-    const testArgs = ['https://github.com/test/test', ...hiveOverrides];
+    const testArgs = ['https://github.com/test/test', ...hiveOverridesForValidation];
 
     // Temporarily suppress stderr to avoid yargs error output during validation
     const originalStderrWrite = process.stderr.write;
@@ -239,7 +247,7 @@ if (hiveEnabled && hiveOverrides.length > 0) {
           throw new Error(msg);
         });
       await testYargs.parse(testArgs);
-      const overrideBranchError = validateBranchInArgs(hiveOverrides); // Issue #1482
+      const overrideBranchError = validateBranchInArgs(hiveOverridesForValidation); // Issue #1482
       if (overrideBranchError) throw new Error(overrideBranchError);
       console.log('✅ Hive overrides validated successfully');
     } finally {
@@ -890,7 +898,13 @@ async function handleSolveCommand(ctx) {
     await safeReply(ctx, `❌ Invalid --isolation value '${escapeMarkdown(solvePerCommandIsolation)}'. Must be: screen, tmux, or docker`, { reply_to_message_id: ctx.message.message_id });
     return;
   }
-  const args = mergeArgsWithOverrides(userArgsWithoutIsolation, solveOverrides);
+  const mergedSolveArgs = mergeArgsWithOverrides(userArgsWithoutIsolation, solveOverrides);
+  const { backend: solveOverrideIsolation, filteredArgs: args } = extractIsolationFromArgs(mergedSolveArgs);
+  if (solveOverrideIsolation && !isValidPerCommandIsolation(solveOverrideIsolation)) {
+    await safeReply(ctx, `❌ Invalid locked --isolation value '${escapeMarkdown(solveOverrideIsolation)}'. Must be: screen, tmux, or docker`, { reply_to_message_id: ctx.message.message_id });
+    return;
+  }
+  const effectiveSolveIsolation = solveOverrideIsolation || solvePerCommandIsolation;
 
   // Determine tool from args (default: claude)
   let solveTool = 'claude';
@@ -990,9 +1004,9 @@ async function handleSolveCommand(ctx) {
   const toolQueuedCount = queueStats.queuedByTool[solveTool] || 0; // tool-specific queue count (#1551)
   if (check.canStart && toolQueuedCount === 0) {
     const startingMessage = await safeReply(ctx, `🚀 Starting solve command...\n\n${infoBlock}`, { reply_to_message_id: ctx.message.message_id });
-    await executeAndUpdateMessage(ctx, startingMessage, 'solve', args, infoBlock, solvePerCommandIsolation);
+    await executeAndUpdateMessage(ctx, startingMessage, 'solve', args, infoBlock, effectiveSolveIsolation);
   } else {
-    const queueItem = solveQueue.enqueue({ url: normalizedUrl, args, ctx, requester, infoBlock, tool: solveTool, perCommandIsolation: solvePerCommandIsolation });
+    const queueItem = solveQueue.enqueue({ url: normalizedUrl, args, ctx, requester, infoBlock, tool: solveTool, perCommandIsolation: effectiveSolveIsolation });
     let queueMessage = `📋 Solve command queued (${solveTool} queue position #${toolQueuedCount + 1})\n\n${infoBlock}`; // tool-specific position (#1551)
     if (check.reason) queueMessage += `\n\n⏳ Waiting: ${escapeMarkdown(check.reason)}`;
     const queuedMessage = await safeReply(ctx, queueMessage, { reply_to_message_id: ctx.message.message_id });
@@ -1102,7 +1116,13 @@ async function handleHiveCommand(ctx) {
     await safeReply(ctx, `❌ Invalid --isolation value '${escapeMarkdown(hivePerCommandIsolation)}'. Must be: screen, tmux, or docker`, { reply_to_message_id: ctx.message.message_id });
     return;
   }
-  const args = mergeArgsWithOverrides(normalizedArgsWithoutIsolation, hiveOverrides);
+  const mergedHiveArgs = mergeArgsWithOverrides(normalizedArgsWithoutIsolation, hiveOverrides);
+  const { backend: hiveOverrideIsolation, filteredArgs: args } = extractIsolationFromArgs(mergedHiveArgs);
+  if (hiveOverrideIsolation && !isValidPerCommandIsolation(hiveOverrideIsolation)) {
+    await safeReply(ctx, `❌ Invalid locked --isolation value '${escapeMarkdown(hiveOverrideIsolation)}'. Must be: screen, tmux, or docker`, { reply_to_message_id: ctx.message.message_id });
+    return;
+  }
+  const effectiveHiveIsolation = hiveOverrideIsolation || hivePerCommandIsolation;
 
   // Determine tool from args (default: claude)
   let hiveTool = 'claude';
@@ -1161,7 +1181,7 @@ async function handleHiveCommand(ctx) {
   }
 
   const startingMessage = await safeReply(ctx, `🚀 Starting hive command...\n\n${infoBlock}`, { reply_to_message_id: ctx.message.message_id });
-  await executeAndUpdateMessage(ctx, startingMessage, 'hive', args, infoBlock, hivePerCommandIsolation);
+  await executeAndUpdateMessage(ctx, startingMessage, 'hive', args, infoBlock, effectiveHiveIsolation);
 }
 
 bot.command(/^hive$/i, handleHiveCommand);