@link-assistant/hive-mind 1.56.13 → 1.56.14

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 1.56.14
+
+### Patch Changes
+
+- 77d6be2: Prevent failure-log uploads from posting broken `null` links and replace green-check failure-log terminal status with neutral attachment wording.
+
 ## 1.56.13
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.56.13",
+  "version": "1.56.14",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -15,7 +15,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-issue-1680-session-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-log-upload-output-1682.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-issue-1680-session-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",

package/src/github.lib.mjs

@@ -299,6 +299,26 @@ Thank you! 🙏`;
     return false;
   }
 };
+export const selectLogUploadUrl = ({ uploadResult, isPublicRepo }) => {
+  if (!uploadResult?.success) return null;
+
+  const chunks = Number.isFinite(uploadResult.chunks) ? uploadResult.chunks : 1;
+  const rawUrl = uploadResult.rawUrl || null;
+  const pageUrl = uploadResult.url || null;
+  const canUseRawUrl = chunks === 1 && rawUrl && (isPublicRepo || uploadResult.type !== 'repository');
+
+  return canUseRawUrl ? rawUrl : pageUrl;
+};
+
+const isUsableLogUrl = value => typeof value === 'string' && /^https:\/\/[^\s)]+$/u.test(value);
+
+const getLogUploadTerminalStatus = ({ errorMessage, errorDuringExecution, isUsageLimit }) => {
+  if (errorMessage) return { emoji: '📎', label: 'Failure log' };
+  if (errorDuringExecution) return { emoji: '📎', label: 'Finished-with-errors log' };
+  if (isUsageLimit) return { emoji: '📎', label: 'Usage-limit execution log' };
+  return { emoji: '✅', label: 'Solution draft log' };
+};
+
 /** Attaches a log file to a GitHub PR or issue as a comment. Returns true if upload succeeded. */
 export async function attachLogToGitHub(options) {
   const fs = (await use('fs')).promises;
@@ -616,8 +636,14 @@ ${logContent}
           // Requirements: 1 chunk = direct raw link, >1 chunks = repo link
           // Private repository raw URLs can contain short-lived tokens, so keep
           // private uploads on the stable repository/tree page URL.
-          const useRawLogUrl = uploadResult.chunks === 1 && uploadResult.rawUrl && (isPublicRepo || uploadResult.type !== 'repository');
-          const logUrl = useRawLogUrl ? uploadResult.rawUrl : uploadResult.url;
+          const logUrl = selectLogUploadUrl({ uploadResult, isPublicRepo });
+          if (!isUsableLogUrl(logUrl)) {
+            await log('  ❌ gh-upload-log completed but no usable log URL was resolved');
+            await log('  ⚠️  Full log upload failed; not posting a broken log link');
+            await log(`  📁 Full log remains available locally at: ${logFile}`);
+            return false;
+          }
+
           const uploadTypeLabel = uploadResult.type === 'gist' ? 'Gist' : 'Repository';
           const chunkInfo = uploadResult.chunks > 1 ? ` (${uploadResult.chunks} chunks)` : '';
 
@@ -745,7 +771,8 @@ ${sessionNote}
           const posted = await postTrackedCommentFromFile({ $, owner, repo, targetNumber, bodyFile: tempCommentFile });
           await fs.unlink(tempCommentFile).catch(() => {});
           if (posted.ok) {
-            await log(`  ✅ Solution draft log uploaded to ${targetName} as ${isPublicRepo ? 'public' : 'private'} ${uploadTypeLabel}${chunkInfo}${posted.commentId ? ` (comment id=${posted.commentId})` : ''}`);
+            const status = getLogUploadTerminalStatus({ errorMessage, errorDuringExecution, isUsageLimit });
+            await log(`  ${status.emoji} ${status.label} uploaded to ${targetName} as ${isPublicRepo ? 'public' : 'private'} ${uploadTypeLabel}${chunkInfo}${posted.commentId ? ` (comment id=${posted.commentId})` : ''}`);
             await log(`  🔗 Log URL: ${logUrl}`);
             await log(`  📊 Log size: ${Math.round(logStats.size / 1024)}KB`);
             return true;
@@ -785,7 +812,7 @@ ${sessionNote}
  */
 async function attachRegularComment(options, logComment) {
   const fs = (await use('fs')).promises;
-  const { targetType, targetNumber, owner, repo, $, log, logFile } = options;
+  const { targetType, targetNumber, owner, repo, $, log, logFile, errorMessage, errorDuringExecution, isUsageLimit } = options;
 
   const targetName = targetType === 'pr' ? 'Pull Request' : 'Issue';
   const ghCommand = targetType === 'pr' ? 'pr' : 'issue';
@@ -801,7 +828,8 @@ async function attachRegularComment(options, logComment) {
   await fs.unlink(tempFile).catch(() => {});
 
   if (posted.ok) {
-    await log(`  ✅ Solution draft log uploaded to ${targetName} as comment${posted.commentId ? ` (id=${posted.commentId})` : ''}`);
+    const status = getLogUploadTerminalStatus({ errorMessage, errorDuringExecution, isUsageLimit });
+    await log(`  ${status.emoji} ${status.label} uploaded to ${targetName} as comment${posted.commentId ? ` (id=${posted.commentId})` : ''}`);
     await log(`  📊 Log size: ${Math.round(logStats.size / 1024)}KB`);
     return true;
   } else {

package/src/solve.mjs

@@ -1124,7 +1124,7 @@ try {
         });
 
         if (logUploadSuccess) {
-          await log(`  ✅ Failure logs uploaded to ${logTargetLabel} successfully`);
+          await log(`  📎 Failure logs attached to ${logTargetLabel}`);
         } else {
           // Issue #1212: Always show log upload failures (not just verbose)
           await log('  ⚠️  Failed to upload failure logs');