@link-assistant/hive-mind 1.56.12 → 1.56.14

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @link-assistant/hive-mind
 
+## 1.56.14
+
+### Patch Changes
+
+- 77d6be2: Prevent failure-log uploads from posting broken `null` links and replace green-check failure-log terminal status with neutral attachment wording.
+
+## 1.56.13
+
+### Patch Changes
+
+- ca1ac93: Start Telegram work-session monitoring before Telegraf long polling can block startup code, and keep completed screen-isolated sessions in memory until their completion message is updated.
+
 ## 1.56.12
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.56.12",
+  "version": "1.56.14",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -15,7 +15,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-log-upload-output-1682.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-issue-1680-session-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",

package/src/github.lib.mjs

@@ -299,6 +299,26 @@ Thank you! 🙏`;
     return false;
   }
 };
+export const selectLogUploadUrl = ({ uploadResult, isPublicRepo }) => {
+  if (!uploadResult?.success) return null;
+
+  const chunks = Number.isFinite(uploadResult.chunks) ? uploadResult.chunks : 1;
+  const rawUrl = uploadResult.rawUrl || null;
+  const pageUrl = uploadResult.url || null;
+  const canUseRawUrl = chunks === 1 && rawUrl && (isPublicRepo || uploadResult.type !== 'repository');
+
+  return canUseRawUrl ? rawUrl : pageUrl;
+};
+
+const isUsableLogUrl = value => typeof value === 'string' && /^https:\/\/[^\s)]+$/u.test(value);
+
+const getLogUploadTerminalStatus = ({ errorMessage, errorDuringExecution, isUsageLimit }) => {
+  if (errorMessage) return { emoji: '📎', label: 'Failure log' };
+  if (errorDuringExecution) return { emoji: '📎', label: 'Finished-with-errors log' };
+  if (isUsageLimit) return { emoji: '📎', label: 'Usage-limit execution log' };
+  return { emoji: '✅', label: 'Solution draft log' };
+};
+
 /** Attaches a log file to a GitHub PR or issue as a comment. Returns true if upload succeeded. */
 export async function attachLogToGitHub(options) {
   const fs = (await use('fs')).promises;
@@ -616,8 +636,14 @@ ${logContent}
           // Requirements: 1 chunk = direct raw link, >1 chunks = repo link
           // Private repository raw URLs can contain short-lived tokens, so keep
           // private uploads on the stable repository/tree page URL.
-          const useRawLogUrl = uploadResult.chunks === 1 && uploadResult.rawUrl && (isPublicRepo || uploadResult.type !== 'repository');
-          const logUrl = useRawLogUrl ? uploadResult.rawUrl : uploadResult.url;
+          const logUrl = selectLogUploadUrl({ uploadResult, isPublicRepo });
+          if (!isUsableLogUrl(logUrl)) {
+            await log('  ❌ gh-upload-log completed but no usable log URL was resolved');
+            await log('  ⚠️  Full log upload failed; not posting a broken log link');
+            await log(`  📁 Full log remains available locally at: ${logFile}`);
+            return false;
+          }
+
           const uploadTypeLabel = uploadResult.type === 'gist' ? 'Gist' : 'Repository';
           const chunkInfo = uploadResult.chunks > 1 ? ` (${uploadResult.chunks} chunks)` : '';
 
@@ -745,7 +771,8 @@ ${sessionNote}
           const posted = await postTrackedCommentFromFile({ $, owner, repo, targetNumber, bodyFile: tempCommentFile });
           await fs.unlink(tempCommentFile).catch(() => {});
           if (posted.ok) {
-            await log(`  ✅ Solution draft log uploaded to ${targetName} as ${isPublicRepo ? 'public' : 'private'} ${uploadTypeLabel}${chunkInfo}${posted.commentId ? ` (comment id=${posted.commentId})` : ''}`);
+            const status = getLogUploadTerminalStatus({ errorMessage, errorDuringExecution, isUsageLimit });
+            await log(`  ${status.emoji} ${status.label} uploaded to ${targetName} as ${isPublicRepo ? 'public' : 'private'} ${uploadTypeLabel}${chunkInfo}${posted.commentId ? ` (comment id=${posted.commentId})` : ''}`);
             await log(`  🔗 Log URL: ${logUrl}`);
             await log(`  📊 Log size: ${Math.round(logStats.size / 1024)}KB`);
             return true;
@@ -785,7 +812,7 @@ ${sessionNote}
  */
 async function attachRegularComment(options, logComment) {
   const fs = (await use('fs')).promises;
-  const { targetType, targetNumber, owner, repo, $, log, logFile } = options;
+  const { targetType, targetNumber, owner, repo, $, log, logFile, errorMessage, errorDuringExecution, isUsageLimit } = options;
 
   const targetName = targetType === 'pr' ? 'Pull Request' : 'Issue';
   const ghCommand = targetType === 'pr' ? 'pr' : 'issue';
@@ -801,7 +828,8 @@ async function attachRegularComment(options, logComment) {
   await fs.unlink(tempFile).catch(() => {});
 
   if (posted.ok) {
-    await log(`  ✅ Solution draft log uploaded to ${targetName} as comment${posted.commentId ? ` (id=${posted.commentId})` : ''}`);
+    const status = getLogUploadTerminalStatus({ errorMessage, errorDuringExecution, isUsageLimit });
+    await log(`  ${status.emoji} ${status.label} uploaded to ${targetName} as comment${posted.commentId ? ` (id=${posted.commentId})` : ''}`);
     await log(`  📊 Log size: ${Math.round(logStats.size / 1024)}KB`);
     return true;
   } else {

package/src/session-monitor.lib.mjs

@@ -34,6 +34,10 @@ async function getIsolationRunner() {
 // In-memory session store
 const activeSessions = new Map();
 
+export function resetSessionMonitorForTests() {
+  activeSessions.clear();
+}
+
 /**
  * Issue #1586: Timeout for non-isolation sessions.
  * Non-isolation (plain start-screen) sessions cannot reliably detect completion
@@ -124,6 +128,11 @@ function completeSession(sessionName, exitCode = 0, verbose = false) {
   }
 }
 
+function isMessageAlreadyUpdatedError(error) {
+  const message = String(error?.message || '').toLowerCase();
+  return message.includes('message is not modified');
+}
+
 function normalizeSessionUrl(url) {
   return url.replace(/\/+$/, '').replace(/#.*$/, '').toLowerCase();
 }
@@ -190,7 +199,7 @@ async function getIsolationSessionState(sessionName, sessionInfo, options = {})
  * @param {Object} bot - Telegraf bot instance for sending messages
  * @param {boolean} verbose - Whether to log verbose output
  */
-export async function monitorSessions(bot, verbose = false) {
+export async function monitorSessions(bot, verbose = false, options = {}) {
   const sessions = getActiveSessions(verbose);
 
   if (sessions.length === 0) {
@@ -210,7 +219,10 @@ export async function monitorSessions(bot, verbose = false) {
       // Isolation mode: use $ --status, with screen -ls only as a fallback
       // when the status record is unavailable. Terminal $ statuses are
       // authoritative so completed screen sessions do not stay blocked.
-      const state = await getIsolationSessionState(sessionName, sessionInfo, { verbose });
+      const state = await getIsolationSessionState(sessionName, sessionInfo, {
+        verbose,
+        statusProvider: options.statusProvider,
+      });
       stillRunning = state.running;
       exitCode = state.exitCode;
       statusResult = state.statusResult;
@@ -257,7 +269,16 @@ export async function monitorSessions(bot, verbose = false) {
         completeSession(sessionName, finalExitCode || 0, verbose);
       } catch (error) {
         console.error(`Failed to send completion notification for ${sessionName}:`, error);
-        completeSession(sessionName, 1, verbose);
+        if (isMessageAlreadyUpdatedError(error)) {
+          completeSession(sessionName, exitCode || 0, verbose);
+        } else {
+          sessionInfo.lastNotificationError = error.message;
+          sessionInfo.lastKnownStatus = statusResult?.status || sessionInfo.lastKnownStatus || null;
+          sessionInfo.lastKnownExitCode = exitCode ?? sessionInfo.lastKnownExitCode ?? null;
+          if (verbose) {
+            console.log(`[VERBOSE] Session ${sessionName} kept in memory so the completion notification can be retried`);
+          }
+        }
       }
     }
   }
@@ -270,8 +291,14 @@ export async function monitorSessions(bot, verbose = false) {
  * @param {number} intervalMs - Monitoring interval in milliseconds (default: 30000)
  * @returns {NodeJS.Timer} The interval timer (can be cleared with clearInterval)
  */
-export function startSessionMonitoring(bot, verbose = false, intervalMs = 30000) {
-  const timer = setInterval(() => monitorSessions(bot, verbose), intervalMs);
+export function startSessionMonitoring(bot, verbose = false, intervalMs = 30000, options = {}) {
+  const runMonitor = () => {
+    monitorSessions(bot, verbose, options).catch(error => {
+      console.error(`[session-monitor] Session monitoring tick failed: ${error.message}`);
+    });
+  };
+  const timer = setInterval(runMonitor, intervalMs);
+  runMonitor();
   console.log(`📊 Session monitoring started (checking every ${intervalMs / 1000} seconds, storage: in-memory)`);
   return timer;
 }

package/src/solve.mjs

@@ -1124,7 +1124,7 @@ try {
         });
 
         if (logUploadSuccess) {
-          await log(`  ✅ Failure logs uploaded to ${logTargetLabel} successfully`);
+          await log(`  📎 Failure logs attached to ${logTargetLabel}`);
         } else {
           // Issue #1212: Always show log upload failures (not just verbose)
           await log('  ⚠️  Failed to upload failure logs');

package/src/telegram-bot-launcher.lib.mjs

@@ -105,13 +105,28 @@ export function formatDelay(delayMs) {
  * @param {number} [retryOptions.jitterFraction] - Jitter fraction (default: 0.1)
  * @param {boolean} [retryOptions.verbose] - Enable verbose logging
  * @param {Function} [retryOptions.onRetry] - Callback on each retry: (attempt, error, delayMs) => void
+ * @param {Function} [retryOptions.onLaunch] - Callback when Telegraf reports that launch has started
  * @param {AbortSignal} [retryOptions.signal] - AbortSignal to cancel retry loop
  * @returns {Promise<void>} Resolves when bot is successfully launched
  * @throws {Error} If a non-retryable error occurs or signal is aborted
  */
 export async function launchBotWithRetry(bot, launchOptions, retryOptions = {}) {
-  const { verbose = false, onRetry, signal, ...backoffConfig } = retryOptions;
+  const { verbose = false, onRetry, onLaunch, signal, ...backoffConfig } = retryOptions;
   let attempt = 0;
+  let launchNotified = false;
+
+  const notifyLaunched = () => {
+    if (launchNotified || typeof onLaunch !== 'function') return;
+    launchNotified = true;
+    try {
+      const result = onLaunch();
+      if (result && typeof result.catch === 'function') {
+        result.catch(error => console.error(`[telegram-bot-launcher] onLaunch callback failed: ${error.message}`));
+      }
+    } catch (error) {
+      console.error(`[telegram-bot-launcher] onLaunch callback failed: ${error.message}`);
+    }
+  };
 
   while (true) {
     // Check if abort was requested (e.g., during shutdown)
@@ -130,10 +145,13 @@ export async function launchBotWithRetry(bot, launchOptions, retryOptions = {})
 
       if (verbose) console.log(`[VERBOSE] Launch attempt ${attempt}: starting polling...`);
 
-      // Step 2: Launch bot in polling mode
-      await bot.launch(launchOptions);
+      // Step 2: Launch bot in polling mode. In Telegraf long-polling mode the
+      // launch promise may stay pending while polling is active, so use the
+      // launch callback for startup side effects such as session monitoring.
+      await bot.launch(launchOptions, notifyLaunched);
 
       // Success -- bot is running
+      notifyLaunched();
       if (attempt > 1) {
         console.log(`✅ Bot launched successfully after ${attempt} attempts`);
       }

package/src/telegram-bot.mjs

@@ -1376,6 +1376,64 @@ if (VERBOSE) {
 // The launcher handles deleteWebhook + bot.launch() with retry on transient errors.
 // Non-retryable errors (401 Unauthorized) cause immediate exit.
 const launchAbortController = new AbortController();
+let sessionMonitoringTimer = null;
+let launchAnnouncementShown = false;
+
+function startSessionMonitoringOnce() {
+  if (sessionMonitoringTimer) return;
+  sessionMonitoringTimer = startSessionMonitoring(bot, VERBOSE);
+}
+
+async function onBotLaunched() {
+  if (isShuttingDown || launchAnnouncementShown) return;
+  launchAnnouncementShown = true;
+
+  console.log('✅ SwarmMindBot is now running!');
+  console.log('Press Ctrl+C to stop');
+  startSessionMonitoringOnce();
+
+  if (VERBOSE) {
+    console.log('[VERBOSE] Bot launched successfully');
+    console.log('[VERBOSE] Polling is active, waiting for messages...');
+
+    // Get bot info and webhook status for diagnostics
+    try {
+      const botInfo = await bot.telegram.getMe();
+      const webhookInfo = await bot.telegram.getWebhookInfo();
+
+      console.log('[VERBOSE] Bot info:');
+      console.log('[VERBOSE]   Username: @' + botInfo.username);
+      console.log('[VERBOSE]   Bot ID:', botInfo.id);
+      console.log('[VERBOSE] Webhook info:');
+      console.log('[VERBOSE]   URL:', webhookInfo.url || 'none (polling mode)');
+      console.log('[VERBOSE]   Pending updates:', webhookInfo.pending_update_count);
+      if (webhookInfo.last_error_date) {
+        console.log('[VERBOSE]   Last error:', new Date(webhookInfo.last_error_date * 1000).toISOString());
+        console.log('[VERBOSE]   Error message:', webhookInfo.last_error_message);
+      }
+
+      console.log('[VERBOSE]');
+      console.log('[VERBOSE] ⚠️  IMPORTANT: If bot is not receiving messages in group chats:');
+      console.log('[VERBOSE]   1. Privacy Mode: Check if bot has privacy mode enabled in @BotFather');
+      console.log('[VERBOSE]      - Send /setprivacy to @BotFather');
+      console.log('[VERBOSE]      - Select @' + botInfo.username);
+      console.log('[VERBOSE]      - Choose "Disable" to receive all group messages');
+      console.log('[VERBOSE]      - IMPORTANT: Remove bot from group and re-add after changing!');
+      console.log('[VERBOSE]   2. Admin Status: Make bot an admin in the group (admins see all messages)');
+      console.log('[VERBOSE]   3. Run diagnostic: node experiments/test-telegram-bot-privacy-mode.mjs');
+      console.log('[VERBOSE]');
+    } catch (err) {
+      console.log('[VERBOSE] Could not fetch bot info:', err.message);
+    }
+
+    console.log('[VERBOSE] Send a message to the bot to test message reception');
+  }
+}
+
+// Start completion polling before entering Telegraf long polling. The active
+// session map is empty until commands are received, but bot.launch() may stay
+// pending while polling is active.
+startSessionMonitoringOnce();
 
 launchBotWithRetry(
   bot,
@@ -1386,52 +1444,11 @@ launchBotWithRetry(
   {
     verbose: VERBOSE,
     signal: launchAbortController.signal,
+    onLaunch: onBotLaunched,
   }
 )
-  .then(async () => {
-    if (isShuttingDown) return; // Skip success messages if shutting down
-
-    console.log('✅ SwarmMindBot is now running!');
-    console.log('Press Ctrl+C to stop');
-    if (VERBOSE) {
-      console.log('[VERBOSE] Bot launched successfully');
-      console.log('[VERBOSE] Polling is active, waiting for messages...');
-
-      // Get bot info and webhook status for diagnostics
-      try {
-        const botInfo = await bot.telegram.getMe();
-        const webhookInfo = await bot.telegram.getWebhookInfo();
-
-        console.log('[VERBOSE] Bot info:');
-        console.log('[VERBOSE]   Username: @' + botInfo.username);
-        console.log('[VERBOSE]   Bot ID:', botInfo.id);
-        console.log('[VERBOSE] Webhook info:');
-        console.log('[VERBOSE]   URL:', webhookInfo.url || 'none (polling mode)');
-        console.log('[VERBOSE]   Pending updates:', webhookInfo.pending_update_count);
-        if (webhookInfo.last_error_date) {
-          console.log('[VERBOSE]   Last error:', new Date(webhookInfo.last_error_date * 1000).toISOString());
-          console.log('[VERBOSE]   Error message:', webhookInfo.last_error_message);
-        }
-
-        console.log('[VERBOSE]');
-        console.log('[VERBOSE] ⚠️  IMPORTANT: If bot is not receiving messages in group chats:');
-        console.log('[VERBOSE]   1. Privacy Mode: Check if bot has privacy mode enabled in @BotFather');
-        console.log('[VERBOSE]      - Send /setprivacy to @BotFather');
-        console.log('[VERBOSE]      - Select @' + botInfo.username);
-        console.log('[VERBOSE]      - Choose "Disable" to receive all group messages');
-        console.log('[VERBOSE]      - IMPORTANT: Remove bot from group and re-add after changing!');
-        console.log('[VERBOSE]   2. Admin Status: Make bot an admin in the group (admins see all messages)');
-        console.log('[VERBOSE]   3. Run diagnostic: node experiments/test-telegram-bot-privacy-mode.mjs');
-        console.log('[VERBOSE]');
-      } catch (err) {
-        console.log('[VERBOSE] Could not fetch bot info:', err.message);
-      }
-
-      console.log('[VERBOSE] Send a message to the bot to test message reception');
-    }
-
-    // Start session monitoring - check for completed sessions every 30 seconds
-    startSessionMonitoring(bot, VERBOSE);
+  .then(() => {
+    if (!isShuttingDown && VERBOSE) console.log('[VERBOSE] Bot launch promise resolved');
   })
   .catch(error => {
     console.error('❌ Failed to start bot:', error);
@@ -1460,6 +1477,7 @@ process.once('SIGINT', () => {
   console.log('\n🛑 Received SIGINT (Ctrl+C), stopping bot...');
   if (VERBOSE) console.log(`[VERBOSE] Signal: SIGINT, PID: ${process.pid}, PPID: ${process.ppid}`);
   launchAbortController.abort(); // Cancel retry loop if still retrying (issue #1240)
+  if (sessionMonitoringTimer) clearInterval(sessionMonitoringTimer);
   stopSolveQueue();
   bot.stop('SIGINT');
 });
@@ -1469,6 +1487,7 @@ process.once('SIGTERM', () => {
   console.log('\n🛑 Received SIGTERM, stopping bot... (Check system logs: journalctl -u <service> or dmesg)');
   if (VERBOSE) console.log(`[VERBOSE] Signal: SIGTERM, PID: ${process.pid}, PPID: ${process.ppid}`);
   launchAbortController.abort(); // Cancel retry loop if still retrying (issue #1240)
+  if (sessionMonitoringTimer) clearInterval(sessionMonitoringTimer);
   stopSolveQueue();
   bot.stop('SIGTERM');
 });