@link-assistant/hive-mind 1.56.11 → 1.56.12

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 1.56.12
+
+### Patch Changes
+
+- 71e1ef5: Prevent `--attach-logs` from posting truncated fallback comments when full `gh-upload-log` uploads fail, and parse newer `gh-upload-log` repository output including shared-repository paths.
+
 ## 1.56.11
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.56.11",
+  "version": "1.56.12",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -15,7 +15,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-claude-quiet-config.mjs && node tests/test-configure-claude-bin.mjs && node tests/test-docker-release-order.mjs && node tests/test-docker-box-migration.mjs && node tests/test-hive-screens.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-ready-to-merge-pagination-1645.mjs && node tests/test-require-gh-paginate-rule.mjs && node tests/test-auto-restart-limits-1664.mjs && node tests/test-log-upload-output-1678.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-telegram-options-before-url.mjs && node tests/test-telegram-bot-configuration-isolation-links-notation.mjs && node tests/test-extract-isolation-from-args.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-issue-1670-screen-status-monitoring.mjs && node tests/test-telegram-bot-launcher.mjs",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",

package/src/github.lib.mjs

@@ -614,7 +614,10 @@ ${logContent}
         if (uploadResult.success) {
           // Use rawUrl for direct file access (single chunk) or url for repository (multiple chunks)
           // Requirements: 1 chunk = direct raw link, >1 chunks = repo link
-          const logUrl = uploadResult.chunks === 1 ? uploadResult.rawUrl : uploadResult.url;
+          // Private repository raw URLs can contain short-lived tokens, so keep
+          // private uploads on the stable repository/tree page URL.
+          const useRawLogUrl = uploadResult.chunks === 1 && uploadResult.rawUrl && (isPublicRepo || uploadResult.type !== 'repository');
+          const logUrl = useRawLogUrl ? uploadResult.rawUrl : uploadResult.url;
           const uploadTypeLabel = uploadResult.type === 'gist' ? 'Gist' : 'Repository';
           const chunkInfo = uploadResult.chunks > 1 ? ` (${uploadResult.chunks} chunks)` : '';
 
@@ -752,10 +755,9 @@ ${sessionNote}
           }
         } else {
           await log('  ❌ gh-upload-log failed');
-
-          // Fallback to truncated comment
-          await log('  🔄 Falling back to truncated comment...');
-          return await attachTruncatedLog(options);
+          await log('  ⚠️  Full log upload failed; not posting a truncated log because --attach-logs must preserve complete logs');
+          await log(`  📁 Full log remains available locally at: ${logFile}`);
+          return false;
         }
       } catch (uploadError) {
         reportError(uploadError, {
@@ -763,8 +765,9 @@ ${sessionNote}
           level: 'error',
         });
         await log(`  ❌ Error uploading log: ${uploadError.message}`);
-        // Try regular comment as last resort
-        return await attachRegularComment(options, logComment);
+        await log('  ⚠️  Full log upload failed; not posting a truncated log because --attach-logs must preserve complete logs');
+        await log(`  📁 Full log remains available locally at: ${logFile}`);
+        return false;
       }
     } else {
       // Comment fits within limit
@@ -777,60 +780,6 @@ ${sessionNote}
     return false;
   }
 }
-/**
- * Helper to attach a truncated log when full log is too large
- */
-async function attachTruncatedLog(options) {
-  const fs = (await use('fs')).promises;
-  const { logFile, targetType, targetNumber, owner, repo, $, log, sanitizeLogContent } = options;
-
-  const targetName = targetType === 'pr' ? 'Pull Request' : 'Issue';
-  const ghCommand = targetType === 'pr' ? 'pr' : 'issue';
-
-  const rawLogContent = await fs.readFile(logFile, 'utf8');
-  let logContent = await sanitizeLogContent(rawLogContent);
-  // Escape code blocks to prevent markdown breaking
-  logContent = escapeCodeBlocksInLog(logContent);
-  const logStats = await fs.stat(logFile);
-
-  const GITHUB_COMMENT_LIMIT = 65536;
-  const maxContentLength = GITHUB_COMMENT_LIMIT - 500;
-  const truncatedContent = logContent.substring(0, maxContentLength) + '\n\n[... Log truncated due to length ...]';
-
-  const truncatedComment = `## 🤖 ${SOLUTION_DRAFT_LOG_MARKER} (Truncated)
-This log file contains the complete execution trace of the AI ${targetType === 'pr' ? 'solution draft' : 'analysis'} process.
-⚠️ **Log was truncated** due to GitHub comment size limits.
-
-<details>
-<summary>Click to expand solution draft log (${Math.round(logStats.size / 1024)}KB, truncated)</summary>
-
-\`\`\`
-${truncatedContent}
-\`\`\`
-
-</details>
-
----
-*${NOW_WORKING_SESSION_IS_ENDED_MARKER}, feel free to review and add any feedback on the solution draft.*`;
-  const tempFile = `/tmp/log-truncated-comment-${targetType}-${Date.now()}.md`;
-  await fs.writeFile(tempFile, truncatedComment);
-
-  // Issue #1625: track the posted comment ID so it's excluded from the
-  // AI-authored-comment check in --auto-attach-solution-summary.
-  const posted = await postTrackedCommentFromFile({ $, owner, repo, targetNumber, bodyFile: tempFile });
-  await fs.unlink(tempFile).catch(() => {});
-  // ghCommand and targetName are retained in signature for symmetry with
-  // attachLogToGitHub's logging vocabulary.
-  void ghCommand;
-  if (posted.ok) {
-    await log(`  ✅ Truncated solution draft log uploaded to ${targetName}${posted.commentId ? ` (comment id=${posted.commentId})` : ''}`);
-    await log(`  📊 Log size: ${Math.round(logStats.size / 1024)}KB (truncated)`);
-    return true;
-  } else {
-    await log(`  ❌ Failed to upload truncated log: ${posted.stderr || 'unknown error'}`);
-    return false;
-  }
-}
 /**
  * Helper to attach a regular comment when it fits within limits
  */

package/src/log-upload.lib.mjs

@@ -27,6 +27,54 @@ const summarizeCommandOutput = value => {
   return text.length > 500 ? `${text.slice(0, 500)}... [truncated ${text.length - 500} chars]` : text;
 };
 
+export const parseGhUploadLogOutput = outputValue => {
+  const output = outputValue?.toString?.() || '';
+  const parsed = {
+    url: null,
+    rawUrl: null,
+    type: null,
+    chunks: 1,
+    repositoryName: null,
+    repositoryPath: null,
+  };
+
+  const urlMatch = output.match(/(?:^|\n)🔗\s+(https:\/\/[^\s\n]+)/u);
+  if (urlMatch) {
+    parsed.url = urlMatch[1].trim();
+  }
+
+  const rawUrlMatch = output.match(/(?:^|\n)📄\s+(https:\/\/[^\s\n]+)/u);
+  if (rawUrlMatch) {
+    parsed.rawUrl = rawUrlMatch[1].trim();
+  }
+
+  if (output.includes('Type: 📝 Gist') || parsed.url?.includes('gist.github.com')) {
+    parsed.type = 'gist';
+  } else if (output.includes('Type: 📦 Repository') || (parsed.url?.includes('github.com') && !parsed.url?.includes('gist'))) {
+    parsed.type = 'repository';
+  }
+
+  const fileCountMatch = output.match(/File count:\s*(\d+)/i);
+  const chunkMatch = output.match(/split into (\d+) chunks/i);
+  if (fileCountMatch) {
+    parsed.chunks = parseInt(fileCountMatch[1], 10);
+  } else if (chunkMatch) {
+    parsed.chunks = parseInt(chunkMatch[1], 10);
+  }
+
+  const repositoryMatch = output.match(/Repository:\s*([^\s\n]+)/i);
+  if (repositoryMatch) {
+    parsed.repositoryName = repositoryMatch[1].trim();
+  }
+
+  const pathMatch = output.match(/Path:\s*([^\s\n]+)/i);
+  if (pathMatch) {
+    parsed.repositoryPath = pathMatch[1].trim();
+  }
+
+  return parsed;
+};
+
 /**
  * Upload a log file using gh-upload-log command
  * @param {Object} options - Upload options
@@ -34,7 +82,7 @@ const summarizeCommandOutput = value => {
  * @param {boolean} options.isPublic - Whether to make the upload public
  * @param {string} options.description - Description for the upload
  * @param {boolean} [options.verbose=false] - Enable verbose logging
- * @returns {Promise<{success: boolean, url: string|null, rawUrl: string|null, type: 'gist'|'repository'|null, chunks: number}>}
+ * @returns {Promise<{success: boolean, url: string|null, rawUrl: string|null, type: 'gist'|'repository'|null, chunks: number, repositoryName?: string|null, repositoryPath?: string|null}>}
  */
 export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description, verbose = false }) => {
   const result = { success: false, url: null, rawUrl: null, type: null, chunks: 1 };
@@ -71,25 +119,7 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
       return result;
     }
 
-    // Parse output to extract URL and type
-    // Look for the URL line: 🔗 https://...
-    const urlMatch = output.match(/🔗\s+(https:\/\/[^\s\n]+)/);
-    if (urlMatch) {
-      result.url = urlMatch[1].trim();
-    }
-
-    // Determine type from output
-    if (output.includes('Type: 📝 Gist') || result.url?.includes('gist.github.com')) {
-      result.type = 'gist';
-    } else if (output.includes('Type: 📦 Repository') || (result.url?.includes('github.com') && !result.url?.includes('gist'))) {
-      result.type = 'repository';
-    }
-
-    // Extract chunk count if mentioned
-    const chunkMatch = output.match(/split into (\d+) chunks/i);
-    if (chunkMatch) {
-      result.chunks = parseInt(chunkMatch[1], 10);
-    }
+    Object.assign(result, parseGhUploadLogOutput(output));
 
     // Construct raw URL based on type and chunks
     if (result.url) {
@@ -139,17 +169,23 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
           result.rawUrl = result.url;
         }
       } else if (result.type === 'repository') {
-        if (result.chunks === 1) {
+        if (result.rawUrl) {
+          // gh-upload-log v0.8+ prints the exact raw/download URL. Prefer it
+          // over reconstructing paths, especially for shared repositories.
+        } else if (result.chunks === 1) {
           // For single chunk repository: construct raw URL to the file
           // Repository URL format: https://github.com/owner/repo
           // We need to find the actual file name in the repo
           try {
             const repoUrl = result.url;
-            const repoPath = repoUrl.replace('https://github.com/', '');
+            const repoMatch = repoUrl.match(/^https:\/\/github\.com\/([^/]+)\/([^/]+)(?:\/tree\/([^/]+)\/(.+))?$/);
+            const [, repoOwner, repoName, branchName = 'main', treePath = null] = repoMatch || [];
+            const repoPath = repoOwner && repoName ? `${repoOwner}/${repoName}` : repoUrl.replace('https://github.com/', '');
+            const apiPath = treePath ? `repos/${repoPath}/contents/${treePath}?ref=${branchName}` : `repos/${repoPath}/contents`;
             if (verbose) {
               await log(`  🔍 Fetching repository contents for raw URL resolution (repoPath=${repoPath})`, { verbose: true });
             }
-            const contentsResult = await $silent`gh api repos/${repoPath}/contents --paginate --jq '.[].name'`;
+            const contentsResult = await $silent`gh api ${apiPath} --paginate --jq '.[].name'`;
             if (verbose) {
               await log(`  📥 Repository contents fetch completed (code=${contentsResult.code ?? 'unknown'})`, { verbose: true });
             }
@@ -161,7 +197,9 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
                 .filter(f => f && !f.startsWith('.'));
               if (files.length > 0) {
                 const fileName = files[0];
-                result.rawUrl = `${repoUrl}/raw/main/${fileName}`;
+                const rawPath = treePath ? `${treePath}/${fileName}` : fileName;
+                const baseRepoUrl = repoOwner && repoName ? `https://github.com/${repoOwner}/${repoName}` : repoUrl;
+                result.rawUrl = `${baseRepoUrl}/raw/${branchName}/${rawPath}`;
                 if (verbose) {
                   await log(`  🧩 Repository contents resolved fileName=${fileName}`, { verbose: true });
                 }
@@ -212,5 +250,6 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
 
 // Export all functions as default object too
 export default {
+  parseGhUploadLogOutput,
   uploadLogWithGhUploadLog,
 };