@link-assistant/hive-mind 1.56.1 → 1.56.2

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # @link-assistant/hive-mind
 
+## 1.56.2
+
+### Patch Changes
+
+- d39f08f: fix(hive-screens): make `--list` default to `--all`, print log/issue after `--enter` exits, and actually close sessions on `--close`
+
+  Addresses issue #1654:
+  - `hive-screens --list` now defaults to `--all` so a bare `--list` lists every
+    match, matching user expectations. `--enter` and `--close` keep `--oldest` as
+    their default because they are destructive.
+  - `hive-screens --enter` now prints `Log:` and `Issue:` lines **after** the
+    user detaches from the screen session, so the information is not wiped by
+    `screen -r` swapping to the alternate buffer.
+  - `hive-screens --close` now spawns `screen -X stuff exit\n` directly (with
+    the newline as a literal argv element) instead of shelling out with bash
+    ANSI-C quoting (`$'exit\n'`). The legacy form relied on `/bin/sh` being
+    bash, but on Debian/Ubuntu it is `dash`, which does not understand
+    `$'...'` — so the previous command sent the literal string `$exit\n` into
+    each session and never actually closed it.
+  - Adds a `--verbose` / `-v` flag that prints scanning diagnostics to stderr.
+
 ## 1.56.1
 
 ### Patch Changes

package/README.md

@@ -831,7 +831,7 @@ you see under `--list` is guaranteed to be the same set `--close` will act on
 
 ```bash
 # Safe preview — show every finished, mergeable solve session.
-hive-screens --list --all
+hive-screens --list
 
 # Close the oldest finished session (same as the legacy script's default).
 hive-screens --close
@@ -841,10 +841,15 @@ hive-screens --enter --newest
 
 # Close every finished session.
 hive-screens --close --all
+
+# Print diagnostic output while scanning (useful when matching fails).
+hive-screens --list --verbose
 ```
 
-Selection defaults to `--oldest`. Supply `--newest` or `--all` to change it.
-Run `hive-screens --help` for the full option list.
+`--list` defaults to `--all` so a bare `hive-screens --list` shows every match.
+`--enter` and `--close` default to `--oldest` because they are destructive.
+Supply `--oldest`, `--newest`, or `--all` to override. Run
+`hive-screens --help` for the full option list.
 
 ### Reboot server.
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.56.1",
+  "version": "1.56.2",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/hive-screens.lib.mjs

@@ -18,7 +18,7 @@ import { promisify } from 'node:util';
 
 const execAsync = promisify(execCallback);
 
-export const HIVE_SCREENS_HELP = `Usage: hive-screens (--list | --enter | --close) [--oldest|--newest|--all]
+export const HIVE_SCREENS_HELP = `Usage: hive-screens (--list | --enter | --close) [--oldest|--newest|--all] [--verbose]
 
 Scan detached GNU screen sessions for completed solve runs and either list,
 enter, or close them. A session matches when its scrollback contains both
@@ -30,21 +30,24 @@ Actions (one required):
       --enter          Attach to the selected match (blocking)
       --close          Send \`exit\\n\` to the selected match so it terminates
 
-Selection (optional, default: --oldest):
-      --oldest         Act on the oldest match (default)
+Selection (optional):
+      --oldest         Act on the oldest match (default for --enter/--close)
       --newest         Act on the newest match
-      --all            Act on every match in oldest-first order
+      --all            Act on every match (default for --list)
 
 Options:
+  -v, --verbose        Print diagnostic output to stderr while scanning
   -h, --help           Show this help and exit
 
 Examples:
-  hive-screens --list                   # safe preview of matches
-  hive-screens --list --all             # preview every match
-  hive-screens --close --oldest         # close the oldest finished run
+  hive-screens --list                   # list every match (default is --all)
+  hive-screens --list --oldest          # preview only the oldest match
+  hive-screens --close                  # close the oldest finished run
   hive-screens --enter --newest         # attach to the newest finished run
 
-Reference: https://github.com/link-assistant/hive-mind/issues/1649
+References:
+  https://github.com/link-assistant/hive-mind/issues/1649
+  https://github.com/link-assistant/hive-mind/issues/1654
 `;
 
 const ACTION_FLAGS = new Set(['--enter', '--close', '--list']);
@@ -61,6 +64,7 @@ export const parseHiveScreensArgs = argv => {
     close: false,
     list: false,
     selection: null,
+    verbose: false,
     help: false,
     error: null,
   };
@@ -70,6 +74,10 @@ export const parseHiveScreensArgs = argv => {
       result.help = true;
       continue;
     }
+    if (arg === '--verbose' || arg === '-v') {
+      result.verbose = true;
+      continue;
+    }
     if (ACTION_FLAGS.has(arg)) {
       if (arg === '--enter') result.enter = true;
       else if (arg === '--close') result.close = true;
@@ -100,7 +108,10 @@ export const parseHiveScreensArgs = argv => {
     return result;
   }
 
-  if (!result.selection) result.selection = 'oldest';
+  // --list is a safe preview so default to showing every match. --enter and
+  // --close are destructive, so their default stays --oldest (mirrors the
+  // legacy hive-screens.sh behaviour).
+  if (!result.selection) result.selection = result.list ? 'all' : 'oldest';
   return result;
 };
 
@@ -212,7 +223,12 @@ export const selectMatches = (matches, selection) => {
   return [matches[0]];
 };
 
-const printSession = ({ session, logPath, issueUrl }, { log }) => {
+/**
+ * Print the Session / Log / Issue triple for one match. Shared by --list,
+ * --enter (after leaving), and --close so every action surfaces the same
+ * human-readable context the legacy hive-screens.sh script showed.
+ */
+const printSessionInfo = ({ session, logPath, issueUrl }, { log }) => {
   log(`Session: ${session}`);
   log(logPath ? `Log: ${logPath}` : 'Log: (not found)');
   log(issueUrl ? `Issue: ${issueUrl}` : 'Issue: (not found)');
@@ -220,13 +236,32 @@ const printSession = ({ session, logPath, issueUrl }, { log }) => {
 
 const SEPARATOR = '-----------------------------------';
 
+/**
+ * Send `exit\n` to a detached screen session so its login shell terminates
+ * and the session is destroyed. Uses `spawn` with an argv array instead of
+ * `exec` with a shell string so we do not depend on the invoking shell
+ * understanding bash ANSI-C quoting (`$'exit\n'`), which `/bin/sh` on
+ * Debian/Ubuntu is dash and does not support. See issue #1654.
+ */
+export const closeScreenSession = async (session, { spawn } = {}) => {
+  const spawnFn = spawn || (await import('node:child_process')).spawn;
+  return new Promise((resolve, reject) => {
+    const child = spawnFn('screen', ['-S', session, '-X', 'stuff', 'exit\n'], { stdio: 'ignore' });
+    child.on('error', reject);
+    child.on('exit', code => {
+      if (code === 0) resolve();
+      else reject(new Error(`screen -X stuff exited with code ${code}`));
+    });
+  });
+};
+
 /**
  * Top-level orchestrator used by the bin. `deps` is injected so tests can
  * stub `exec`, `fs`, stdio, and process spawning without touching real
  * screen sessions.
  */
 export const runHiveScreens = async (argv, deps = {}) => {
-  const { exec = execAsync, fsModule = fs, tmpDir = os.tmpdir(), log = (...args) => console.log(...args), error = (...args) => console.error(...args), spawnScreen, captureOptions } = deps;
+  const { exec = execAsync, fsModule = fs, tmpDir = os.tmpdir(), log = (...args) => console.log(...args), error = (...args) => console.error(...args), spawnScreen, closeScreen, captureOptions } = deps;
 
   const args = parseHiveScreensArgs(argv);
   if (args.help) {
@@ -238,8 +273,12 @@ export const runHiveScreens = async (argv, deps = {}) => {
     return 1;
   }
 
+  const debug = args.verbose ? (...parts) => error('[hive-screens]', ...parts) : () => {};
+
   const order = args.selection === 'newest' ? 'newest' : 'oldest';
+  debug(`scanning detached sessions in ${order}-first order`);
   const matches = await findMatchingSessions({ exec, fsModule, tmpDir, order, captureOptions });
+  debug(`found ${matches.length} matching session(s)`);
 
   if (!matches.length) {
     log('No matching sessions');
@@ -247,10 +286,15 @@ export const runHiveScreens = async (argv, deps = {}) => {
   }
 
   const selected = selectMatches(matches, args.selection);
+  debug(`selection=${args.selection} -> acting on ${selected.length} session(s)`);
 
   for (const match of selected) {
-    printSession(match, { log });
     if (args.enter) {
+      // Print the session name up-front so the user knows which one they
+      // are about to attach to, then print the Log/Issue context AFTER
+      // control returns — otherwise `screen -r` swaps to the alternate
+      // buffer and wipes any context we printed beforehand.
+      log(`Session: ${match.session}`);
       log(`Entering ${match.session}`);
       if (spawnScreen) {
         await spawnScreen(match.session);
@@ -258,13 +302,23 @@ export const runHiveScreens = async (argv, deps = {}) => {
         await attachScreen(match.session);
       }
       log(`Left ${match.session}`);
-    }
-    if (args.close) {
+      log(match.logPath ? `Log: ${match.logPath}` : 'Log: (not found)');
+      log(match.issueUrl ? `Issue: ${match.issueUrl}` : 'Issue: (not found)');
+    } else if (args.close) {
+      printSessionInfo(match, { log });
       log(`Closing ${match.session}`);
-      const shellSession = match.session.replace(/'/g, "'\\''");
-      await exec(`screen -S '${shellSession}' -X stuff $'exit\\n'`).catch(err => {
+      debug(`sending 'exit\\n' to ${match.session} via screen -X stuff`);
+      try {
+        if (closeScreen) {
+          await closeScreen(match.session);
+        } else {
+          await closeScreenSession(match.session);
+        }
+      } catch (err) {
         error(`Failed to send exit to ${match.session}: ${err.message}`);
-      });
+      }
+    } else {
+      printSessionInfo(match, { log });
     }
     log(SEPARATOR);
   }