@link-assistant/hive-mind 1.54.3 → 1.54.4

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 1.54.4
+
+### Patch Changes
+
+- 2ac0a14: Notify the source issue when solve exits with a known issue but no pull request, including failure logs when `--attach-logs` is enabled.
+
 ## 1.54.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.54.3",
+  "version": "1.54.4",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",
@@ -13,7 +13,7 @@
     "hive-telegram-bot": "./src/telegram-bot.mjs"
   },
   "scripts": {
-    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-telegram-bot-launcher.mjs",
+    "test": "node tests/solve-queue.test.mjs && node tests/limits-display.test.mjs && node tests/test-usage-limit.mjs && node tests/test-codex-support.mjs && node tests/test-build-cost-info-string.mjs && node tests/test-claude-code-install-method.mjs && node tests/test-issue-1616-pr-issue-link-preservation.mjs && node tests/test-pre-pr-failure-notifier-1640.mjs && node tests/test-telegram-message-filters.mjs && node tests/test-telegram-bot-command-aliases.mjs && node tests/test-solve-queue-command.mjs && node tests/test-queue-display-1267.mjs && node tests/test-telegram-bot-launcher.mjs",
     "test:queue": "node tests/solve-queue.test.mjs",
     "test:limits-display": "node tests/limits-display.test.mjs",
     "test:usage-limit": "node tests/test-usage-limit.mjs",

package/src/exit-handler.lib.mjs

@@ -27,6 +27,8 @@ let logFunction = null;
 let cleanupFunction = null;
 let interruptFunction = null;
 let interruptHandlerRan = false;
+let preExitFunction = null;
+let preExitHandlerRan = false;
 
 /**
  * Initialize the exit handler with required dependencies
@@ -36,11 +38,16 @@ let interruptHandlerRan = false;
  * @param {Function} interrupt - Optional interrupt function to call on SIGINT/SIGTERM before cleanup
  *                               (e.g., auto-commit uncommitted changes, upload logs)
  */
-export const initializeExitHandler = (getLogPath, log, cleanup = null, interrupt = null) => {
+export const initializeExitHandler = (getLogPath, log, cleanup = null, interrupt = null, preExit = null) => {
   getLogPathFunction = getLogPath;
   logFunction = log;
   cleanupFunction = cleanup;
   interruptFunction = interrupt;
+  preExitFunction = preExit;
+};
+
+export const setPreExitHandler = preExit => {
+  preExitFunction = preExit;
 };
 
 /**
@@ -200,6 +207,20 @@ export const logActiveHandles = async (log = null) => {
 export const safeExit = async (code = 0, reason = 'Process completed') => {
   await showExitMessage(reason, code);
 
+  if (code !== 0 && preExitFunction && !preExitHandlerRan) {
+    preExitHandlerRan = true;
+    try {
+      await preExitFunction({ code, reason });
+    } catch (error) {
+      const message = error && error.message ? error.message : String(error);
+      if (logFunction) {
+        await logFunction(`⚠️  Pre-exit handler failed: ${message}`, { level: 'warning' });
+      } else {
+        console.warn(`⚠️  Pre-exit handler failed: ${message}`);
+      }
+    }
+  }
+
   // Issue #1431: Drain/unref active handles so the event loop exits naturally.
   // This resolves the root causes of dangling ReadStream (stdin), Socket (undici),
   // ChildProcess (command-stream), and WriteStream (stdout/stderr) handles.

package/src/solve.error-handlers.lib.mjs

@@ -70,6 +70,7 @@ export const handleFailure = async options => {
         });
         if (logUploadSuccess) {
           await log(`📎 Failure log attached to ${targetLabel}`);
+          if (!hasPR && hasIssue) global.prePullRequestFailureNotificationPosted = true;
         }
       } catch (attachError) {
         reportError(attachError, {

package/src/solve.mjs

@@ -41,6 +41,7 @@ const { formatResetTimeWithRelative } = usageLimitLib;
 
 const errorHandlers = await import('./solve.error-handlers.lib.mjs');
 const { createUncaughtExceptionHandler, createUnhandledRejectionHandler, handleMainExecutionError, handleNoPrAvailableError } = errorHandlers;
+const { notifyIssueAboutPrePullRequestFailure } = await import('./solve.pre-pr-failure-notifier.lib.mjs');
 
 const watchLib = await import('./solve.watch.lib.mjs');
 const { startWatchMode } = watchLib;
@@ -132,7 +133,7 @@ const cleanupWrapper = async () => {
   }
 };
 const interruptWrapper = createInterruptWrapper({ cleanupContext, checkForUncommittedChanges, shouldAttachLogs, attachLogToGitHub, getLogFile, sanitizeLogContent, $, log });
-initializeExitHandler(getAbsoluteLogPath, log, cleanupWrapper, interruptWrapper);
+initializeExitHandler(getAbsoluteLogPath, log, cleanupWrapper, interruptWrapper, ({ code, reason }) => notifyIssueAboutPrePullRequestFailure({ code, reason, argv, globalState: global, $, log, getLogFile, shouldAttachLogs, attachLogToGitHub, sanitizeLogContent, rawCommand }));
 installGlobalExitHandlers();
 
 // Now handle argument validation that was moved from early checks

package/src/solve.pre-pr-failure-notifier.lib.mjs

@@ -0,0 +1,107 @@
+import { getTrackedToolCommentIds, postTrackedComment, SOLUTION_DRAFT_FAILED_MARKER } from './tool-comments.lib.mjs';
+
+const truncate = (value, maxLength = 2000) => {
+  const text = value === null || value === undefined ? '' : String(value);
+  if (text.length <= maxLength) return text;
+  return `${text.slice(0, maxLength - 22)}\n... truncated ...`;
+};
+
+const fence = value => truncate(value || 'Unknown error').replaceAll('```', '` ` `');
+
+export function shouldNotifyIssueAboutPrePullRequestFailure({ code, globalState }) {
+  if (code === 0) return false;
+  if (!globalState?.issueNumber || !globalState?.owner || !globalState?.repo) return false;
+  if (globalState?.createdPR?.number) return false;
+  if (globalState.prePullRequestFailureNotificationPosted || globalState.prePullRequestFailureNotificationInProgress) return false;
+  return getTrackedToolCommentIds().size === 0;
+}
+
+export function buildPrePullRequestFailureComment({ reason, owner, repo, issueNumber, argv = {}, rawCommand = null, logAttachmentAttempted = false }) {
+  const tool = argv.tool || 'claude';
+  const modelLine = argv.model ? `\n- **Requested model**: \`${argv.model}\`` : '';
+  const commandBlock = rawCommand
+    ? `
+
+### Command
+\`\`\`bash
+${fence(rawCommand)}
+\`\`\``
+    : '';
+  const logLine = logAttachmentAttempted ? 'Log attachment was attempted but failed. Check the solver terminal log for the complete failure output.' : 'Logs were not attached because `--attach-logs` was not enabled.';
+
+  return `## 🚨 ${SOLUTION_DRAFT_FAILED_MARKER}
+
+The automated solver stopped before creating a pull request, so no PR was opened for this issue.
+
+### Failure
+- **Repository**: \`${owner}/${repo}\`
+- **Issue**: #${issueNumber}
+- **Tool**: \`${tool}\`${modelLine}
+
+**Reason**
+\`\`\`text
+${fence(reason)}
+\`\`\`${commandBlock}
+
+${logLine}
+
+Please resolve the reported problem and rerun the solve command.`;
+}
+
+export async function notifyIssueAboutPrePullRequestFailure(options) {
+  const { code, reason, argv = {}, globalState = globalThis, $, log = async () => {}, getLogFile, shouldAttachLogs = false, attachLogToGitHub, sanitizeLogContent, rawCommand = null, postComment = postTrackedComment } = options;
+
+  if (!shouldNotifyIssueAboutPrePullRequestFailure({ code, globalState })) {
+    return { notified: false, skipped: true };
+  }
+
+  const owner = globalState.owner;
+  const repo = globalState.repo;
+  const issueNumber = globalState.issueNumber;
+  globalState.prePullRequestFailureNotificationInProgress = true;
+
+  try {
+    if (shouldAttachLogs && getLogFile && attachLogToGitHub && sanitizeLogContent) {
+      await log(`\n📄 Notifying issue #${issueNumber} about pre-PR failure with logs...`);
+      const uploaded = await attachLogToGitHub({
+        logFile: getLogFile(),
+        targetType: 'issue',
+        targetNumber: issueNumber,
+        owner,
+        repo,
+        $,
+        log,
+        sanitizeLogContent,
+        verbose: argv.verbose,
+        errorMessage: `The solver stopped before creating a pull request.\n\nReason: ${reason || 'Unknown error'}`,
+        requestedModel: argv.model,
+        tool: argv.tool || 'claude',
+      });
+      if (uploaded) {
+        globalState.prePullRequestFailureNotificationPosted = true;
+        return { notified: true, method: 'log-upload' };
+      }
+    }
+
+    await log(`\n💬 Notifying issue #${issueNumber} about pre-PR failure...`);
+    const body = buildPrePullRequestFailureComment({
+      reason,
+      owner,
+      repo,
+      issueNumber,
+      argv,
+      rawCommand,
+      logAttachmentAttempted: shouldAttachLogs,
+    });
+    const posted = await postComment({ $, owner, repo, targetNumber: issueNumber, body });
+    if (posted.ok) {
+      globalState.prePullRequestFailureNotificationPosted = true;
+      await log(`  ✅ Pre-PR failure comment posted to issue #${issueNumber}${posted.commentId ? ` (id=${posted.commentId})` : ''}`);
+      return { notified: true, method: 'comment', commentId: posted.commentId || null };
+    }
+    await log(`  ⚠️  Could not post pre-PR failure comment: ${posted.stderr || 'unknown error'}`, { level: 'warning' });
+    return { notified: false, error: posted.stderr || 'unknown error' };
+  } finally {
+    globalState.prePullRequestFailureNotificationInProgress = false;
+  }
+}