@link-assistant/hive-mind 1.47.1 → 1.47.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 1.47.2
+
+### Patch Changes
+
+- 7afe67b: Fix ghPrView false positive on "Could not resolve" in PR body causing "Failed to get PR details" error on fork PRs, and add stdio log interceptor for terminal/log output parity
+
 ## 1.47.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.47.1",
+  "version": "1.47.2",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/github.lib.mjs

@@ -1328,7 +1328,7 @@ export async function ghPrView({ prNumber, owner, repo, jsonFields = 'headRefNam
     const stderr = prResult.stderr ? prResult.stderr.toString() : '';
     const code = prResult.code || 0;
     let data = null;
-    if (code === 0 && stdout && !stdout.includes('Could not resolve')) {
+    if (code === 0 && stdout && !(stderr && stderr.includes('Could not resolve'))) {
       try {
         data = JSON.parse(stdout);
       } catch {
@@ -1368,7 +1368,7 @@ export async function ghIssueView({ issueNumber, owner, repo, jsonFields = 'numb
     const stderr = issueResult.stderr ? issueResult.stderr.toString() : '';
     const code = issueResult.code || 0;
     let data = null;
-    if (code === 0 && stdout && !stdout.includes('Could not resolve')) {
+    if (code === 0 && stdout && !(stderr && stderr.includes('Could not resolve'))) {
       try {
         data = JSON.parse(stdout);
       } catch {

package/src/hive.mjs

@@ -95,7 +95,7 @@ if (isDirectExecution) {
     const fs = (await withTimeout(use('fs'), 30000, 'loading fs')).promises;
     // Import shared library functions
     const lib = await import('./lib.mjs');
-    const { log, setLogFile, getAbsoluteLogPath, formatTimestamp, cleanErrorMessage, cleanupTempDirectories, setupVerboseLogInterceptor } = lib;
+    const { log, setLogFile, getAbsoluteLogPath, formatTimestamp, cleanErrorMessage, cleanupTempDirectories, setupVerboseLogInterceptor, setupStdioLogInterceptor } = lib;
     const yargsConfigLib = await import('./hive.config.lib.mjs');
     const { createYargsConfig } = yargsConfigLib;
     const claudeLib = await import('./claude.lib.mjs');
@@ -309,8 +309,8 @@ if (isDirectExecution) {
     // Set global verbose mode
     global.verboseMode = argv.verbose;
 
-    // Issue #1466: Intercept console.log to capture [VERBOSE] output in log files
-    setupVerboseLogInterceptor();
+    setupVerboseLogInterceptor(); // Issue #1466: capture [VERBOSE] output in log files
+    setupStdioLogInterceptor(); // Issue #1549: capture ALL terminal output in log file
 
     // Use the universal GitHub URL parser
     if (githubUrl) {

package/src/lib.mjs

@@ -99,18 +99,24 @@ export const log = async (message, options = {}) => {
   }
 
   // Write to console based on level
-  switch (level) {
-    case 'error':
-      console.error(message);
-      break;
-    case 'warning':
-    case 'warn':
-      console.warn(message);
-      break;
-    case 'info':
-    default:
-      console.log(message);
-      break;
+  // Set guard flag to prevent stdio interceptor from double-logging (issue #1549)
+  _writingFromLog = true;
+  try {
+    switch (level) {
+      case 'error':
+        console.error(message);
+        break;
+      case 'warning':
+      case 'warn':
+        console.warn(message);
+        break;
+      case 'info':
+      default:
+        console.log(message);
+        break;
+    }
+  } finally {
+    _writingFromLog = false;
   }
 };
 
@@ -134,20 +140,90 @@ export const setupVerboseLogInterceptor = () => {
 
   const originalConsoleLog = console.log.bind(console);
   console.log = (...args) => {
-    // Always call original console.log first
-    originalConsoleLog(...args);
-
     // If a log file is set and the message looks like a [VERBOSE] log, append to file
+    // and set guard flag to prevent stdio interceptor from double-logging (issue #1549)
     if (logFile && args.length > 0) {
       const firstArg = String(args[0]);
       if (firstArg.includes('[VERBOSE]')) {
         const message = args.map(a => String(a)).join(' ');
         const logMessage = `[${new Date().toISOString()}] [VERBOSE] ${message}`;
+        _writingFromLog = true;
+        fs.appendFile(logFile, logMessage + '\n').catch(() => {
+          // Silent fail to avoid infinite loops
+        });
+      }
+    }
+
+    // Always call original console.log (with guard flag set if [VERBOSE])
+    try {
+      originalConsoleLog(...args);
+    } finally {
+      _writingFromLog = false;
+    }
+  };
+};
+
+/**
+ * Issue #1549: Intercept process.stdout.write and process.stderr.write to capture
+ * ALL terminal output in the log file, ensuring 100% parity between terminal and log.
+ *
+ * The command-stream library uses process.stdout.write/process.stderr.write directly
+ * when mirror:true (the default). console.log/console.error also end up calling these.
+ * By intercepting at the write() level, we capture everything regardless of source:
+ * - command-stream mirror output (e.g., gh CLI JSON responses)
+ * - console.log() / console.error() calls
+ * - process.stdout.write() / process.stderr.write() direct calls
+ *
+ * To avoid double-logging (since the log() function already writes to the log file AND
+ * calls console.log which calls process.stdout.write), we use a guard flag
+ * `_writingFromLog` to skip interception when the write originates from log().
+ *
+ * This ensures the log file is a complete record of all terminal output.
+ * Call this once after setLogFile() to enable the interceptor.
+ */
+let stdioInterceptorInstalled = false;
+let _writingFromLog = false; // Guard flag to prevent double-logging from log()
+export const setupStdioLogInterceptor = () => {
+  if (stdioInterceptorInstalled) return;
+  stdioInterceptorInstalled = true;
+
+  const originalStdoutWrite = process.stdout.write.bind(process.stdout);
+  const originalStderrWrite = process.stderr.write.bind(process.stderr);
+
+  process.stdout.write = (chunk, encoding, callback) => {
+    // Always write to terminal first
+    const result = originalStdoutWrite(chunk, encoding, callback);
+
+    // Also append to log file if set, but skip if this write originated from log()
+    if (logFile && !_writingFromLog) {
+      const text = typeof chunk === 'string' ? chunk : chunk.toString(encoding || 'utf8');
+      if (text.trim()) {
+        const logMessage = `[${new Date().toISOString()}] [STDOUT] ${text.replace(/\n$/, '')}`;
+        fs.appendFile(logFile, logMessage + '\n').catch(() => {
+          // Silent fail to avoid infinite loops
+        });
+      }
+    }
+
+    return result;
+  };
+
+  process.stderr.write = (chunk, encoding, callback) => {
+    // Always write to terminal first
+    const result = originalStderrWrite(chunk, encoding, callback);
+
+    // Also append to log file if set, but skip if this write originated from log()
+    if (logFile && !_writingFromLog) {
+      const text = typeof chunk === 'string' ? chunk : chunk.toString(encoding || 'utf8');
+      if (text.trim()) {
+        const logMessage = `[${new Date().toISOString()}] [STDERR] ${text.replace(/\n$/, '')}`;
         fs.appendFile(logFile, logMessage + '\n').catch(() => {
           // Silent fail to avoid infinite loops
         });
       }
     }
+
+    return result;
   };
 };
 
@@ -611,6 +687,7 @@ export default {
   displayFormattedError,
   cleanupTempDirectories,
   setupVerboseLogInterceptor,
+  setupStdioLogInterceptor,
 };
 
 /**

package/src/solve.mjs

@@ -48,7 +48,7 @@ const fs = (await use('fs')).promises;
 const crypto = (await use('crypto')).default;
 const memoryCheck = await import('./memory-check.mjs');
 const lib = await import('./lib.mjs');
-const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, formatAligned, getVersionInfo, setupVerboseLogInterceptor } = lib;
+const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, formatAligned, getVersionInfo, setupVerboseLogInterceptor, setupStdioLogInterceptor } = lib;
 const githubLib = await import('./github.lib.mjs');
 const { sanitizeLogContent, attachLogToGitHub, getToolDisplayName } = githubLib;
 const validation = await import('./solve.validation.lib.mjs');
@@ -111,8 +111,8 @@ try {
 }
 global.verboseMode = argv.verbose;
 
-// Issue #1466: Intercept console.log to capture [VERBOSE] output in log files
-setupVerboseLogInterceptor();
+setupVerboseLogInterceptor(); // Issue #1466: capture [VERBOSE] output in log files
+setupStdioLogInterceptor(); // Issue #1549: capture ALL terminal output in log file
 
 // Early logs go to cwd; custom log dir takes effect after argv is parsed