@link-assistant/hive-mind 1.47.0 → 1.47.2

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @link-assistant/hive-mind
 
+## 1.47.2
+
+### Patch Changes
+
+- 7afe67b: Fix ghPrView false positive on "Could not resolve" in PR body causing "Failed to get PR details" error on fork PRs, and add stdio log interceptor for terminal/log output parity
+
+## 1.47.1
+
+### Patch Changes
+
+- 3bbd66e: Improve Context and tokens usage output format: move percentage before unit label, parenthesize cached tokens in Total line, use consistent X / Y (Z%) format for output tokens when limit is known, and show sub-sessions under model heading instead of globally
+
 ## 1.47.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.47.0",
+  "version": "1.47.2",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/claude.budget-stats.lib.mjs

@@ -165,16 +165,15 @@ export const displayBudgetStats = async (usage, tokenUsage, log) => {
       const sub = subSessions[i];
       const subPeak = sub.peakContextUsage || 0;
       // Issue #1539: Only use peak per-request context for context window display.
-      // Cumulative totals across all requests can exceed the context limit and produce
-      // impossible percentages (e.g. 250%). When peak is unknown, skip context display.
+      // Issue #1547: Percentage before unit label: X / Y (Z%) input tokens
       const parts = [];
       if (contextLimit && subPeak > 0) {
         const pct = ((subPeak / contextLimit) * 100).toFixed(0);
-        parts.push(`${formatNumber(subPeak)} / ${formatNumber(contextLimit)} input tokens (${pct}%)`);
+        parts.push(`${formatNumber(subPeak)} / ${formatNumber(contextLimit)} (${pct}%) input tokens`);
       }
       if (outputLimit) {
         const outPct = ((sub.outputTokens / outputLimit) * 100).toFixed(0);
-        parts.push(`${formatNumber(sub.outputTokens)} / ${formatNumber(outputLimit)} output tokens (${outPct}%)`);
+        parts.push(`${formatNumber(sub.outputTokens)} / ${formatNumber(outputLimit)} (${outPct}%) output tokens`);
       }
       if (parts.length > 0) {
         await log(`        ${i + 1}. Context window: ${parts.join(', ')}`);
@@ -182,14 +181,15 @@ export const displayBudgetStats = async (usage, tokenUsage, log) => {
     }
   } else if (peakContext > 0) {
     // Single sub-session with known peak: single-line format
+    // Issue #1547: Percentage before unit label
     const parts = [];
     if (contextLimit) {
       const pct = ((peakContext / contextLimit) * 100).toFixed(0);
-      parts.push(`${formatNumber(peakContext)} / ${formatNumber(contextLimit)} input tokens (${pct}%)`);
+      parts.push(`${formatNumber(peakContext)} / ${formatNumber(contextLimit)} (${pct}%) input tokens`);
     }
     if (outputLimit) {
       const outPct = ((usage.outputTokens / outputLimit) * 100).toFixed(0);
-      parts.push(`${formatNumber(usage.outputTokens)} / ${formatNumber(outputLimit)} output tokens (${outPct}%)`);
+      parts.push(`${formatNumber(usage.outputTokens)} / ${formatNumber(outputLimit)} (${outPct}%) output tokens`);
     }
     if (parts.length > 0) {
       await log(`        Context window: ${parts.join(', ')}`);
@@ -199,15 +199,20 @@ export const displayBudgetStats = async (usage, tokenUsage, log) => {
   // Cumulative totals are shown on the Total line below — no duplication needed.
 
   // Cumulative totals — single line
+  // Issue #1547: Parenthesized cached format and consistent output format
   const totalInputNonCached = usage.inputTokens + usage.cacheCreationTokens;
   const cachedTokens = usage.cacheReadTokens;
-  let totalLine = `${formatNumber(totalInputNonCached)}`;
-  if (cachedTokens > 0) totalLine += ` + ${formatNumber(cachedTokens)} cached`;
-  totalLine += ` input tokens, ${formatNumber(usage.outputTokens)} output tokens`;
-  // Issue #1539: When peakContextUsage is unknown, embed output percentage in Total line
+  let totalLine;
+  if (cachedTokens > 0) {
+    totalLine = `(${formatNumber(totalInputNonCached)} + ${formatNumber(cachedTokens)} cached) input tokens`;
+  } else {
+    totalLine = `${formatNumber(totalInputNonCached)} input tokens`;
+  }
   if (peakContext === 0 && outputLimit) {
     const outPct = ((usage.outputTokens / outputLimit) * 100).toFixed(0);
-    totalLine += ` (${outPct}% of ${formatNumber(outputLimit)} output limit)`;
+    totalLine += `, ${formatNumber(usage.outputTokens)} / ${formatNumber(outputLimit)} (${outPct}%) output tokens`;
+  } else {
+    totalLine += `, ${formatNumber(usage.outputTokens)} output tokens`;
   }
   await log(`        Total: ${totalLine}`);
 };
@@ -325,12 +330,12 @@ const formatContextOutputLine = (peakContext, contextLimit, outputTokens, output
     // context window metrics and produce impossible percentages (e.g. 250%).
     if (peakContext > 0) {
       const pct = ((peakContext / contextLimit) * 100).toFixed(0);
-      parts.push(`${formatTokensCompact(peakContext)} / ${formatTokensCompact(contextLimit)} input tokens (${pct}%)`);
+      parts.push(`${formatTokensCompact(peakContext)} / ${formatTokensCompact(contextLimit)} (${pct}%) input tokens`);
     }
   }
   if (outputLimit) {
     const outPct = ((outputTokens / outputLimit) * 100).toFixed(0);
-    parts.push(`${formatTokensCompact(outputTokens)} / ${formatTokensCompact(outputLimit)} output tokens (${outPct}%)`);
+    parts.push(`${formatTokensCompact(outputTokens)} / ${formatTokensCompact(outputLimit)} (${outPct}%) output tokens`);
   }
   if (parts.length === 0) return '';
   return `\n${prefix}Context window: ${parts.join(', ')}`;
@@ -364,15 +369,6 @@ export const buildBudgetStatsString = tokenUsage => {
     const subSessions = tokenUsage.subSessions || [];
     const hasMultipleSubSessions = subSessions.length > 1;
 
-    if (isMultiModel && hasMultipleSubSessions) {
-      // Issue #1508: For multi-model sessions, show global sub-sessions once (not per-model),
-      // since sub-sessions track compactification boundaries which are session-wide.
-      // Per-model context/output limits are shown below under each model heading.
-      const primaryModelId = modelIds[0];
-      const primaryUsage = tokenUsage.modelUsage[primaryModelId];
-      stats += formatSubSessionsList(subSessions, primaryUsage.modelInfo?.limit?.context, primaryUsage.modelInfo?.limit?.output);
-    }
-
     for (const modelId of modelIds) {
       const usage = tokenUsage.modelUsage[modelId];
       const modelName = usage.modelName || modelId;
@@ -383,8 +379,9 @@ export const buildBudgetStatsString = tokenUsage => {
 
       const peakContext = usage.peakContextUsage || 0;
 
-      if (!isMultiModel && hasMultipleSubSessions) {
-        // Single-model + multiple sub-sessions: show numbered sub-sessions under that model
+      if (hasMultipleSubSessions && (!isMultiModel || modelId === modelIds[0])) {
+        // Issue #1547: Show sub-sessions under the primary model heading (not globally).
+        // For single-model sessions, show under that model. For multi-model, under the first model.
         stats += formatSubSessionsList(subSessions, contextLimit, outputLimit);
       } else if (peakContext > 0) {
         // Issue #1526: Single line format for context window + output tokens
@@ -394,18 +391,22 @@ export const buildBudgetStatsString = tokenUsage => {
       // Cumulative totals are shown on the Total line below — no duplication needed.
 
       // Cumulative totals per model: input tokens + cached shown separately
-      // Issue #1526: Shorter format — single "Total:" line
+      // Issue #1547: Parenthesized cached format: (X + Y cached) input tokens
       const totalInputNonCached = usage.inputTokens + usage.cacheCreationTokens;
       const cachedTokens = usage.cacheReadTokens;
-      let totalLine = `${formatTokensCompact(totalInputNonCached)}`;
-      if (cachedTokens > 0) totalLine += ` + ${formatTokensCompact(cachedTokens)} cached`;
-      totalLine += ` input tokens, ${formatTokensCompact(usage.outputTokens)} output tokens`;
+      let totalLine;
+      if (cachedTokens > 0) {
+        totalLine = `(${formatTokensCompact(totalInputNonCached)} + ${formatTokensCompact(cachedTokens)} cached) input tokens`;
+      } else {
+        totalLine = `${formatTokensCompact(totalInputNonCached)} input tokens`;
+      }
 
-      // Issue #1539: When peakContextUsage is unknown (no per-request data), embed
-      // output token percentage in the Total line so no data is lost.
+      // Issue #1547: Consistent output format — use X / Y (Z%) output tokens when limit known
       if (peakContext === 0 && outputLimit) {
         const outPct = ((usage.outputTokens / outputLimit) * 100).toFixed(0);
-        totalLine += ` (${outPct}% of ${formatTokensCompact(outputLimit)} output limit)`;
+        totalLine += `, ${formatTokensCompact(usage.outputTokens)} / ${formatTokensCompact(outputLimit)} (${outPct}%) output tokens`;
+      } else {
+        totalLine += `, ${formatTokensCompact(usage.outputTokens)} output tokens`;
       }
 
       // Issue #1508: Show per-model cost when available

package/src/github.lib.mjs

@@ -1328,7 +1328,7 @@ export async function ghPrView({ prNumber, owner, repo, jsonFields = 'headRefNam
     const stderr = prResult.stderr ? prResult.stderr.toString() : '';
     const code = prResult.code || 0;
     let data = null;
-    if (code === 0 && stdout && !stdout.includes('Could not resolve')) {
+    if (code === 0 && stdout && !(stderr && stderr.includes('Could not resolve'))) {
       try {
         data = JSON.parse(stdout);
       } catch {
@@ -1368,7 +1368,7 @@ export async function ghIssueView({ issueNumber, owner, repo, jsonFields = 'numb
     const stderr = issueResult.stderr ? issueResult.stderr.toString() : '';
     const code = issueResult.code || 0;
     let data = null;
-    if (code === 0 && stdout && !stdout.includes('Could not resolve')) {
+    if (code === 0 && stdout && !(stderr && stderr.includes('Could not resolve'))) {
       try {
         data = JSON.parse(stdout);
       } catch {

package/src/hive.mjs

@@ -95,7 +95,7 @@ if (isDirectExecution) {
     const fs = (await withTimeout(use('fs'), 30000, 'loading fs')).promises;
     // Import shared library functions
     const lib = await import('./lib.mjs');
-    const { log, setLogFile, getAbsoluteLogPath, formatTimestamp, cleanErrorMessage, cleanupTempDirectories, setupVerboseLogInterceptor } = lib;
+    const { log, setLogFile, getAbsoluteLogPath, formatTimestamp, cleanErrorMessage, cleanupTempDirectories, setupVerboseLogInterceptor, setupStdioLogInterceptor } = lib;
     const yargsConfigLib = await import('./hive.config.lib.mjs');
     const { createYargsConfig } = yargsConfigLib;
     const claudeLib = await import('./claude.lib.mjs');
@@ -309,8 +309,8 @@ if (isDirectExecution) {
     // Set global verbose mode
     global.verboseMode = argv.verbose;
 
-    // Issue #1466: Intercept console.log to capture [VERBOSE] output in log files
-    setupVerboseLogInterceptor();
+    setupVerboseLogInterceptor(); // Issue #1466: capture [VERBOSE] output in log files
+    setupStdioLogInterceptor(); // Issue #1549: capture ALL terminal output in log file
 
     // Use the universal GitHub URL parser
     if (githubUrl) {

package/src/lib.mjs

@@ -99,18 +99,24 @@ export const log = async (message, options = {}) => {
   }
 
   // Write to console based on level
-  switch (level) {
-    case 'error':
-      console.error(message);
-      break;
-    case 'warning':
-    case 'warn':
-      console.warn(message);
-      break;
-    case 'info':
-    default:
-      console.log(message);
-      break;
+  // Set guard flag to prevent stdio interceptor from double-logging (issue #1549)
+  _writingFromLog = true;
+  try {
+    switch (level) {
+      case 'error':
+        console.error(message);
+        break;
+      case 'warning':
+      case 'warn':
+        console.warn(message);
+        break;
+      case 'info':
+      default:
+        console.log(message);
+        break;
+    }
+  } finally {
+    _writingFromLog = false;
   }
 };
 
@@ -134,20 +140,90 @@ export const setupVerboseLogInterceptor = () => {
 
   const originalConsoleLog = console.log.bind(console);
   console.log = (...args) => {
-    // Always call original console.log first
-    originalConsoleLog(...args);
-
     // If a log file is set and the message looks like a [VERBOSE] log, append to file
+    // and set guard flag to prevent stdio interceptor from double-logging (issue #1549)
     if (logFile && args.length > 0) {
       const firstArg = String(args[0]);
       if (firstArg.includes('[VERBOSE]')) {
         const message = args.map(a => String(a)).join(' ');
         const logMessage = `[${new Date().toISOString()}] [VERBOSE] ${message}`;
+        _writingFromLog = true;
+        fs.appendFile(logFile, logMessage + '\n').catch(() => {
+          // Silent fail to avoid infinite loops
+        });
+      }
+    }
+
+    // Always call original console.log (with guard flag set if [VERBOSE])
+    try {
+      originalConsoleLog(...args);
+    } finally {
+      _writingFromLog = false;
+    }
+  };
+};
+
+/**
+ * Issue #1549: Intercept process.stdout.write and process.stderr.write to capture
+ * ALL terminal output in the log file, ensuring 100% parity between terminal and log.
+ *
+ * The command-stream library uses process.stdout.write/process.stderr.write directly
+ * when mirror:true (the default). console.log/console.error also end up calling these.
+ * By intercepting at the write() level, we capture everything regardless of source:
+ * - command-stream mirror output (e.g., gh CLI JSON responses)
+ * - console.log() / console.error() calls
+ * - process.stdout.write() / process.stderr.write() direct calls
+ *
+ * To avoid double-logging (since the log() function already writes to the log file AND
+ * calls console.log which calls process.stdout.write), we use a guard flag
+ * `_writingFromLog` to skip interception when the write originates from log().
+ *
+ * This ensures the log file is a complete record of all terminal output.
+ * Call this once after setLogFile() to enable the interceptor.
+ */
+let stdioInterceptorInstalled = false;
+let _writingFromLog = false; // Guard flag to prevent double-logging from log()
+export const setupStdioLogInterceptor = () => {
+  if (stdioInterceptorInstalled) return;
+  stdioInterceptorInstalled = true;
+
+  const originalStdoutWrite = process.stdout.write.bind(process.stdout);
+  const originalStderrWrite = process.stderr.write.bind(process.stderr);
+
+  process.stdout.write = (chunk, encoding, callback) => {
+    // Always write to terminal first
+    const result = originalStdoutWrite(chunk, encoding, callback);
+
+    // Also append to log file if set, but skip if this write originated from log()
+    if (logFile && !_writingFromLog) {
+      const text = typeof chunk === 'string' ? chunk : chunk.toString(encoding || 'utf8');
+      if (text.trim()) {
+        const logMessage = `[${new Date().toISOString()}] [STDOUT] ${text.replace(/\n$/, '')}`;
+        fs.appendFile(logFile, logMessage + '\n').catch(() => {
+          // Silent fail to avoid infinite loops
+        });
+      }
+    }
+
+    return result;
+  };
+
+  process.stderr.write = (chunk, encoding, callback) => {
+    // Always write to terminal first
+    const result = originalStderrWrite(chunk, encoding, callback);
+
+    // Also append to log file if set, but skip if this write originated from log()
+    if (logFile && !_writingFromLog) {
+      const text = typeof chunk === 'string' ? chunk : chunk.toString(encoding || 'utf8');
+      if (text.trim()) {
+        const logMessage = `[${new Date().toISOString()}] [STDERR] ${text.replace(/\n$/, '')}`;
         fs.appendFile(logFile, logMessage + '\n').catch(() => {
           // Silent fail to avoid infinite loops
         });
       }
     }
+
+    return result;
   };
 };
 
@@ -611,6 +687,7 @@ export default {
   displayFormattedError,
   cleanupTempDirectories,
   setupVerboseLogInterceptor,
+  setupStdioLogInterceptor,
 };
 
 /**

package/src/solve.mjs

@@ -48,7 +48,7 @@ const fs = (await use('fs')).promises;
 const crypto = (await use('crypto')).default;
 const memoryCheck = await import('./memory-check.mjs');
 const lib = await import('./lib.mjs');
-const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, formatAligned, getVersionInfo, setupVerboseLogInterceptor } = lib;
+const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, formatAligned, getVersionInfo, setupVerboseLogInterceptor, setupStdioLogInterceptor } = lib;
 const githubLib = await import('./github.lib.mjs');
 const { sanitizeLogContent, attachLogToGitHub, getToolDisplayName } = githubLib;
 const validation = await import('./solve.validation.lib.mjs');
@@ -111,8 +111,8 @@ try {
 }
 global.verboseMode = argv.verbose;
 
-// Issue #1466: Intercept console.log to capture [VERBOSE] output in log files
-setupVerboseLogInterceptor();
+setupVerboseLogInterceptor(); // Issue #1466: capture [VERBOSE] output in log files
+setupStdioLogInterceptor(); // Issue #1549: capture ALL terminal output in log file
 
 // Early logs go to cwd; custom log dir takes effect after argv is parsed