@link-assistant/hive-mind 1.34.5 → 1.34.7

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # @link-assistant/hive-mind
 
+## 1.34.7
+
+### Patch Changes
+
+- bb83be9: fix: fail with helpful error when --fork used on own repository (issue #1206)
+
+## 1.34.6
+
+### Patch Changes
+
+- 3157192: Optimize CI/CD to skip checks for .gitkeep-only changes and harden .gitkeep cleanup logic (Issue #1436).
+
+  CI/CD jobs `version-check` and `helm-pr-check` now skip when only `.gitkeep` files changed, saving ~21 seconds of runner time per PR on the initial commit. The `detect-code-changes.mjs` script now excludes `.gitkeep` files from code change detection and outputs a `gitkeep-only` flag.
+
+  The `.gitkeep` cleanup logic in `solve.results.lib.mjs` is hardened with: (1) full commit message body detection (`%B` instead of `%s`) so `.gitkeep` references in commit body are found, (2) fallback file detection via `git diff-tree`, and (3) post-cleanup verification with direct removal fallback to prevent leftover `.gitkeep` files.
+
+  Also removes the leftover `.gitkeep` file from the repository that was left behind by PR #1420.
+
 ## 1.34.5
 
 ### Patch Changes

package/README.md

@@ -509,6 +509,21 @@ Shows:
 - Commands run as the system user running the bot
 - Ensure proper authentication (`gh auth login`, `claude-profiles`)
 
+## 🏆 Best Practices
+
+Hive Mind works even better when repositories have strong CI/CD pipelines and clear issue requirements. See:
+
+- [BEST-PRACTICES.md](./docs/BEST-PRACTICES.md) — Universal prompts, issue writing guidelines, architecture improvement, and subagent patterns
+- [CI-CD-BEST-PRACTICES.md](./docs/CI-CD-BEST-PRACTICES.md) — CI/CD pipeline setup, recommended templates, and enforcement strategies
+
+Key benefits of proper CI/CD:
+
+- AI solvers iterate until all checks pass
+- Consistent quality regardless of human/AI team composition
+- File size limits ensure code is readable by both AI and humans
+
+Ready-to-use templates are available for JavaScript, Rust, Python, Go, C#, and Java.
+
 ## 🏗️ Architecture
 
 The Hive Mind operates on three layers:
@@ -850,21 +865,6 @@ That can be done, but not recommended as reboot have better effect.
 
 Unlicense License - see [LICENSE](./LICENSE)
 
-## 🏆 Best Practices
-
-Hive Mind works even better when repositories have strong CI/CD pipelines and clear issue requirements. See:
-
-- [BEST-PRACTICES.md](./docs/BEST-PRACTICES.md) — Universal prompts, issue writing guidelines, architecture improvement, and subagent patterns
-- [CI-CD-BEST-PRACTICES.md](./docs/CI-CD-BEST-PRACTICES.md) — CI/CD pipeline setup, recommended templates, and enforcement strategies
-
-Key benefits of proper CI/CD:
-
-- AI solvers iterate until all checks pass
-- Consistent quality regardless of human/AI team composition
-- File size limits ensure code is readable by both AI and humans
-
-Ready-to-use templates are available for JavaScript, Rust, Python, Go, C#, and Java.
-
 ## 🤖 Contributing
 
 This project uses AI-driven development. See [CONTRIBUTING.md](./docs/CONTRIBUTING.md) for human-AI collaboration guidelines.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.34.5",
+  "version": "1.34.7",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.repository.lib.mjs

@@ -33,38 +33,16 @@ import { safeExit } from './exit-handler.lib.mjs';
 const githubLib = await import('./github.lib.mjs');
 const { checkRepositoryWritePermission } = githubLib;
 
-// Get the root repository of any repository
-// Returns the source (root) repository if the repo is a fork, otherwise returns the repo itself
-// Returns null if repository is not accessible (404 or other errors)
+// Get root repository (fork source or self), or null if inaccessible
 export const getRootRepository = async (owner, repo) => {
   try {
     const result = await $`gh api repos/${owner}/${repo} --jq '{fork: .fork, source: .source.full_name}' 2>&1`;
-
-    if (result.code !== 0) {
-      // Check if it's a 404 error - repository doesn't exist or no permissions
-      const errorOutput = (result.stderr || result.stdout || '').toString();
-      if (errorOutput.includes('HTTP 404') || errorOutput.includes('Not Found')) {
-        // Repository not accessible - this will be handled by fork creation logic
-        // Return null to indicate we couldn't determine root repo
-        return null;
-      }
-      return null;
-    }
+    if (result.code !== 0) return null;
 
     const repoInfo = JSON.parse(result.stdout.toString().trim());
-
-    if (repoInfo.fork && repoInfo.source) {
-      return repoInfo.source;
-    } else {
-      return `${owner}/${repo}`;
-    }
+    return repoInfo.fork && repoInfo.source ? repoInfo.source : `${owner}/${repo}`;
   } catch (error) {
-    reportError(error, {
-      context: 'get_root_repository',
-      owner,
-      repo,
-      operation: 'determine_fork_root',
-    });
+    reportError(error, { context: 'get_root_repository', owner, repo, operation: 'determine_fork_root' });
     return null;
   }
 };
@@ -73,34 +51,20 @@ export const getRootRepository = async (owner, repo) => {
 export const checkExistingForkOfRoot = async rootRepo => {
   try {
     const userResult = await $`gh api user --jq .login`;
-    if (userResult.code !== 0) {
-      return null;
-    }
+    if (userResult.code !== 0) return null;
     const currentUser = userResult.stdout.toString().trim();
 
     const forksResult = await $`gh api repos/${rootRepo}/forks --paginate --jq '.[] | select(.owner.login == "${currentUser}") | .full_name'`;
-
-    if (forksResult.code !== 0) {
-      return null;
-    }
+    if (forksResult.code !== 0) return null;
 
     const forks = forksResult.stdout
       .toString()
       .trim()
       .split('\n')
       .filter(f => f);
-
-    if (forks.length > 0) {
-      return forks[0];
-    } else {
-      return null;
-    }
+    return forks.length > 0 ? forks[0] : null;
   } catch (error) {
-    reportError(error, {
-      context: 'check_existing_fork_of_root',
-      rootRepo,
-      operation: 'search_user_forks',
-    });
+    reportError(error, { context: 'check_existing_fork_of_root', rootRepo, operation: 'search_user_forks' });
     return null;
   }
 };
@@ -407,6 +371,30 @@ export const setupRepository = async (argv, owner, repo, forkOwner = null, issue
     }
     const currentUser = userResult.stdout.toString().trim();
 
+    // Check if user owns the repository (Issue #1206)
+    // GitHub doesn't allow forking your own repositories and returns HTTP 403
+    // When --fork is explicitly used, fail with a clear error and suggest --auto-fork
+    if (currentUser === owner) {
+      await log('');
+      await log(`${formatAligned('❌', 'CANNOT FORK OWN REPOSITORY', '')}`, { level: 'error' });
+      await log('');
+      await log('  🔍 What happened:');
+      await log(`     You are the owner of ${owner}/${repo}`);
+      await log('     GitHub does not allow forking your own repositories (returns HTTP 403)');
+      await log('');
+      await log('  💡 Solutions:');
+      await log('');
+      await log('     Option 1: Use --auto-fork instead of --fork');
+      await log('        --auto-fork automatically detects ownership and works directly');
+      await log('        on the repository when you have write access, without forking.');
+      await log(`        Example: solve "${issueUrl || `https://github.com/${owner}/${repo}/issues/<number>`}" --auto-fork`);
+      await log('');
+      await log('     Option 2: Work directly on the repository without forking');
+      await log(`        Example: solve "${issueUrl || `https://github.com/${owner}/${repo}/issues/<number>`}"`);
+      await log('');
+      await safeExit(1, 'Cannot fork own repository - use --auto-fork or remove --fork flag');
+    }
+
     // Check for fork conflicts (Issue #344)
     // Detect if we're trying to fork a repository that shares the same root
     // as an existing fork we already have

package/src/solve.results.lib.mjs

@@ -251,11 +251,19 @@ export const cleanupClaudeFile = async (tempDir, branchName, claudeCommitHash =
       await log(`   Detected initial commit: ${claudeCommitHash.substring(0, 7)}`, { verbose: true });
     }
 
-    // Determine which file was used based on the commit message or flags
-    // Check the commit message to determine which file was committed
-    const commitMsgResult = await $({ cwd: tempDir })`git log -1 --format=%s ${claudeCommitHash} 2>&1`;
+    // Determine which file was used based on the commit message or actual files changed
+    // Use %B (full message including body) instead of %s (subject only) to catch ".gitkeep" in body
+    // Also check the actual files changed as a fallback (Issue #1436)
+    const commitMsgResult = await $({ cwd: tempDir })`git log -1 --format=%B ${claudeCommitHash} 2>&1`;
     const commitMsg = commitMsgResult.stdout?.trim() || '';
-    const isGitkeepFile = commitMsg.includes('.gitkeep');
+    let isGitkeepFile = commitMsg.includes('.gitkeep');
+
+    // Fallback: check actual files changed in the commit if message doesn't mention .gitkeep
+    if (!isGitkeepFile) {
+      const filesResult = await $({ cwd: tempDir })`git diff-tree --no-commit-id --name-only -r ${claudeCommitHash} 2>&1`;
+      const files = filesResult.stdout?.trim().split('\n').filter(Boolean) || [];
+      isGitkeepFile = files.includes('.gitkeep');
+    }
     const fileName = isGitkeepFile ? '.gitkeep' : 'CLAUDE.md';
 
     await log(formatAligned('🔄', 'Cleanup:', `Reverting ${fileName} commit`));
@@ -381,6 +389,31 @@ export const cleanupClaudeFile = async (tempDir, branchName, claudeCommitHash =
         }
       }
     }
+    // Post-cleanup verification: check if the file was actually removed (Issue #1436)
+    // This catches cases where revert/push succeeded in logs but file still exists
+    const verifyResult = await $({ cwd: tempDir })`git ls-files ${fileName} 2>&1`;
+    const fileStillExists = verifyResult.code === 0 && verifyResult.stdout && verifyResult.stdout.trim();
+    if (fileStillExists) {
+      await log(`   ⚠️  WARNING: ${fileName} still exists after cleanup — attempting direct removal...`);
+      // Check if the file existed before the initial commit (parent)
+      const parentCommit = `${claudeCommitHash}~1`;
+      const parentFileExists = await $({ cwd: tempDir })`git cat-file -e ${parentCommit}:${fileName} 2>&1`;
+      if (parentFileExists.code !== 0) {
+        // File didn't exist before the session — force remove it
+        await $({ cwd: tempDir })`git rm -f ${fileName} 2>&1`;
+        const fallbackCommit = await $({ cwd: tempDir })`git commit -m "Remove leftover ${fileName} (post-cleanup fallback, Issue #1436)" 2>&1`;
+        if (fallbackCommit.code === 0) {
+          const fallbackPush = await $({ cwd: tempDir })`git push origin ${branchName} 2>&1`;
+          if (fallbackPush.code === 0) {
+            await log(`   ✅ ${fileName} removed via post-cleanup fallback`);
+          } else {
+            await log(`   ⚠️  ${fileName} removed locally but push failed`, { verbose: true });
+          }
+        }
+      } else {
+        await log(`   ℹ️  ${fileName} existed before this session — keeping pre-existing file`, { verbose: true });
+      }
+    }
   } catch (e) {
     reportError(e, {
       context: 'cleanup_claude_file',