@link-assistant/hive-mind 1.24.2 → 1.24.4

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @link-assistant/hive-mind
 
+## 1.24.4
+
+### Patch Changes
+
+- 40282f3: fix: escape '...' ellipsis in MarkdownV2 and retry on UNKNOWN merge state (Issue #1339)
+
+  Two root causes fixed:
+  1. **MarkdownV2 escaping**: In `formatProgressMessage()`, literal '...' was appended in PR titles, error messages, and overflow lines. Telegram's MarkdownV2 requires '.' to be escaped as '\.' - unescaped periods caused 400 Bad Request errors on every message update during CI wait.
+  2. **UNKNOWN merge state**: GitHub computes PR mergeability asynchronously, so initial queries may return `mergeStateStatus: 'UNKNOWN'`. The old code immediately skipped PRs in this state. Fixed by adding retry logic to `checkPRMergeable()` that retries up to 3 times with 5-second delays before giving up.
+
+## 1.24.3
+
+### Patch Changes
+
+- 297e07c: Fix incorrect iteration counter and duplicate comments in auto-restart mode
+  - Fixed iteration counter to show actual AI restart count instead of check cycle number
+  - Added deduplication check to prevent duplicate "Ready to merge" status comments
+  - Added case study documentation for issue #1323
+
 ## 1.24.2
 
 ### Patch Changes

package/README.md

@@ -811,9 +811,21 @@ procinfo 62220
 
 ## Maintenance
 
-### Reboot server.
+### Enter latest screen
+
+```bash
+s=$(screen -ls | awk '/Detached/ {print $1; exit}'); echo "Entering $s"; screen -r "$s"; echo "Left $s";
+```
+
+### Enter oldest screen
 
+```bash
+s=$(screen -ls | awk '/Detached/ {last=$1} END{print last}'); echo "Entering $s"; screen -r "$s"; echo "Left $s";
 ```
+
+### Reboot server.
+
+```bash
 sudo reboot
 ```
 
@@ -821,7 +833,7 @@ That will remove all dangling unused proccesses and screens, which will in turn
 
 ### Cleanup disk space.
 
-```
+```bash
 df -h
 
 rm -rf /tmp

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.24.2",
+  "version": "1.24.4",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/github-merge.lib.mjs

@@ -400,6 +400,11 @@ export async function checkPRCIStatus(owner, repo, prNumber, verbose = false) {
 
 /**
  * Check if PR is mergeable
+ *
+ * Issue #1339: GitHub computes mergeability asynchronously. The first request may return
+ * mergeable: null and mergeStateStatus: 'UNKNOWN' while the computation is in progress.
+ * We retry up to 3 times with a 5-second delay between attempts to handle this case.
+ *
  * @param {string} owner - Repository owner
  * @param {string} repo - Repository name
  * @param {number} prNumber - Pull request number
@@ -407,46 +412,73 @@ export async function checkPRCIStatus(owner, repo, prNumber, verbose = false) {
  * @returns {Promise<{mergeable: boolean, reason: string|null}>}
  */
 export async function checkPRMergeable(owner, repo, prNumber, verbose = false) {
-  try {
-    const { stdout } = await exec(`gh pr view ${prNumber} --repo ${owner}/${repo} --json mergeable,mergeStateStatus`);
-    const pr = JSON.parse(stdout.trim());
-
-    const mergeable = pr.mergeable === 'MERGEABLE';
-    let reason = null;
-
-    if (!mergeable) {
-      switch (pr.mergeStateStatus) {
-        case 'BLOCKED':
-          reason = 'PR is blocked (possibly by branch protection rules)';
-          break;
-        case 'BEHIND':
-          reason = 'PR branch is behind the base branch';
-          break;
-        case 'DIRTY':
-          reason = 'PR has merge conflicts';
-          break;
-        case 'UNSTABLE':
-          reason = 'PR has failing required status checks';
-          break;
-        case 'DRAFT':
-          reason = 'PR is a draft';
-          break;
-        default:
-          reason = `Merge state: ${pr.mergeStateStatus || 'unknown'}`;
+  // Issue #1339: GitHub computes mergeability asynchronously. When mergeStateStatus is
+  // 'UNKNOWN', it means GitHub hasn't calculated the merge state yet. Retry a few times.
+  const MAX_UNKNOWN_RETRIES = 3;
+  const UNKNOWN_RETRY_DELAY_MS = 5000;
+
+  for (let attempt = 0; attempt < MAX_UNKNOWN_RETRIES; attempt++) {
+    try {
+      const { stdout } = await exec(`gh pr view ${prNumber} --repo ${owner}/${repo} --json mergeable,mergeStateStatus`);
+      const pr = JSON.parse(stdout.trim());
+
+      // Issue #1339: If mergeStateStatus is 'UNKNOWN', GitHub is still computing.
+      // Wait and retry instead of immediately skipping the PR.
+      if (pr.mergeStateStatus === 'UNKNOWN' || pr.mergeable === null) {
+        if (attempt < MAX_UNKNOWN_RETRIES - 1) {
+          if (verbose) {
+            console.log(`[VERBOSE] /merge: PR #${prNumber} mergeability is UNKNOWN (attempt ${attempt + 1}/${MAX_UNKNOWN_RETRIES}), retrying in ${UNKNOWN_RETRY_DELAY_MS / 1000}s...`);
+          }
+          await new Promise(resolve => setTimeout(resolve, UNKNOWN_RETRY_DELAY_MS));
+          continue;
+        }
+        // All retries exhausted, still UNKNOWN - treat as not mergeable
+        if (verbose) {
+          console.log(`[VERBOSE] /merge: PR #${prNumber} mergeability still UNKNOWN after ${MAX_UNKNOWN_RETRIES} attempts`);
+        }
+        return { mergeable: false, reason: `Merge state: UNKNOWN (GitHub could not compute mergeability after ${MAX_UNKNOWN_RETRIES} attempts)` };
       }
-    }
 
-    if (verbose) {
-      console.log(`[VERBOSE] /merge: PR #${prNumber} mergeable: ${mergeable}, state: ${pr.mergeStateStatus}`);
-    }
+      const mergeable = pr.mergeable === 'MERGEABLE';
+      let reason = null;
+
+      if (!mergeable) {
+        switch (pr.mergeStateStatus) {
+          case 'BLOCKED':
+            reason = 'PR is blocked (possibly by branch protection rules)';
+            break;
+          case 'BEHIND':
+            reason = 'PR branch is behind the base branch';
+            break;
+          case 'DIRTY':
+            reason = 'PR has merge conflicts';
+            break;
+          case 'UNSTABLE':
+            reason = 'PR has failing required status checks';
+            break;
+          case 'DRAFT':
+            reason = 'PR is a draft';
+            break;
+          default:
+            reason = `Merge state: ${pr.mergeStateStatus || 'unknown'}`;
+        }
+      }
 
-    return { mergeable, reason };
-  } catch (error) {
-    if (verbose) {
-      console.log(`[VERBOSE] /merge: Error checking mergeability: ${error.message}`);
+      if (verbose) {
+        console.log(`[VERBOSE] /merge: PR #${prNumber} mergeable: ${mergeable}, state: ${pr.mergeStateStatus}`);
+      }
+
+      return { mergeable, reason };
+    } catch (error) {
+      if (verbose) {
+        console.log(`[VERBOSE] /merge: Error checking mergeability: ${error.message}`);
+      }
+      return { mergeable: false, reason: error.message };
     }
-    return { mergeable: false, reason: error.message };
   }
+
+  // Should not reach here, but return safe default
+  return { mergeable: false, reason: 'Merge state: UNKNOWN' };
 }
 
 /**

package/src/solve.auto-merge.lib.mjs

@@ -43,6 +43,37 @@ const { sanitizeLogContent, attachLogToGitHub } = githubLib;
 const restartShared = await import('./solve.restart-shared.lib.mjs');
 const { checkPRMerged, checkPRClosed, checkForUncommittedChanges, getUncommittedChangesDetails, executeToolIteration, buildAutoRestartInstructions, isApiError } = restartShared;
 
+/**
+ * Issue #1323: Check if a comment with specific content already exists on the PR
+ * This prevents duplicate status comments when multiple processes or restarts occur
+ * @param {string} owner - Repository owner
+ * @param {string} repo - Repository name
+ * @param {number} prNumber - Pull request number
+ * @param {string} commentSignature - Unique signature to search for in comment body (e.g., "✅ Ready to merge")
+ * @param {boolean} verbose - Enable verbose logging
+ * @returns {Promise<boolean>} - True if a matching comment already exists
+ */
+const checkForExistingComment = async (owner, repo, prNumber, commentSignature, verbose = false) => {
+  try {
+    // Fetch recent PR comments (last 20 to avoid fetching entire history)
+    const result = await $`gh api repos/${owner}/${repo}/issues/${prNumber}/comments --jq '.[].body' 2>/dev/null`;
+    if (result.code === 0 && result.stdout) {
+      const bodies = result.stdout.toString();
+      const hasMatch = bodies.includes(commentSignature);
+      if (verbose && hasMatch) {
+        console.log(`[VERBOSE] Found existing comment with signature: "${commentSignature}"`);
+      }
+      return hasMatch;
+    }
+  } catch (error) {
+    // If check fails, allow posting to avoid silent failures
+    if (verbose) {
+      console.log(`[VERBOSE] Failed to check for existing comment: ${error.message}`);
+    }
+  }
+  return false;
+};
+
 /**
  * Check for new comments from non-bot users since last commit
  * @returns {Promise<{hasNewComments: boolean, comments: Array}>}
@@ -258,6 +289,11 @@ export const watchUntilMergeable = async params => {
   let latestSessionId = null;
   let latestAnthropicCost = null;
 
+  // Issue #1323: Track actual restart count separately from check cycle iteration
+  // `iteration` counts check cycles (how many times we check for blockers)
+  // `restartCount` counts actual AI tool executions (when we actually restart the AI)
+  let restartCount = 0;
+
   // Track consecutive API errors for retry limit
   const MAX_API_ERROR_RETRIES = 3;
   let consecutiveApiErrors = 0;
@@ -344,10 +380,17 @@ export const watchUntilMergeable = async params => {
           await log(formatAligned('', 'PR is ready to be merged manually', '', 2));
           await log(formatAligned('', 'Exiting auto-restart-until-mergeable mode', '', 2));
 
-          // Post success comment
+          // Issue #1323: Post success comment only if one doesn't already exist
+          // This prevents duplicate comments when multiple processes reach this point
           try {
-            const commentBody = `## ✅ Ready to merge\n\nThis pull request is now ready to be merged:\n- All CI checks have passed\n- No merge conflicts\n- No pending changes\n\n---\n*Monitored by hive-mind with --auto-restart-until-mergeable flag*`;
-            await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
+            const readyToMergeSignature = '## ✅ Ready to merge';
+            const hasExistingComment = await checkForExistingComment(owner, repo, prNumber, readyToMergeSignature, argv.verbose);
+            if (!hasExistingComment) {
+              const commentBody = `## ✅ Ready to merge\n\nThis pull request is now ready to be merged:\n- All CI checks have passed\n- No merge conflicts\n- No pending changes\n\n---\n*Monitored by hive-mind with --auto-restart-until-mergeable flag*`;
+              await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
+            } else {
+              await log(formatAligned('', 'Skipping duplicate "Ready to merge" comment', '', 2));
+            }
           } catch {
             // Don't fail if comment posting fails
           }
@@ -518,10 +561,14 @@ Once the billing issue is resolved, you can re-run the CI checks or push a new c
       }
 
       if (shouldRestart) {
+        // Issue #1323: Increment restart count (actual AI executions, not check cycles)
+        restartCount++;
+
         // Add standard instructions for auto-restart-until-mergeable mode using shared utility
         feedbackLines.push(...buildAutoRestartInstructions());
 
         await log(formatAligned('🔄', 'RESTART TRIGGERED:', restartReason));
+        await log(formatAligned('', 'Restart iteration:', `${restartCount}`, 2));
         await log('');
 
         // Post a comment to PR about the restart
@@ -601,7 +648,8 @@ Once the billing issue is resolved, you can re-run the CI checks or push a new c
             try {
               const logFile = getLogFile();
               if (logFile) {
-                const customTitle = `🔄 Auto-restart-until-mergeable Log (iteration ${iteration})`;
+                // Issue #1323: Use restartCount (actual AI executions) instead of iteration (check cycles)
+                const customTitle = `🔄 Auto-restart-until-mergeable Log (iteration ${restartCount})`;
                 await attachLogToGitHub({
                   logFile,
                   targetType: 'pr',
@@ -779,11 +827,17 @@ export const startAutoRestartUntilMergeable = async params => {
     await log(formatAligned('', 'Action:', 'PR is ready for manual merge by a repository maintainer', 2));
     await log('');
 
-    // Post a comment to the PR notifying the maintainer
+    // Issue #1323: Post a comment to the PR notifying the maintainer (with deduplication)
     try {
-      const commentBody = `## ✅ Ready to merge\n\nThis pull request is ready to be merged. Auto-merge was requested (\`--auto-merge\`) but cannot be performed because this PR was created from a fork (no write access to the target repository).\n\nPlease merge manually.\n\n---\n*hive-mind with --auto-merge flag (fork mode)*`;
-      await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
-      await log(formatAligned('', '💬 Posted merge readiness notification to PR', '', 2));
+      const readyToMergeSignature = '## ✅ Ready to merge';
+      const hasExistingComment = await checkForExistingComment(owner, repo, prNumber, readyToMergeSignature, argv.verbose);
+      if (!hasExistingComment) {
+        const commentBody = `## ✅ Ready to merge\n\nThis pull request is ready to be merged. Auto-merge was requested (\`--auto-merge\`) but cannot be performed because this PR was created from a fork (no write access to the target repository).\n\nPlease merge manually.\n\n---\n*hive-mind with --auto-merge flag (fork mode)*`;
+        await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
+        await log(formatAligned('', '💬 Posted merge readiness notification to PR', '', 2));
+      } else {
+        await log(formatAligned('', 'Skipping duplicate "Ready to merge" comment', '', 2));
+      }
     } catch {
       // Don't fail if comment posting fails
     }
@@ -802,11 +856,17 @@ export const startAutoRestartUntilMergeable = async params => {
       await log(formatAligned('', 'Action:', 'PR is ready for manual merge by a repository maintainer', 2));
       await log('');
 
-      // Post a comment to the PR notifying the maintainer
+      // Issue #1323: Post a comment to the PR notifying the maintainer (with deduplication)
       try {
-        const commentBody = `## ✅ Ready to merge\n\nThis pull request is ready to be merged. Auto-merge was requested (\`--auto-merge\`) but cannot be performed because the authenticated user lacks write access to \`${owner}/${repo}\` (current permission: \`${permission || 'unknown'}\`).\n\nPlease merge manually.\n\n---\n*hive-mind with --auto-merge flag*`;
-        await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
-        await log(formatAligned('', '💬 Posted merge readiness notification to PR', '', 2));
+        const readyToMergeSignature = '## ✅ Ready to merge';
+        const hasExistingComment = await checkForExistingComment(owner, repo, prNumber, readyToMergeSignature, argv.verbose);
+        if (!hasExistingComment) {
+          const commentBody = `## ✅ Ready to merge\n\nThis pull request is ready to be merged. Auto-merge was requested (\`--auto-merge\`) but cannot be performed because the authenticated user lacks write access to \`${owner}/${repo}\` (current permission: \`${permission || 'unknown'}\`).\n\nPlease merge manually.\n\n---\n*hive-mind with --auto-merge flag*`;
+          await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${commentBody}`;
+          await log(formatAligned('', '💬 Posted merge readiness notification to PR', '', 2));
+        } else {
+          await log(formatAligned('', 'Skipping duplicate "Ready to merge" comment', '', 2));
+        }
       } catch {
         // Don't fail if comment posting fails
       }

package/src/telegram-merge-queue.lib.mjs

@@ -520,7 +520,7 @@ export class MergeQueueProcessor {
       const elapsedSec = Math.round(this.targetBranchCIStatus.elapsedMs / 1000);
       const elapsedMin = Math.floor(elapsedSec / 60);
       const elapsedSecRemainder = elapsedSec % 60;
-      message += `⏱️ Waiting for ${this.targetBranchCIStatus.count} CI run\\(s\\) on target branch to complete \\(${elapsedMin}m ${elapsedSecRemainder}s\\)\\.\\.\\.\\n\\n`;
+      message += `⏱️ Waiting for ${this.targetBranchCIStatus.count} CI run\\(s\\) on target branch to complete \\(${elapsedMin}m ${elapsedSecRemainder}s\\)\\.\\.\\.\n\n`;
     } else if (this.waitingForTargetBranchCI) {
       message += `⏱️ Checking for active CI runs on target branch\\.\\.\\.\n\n`;
     }
@@ -528,7 +528,8 @@ export class MergeQueueProcessor {
     // Current item being processed
     if (update.current && !this.waitingForTargetBranchCI) {
       const statusEmoji = update.currentStatus === MergeItemStatus.WAITING_CI ? '⏱️' : '🔄';
-      message += `${statusEmoji} ${update.current}\n\n`;
+      // Issue #1339: escape the current item description for MarkdownV2
+      message += `${statusEmoji} ${this.escapeMarkdown(update.current)}\n\n`;
     }
 
     // Show errors/failures/skips inline so user gets immediate feedback (Issue #1269, #1294)
@@ -538,10 +539,12 @@ export class MergeQueueProcessor {
       message += `⚠️ *Issues:*\n`;
       for (const item of problemItems.slice(0, 5)) {
         const statusEmoji = item.status === MergeItemStatus.FAILED ? '❌' : '⏭️';
-        message += `  ${statusEmoji} \\#${item.prNumber}: ${this.escapeMarkdown(item.error.substring(0, 50))}${item.error.length > 50 ? '...' : ''}\n`;
+        // Issue #1339: escape the ellipsis '...' for MarkdownV2 (periods are reserved)
+        message += `  ${statusEmoji} \\#${item.prNumber}: ${this.escapeMarkdown(item.error.substring(0, 50))}${item.error.length > 50 ? '\\.\\.\\.' : ''}\n`;
       }
       if (problemItems.length > 5) {
-        message += `  _...and ${problemItems.length - 5} more issues_\n`;
+        // Issue #1339: escape the ellipsis '...' for MarkdownV2
+        message += `  _\\.\\.\\.and ${problemItems.length - 5} more issues_\n`;
       }
       message += '\n';
     }
@@ -549,11 +552,13 @@ export class MergeQueueProcessor {
     // PRs list with emojis
     message += `*Queue:*\n`;
     for (const item of update.items.slice(0, 10)) {
-      message += `${item.emoji} \\#${item.prNumber}: ${this.escapeMarkdown(item.title.substring(0, 35))}${item.title.length > 35 ? '...' : ''}\n`;
+      // Issue #1339: escape the ellipsis '...' for MarkdownV2 (periods are reserved)
+      message += `${item.emoji} \\#${item.prNumber}: ${this.escapeMarkdown(item.title.substring(0, 35))}${item.title.length > 35 ? '\\.\\.\\.' : ''}\n`;
     }
 
     if (update.items.length > 10) {
-      message += `_...and ${update.items.length - 10} more_\n`;
+      // Issue #1339: escape the ellipsis '...' for MarkdownV2
+      message += `_\\.\\.\\.and ${update.items.length - 10} more_\n`;
     }
 
     return message;