@link-assistant/hive-mind 1.2.8 → 1.2.10

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @link-assistant/hive-mind
 
+## 1.2.10
+
+### Patch Changes
+
+- 7ba1476: Auto-cleanup .playwright-mcp/ folder to prevent false auto-restart triggers
+  - Add auto-cleanup of .playwright-mcp/ folder before checking uncommitted changes
+  - Add --playwright-mcp-auto-cleanup option (enabled by default)
+  - Use --no-playwright-mcp-auto-cleanup to disable cleanup for debugging
+  - Add comprehensive case study documentation for issue #1124
+
+## 1.2.9
+
+### Patch Changes
+
+- b5e047a: Fix branch checkout error showing null/null instead of actual repository URL
+  - Pass owner/repo/prNumber to branch error handlers for accurate error messages
+  - Add upstream remote fallback when PR branch not found in origin (handles bot PRs)
+  - Add case study documentation for issue #1120
+
 ## 1.2.8
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.2.8",
+  "version": "1.2.10",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.branch.lib.mjs

@@ -100,7 +100,7 @@ export function detectBranchFormat(branchName) {
   return null;
 }
 
-export async function createOrCheckoutBranch({ isContinueMode, prBranch, issueNumber, tempDir, defaultBranch, argv, log, formatAligned, $, crypto }) {
+export async function createOrCheckoutBranch({ isContinueMode, prBranch, issueNumber, tempDir, defaultBranch, argv, log, formatAligned, $, crypto, owner, repo, prNumber }) {
   // Create a branch for the issue or checkout existing PR branch
   let branchName;
   let checkoutResult;
@@ -136,11 +136,11 @@ export async function createOrCheckoutBranch({ isContinueMode, prBranch, issueNu
       const { handleBranchCheckoutError } = branchErrors;
       await handleBranchCheckoutError({
         branchName,
-        prNumber: null, // Will be set later
+        prNumber,
         errorOutput,
         issueUrl: argv['issue-url'] || argv._[0],
-        owner: null, // Will be set later
-        repo: null, // Will be set later
+        owner,
+        repo,
         tempDir,
         argv,
         formatAligned,
@@ -154,8 +154,8 @@ export async function createOrCheckoutBranch({ isContinueMode, prBranch, issueNu
         branchName,
         errorOutput,
         tempDir,
-        owner: null, // Will be set later
-        repo: null, // Will be set later
+        owner,
+        repo,
         formatAligned,
         log,
       });
@@ -193,9 +193,9 @@ export async function createOrCheckoutBranch({ isContinueMode, prBranch, issueNu
       isContinueMode,
       branchName,
       actualBranch,
-      prNumber: null, // Will be set later
-      owner: null, // Will be set later
-      repo: null, // Will be set later
+      prNumber,
+      owner,
+      repo,
       tempDir,
       formatAligned,
       log,

package/src/solve.config.lib.mjs

@@ -311,6 +311,11 @@ export const createYargsConfig = yargsInstance => {
         description: 'Include prompt to check related/sibling pull requests when studying related work. Enabled by default, use --no-prompt-check-sibling-pull-requests to disable.',
         default: true,
       })
+      .option('playwright-mcp-auto-cleanup', {
+        type: 'boolean',
+        description: 'Automatically remove .playwright-mcp/ folder before checking for uncommitted changes. This prevents browser automation artifacts from triggering auto-restart. Use --no-playwright-mcp-auto-cleanup to keep the folder for debugging.',
+        default: true,
+      })
       .parserConfiguration({
         'boolean-negation': true,
       })

package/src/solve.mjs

@@ -553,6 +553,9 @@ try {
     formatAligned,
     $,
     crypto,
+    owner,
+    repo,
+    prNumber,
   });
 
   // Auto-merge default branch to pull request branch if enabled
@@ -1113,6 +1116,27 @@ try {
     await safeExit(1, `${argv.tool.toUpperCase()} execution failed`);
   }
 
+  // Clean up .playwright-mcp/ folder before checking for uncommitted changes
+  // This prevents browser automation artifacts from triggering auto-restart (Issue #1124)
+  if (argv.playwrightMcpAutoCleanup !== false) {
+    const playwrightMcpDir = path.join(tempDir, '.playwright-mcp');
+    try {
+      const playwrightMcpExists = await fs
+        .stat(playwrightMcpDir)
+        .then(() => true)
+        .catch(() => false);
+      if (playwrightMcpExists) {
+        await fs.rm(playwrightMcpDir, { recursive: true, force: true });
+        await log('🧹 Cleaned up .playwright-mcp/ folder (browser automation artifacts)', { verbose: true });
+      }
+    } catch (cleanupError) {
+      // Non-critical error, just log and continue
+      await log(`⚠️  Could not clean up .playwright-mcp/ folder: ${cleanupError.message}`, { verbose: true });
+    }
+  } else {
+    await log('ℹ️  Playwright MCP auto-cleanup disabled via --no-playwright-mcp-auto-cleanup', { verbose: true });
+  }
+
   // Check for uncommitted changes
   // When limit is reached, force auto-commit of any uncommitted changes to preserve work
   const shouldAutoCommit = argv['auto-commit-uncommitted-changes'] || limitReached;

package/src/solve.repository.lib.mjs

@@ -1208,6 +1208,41 @@ export const checkoutPrBranch = async (tempDir, branchName, prForkRemote, prFork
   } else {
     // Branch doesn't exist locally, try to checkout from remote
     checkoutResult = await $({ cwd: tempDir })`git checkout -b ${branchName} ${remoteName}/${branchName}`;
+
+    // If checkout from origin failed, try upstream remote as fallback
+    // This handles the case where we're in fork mode but the PR branch exists in upstream
+    // (e.g., a bot created PR in the upstream repo, not a fork PR)
+    if (checkoutResult.code !== 0 && remoteName === 'origin') {
+      await log(`${formatAligned('🔄', 'Branch not in origin:', 'Checking upstream remote...')}`);
+
+      // Check if upstream remote exists
+      const upstreamCheckResult = await $({ cwd: tempDir })`git remote get-url upstream 2>/dev/null`;
+      if (upstreamCheckResult.code === 0) {
+        // Fetch from upstream to ensure we have the latest branches
+        await log(`${formatAligned('📥', 'Fetching from upstream:', 'Looking for PR branch...')}`);
+        const fetchUpstreamResult = await $({ cwd: tempDir })`git fetch upstream`;
+
+        if (fetchUpstreamResult.code === 0) {
+          // Check if branch exists in upstream
+          const upstreamBranchCheckResult = await $({ cwd: tempDir })`git show-ref --verify --quiet refs/remotes/upstream/${branchName}`;
+
+          if (upstreamBranchCheckResult.code === 0) {
+            await log(`${formatAligned('✅', 'Found branch in upstream:', `upstream/${branchName}`)}`);
+            // Try to checkout from upstream instead
+            checkoutResult = await $({ cwd: tempDir })`git checkout -b ${branchName} upstream/${branchName}`;
+
+            if (checkoutResult.code === 0) {
+              await log(`${formatAligned('ℹ️', 'Note:', 'PR branch was in upstream repository, not your fork')}`);
+              await log(`${formatAligned('', '', 'This can happen when a bot creates a PR directly in the main repository')}`);
+            }
+          } else {
+            await log(`${formatAligned('⚠️', 'Branch not found:', `Not in origin or upstream remotes`)}`, { level: 'warning' });
+          }
+        } else {
+          await log(`${formatAligned('⚠️', 'Warning:', 'Failed to fetch from upstream')}`, { level: 'warning' });
+        }
+      }
+    }
   }
 
   return checkoutResult;

package/src/solve.watch.lib.mjs

@@ -15,6 +15,10 @@ const use = globalThis.use;
 // Use command-stream for consistent $ behavior across runtimes
 const { $ } = await use('command-stream');
 
+// Import path and fs for cleanup operations
+const path = (await use('path')).default;
+const fs = (await use('fs')).promises;
+
 // Import shared library functions
 const lib = await import('./lib.mjs');
 const { log, cleanErrorMessage, formatAligned } = lib;
@@ -50,10 +54,36 @@ const checkPRMerged = async (owner, repo, prNumber) => {
   return false;
 };
 
+/**
+ * Clean up .playwright-mcp/ folder to prevent browser automation artifacts
+ * from triggering auto-restart (Issue #1124)
+ */
+const cleanupPlaywrightMcpFolder = async (tempDir, argv) => {
+  if (argv.playwrightMcpAutoCleanup !== false) {
+    const playwrightMcpDir = path.join(tempDir, '.playwright-mcp');
+    try {
+      const playwrightMcpExists = await fs
+        .stat(playwrightMcpDir)
+        .then(() => true)
+        .catch(() => false);
+      if (playwrightMcpExists) {
+        await fs.rm(playwrightMcpDir, { recursive: true, force: true });
+        await log('🧹 Cleaned up .playwright-mcp/ folder (browser automation artifacts)', { verbose: true });
+      }
+    } catch (cleanupError) {
+      // Non-critical error, just log and continue
+      await log(`⚠️  Could not clean up .playwright-mcp/ folder: ${cleanupError.message}`, { verbose: true });
+    }
+  }
+};
+
 /**
  * Check if there are uncommitted changes in the repository
  */
-const checkForUncommittedChanges = async (tempDir, $) => {
+const checkForUncommittedChanges = async (tempDir, $, argv = {}) => {
+  // First, clean up .playwright-mcp/ folder to prevent false positives (Issue #1124)
+  await cleanupPlaywrightMcpFolder(tempDir, argv);
+
   try {
     const gitStatusResult = await $({ cwd: tempDir })`git status --porcelain 2>&1`;
     if (gitStatusResult.code === 0) {
@@ -130,7 +160,7 @@ export const watchForFeedback = async params => {
 
     // In temporary watch mode, check if all changes have been committed
     if (isTemporaryWatch && !firstIterationInTemporaryMode) {
-      const hasUncommitted = await checkForUncommittedChanges(tempDir, $);
+      const hasUncommitted = await checkForUncommittedChanges(tempDir, $, argv);
       if (!hasUncommitted) {
         await log('');
         await log(formatAligned('✅', 'CHANGES COMMITTED!', 'Exiting auto-restart mode'));
@@ -185,7 +215,7 @@ export const watchForFeedback = async params => {
       // In temporary watch mode, also check for uncommitted changes as a restart trigger
       let hasUncommittedInTempMode = false;
       if (isTemporaryWatch && !firstIterationInTemporaryMode) {
-        hasUncommittedInTempMode = await checkForUncommittedChanges(tempDir, $);
+        hasUncommittedInTempMode = await checkForUncommittedChanges(tempDir, $, argv);
       }
 
       const shouldRestart = hasFeedback || firstIterationInTemporaryMode || hasUncommittedInTempMode;