@link-assistant/hive-mind 1.2.6 → 1.2.7

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # @link-assistant/hive-mind
 
+## 1.2.7
+
+### Patch Changes
+
+- 12831a1: fix: Allow issues_list and pulls_list URLs for /hive command (Issue #1102)
+  - Accept issues_list URLs (e.g., `https://github.com/owner/repo/issues`) for /hive command
+  - Clean non-printable characters from URLs to prevent Markdown parsing errors
+  - Escape special characters in error messages
+  - Normalize issues_list URLs to base repo URLs before processing
+
 ## 1.2.6
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.2.6",
+  "version": "1.2.7",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/telegram-bot.mjs

@@ -595,66 +595,28 @@ function mergeArgsWithOverrides(userArgs, overrides) {
   return [...filteredArgs, ...overrides];
 }
 
-/**
- * Validate GitHub URL for Telegram bot commands
- *
- * @param {string[]} args - Command arguments (first arg should be URL)
- * @param {Object} options - Validation options
- * @param {string[]} options.allowedTypes - Allowed URL types (e.g., ['issue', 'pull'] or ['repository', 'organization', 'user'])
- * @param {string} options.commandName - Command name for error messages (e.g., 'solve' or 'hive')
- * @param {string} options.exampleUrl - Example URL for error messages
- * @returns {{ valid: boolean, error?: string }}
- */
+/** Validate GitHub URL for Telegram bot commands. Returns { valid, error?, parsed?, normalizedUrl? } */
 function validateGitHubUrl(args, options = {}) {
-  // Default options for /solve command (backward compatibility)
   const { allowedTypes = ['issue', 'pull'], commandName = 'solve' } = options;
-
-  if (args.length === 0) {
-    return {
-      valid: false,
-      error: `Missing GitHub URL. Usage: /${commandName} <github-url> [options]`,
-    };
-  }
-
-  const url = args[0];
-  if (!url.includes('github.com')) {
-    return {
-      valid: false,
-      error: 'First argument must be a GitHub URL',
-    };
-  }
-
-  // Parse the URL to validate structure
+  if (args.length === 0) return { valid: false, error: `Missing GitHub URL. Usage: /${commandName} <github-url> [options]` };
+  // Issue #1102: Clean non-printable chars (Zero-Width Space, BOM, etc.) from URLs
+  const url = cleanNonPrintableChars(args[0]);
+  if (!url.includes('github.com')) return { valid: false, error: 'First argument must be a GitHub URL' };
   const parsed = parseGitHubUrl(url);
-  if (!parsed.valid) {
-    return {
-      valid: false,
-      error: parsed.error || 'Invalid GitHub URL',
-      suggestion: parsed.suggestion,
-    };
-  }
-
-  // Check if the URL type is allowed for this command
+  if (!parsed.valid) return { valid: false, error: parsed.error || 'Invalid GitHub URL', suggestion: parsed.suggestion };
   if (!allowedTypes.includes(parsed.type)) {
     const allowedTypesStr = allowedTypes.map(t => (t === 'pull' ? 'pull request' : t)).join(', ');
     const baseUrl = `https://github.com/${parsed.owner}/${parsed.repo}`;
-
-    // Provide specific, helpful error messages based on the URL type
+    const escapedUrl = escapeMarkdown(url),
+      escapedBaseUrl = escapeMarkdown(baseUrl); // Issue #1102: escape for Markdown
     let error;
-    if (parsed.type === 'issues_list') {
-      error = `URL points to the issues list page, but you need a specific issue\n\n💡 How to fix:\n1. Open the repository: ${url}\n2. Click on a specific issue\n3. Copy the URL (it should end with /issues/NUMBER)\n\nExample: \`${baseUrl}/issues/1\``;
-    } else if (parsed.type === 'pulls_list') {
-      error = `URL points to the pull requests list page, but you need a specific pull request\n\n💡 How to fix:\n1. Open the repository: ${url}\n2. Click on a specific pull request\n3. Copy the URL (it should end with /pull/NUMBER)\n\nExample: \`${baseUrl}/pull/1\``;
-    } else if (parsed.type === 'repo') {
-      error = `URL points to a repository, but you need a specific ${allowedTypesStr}\n\n💡 How to fix:\n1. Go to: ${url}/issues\n2. Click on an issue to solve\n3. Use the full URL with the issue number\n\nExample: \`${baseUrl}/issues/1\``;
-    } else {
-      error = `URL must be a GitHub ${allowedTypesStr} (not ${parsed.type.replace('_', ' ')})`;
-    }
-
+    if (parsed.type === 'issues_list') error = `URL points to the issues list page, but you need a specific issue\n\n💡 How to fix:\n1. Open the repository: ${escapedUrl}\n2. Click on a specific issue\n3. Copy the URL (it should end with /issues/NUMBER)\n\nExample: \`${escapedBaseUrl}/issues/1\``;
+    else if (parsed.type === 'pulls_list') error = `URL points to the pull requests list page, but you need a specific pull request\n\n💡 How to fix:\n1. Open the repository: ${escapedUrl}\n2. Click on a specific pull request\n3. Copy the URL (it should end with /pull/NUMBER)\n\nExample: \`${escapedBaseUrl}/pull/1\``;
+    else if (parsed.type === 'repo') error = `URL points to a repository, but you need a specific ${allowedTypesStr}\n\n💡 How to fix:\n1. Go to: ${escapedUrl}/issues\n2. Click on an issue to solve\n3. Use the full URL with the issue number\n\nExample: \`${escapedBaseUrl}/issues/1\``;
+    else error = `URL must be a GitHub ${allowedTypesStr} (not ${parsed.type.replace('_', ' ')})`;
     return { valid: false, error };
   }
-
-  return { valid: true };
+  return { valid: true, parsed, normalizedUrl: url };
 }
 
 /**
@@ -1174,23 +1136,25 @@ bot.command(/^hive$/i, async ctx => {
 
   const userArgs = parseCommandArgs(ctx.message.text);
 
-  const validation = validateGitHubUrl(userArgs, {
-    allowedTypes: ['repo', 'organization', 'user'],
-    commandName: 'hive',
-    exampleUrl: 'https://github.com/owner/repo',
-  });
+  // Issue #1102: Allow issues_list/pulls_list URLs and normalize to repo URLs
+  const validation = validateGitHubUrl(userArgs, { allowedTypes: ['repo', 'organization', 'user', 'issues_list', 'pulls_list'], commandName: 'hive' });
   if (!validation.valid) {
     let errorMsg = `❌ ${validation.error}`;
-    if (validation.suggestion) {
-      errorMsg += `\n\n💡 Did you mean: \`${validation.suggestion}\``;
-    }
+    if (validation.suggestion) errorMsg += `\n\n💡 Did you mean: \`${escapeMarkdown(validation.suggestion)}\``;
     errorMsg += '\n\nExample: `/hive https://github.com/owner/repo`';
     await ctx.reply(errorMsg, { parse_mode: 'Markdown', reply_to_message_id: ctx.message.message_id });
     return;
   }
+  // Normalize issues_list/pulls_list to base repo URL, or use cleaned URL
+  let normalizedArgs = [...userArgs];
+  const p = validation.parsed;
+  if (p && (p.type === 'issues_list' || p.type === 'pulls_list')) {
+    normalizedArgs[0] = `https://github.com/${p.owner}/${p.repo}`;
+    if (VERBOSE) console.log(`[VERBOSE] /hive: Normalized ${p.type} URL to repo URL: ${normalizedArgs[0]}`);
+  } else if (validation.normalizedUrl && validation.normalizedUrl !== userArgs[0]) normalizedArgs[0] = validation.normalizedUrl;
 
   // Merge user args with overrides
-  const args = mergeArgsWithOverrides(userArgs, hiveOverrides);
+  const args = mergeArgsWithOverrides(normalizedArgs, hiveOverrides);
 
   // Determine tool from args (default: claude)
   let hiveTool = 'claude';