@link-assistant/hive-mind 1.2.5 → 1.2.6

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @link-assistant/hive-mind
 
+## 1.2.6
+
+### Patch Changes
+
+- 94dfb13: Fix gh-upload-log argument parsing bug causing "File does not exist" error
+  - Fixed bug where `gh-upload-log` received all arguments as a single concatenated string
+  - The issue was caused by using `${commandArgs.join(' ')}` in command-stream template literal, which treats the entire joined string as one argument
+  - Now using separate `${}` interpolations for each argument to ensure proper argument parsing
+  - Also fixed: description flag is now properly passed to gh-upload-log (was only displayed, never sent)
+  - Added comprehensive regression tests and case study documentation
+
 ## 1.2.5
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/log-upload.lib.mjs

@@ -33,23 +33,30 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
   const result = { success: false, url: null, rawUrl: null, type: null, chunks: 1 };
 
   try {
-    // Build command with appropriate flags
+    // Build command flags
+    // IMPORTANT: When using command-stream's $ template tag, each ${} interpolation is treated
+    // as a single argument. DO NOT use commandArgs.join(' ') as it will make all flags part
+    // of the first positional argument, causing "File does not exist" errors.
+    // See case study: docs/case-studies/issue-1096/README.md
     const publicFlag = isPublic ? '--public' : '--private';
-    const descFlag = description ? `--description "${description}"` : '';
-    const verboseFlag = verbose ? '--verbose' : '';
-
-    const command = `gh-upload-log "${logFile}" ${publicFlag} ${descFlag} ${verboseFlag}`.trim().replace(/\s+/g, ' ');
 
     if (verbose) {
-      await log(`  📤 Running: ${command}`, { verbose: true });
+      const descDisplay = description ? ` --description "${description}"` : '';
+      await log(`  📤 Running: gh-upload-log "${logFile}" ${publicFlag}${descDisplay} --verbose`, { verbose: true });
     }
 
-    // Build command arguments array, filtering out empty strings to prevent "Unknown argument: ''" error
-    const commandArgs = [`"${logFile}"`, publicFlag];
-    if (verbose) {
-      commandArgs.push('--verbose');
+    // Execute command with separate interpolations for each argument
+    // Each ${} is properly passed as a separate argument to the shell
+    let uploadResult;
+    if (description && verbose) {
+      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --description ${description} --verbose`;
+    } else if (description) {
+      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --description ${description}`;
+    } else if (verbose) {
+      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag} --verbose`;
+    } else {
+      uploadResult = await $`gh-upload-log ${logFile} ${publicFlag}`;
     }
-    const uploadResult = await $`gh-upload-log ${commandArgs.join(' ')}`;
     const output = (uploadResult.stdout?.toString() || '') + (uploadResult.stderr?.toString() || '');
 
     if (uploadResult.code !== 0) {