@link-assistant/hive-mind 1.2.3 → 1.2.4

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # @link-assistant/hive-mind
 
+## 1.2.4
+
+### Patch Changes
+
+- 14ea4b6: Add validation for LINO configuration to detect invalid input
+  - Add validation in `lenv-reader.lib.mjs` to reject multiple values on the same line (e.g., `--option1  --option2`)
+  - Add validation to reject unrecognized characters in command-line options (e.g., `?`, `@`, `!`)
+  - Errors include clear messages showing the problematic value and instructions for correction
+  - Valid option characters: letters, numbers, hyphens, underscores, equals signs
+  - Add comprehensive unit tests for LINO parsing logic (`test-lino.mjs`)
+  - Add validation tests to lenv-reader test suite (`test-lenv-reader.mjs`)
+  - Add lino tests to CI/CD workflow
+
+  This approach helps users identify and correct configuration errors early, rather than silently dropping invalid options.
+
+  Fixes #1086
+
 ## 1.2.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.2.3",
+  "version": "1.2.4",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/lenv-reader.lib.mjs

@@ -77,6 +77,47 @@ export class LenvReader {
 
         // The values are the variable value
         if (link.values && link.values.length > 0) {
+          // Check for nested structures (multiple items on same line) - reject with error
+          // A nested tuple with id=null that appears amongst other direct values indicates
+          // same-line grouping (e.g., "--option1  --option2" on same line)
+          // However, if the entire list is a SINGLE nested tuple (e.g., "VAR: (\n  1\n  2\n)"),
+          // that's valid parenthesized syntax
+          const hasDirectValues = link.values.some(v => v && typeof v === 'object' && v.id !== null);
+          const hasNestedTuples = link.values.some(v => v && typeof v === 'object' && v.id === null && v.values && v.values.length > 0);
+
+          if (hasDirectValues && hasNestedTuples) {
+            // Mixed direct values and nested tuples indicates same-line grouping
+            for (const v of link.values) {
+              if (v && typeof v === 'object' && v.id === null && v.values && v.values.length > 0) {
+                const nestedItems = v.values.map(nested => nested.id || nested).join(' ');
+                throw new Error(`Invalid LINO format in "${varName}": Multiple values on the same line are not supported.\n` + `Found: "${nestedItems}"\n` + `Each value must be on its own line with proper indentation.`);
+              }
+            }
+          }
+
+          // Determine which values to validate for invalid characters
+          // If it's a single nested tuple (parenthesized list), unwrap it for validation
+          let valuesToValidate = link.values;
+          if (link.values.length === 1 && link.values[0] && typeof link.values[0] === 'object' && link.values[0].id === null && link.values[0].values) {
+            // Single parenthesized list - use inner values
+            valuesToValidate = link.values[0].values;
+          }
+
+          // Check for invalid characters in option-like values
+          for (const v of valuesToValidate) {
+            // Options should match pattern: --option-name or -o (with optional =value)
+            const valueStr = v.id || v;
+            if (typeof valueStr === 'string' && valueStr.startsWith('-')) {
+              // This looks like a command-line option, validate it
+              // Valid option pattern: -x, --option-name, --option-name=value
+              // Invalid characters: ?, !, @, #, $, %, ^, &, *, etc.
+              const invalidCharMatch = valueStr.match(/[^a-zA-Z0-9=_.-]/);
+              if (invalidCharMatch) {
+                throw new Error(`Invalid LINO format in "${varName}": Unrecognized character "${invalidCharMatch[0]}" in option.\n` + `Found: "${valueStr}"\n` + `Options should only contain letters, numbers, hyphens, underscores, and equals signs.`);
+              }
+            }
+          }
+
           // If there are multiple values, format them as LINO notation
           const values = link.values.map(v => v.id || v);
 
@@ -98,6 +139,11 @@ export class LenvReader {
 
       return result;
     } catch (error) {
+      // Re-throw validation errors so users can correct their configuration
+      if (error.message.includes('Invalid LINO format')) {
+        throw error;
+      }
+      // For other parsing errors, log and return empty
       console.error(`Error parsing LINO configuration: ${error.message}`);
       return {};
     }