@link-assistant/hive-mind 1.2.2 → 1.2.3

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @link-assistant/hive-mind
 
+## 1.2.3
+
+### Patch Changes
+
+- 5411e77: Fix gh-upload-log command invocation error caused by empty string argument
+  - Fixed bug where `gh-upload-log` failed with "Unknown argument: ''" when verbose=false
+  - The issue was caused by template literal interpolation `${verbose ? '--verbose' : ''}` passing empty string as an argument
+  - Now using array-based command building to avoid empty arguments
+  - Added improved handling for `error_during_execution` result subtype from Claude CLI
+  - Added tests for log upload command construction to prevent regression
+
 ## 1.2.2
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.2.2",
+  "version": "1.2.3",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/claude.lib.mjs

@@ -680,6 +680,24 @@ const displayModelUsage = async (usage, log) => {
     await log('      Cost: Not available (could not fetch pricing)');
   }
 };
+/**
+ * Display cost comparison between public pricing and Anthropic's official cost
+ * @param {number|null} publicCost - Public pricing estimate
+ * @param {number|null} anthropicCost - Anthropic's official cost
+ * @param {Function} log - Logging function
+ */
+const displayCostComparison = async (publicCost, anthropicCost, log) => {
+  await log('\n   💰 Cost estimation:');
+  await log(`      Public pricing estimate: ${publicCost !== null && publicCost !== undefined ? `$${publicCost.toFixed(6)} USD` : 'unknown'}`);
+  await log(`      Calculated by Anthropic: ${anthropicCost !== null && anthropicCost !== undefined ? `$${anthropicCost.toFixed(6)} USD` : 'unknown'}`);
+  if (publicCost !== null && publicCost !== undefined && anthropicCost !== null && anthropicCost !== undefined) {
+    const difference = anthropicCost - publicCost;
+    const percentDiff = publicCost > 0 ? (difference / publicCost) * 100 : 0;
+    await log(`      Difference:              $${difference.toFixed(6)} (${percentDiff > 0 ? '+' : ''}${percentDiff.toFixed(2)}%)`);
+  } else {
+    await log('      Difference:              unknown');
+  }
+};
 export const calculateSessionTokens = async (sessionId, tempDir) => {
   const os = (await use('os')).default;
   const homeDir = os.homedir();
@@ -885,6 +903,7 @@ export const executeClaudeCommand = async params => {
     let is503Error = false;
     let stderrErrors = [];
     let anthropicTotalCostUSD = null; // Capture Anthropic's official total_cost_usd from result
+    let errorDuringExecution = false; // Issue #1088: Track if error_during_execution subtype occurred
 
     // Create interactive mode handler if enabled
     let interactiveHandler = null;
@@ -1011,21 +1030,24 @@ export const executeClaudeCommand = async params => {
               } else if (data.type === 'tool_use') {
                 toolUseCount++;
               }
-              // Handle session result type from Claude CLI
-              // This is emitted when a session completes, either successfully or with an error
-              // Example: {"type": "result", "subtype": "success", "is_error": true, "result": "Session limit reached ∙ resets 10am"}
+              // Handle session result type from Claude CLI (emitted when session completes)
+              // Subtypes: "success", "error_during_execution" (work may have been done), etc.
               if (data.type === 'result') {
-                // Capture Anthropic's official total_cost_usd from the result
                 if (data.total_cost_usd !== undefined && data.total_cost_usd !== null) {
                   anthropicTotalCostUSD = data.total_cost_usd;
-                  await log(`💰 Anthropic official cost captured: $${anthropicTotalCostUSD.toFixed(6)}`, {
-                    verbose: true,
-                  });
+                  await log(`💰 Anthropic official cost captured: $${anthropicTotalCostUSD.toFixed(6)}`, { verbose: true });
                 }
                 if (data.is_error === true) {
-                  commandFailed = true;
                   lastMessage = data.result || JSON.stringify(data);
-                  await log('⚠️ Detected error result from Claude CLI', { verbose: true });
+                  const subtype = data.subtype || 'unknown';
+                  // Issue #1088: "error_during_execution" = warning (work may exist), others = failure
+                  if (subtype === 'error_during_execution') {
+                    errorDuringExecution = true;
+                    await log(`⚠️ Error during execution (subtype: ${subtype}) - work may be completed`, { verbose: true });
+                  } else {
+                    commandFailed = true;
+                    await log(`⚠️ Detected error from Claude CLI (subtype: ${subtype})`, { verbose: true });
+                  }
                   if (lastMessage.includes('Session limit reached') || lastMessage.includes('limit reached')) {
                     limitReached = true;
                     await log('⚠️ Detected session limit in result', { verbose: true });
@@ -1264,9 +1286,16 @@ export const executeClaudeCommand = async params => {
           limitResetTime,
           messageCount,
           toolUseCount,
+          errorDuringExecution,
         };
       }
-      await log('\n\n✅ Claude command completed');
+      // Issue #1088: If error_during_execution occurred but command didn't fail,
+      // log it as "Finished with errors" instead of pure success
+      if (errorDuringExecution) {
+        await log('\n\n⚠️ Claude command finished with errors');
+      } else {
+        await log('\n\n✅ Claude command completed');
+      }
       await log(`📊 Total messages: ${messageCount}, Tool uses: ${toolUseCount}`);
       // Calculate and display total token usage from session JSONL file
       if (sessionId && tempDir) {
@@ -1289,49 +1318,11 @@ export const executeClaudeCommand = async params => {
               // Show totals if multiple models were used
               if (modelIds.length > 1) {
                 await log('\n   📈 Total across all models:');
-                // Show cost comparison
-                await log('\n   💰 Cost estimation:');
-                if (tokenUsage.totalCostUSD !== null && tokenUsage.totalCostUSD !== undefined) {
-                  await log(`      Public pricing estimate: $${tokenUsage.totalCostUSD.toFixed(6)} USD`);
-                } else {
-                  await log('      Public pricing estimate: unknown');
-                }
-                if (anthropicTotalCostUSD !== null && anthropicTotalCostUSD !== undefined) {
-                  await log(`      Calculated by Anthropic: $${anthropicTotalCostUSD.toFixed(6)} USD`);
-                  // Show comparison if both are available
-                  if (tokenUsage.totalCostUSD !== null && tokenUsage.totalCostUSD !== undefined) {
-                    const difference = anthropicTotalCostUSD - tokenUsage.totalCostUSD;
-                    const percentDiff = tokenUsage.totalCostUSD > 0 ? (difference / tokenUsage.totalCostUSD) * 100 : 0;
-                    await log(`      Difference:              $${difference.toFixed(6)} (${percentDiff > 0 ? '+' : ''}${percentDiff.toFixed(2)}%)`);
-                  } else {
-                    await log('      Difference:              unknown');
-                  }
-                } else {
-                  await log('      Calculated by Anthropic: unknown');
-                  await log('      Difference:              unknown');
-                }
-              } else {
-                // Single model - show cost comparison
-                await log('\n   💰 Cost estimation:');
-                if (tokenUsage.totalCostUSD !== null && tokenUsage.totalCostUSD !== undefined) {
-                  await log(`      Public pricing estimate: $${tokenUsage.totalCostUSD.toFixed(6)} USD`);
-                } else {
-                  await log('      Public pricing estimate: unknown');
-                }
-                if (anthropicTotalCostUSD !== null && anthropicTotalCostUSD !== undefined) {
-                  await log(`      Calculated by Anthropic: $${anthropicTotalCostUSD.toFixed(6)} USD`);
-                  // Show comparison if both are available
-                  if (tokenUsage.totalCostUSD !== null && tokenUsage.totalCostUSD !== undefined) {
-                    const difference = anthropicTotalCostUSD - tokenUsage.totalCostUSD;
-                    const percentDiff = tokenUsage.totalCostUSD > 0 ? (difference / tokenUsage.totalCostUSD) * 100 : 0;
-                    await log(`      Difference:              $${difference.toFixed(6)} (${percentDiff > 0 ? '+' : ''}${percentDiff.toFixed(2)}%)`);
-                  } else {
-                    await log('      Difference:              unknown');
-                  }
-                } else {
-                  await log('      Calculated by Anthropic: unknown');
-                  await log('      Difference:              unknown');
-                }
+              }
+              // Show cost comparison (for both single and multiple models)
+              await displayCostComparison(tokenUsage.totalCostUSD, anthropicTotalCostUSD, log);
+              // Show total tokens for single model only
+              if (modelIds.length === 1) {
                 await log(`      Total tokens: ${formatNumber(tokenUsage.totalTokens)}`);
               }
             } else {
@@ -1365,6 +1356,7 @@ export const executeClaudeCommand = async params => {
         messageCount,
         toolUseCount,
         anthropicTotalCostUSD, // Pass Anthropic's official total cost
+        errorDuringExecution, // Issue #1088: Track if error_during_execution subtype occurred
       };
     } catch (error) {
       reportError(error, {

package/src/github.lib.mjs

@@ -380,6 +380,8 @@ export async function attachLogToGitHub(options) {
     // New parameters for agent tool pricing support
     publicPricingEstimate = null,
     pricingInfo = null,
+    // Issue #1088: Track error_during_execution for "Finished with errors" state
+    errorDuringExecution = false,
   } = options;
   const targetName = targetType === 'pr' ? 'Pull Request' : 'Issue';
   const ghCommand = targetType === 'pr' ? 'pr' : 'issue';
@@ -498,6 +500,25 @@ ${logContent}
 
 </details>
 
+---
+*Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
+    } else if (errorDuringExecution) {
+      // Issue #1088: "Finished with errors" format - work may have been completed but errors occurred
+      const costInfo = buildCostInfoString(totalCostUSD, anthropicTotalCostUSD, pricingInfo);
+      logComment = `## ⚠️ Solution Draft Finished with Errors
+This log file contains the complete execution trace of the AI ${targetType === 'pr' ? 'solution draft' : 'analysis'} process.${costInfo}
+
+**Note**: The session encountered errors during execution, but some work may have been completed. Please review the changes carefully.
+
+<details>
+<summary>Click to expand solution draft log (${Math.round(logStats.size / 1024)}KB)</summary>
+
+\`\`\`
+${logContent}
+\`\`\`
+
+</details>
+
 ---
 *Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
     } else {
@@ -624,6 +645,18 @@ ${errorMessage}
 📎 **Failure log uploaded as ${uploadTypeLabel}${chunkInfo}** (${Math.round(logStats.size / 1024)}KB)
 🔗 [View complete failure log](${logUrl})
 ---
+*Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
+          } else if (errorDuringExecution) {
+            // Issue #1088: "Finished with errors" format - work may have been completed but errors occurred
+            const costInfo = buildCostInfoString(totalCostUSD, anthropicTotalCostUSD, pricingInfo);
+            logUploadComment = `## ⚠️ Solution Draft Finished with Errors
+This log file contains the complete execution trace of the AI ${targetType === 'pr' ? 'solution draft' : 'analysis'} process.${costInfo}
+
+**Note**: The session encountered errors during execution, but some work may have been completed. Please review the changes carefully.
+
+📎 **Log file uploaded as ${uploadTypeLabel}${chunkInfo}** (${Math.round(logStats.size / 1024)}KB)
+🔗 [View complete solution draft log](${logUrl})
+---
 *Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
           } else {
             // Success log format - use helper function for cost info

package/src/log-upload.lib.mjs

@@ -44,7 +44,12 @@ export const uploadLogWithGhUploadLog = async ({ logFile, isPublic, description,
       await log(`  📤 Running: ${command}`, { verbose: true });
     }
 
-    const uploadResult = await $`gh-upload-log "${logFile}" ${publicFlag} ${verbose ? '--verbose' : ''}`;
+    // Build command arguments array, filtering out empty strings to prevent "Unknown argument: ''" error
+    const commandArgs = [`"${logFile}"`, publicFlag];
+    if (verbose) {
+      commandArgs.push('--verbose');
+    }
+    const uploadResult = await $`gh-upload-log ${commandArgs.join(' ')}`;
     const output = (uploadResult.stdout?.toString() || '') + (uploadResult.stderr?.toString() || '');
 
     if (uploadResult.code !== 0) {

package/src/solve.mjs

@@ -891,6 +891,7 @@ try {
   let anthropicTotalCostUSD = toolResult.anthropicTotalCostUSD;
   let publicPricingEstimate = toolResult.publicPricingEstimate; // Used by agent tool
   let pricingInfo = toolResult.pricingInfo; // Used by agent tool for detailed pricing
+  let errorDuringExecution = toolResult.errorDuringExecution || false; // Issue #1088: Track error_during_execution
   limitReached = toolResult.limitReached;
   cleanupContext.limitReached = limitReached;
 
@@ -1127,7 +1128,8 @@ try {
   // Search for newly created pull requests and comments
   // Pass shouldRestart to prevent early exit when auto-restart is needed
   // Include agent tool pricing data when available (publicPricingEstimate, pricingInfo)
-  await verifyResults(owner, repo, branchName, issueNumber, prNumber, prUrl, referenceTime, argv, shouldAttachLogs, shouldRestart, sessionId, tempDir, anthropicTotalCostUSD, publicPricingEstimate, pricingInfo);
+  // Issue #1088: Pass errorDuringExecution for "Finished with errors" state
+  await verifyResults(owner, repo, branchName, issueNumber, prNumber, prUrl, referenceTime, argv, shouldAttachLogs, shouldRestart, sessionId, tempDir, anthropicTotalCostUSD, publicPricingEstimate, pricingInfo, errorDuringExecution);
 
   // Start watch mode if enabled OR if we need to handle uncommitted changes
   if (argv.verbose) {

package/src/solve.results.lib.mjs

@@ -414,7 +414,7 @@ export const showSessionSummary = async (sessionId, limitReached, argv, issueUrl
 };
 
 // Verify results by searching for new PRs and comments
-export const verifyResults = async (owner, repo, branchName, issueNumber, prNumber, prUrl, referenceTime, argv, shouldAttachLogs, shouldRestart = false, sessionId = null, tempDir = null, anthropicTotalCostUSD = null, publicPricingEstimate = null, pricingInfo = null) => {
+export const verifyResults = async (owner, repo, branchName, issueNumber, prNumber, prUrl, referenceTime, argv, shouldAttachLogs, shouldRestart = false, sessionId = null, tempDir = null, anthropicTotalCostUSD = null, publicPricingEstimate = null, pricingInfo = null, errorDuringExecution = false) => {
   await log('\n🔍 Searching for created pull requests or comments...');
 
   try {
@@ -545,6 +545,8 @@ export const verifyResults = async (owner, repo, branchName, issueNumber, prNumb
             // Pass agent tool pricing data when available
             publicPricingEstimate,
             pricingInfo,
+            // Issue #1088: Pass errorDuringExecution for "Finished with errors" state
+            errorDuringExecution,
           });
         }
 
@@ -608,6 +610,8 @@ export const verifyResults = async (owner, repo, branchName, issueNumber, prNumb
           // Pass agent tool pricing data when available
           publicPricingEstimate,
           pricingInfo,
+          // Issue #1088: Pass errorDuringExecution for "Finished with errors" state
+          errorDuringExecution,
         });
       }