@link-assistant/hive-mind 1.11.1 → 1.11.3

package/CHANGELOG.md

@@ -1,5 +1,25 @@
 # @link-assistant/hive-mind
 
+## 1.11.3
+
+### Patch Changes
+
+- 9f24356: Fix 'ready' label not being created by /merge command
+
+  Two bugs prevented the /merge command from creating the 'ready' label:
+  1. `checkReadyLabelExists()` incorrectly treated GitHub API's 404 JSON error response as the label existing. The function now properly checks for "Not Found" message in the response.
+  2. `createReadyLabel()` used bash-specific heredoc syntax (`<<<`) which fails in `/bin/sh`. Now uses `gh api -f` flags for shell compatibility.
+
+  Fixes #1177
+
+## 1.11.2
+
+### Patch Changes
+
+- 8ee116a: fix: detect "command not found" errors to prevent false success
+
+  When the `claude` CLI command is not found (not installed or not in PATH), the tool was incorrectly reporting "Claude command completed" instead of detecting the failure. This fix adds "not found" to the stderr error detection pattern to properly detect when commands fail to start.
+
 ## 1.11.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "1.11.1",
+  "version": "1.11.3",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/claude.lib.mjs

@@ -1095,7 +1095,9 @@ export const executeClaudeCommand = async params => {
             // Example: "⚠️  [BashTool] Pre-flight check is taking longer than expected. Run with ANTHROPIC_LOG=debug to check for failed or slow API requests."
             // Even though this contains the word "failed", it's a warning, not an error
             const isWarning = trimmed.startsWith('⚠️') || trimmed.startsWith('⚠');
-            if (trimmed && !isWarning && (trimmed.includes('Error:') || trimmed.includes('error') || trimmed.includes('failed'))) {
+            // Issue #1165: Also detect "command not found" errors (e.g., "/bin/sh: 1: claude: not found")
+            // These indicate the Claude CLI is not installed or not in PATH
+            if (trimmed && !isWarning && (trimmed.includes('Error:') || trimmed.includes('error') || trimmed.includes('failed') || trimmed.includes('not found'))) {
               stderrErrors.push(trimmed);
             }
           }
@@ -1108,6 +1110,23 @@ export const executeClaudeCommand = async params => {
         }
       }
 
+      // Issue #1165: Check actual exit code from command result for more reliable detection
+      // The .stream() method may not emit 'exit' chunks, but the command object still tracks the exit code
+      // Exit code 127 is the standard Unix convention for "command not found"
+      if (execCommand.result && typeof execCommand.result.code === 'number') {
+        const resultExitCode = execCommand.result.code;
+        if (exitCode === 0 && resultExitCode !== 0) {
+          exitCode = resultExitCode;
+          await log(`⚠️ Updated exit code from command result: ${resultExitCode}`, { verbose: true });
+        }
+        // Specifically detect "command not found" via exit code 127
+        if (resultExitCode === 127 && !commandFailed) {
+          commandFailed = true;
+          await log(`\n❌ Command not found (exit code 127) - "${claudePath}" is not installed or not in PATH`, { level: 'error' });
+          await log('   Please ensure Claude CLI is installed: npm install -g @anthropic-ai/claude-code', { level: 'error' });
+        }
+      }
+
       // Flush any remaining queued comments from interactive mode
       if (interactiveHandler) {
         try {

package/src/github-merge.lib.mjs

@@ -38,10 +38,25 @@ export async function checkReadyLabelExists(owner, repo, verbose = false) {
     const { stdout } = await exec(`gh api repos/${owner}/${repo}/labels/${READY_LABEL.name} 2>/dev/null || echo ""`);
     if (stdout.trim()) {
       const label = JSON.parse(stdout.trim());
+      // Check if the response is an error (404 Not Found returns JSON with "message" field)
+      if (label.message === 'Not Found' || label.status === '404') {
+        if (verbose) {
+          console.log(`[VERBOSE] /merge: 'ready' label does not exist in ${owner}/${repo}`);
+        }
+        return { exists: false, label: null };
+      }
+      // Valid label has a 'name' field
+      if (label.name) {
+        if (verbose) {
+          console.log(`[VERBOSE] /merge: 'ready' label exists in ${owner}/${repo}`);
+        }
+        return { exists: true, label };
+      }
+      // Unknown response format, treat as not found
       if (verbose) {
-        console.log(`[VERBOSE] /merge: 'ready' label exists in ${owner}/${repo}`);
+        console.log(`[VERBOSE] /merge: Unexpected response format when checking label in ${owner}/${repo}`);
       }
-      return { exists: true, label };
+      return { exists: false, label: null };
     }
     if (verbose) {
       console.log(`[VERBOSE] /merge: 'ready' label does not exist in ${owner}/${repo}`);
@@ -64,13 +79,8 @@ export async function checkReadyLabelExists(owner, repo, verbose = false) {
  */
 export async function createReadyLabel(owner, repo, verbose = false) {
   try {
-    const labelData = JSON.stringify({
-      name: READY_LABEL.name,
-      description: READY_LABEL.description,
-      color: READY_LABEL.color,
-    });
-
-    const { stdout } = await exec(`gh api repos/${owner}/${repo}/labels -X POST -H "Accept: application/vnd.github+json" --input - <<< '${labelData}'`);
+    // Use gh api with -f flags to pass fields directly (avoids shell heredoc compatibility issues)
+    const { stdout } = await exec(`gh api repos/${owner}/${repo}/labels -X POST -H "Accept: application/vnd.github+json" -f name="${READY_LABEL.name}" -f description="${READY_LABEL.description}" -f color="${READY_LABEL.color}"`);
     const label = JSON.parse(stdout.trim());
 
     if (verbose) {