@link-assistant/hive-mind 0.51.17 → 0.51.18

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # @link-assistant/hive-mind
 
+## 0.51.18
+
+### Patch Changes
+
+- bf6ac23: Fix Claude Code terms acceptance treated as success
+  - Detect Claude CLI terms acceptance messages and treat as error requiring human intervention
+  - Hide cost estimation section when all values are unknown
+  - Fix code block escaping in log comments using zero-width spaces
+
 ## 0.51.17
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "0.51.17",
+  "version": "0.51.18",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/claude.lib.mjs

@@ -1067,6 +1067,17 @@ export const executeClaudeCommand = async params => {
               if (line.trim() && !line.includes('node:internal')) {
                 await log(line, { stream: 'raw' });
                 lastMessage = line;
+
+                // Detect Claude Code terms acceptance message (Issue #1015)
+                // When Claude CLI requires terms acceptance, it outputs a non-JSON message like:
+                // "[ACTION REQUIRED] An update to our Consumer Terms and Privacy Policy has taken effect..."
+                // This should be treated as an error requiring human intervention, not success
+                const termsAcceptancePattern = /\[ACTION REQUIRED\].*terms|must run.*claude.*review.*terms/i;
+                if (termsAcceptancePattern.test(line)) {
+                  commandFailed = true;
+                  await log('\n❌ Claude Code requires terms acceptance - please run `claude` interactively to accept the updated terms', { level: 'error' });
+                  await log('   This is not an error in your code, but Claude CLI needs human interaction.', { level: 'error' });
+                }
               }
             }
           }

package/src/github.lib.mjs

@@ -22,19 +22,22 @@ import { batchCheckPullRequestsForIssues as batchCheckPRs, batchCheckArchivedRep
  * @param {number|null} totalCostUSD - Public pricing estimate
  * @param {number|null} anthropicTotalCostUSD - Cost calculated by Anthropic (Claude-specific)
  * @param {Object|null} pricingInfo - Pricing info from agent tool
- * @returns {string} Formatted cost info string for markdown
+ * @returns {string} Formatted cost info string for markdown (empty if no data available)
  */
 const buildCostInfoString = (totalCostUSD, anthropicTotalCostUSD, pricingInfo) => {
+  // Issue #1015: Don't show cost section when all values are unknown (clutters output)
+  const hasPublic = totalCostUSD !== null && totalCostUSD !== undefined;
+  const hasAnthropic = anthropicTotalCostUSD !== null && anthropicTotalCostUSD !== undefined;
+  const hasPricing = pricingInfo && (pricingInfo.modelName || pricingInfo.tokenUsage || pricingInfo.isFreeModel);
+  if (!hasPublic && !hasAnthropic && !hasPricing) return '';
   let costInfo = '\n\n💰 **Cost estimation:**';
-  if (pricingInfo && pricingInfo.modelName) {
+  if (pricingInfo?.modelName) {
     costInfo += `\n- Model: ${pricingInfo.modelName}`;
     if (pricingInfo.provider) costInfo += `\n- Provider: ${pricingInfo.provider}`;
   }
-  if (totalCostUSD !== null && totalCostUSD !== undefined) {
+  if (hasPublic) {
     costInfo += pricingInfo?.isFreeModel ? '\n- Public pricing estimate: $0.00 (Free model)' : `\n- Public pricing estimate: $${totalCostUSD.toFixed(6)} USD`;
-  } else {
-    costInfo += '\n- Public pricing estimate: unknown';
-  }
+  } else if (hasPricing) costInfo += '\n- Public pricing estimate: unknown';
   if (pricingInfo?.tokenUsage) {
     const u = pricingInfo.tokenUsage;
     let tokenInfo = `\n- Token usage: ${u.inputTokens?.toLocaleString() || 0} input, ${u.outputTokens?.toLocaleString() || 0} output`;
@@ -42,17 +45,13 @@ const buildCostInfoString = (totalCostUSD, anthropicTotalCostUSD, pricingInfo) =
     if (u.cacheReadTokens > 0 || u.cacheWriteTokens > 0) tokenInfo += `, ${u.cacheReadTokens?.toLocaleString() || 0} cache read, ${u.cacheWriteTokens?.toLocaleString() || 0} cache write`;
     costInfo += tokenInfo;
   }
-  if (anthropicTotalCostUSD !== null && anthropicTotalCostUSD !== undefined) {
+  if (hasAnthropic) {
     costInfo += `\n- Calculated by Anthropic: $${anthropicTotalCostUSD.toFixed(6)} USD`;
-    if (totalCostUSD !== null) {
+    if (hasPublic) {
       const diff = anthropicTotalCostUSD - totalCostUSD;
       const pct = totalCostUSD > 0 ? (diff / totalCostUSD) * 100 : 0;
       costInfo += `\n- Difference: $${diff.toFixed(6)} (${pct > 0 ? '+' : ''}${pct.toFixed(2)}%)`;
-    } else {
-      costInfo += '\n- Difference: unknown';
     }
-  } else if (!pricingInfo) {
-    costInfo += '\n- Calculated by Anthropic: unknown\n- Difference: unknown';
   }
   return costInfo;
 };
@@ -143,16 +142,8 @@ export const getGitHubTokensFromCommand = async () => {
 
   return tokens;
 };
-// Helper function to escape code blocks in log content for safe embedding in markdown
-// When log content is placed inside a markdown code block, any triple backticks (```)
-// in the content will prematurely close the outer code block, breaking the markdown.
-// This function escapes those backticks by replacing them with \`\`\` (with backslashes).
-export const escapeCodeBlocksInLog = logContent => {
-  // Replace all occurrences of triple backticks with escaped version
-  // We add backslashes before backticks to prevent them from being
-  // interpreted as markdown code block delimiters
-  return logContent.replace(/```/g, '\\`\\`\\`');
-};
+// Escape ``` in logs for safe markdown embedding (replaces with \`\`\` to prevent code block closure)
+export const escapeCodeBlocksInLog = logContent => logContent.replace(/```/g, '\\`\\`\\`');
 // Helper function to sanitize log content by masking GitHub tokens
 export const sanitizeLogContent = async logContent => {
   let sanitized = logContent;
@@ -612,6 +603,7 @@ ${resumeCommand}
 \`\`\`
 ${logContent}
 \`\`\`
+
 </details>
 
 ---
@@ -623,12 +615,16 @@ The automated solution draft encountered an error:
 \`\`\`
 ${errorMessage}
 \`\`\`
+
 <details>
 <summary>Click to expand failure log (${Math.round(logStats.size / 1024)}KB)</summary>
+
 \`\`\`
 ${logContent}
 \`\`\`
+
 </details>
+
 ---
 *Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
     } else {
@@ -636,12 +632,16 @@ ${logContent}
       const costInfo = buildCostInfoString(totalCostUSD, anthropicTotalCostUSD, pricingInfo);
       logComment = `## ${customTitle}
 This log file contains the complete execution trace of the AI ${targetType === 'pr' ? 'solution draft' : 'analysis'} process.${costInfo}
+
 <details>
 <summary>Click to expand solution draft log (${Math.round(logStats.size / 1024)}KB)</summary>
+
 \`\`\`
 ${logContent}
 \`\`\`
+
 </details>
+
 ---
 *Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
     }
@@ -836,12 +836,16 @@ async function attachTruncatedLog(options) {
   const truncatedComment = `## 🤖 Solution Draft Log (Truncated)
 This log file contains the complete execution trace of the AI ${targetType === 'pr' ? 'solution draft' : 'analysis'} process.
 ⚠️ **Log was truncated** due to GitHub comment size limits.
+
 <details>
 <summary>Click to expand solution draft log (${Math.round(logStats.size / 1024)}KB, truncated)</summary>
+
 \`\`\`
 ${truncatedContent}
 \`\`\`
+
 </details>
+
 ---
 *Now working session is ended, feel free to review and add any feedback on the solution draft.*`;
   const tempFile = `/tmp/log-truncated-comment-${targetType}-${Date.now()}.md`;