@link-assistant/hive-mind 0.51.13 → 0.51.15

package/CHANGELOG.md

@@ -1,5 +1,30 @@
 # @link-assistant/hive-mind
 
+## 0.51.15
+
+### Patch Changes
+
+- 93a0af9: Add case study for issue #964: Discussion comments not loaded to AI context
+
+  This case study documents the root cause analysis of why the AI solver failed to see and respond to repository owner feedback on PR #13 in the eg0rmaffin/vapor-rice-i3 repository. The investigation revealed two independent root causes:
+  1. The feedback system tells the AI the count of new comments but not their content
+  2. The AI used an incomplete API command that only fetches conversation comments, missing review comments
+
+  The case study includes proposed solutions to fix this issue.
+
+## 0.51.14
+
+### Patch Changes
+
+- 4e4fe08: Improve fork divergence error message clarity
+  - Remove misleading "Option 3: Work without syncing fork (NOT RECOMMENDED)"
+  - Add new Option 1 for deleting and recreating fork (marked as SIMPLEST)
+  - Reorder options by simplicity: deletion → auto-resolution → manual resolution
+  - Move risk warnings inline with relevant options for better context
+  - Add comprehensive case study documentation in docs/case-studies/issue-972/
+
+  This change makes the error message more useful by removing options that were never actually viable and adding the fork deletion option as the cleanest solution for most fork divergence scenarios.
+
 ## 0.51.13
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "0.51.13",
+  "version": "0.51.15",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/agent.prompts.lib.mjs

@@ -114,7 +114,11 @@ Initial research.
    - When accessing GitHub Gists, use gh gist view command instead of direct URL fetching.
    - When you are fixing a bug, please make sure you first find the actual root cause, do as many experiments as needed.
    - When you are fixing a bug and code does not have enough tracing/logs, add them and make sure they stay in the code, but are switched off by default.
-   - When you need latest comments on pull request, use gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate.
+   - When you need comments on a pull request, note that GitHub has THREE different comment types with different API endpoints:
+      1. PR review comments (inline code comments): gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate
+      2. PR conversation comments (general discussion): gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate
+      3. PR reviews (approve/request changes): gh api repos/${owner}/${repo}/pulls/${prNumber}/reviews --paginate
+      IMPORTANT: The command "gh pr view --json comments" ONLY returns conversation comments and misses review comments!
    - When you need latest comments on issue, use gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate.
 
 Solution development and testing.
@@ -168,7 +172,9 @@ Self review.
 
 GitHub CLI command patterns.
    - IMPORTANT: Always use --paginate flag when fetching lists from GitHub API to ensure all results are returned (GitHub returns max 30 per page by default).
-   - When listing PR comments, use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR review comments (inline code comments), use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR conversation comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
+   - When listing PR reviews, use gh api repos/OWNER/REPO/pulls/NUMBER/reviews --paginate.
    - When listing issue comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
    - When adding PR comment, use gh pr comment NUMBER --body "text" --repo OWNER/REPO.
    - When adding issue comment, use gh issue comment NUMBER --body "text" --repo OWNER/REPO.

package/src/claude.prompts.lib.mjs

@@ -130,7 +130,11 @@ Initial research.
    - When accessing GitHub Gists (especially private ones), use gh gist view command instead of direct URL fetching to ensure proper authentication.
    - When you are fixing a bug, please make sure you first find the actual root cause, do as many experiments as needed.
    - When you are fixing a bug and code does not have enough tracing/logs, add them and make sure they stay in the code, but are switched off by default.
-   - When you need latest comments on pull request, use gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate.
+   - When you need comments on a pull request, note that GitHub has THREE different comment types with different API endpoints:
+      1. PR review comments (inline code comments): gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate
+      2. PR conversation comments (general discussion): gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate
+      3. PR reviews (approve/request changes): gh api repos/${owner}/${repo}/pulls/${prNumber}/reviews --paginate
+      IMPORTANT: The command "gh pr view --json comments" ONLY returns conversation comments and misses review comments!
    - When you need latest comments on issue, use gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate.${argv && argv.promptGeneralPurposeSubAgent ? '\n   - When the task is big and requires processing of lots of files or folders, you should use the `general-purpose` sub agents to delegate work. Each separate file or folder can be delegated to a sub agent for more efficient processing.' : ''}${argv && argv.promptCaseStudies ? `\n   - When working on this issue, create a comprehensive case study in the ./docs/case-studies/issue-${issueNumber}/ directory. Download all logs and data related to the issue to the repository. Perform deep case study analysis by searching online for additional facts and data, reconstructing the timeline/sequence of events, identifying root causes of the problem, and proposing possible solutions. Include files like README.md (executive summary, problem statement, timeline, root cause), TECHNICAL_SUMMARY.md (deep technical analysis), ANALYSIS.md (detailed investigation findings), improvements.md (proposed solutions), and supporting logs/data files.` : ''}
 
 Solution development and testing.
@@ -185,7 +189,9 @@ Self review.
 
 GitHub CLI command patterns.
    - IMPORTANT: Always use --paginate flag when fetching lists from GitHub API to ensure all results are returned (GitHub returns max 30 per page by default).
-   - When listing PR comments, use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR review comments (inline code comments), use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR conversation comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
+   - When listing PR reviews, use gh api repos/OWNER/REPO/pulls/NUMBER/reviews --paginate.
    - When listing issue comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
    - When adding PR comment, use gh pr comment NUMBER --body "text" --repo OWNER/REPO.
    - When adding issue comment, use gh issue comment NUMBER --body "text" --repo OWNER/REPO.

package/src/codex.prompts.lib.mjs

@@ -122,7 +122,11 @@ Initial research.
    - When accessing GitHub Gists (especially private ones), use gh gist view command instead of direct URL fetching to ensure proper authentication.
    - When you are fixing a bug, please make sure you first find the actual root cause, do as many experiments as needed.
    - When you are fixing a bug and code does not have enough tracing/logs, add them and make sure they stay in the code, but are switched off by default.
-   - When you need latest comments on pull request, use gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate.
+   - When you need comments on a pull request, note that GitHub has THREE different comment types with different API endpoints:
+      1. PR review comments (inline code comments): gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate
+      2. PR conversation comments (general discussion): gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate
+      3. PR reviews (approve/request changes): gh api repos/${owner}/${repo}/pulls/${prNumber}/reviews --paginate
+      IMPORTANT: The command "gh pr view --json comments" ONLY returns conversation comments and misses review comments!
    - When you need latest comments on issue, use gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate.
 
 Solution development and testing.
@@ -176,7 +180,9 @@ Self review.
 
 GitHub CLI command patterns.
    - IMPORTANT: Always use --paginate flag when fetching lists from GitHub API to ensure all results are returned (GitHub returns max 30 per page by default).
-   - When listing PR comments, use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR review comments (inline code comments), use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR conversation comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
+   - When listing PR reviews, use gh api repos/OWNER/REPO/pulls/NUMBER/reviews --paginate.
    - When listing issue comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
    - When adding PR comment, use gh pr comment NUMBER --body "text" --repo OWNER/REPO.
    - When adding issue comment, use gh issue comment NUMBER --body "text" --repo OWNER/REPO.

package/src/opencode.prompts.lib.mjs

@@ -114,7 +114,11 @@ Initial research.
    - When accessing GitHub Gists, use gh gist view command instead of direct URL fetching.
    - When you are fixing a bug, please make sure you first find the actual root cause, do as many experiments as needed.
    - When you are fixing a bug and code does not have enough tracing/logs, add them and make sure they stay in the code, but are switched off by default.
-   - When you need latest comments on pull request, use gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate.
+   - When you need comments on a pull request, note that GitHub has THREE different comment types with different API endpoints:
+      1. PR review comments (inline code comments): gh api repos/${owner}/${repo}/pulls/${prNumber}/comments --paginate
+      2. PR conversation comments (general discussion): gh api repos/${owner}/${repo}/issues/${prNumber}/comments --paginate
+      3. PR reviews (approve/request changes): gh api repos/${owner}/${repo}/pulls/${prNumber}/reviews --paginate
+      IMPORTANT: The command "gh pr view --json comments" ONLY returns conversation comments and misses review comments!
    - When you need latest comments on issue, use gh api repos/${owner}/${repo}/issues/${issueNumber}/comments --paginate.
 
 Solution development and testing.
@@ -167,7 +171,9 @@ Self review.
 
 GitHub CLI command patterns.
    - IMPORTANT: Always use --paginate flag when fetching lists from GitHub API to ensure all results are returned (GitHub returns max 30 per page by default).
-   - When listing PR comments, use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR review comments (inline code comments), use gh api repos/OWNER/REPO/pulls/NUMBER/comments --paginate.
+   - When listing PR conversation comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
+   - When listing PR reviews, use gh api repos/OWNER/REPO/pulls/NUMBER/reviews --paginate.
    - When listing issue comments, use gh api repos/OWNER/REPO/issues/NUMBER/comments --paginate.
    - When adding PR comment, use gh pr comment NUMBER --body "text" --repo OWNER/REPO.
    - When adding issue comment, use gh issue comment NUMBER --body "text" --repo OWNER/REPO.

package/src/solve.feedback.lib.mjs

@@ -10,6 +10,7 @@ export const detectAndCountFeedback = async params => {
   const { prNumber, branchName, owner, repo, issueNumber, isContinueMode, argv, mergeStateStatus, prState, workStartTime, log, formatAligned, cleanErrorMessage, $ } = params;
 
   let newPrComments = 0;
+  let newPrReviewComments = 0;
   let newIssueComments = 0;
   let commentInfo = '';
   let feedbackLines = [];
@@ -104,10 +105,8 @@ export const detectAndCountFeedback = async params => {
           prConversationComments = JSON.parse(prConversationCommentsResult.stdout.toString());
         }
 
-        // Combine and count all PR comments after last commit
-        // Filter out comments from current user if made after work started AND filter out log comments
-        const allPrComments = [...prReviewComments, ...prConversationComments];
-        const filteredPrComments = allPrComments.filter(comment => {
+        // Helper function to filter comments based on time and log patterns
+        const filterComment = comment => {
           const commentTime = new Date(comment.created_at);
           const isAfterCommit = commentTime > lastCommitTime;
           const isNotLogPattern = !logPatterns.some(pattern => pattern.test(comment.body || ''));
@@ -122,8 +121,18 @@ export const detectAndCountFeedback = async params => {
           }
 
           return isAfterCommit && isNotLogPattern;
-        });
-        newPrComments = filteredPrComments.length;
+        };
+
+        // Filter and count PR review comments (inline code comments) separately
+        const filteredPrReviewComments = prReviewComments.filter(filterComment);
+        newPrReviewComments = filteredPrReviewComments.length;
+
+        // Filter and count PR conversation comments separately
+        const filteredPrConversationComments = prConversationComments.filter(filterComment);
+        newPrComments = filteredPrConversationComments.length;
+
+        // Combined count for logging purposes
+        const allPrComments = [...prReviewComments, ...prConversationComments];
 
         // Count new issue comments after last commit
         // Use --paginate to get all comments - GitHub API returns max 30 per page by default
@@ -150,11 +159,12 @@ export const detectAndCountFeedback = async params => {
         }
 
         await log(formatAligned('💬', 'New PR comments:', newPrComments.toString(), 2));
+        await log(formatAligned('💬', 'New PR review comments:', newPrReviewComments.toString(), 2));
         await log(formatAligned('💬', 'New issue comments:', newIssueComments.toString(), 2));
 
         if (argv.verbose) {
-          await log(`   Total new comments: ${newPrComments + newIssueComments}`, { verbose: true });
-          await log(`   Comment lines to add: ${newPrComments > 0 || newIssueComments > 0 ? 'Yes' : 'No (saving tokens)'}`, { verbose: true });
+          await log(`   Total new comments: ${newPrComments + newPrReviewComments + newIssueComments}`, { verbose: true });
+          await log(`   Comment lines to add: ${newPrComments > 0 || newPrReviewComments > 0 || newIssueComments > 0 ? 'Yes' : 'No (saving tokens)'}`, { verbose: true });
           await log(`   PR review comments fetched: ${prReviewComments.length}`, { verbose: true });
           await log(`   PR conversation comments fetched: ${prConversationComments.length}`, { verbose: true });
           await log(`   Total PR comments checked: ${allPrComments.length}`, { verbose: true });
@@ -162,7 +172,7 @@ export const detectAndCountFeedback = async params => {
 
         // Check if --auto-continue-only-on-new-comments is enabled and fail if no new comments
         if (argv.autoContinueOnlyOnNewComments && (isContinueMode || argv.autoContinue)) {
-          const totalNewComments = newPrComments + newIssueComments;
+          const totalNewComments = newPrComments + newPrReviewComments + newIssueComments;
           if (totalNewComments === 0) {
             await log('❌ auto-continue-only-on-new-comments: No new comments found since last commit');
             await log('   This option requires new comments to proceed with auto-continue or continue mode.');
@@ -181,6 +191,9 @@ export const detectAndCountFeedback = async params => {
         if (newPrComments > 0) {
           feedbackLines.push(`New comments on the pull request: ${newPrComments}`);
         }
+        if (newPrReviewComments > 0) {
+          feedbackLines.push(`New review comments on the pull request: ${newPrReviewComments}`);
+        }
         if (newIssueComments > 0) {
           feedbackLines.push(`New comments on the issue: ${newIssueComments}`);
         }
@@ -192,7 +205,7 @@ export const detectAndCountFeedback = async params => {
           }
 
           // 1. Check for new comments (already filtered above)
-          const totalNewComments = newPrComments + newIssueComments;
+          const totalNewComments = newPrComments + newPrReviewComments + newIssueComments;
           if (totalNewComments > 0) {
             feedbackDetected = true;
             feedbackSources.push(`New comments (${totalNewComments})`);
@@ -413,5 +426,5 @@ export const detectAndCountFeedback = async params => {
     }
   }
 
-  return { newPrComments, newIssueComments, commentInfo, feedbackLines };
+  return { newPrComments, newPrReviewComments, newIssueComments, commentInfo, feedbackLines };
 };

package/src/solve.repository.lib.mjs

@@ -946,18 +946,19 @@ export const setupUpstreamAndSync = async (tempDir, forkedRepo, upstreamRemote,
                     }
                   } else {
                     // Flag is not enabled - provide guidance
-                    await log('  ⚠️  RISKS of force-pushing:');
-                    await log('     • Overwrites fork history - any unique commits in your fork will be LOST');
-                    await log('     • Other collaborators working on your fork may face conflicts');
-                    await log('     • Cannot be undone - use with extreme caution');
-                    await log('');
                     await log('  💡 Your options:');
                     await log('');
-                    await log('     Option 1: Enable automatic force-push (DANGEROUS)');
+                    await log('     Option 1: Delete your fork and recreate it (SIMPLEST)');
+                    await log(`              gh repo delete ${forkedRepo}`);
+                    await log('              Then run the solve command again - the fork will be recreated automatically');
+                    await log('              ⚠️  Only use this if your fork has no unique commits you need to preserve');
+                    await log('');
+                    await log('     Option 2: Enable automatic force-push (DANGEROUS)');
                     await log('              Add --allow-fork-divergence-resolution-using-force-push-with-lease flag to your command');
                     await log('              This will automatically sync your fork with upstream using force-with-lease');
+                    await log('              ⚠️  Overwrites fork history - any unique commits will be LOST');
                     await log('');
-                    await log('     Option 2: Manually resolve the divergence');
+                    await log('     Option 3: Manually resolve the divergence');
                     await log('              1. Decide if you need any commits unique to your fork');
                     await log('              2. If yes, cherry-pick them after syncing');
                     await log('              3. If no, manually force-push:');
@@ -965,10 +966,6 @@ export const setupUpstreamAndSync = async (tempDir, forkedRepo, upstreamRemote,
                     await log(`                 git reset --hard upstream/${upstreamDefaultBranch}`);
                     await log(`                 git push --force origin ${upstreamDefaultBranch}`);
                     await log('');
-                    await log('     Option 3: Work without syncing fork (NOT RECOMMENDED)');
-                    await log('              Your fork will remain out-of-sync with upstream');
-                    await log('              May cause merge conflicts in pull requests');
-                    await log('');
                     await log('  🔧 To proceed with auto-resolution, restart with:');
                     await log(`     solve ${argv.url || argv['issue-url'] || argv._[0] || '<issue-url>'} --allow-fork-divergence-resolution-using-force-push-with-lease`);
                     await log('');