@link-assistant/hive-mind 0.51.12 → 0.51.14

package/CHANGELOG.md

@@ -1,5 +1,24 @@
 # @link-assistant/hive-mind
 
+## 0.51.14
+
+### Patch Changes
+
+- 4e4fe08: Improve fork divergence error message clarity
+  - Remove misleading "Option 3: Work without syncing fork (NOT RECOMMENDED)"
+  - Add new Option 1 for deleting and recreating fork (marked as SIMPLEST)
+  - Reorder options by simplicity: deletion → auto-resolution → manual resolution
+  - Move risk warnings inline with relevant options for better context
+  - Add comprehensive case study documentation in docs/case-studies/issue-972/
+
+  This change makes the error message more useful by removing options that were never actually viable and adding the fork deletion option as the cleanest solution for most fork divergence scenarios.
+
+## 0.51.13
+
+### Patch Changes
+
+- 20d6f3a: Fix URL hash fragment parsing - URLs with hash fragments like #issuecomment-123 are now correctly parsed. Previously, solving a PR with a comment URL like /pull/9#issuecomment-123 would fail because the PR number was extracted as "9#issuecomment-123" instead of "9".
+
 ## 0.51.12
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "0.51.12",
+  "version": "0.51.14",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.mjs

@@ -52,7 +52,7 @@ const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, form
 const githubLib = await import('./github.lib.mjs');
 const { sanitizeLogContent, attachLogToGitHub } = githubLib;
 const validation = await import('./solve.validation.lib.mjs');
-const { validateGitHubUrl, showAttachLogsWarning, initializeLogFile, validateUrlRequirement, validateContinueOnlyOnFeedback, performSystemChecks, parseUrlComponents } = validation;
+const { validateGitHubUrl, showAttachLogsWarning, initializeLogFile, validateUrlRequirement, validateContinueOnlyOnFeedback, performSystemChecks } = validation;
 const autoContinue = await import('./solve.auto-continue.lib.mjs');
 const { processAutoContinueForIssue } = autoContinue;
 const repository = await import('./solve.repository.lib.mjs');
@@ -175,8 +175,11 @@ const urlValidation = validateGitHubUrl(issueUrl);
 if (!urlValidation.isValid) {
   await safeExit(1, 'Invalid GitHub URL');
 }
-const { isIssueUrl, isPrUrl, normalizedUrl } = urlValidation;
+const { isIssueUrl, isPrUrl, normalizedUrl, owner, repo, number: urlNumber } = urlValidation;
 issueUrl = normalizedUrl || issueUrl;
+// Store owner and repo globally for error handlers early
+global.owner = owner;
+global.repo = repo;
 // Setup unhandled error handlers to ensure log path is always shown
 const errorHandlerOptions = {
   log,
@@ -222,11 +225,9 @@ if (argv.verbose) {
   await log(`   Is PR URL: ${!!isPrUrl}`, { verbose: true });
 }
 const claudePath = process.env.CLAUDE_PATH || 'claude';
-// Parse URL components using validation module
-const { owner, repo, urlNumber } = parseUrlComponents(issueUrl);
-// Store owner and repo globally for error handlers
-global.owner = owner;
-global.repo = repo;
+// Note: owner, repo, and urlNumber are already extracted from validateGitHubUrl() above
+// The parseUrlComponents() call was removed as it had a bug with hash fragments (#issuecomment-xyz)
+// and the validation result already provides these values correctly parsed
 
 // Handle --auto-fork option: automatically fork public repositories without write access
 if (argv.autoFork && !argv.fork) {

package/src/solve.repository.lib.mjs

@@ -946,18 +946,19 @@ export const setupUpstreamAndSync = async (tempDir, forkedRepo, upstreamRemote,
                     }
                   } else {
                     // Flag is not enabled - provide guidance
-                    await log('  ⚠️  RISKS of force-pushing:');
-                    await log('     • Overwrites fork history - any unique commits in your fork will be LOST');
-                    await log('     • Other collaborators working on your fork may face conflicts');
-                    await log('     • Cannot be undone - use with extreme caution');
-                    await log('');
                     await log('  💡 Your options:');
                     await log('');
-                    await log('     Option 1: Enable automatic force-push (DANGEROUS)');
+                    await log('     Option 1: Delete your fork and recreate it (SIMPLEST)');
+                    await log(`              gh repo delete ${forkedRepo}`);
+                    await log('              Then run the solve command again - the fork will be recreated automatically');
+                    await log('              ⚠️  Only use this if your fork has no unique commits you need to preserve');
+                    await log('');
+                    await log('     Option 2: Enable automatic force-push (DANGEROUS)');
                     await log('              Add --allow-fork-divergence-resolution-using-force-push-with-lease flag to your command');
                     await log('              This will automatically sync your fork with upstream using force-with-lease');
+                    await log('              ⚠️  Overwrites fork history - any unique commits will be LOST');
                     await log('');
-                    await log('     Option 2: Manually resolve the divergence');
+                    await log('     Option 3: Manually resolve the divergence');
                     await log('              1. Decide if you need any commits unique to your fork');
                     await log('              2. If yes, cherry-pick them after syncing');
                     await log('              3. If no, manually force-push:');
@@ -965,10 +966,6 @@ export const setupUpstreamAndSync = async (tempDir, forkedRepo, upstreamRemote,
                     await log(`                 git reset --hard upstream/${upstreamDefaultBranch}`);
                     await log(`                 git push --force origin ${upstreamDefaultBranch}`);
                     await log('');
-                    await log('     Option 3: Work without syncing fork (NOT RECOMMENDED)');
-                    await log('              Your fork will remain out-of-sync with upstream');
-                    await log('              May cause merge conflicts in pull requests');
-                    await log('');
                     await log('  🔧 To proceed with auto-resolution, restart with:');
                     await log(`     solve ${argv.url || argv['issue-url'] || argv._[0] || '<issue-url>'} --allow-fork-divergence-resolution-using-force-push-with-lease`);
                     await log('');

package/src/solve.validation.lib.mjs

@@ -272,13 +272,23 @@ export const performSystemChecks = async (minDiskSpace = 2048, skipToolConnectio
   return true;
 };
 
-// Parse URL components
+// Parse URL components using Node.js URL API
+// Note: This function is a simpler alternative to parseGitHubUrl for cases where
+// you only need owner, repo, and urlNumber without full validation.
+// For full validation, use validateGitHubUrl() which internally uses parseGitHubUrl().
+// Uses Node.js URL API (https://nodejs.org/api/url.html) for stable parsing.
 export const parseUrlComponents = issueUrl => {
-  const urlParts = issueUrl.split('/');
+  // Use Node.js URL API for reliable parsing
+  // This automatically handles hash fragments, query params, and edge cases
+  const urlObj = new globalThis.URL(issueUrl);
+
+  // Extract path segments, filtering out empty strings from leading/trailing slashes
+  const pathParts = urlObj.pathname.split('/').filter(p => p);
+
   return {
-    owner: urlParts[3],
-    repo: urlParts[4],
-    urlNumber: urlParts[6], // Could be issue or PR number
+    owner: pathParts[0],
+    repo: pathParts[1],
+    urlNumber: pathParts[3], // Could be issue or PR number (pathParts[2] is 'issues' or 'pull')
   };
 };