@link-assistant/hive-mind 0.51.12 → 0.51.13

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @link-assistant/hive-mind
 
+## 0.51.13
+
+### Patch Changes
+
+- 20d6f3a: Fix URL hash fragment parsing - URLs with hash fragments like #issuecomment-123 are now correctly parsed. Previously, solving a PR with a comment URL like /pull/9#issuecomment-123 would fail because the PR number was extracted as "9#issuecomment-123" instead of "9".
+
 ## 0.51.12
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "0.51.12",
+  "version": "0.51.13",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/solve.mjs

@@ -52,7 +52,7 @@ const { log, setLogFile, getLogFile, getAbsoluteLogPath, cleanErrorMessage, form
 const githubLib = await import('./github.lib.mjs');
 const { sanitizeLogContent, attachLogToGitHub } = githubLib;
 const validation = await import('./solve.validation.lib.mjs');
-const { validateGitHubUrl, showAttachLogsWarning, initializeLogFile, validateUrlRequirement, validateContinueOnlyOnFeedback, performSystemChecks, parseUrlComponents } = validation;
+const { validateGitHubUrl, showAttachLogsWarning, initializeLogFile, validateUrlRequirement, validateContinueOnlyOnFeedback, performSystemChecks } = validation;
 const autoContinue = await import('./solve.auto-continue.lib.mjs');
 const { processAutoContinueForIssue } = autoContinue;
 const repository = await import('./solve.repository.lib.mjs');
@@ -175,8 +175,11 @@ const urlValidation = validateGitHubUrl(issueUrl);
 if (!urlValidation.isValid) {
   await safeExit(1, 'Invalid GitHub URL');
 }
-const { isIssueUrl, isPrUrl, normalizedUrl } = urlValidation;
+const { isIssueUrl, isPrUrl, normalizedUrl, owner, repo, number: urlNumber } = urlValidation;
 issueUrl = normalizedUrl || issueUrl;
+// Store owner and repo globally for error handlers early
+global.owner = owner;
+global.repo = repo;
 // Setup unhandled error handlers to ensure log path is always shown
 const errorHandlerOptions = {
   log,
@@ -222,11 +225,9 @@ if (argv.verbose) {
   await log(`   Is PR URL: ${!!isPrUrl}`, { verbose: true });
 }
 const claudePath = process.env.CLAUDE_PATH || 'claude';
-// Parse URL components using validation module
-const { owner, repo, urlNumber } = parseUrlComponents(issueUrl);
-// Store owner and repo globally for error handlers
-global.owner = owner;
-global.repo = repo;
+// Note: owner, repo, and urlNumber are already extracted from validateGitHubUrl() above
+// The parseUrlComponents() call was removed as it had a bug with hash fragments (#issuecomment-xyz)
+// and the validation result already provides these values correctly parsed
 
 // Handle --auto-fork option: automatically fork public repositories without write access
 if (argv.autoFork && !argv.fork) {

package/src/solve.validation.lib.mjs

@@ -272,13 +272,23 @@ export const performSystemChecks = async (minDiskSpace = 2048, skipToolConnectio
   return true;
 };
 
-// Parse URL components
+// Parse URL components using Node.js URL API
+// Note: This function is a simpler alternative to parseGitHubUrl for cases where
+// you only need owner, repo, and urlNumber without full validation.
+// For full validation, use validateGitHubUrl() which internally uses parseGitHubUrl().
+// Uses Node.js URL API (https://nodejs.org/api/url.html) for stable parsing.
 export const parseUrlComponents = issueUrl => {
-  const urlParts = issueUrl.split('/');
+  // Use Node.js URL API for reliable parsing
+  // This automatically handles hash fragments, query params, and edge cases
+  const urlObj = new globalThis.URL(issueUrl);
+
+  // Extract path segments, filtering out empty strings from leading/trailing slashes
+  const pathParts = urlObj.pathname.split('/').filter(p => p);
+
   return {
-    owner: urlParts[3],
-    repo: urlParts[4],
-    urlNumber: urlParts[6], // Could be issue or PR number
+    owner: pathParts[0],
+    repo: pathParts[1],
+    urlNumber: pathParts[3], // Could be issue or PR number (pathParts[2] is 'issues' or 'pull')
   };
 };