@link-assistant/hive-mind 0.41.3 → 0.41.7

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @link-assistant/hive-mind
 
+## 0.41.7
+
+### Patch Changes
+
+- 781a8e4: Fix: Upload logs when usage limit is reached
+
+## 0.41.5
+
+### Patch Changes
+
+- 27bbc44: Add backslash detection and validation in GitHub URLs
+
+  When users provide URLs with backslashes (e.g., `https://github.com/owner/repo/issues/123\`), the system now properly validates them and provides helpful error messages with auto-corrected URL suggestions. According to RFC 3986, backslash is not a valid character in URL paths.
+
+  **Changes:**
+
+  - Enhanced `parseGitHubUrl()` function to detect backslashes in URL paths
+  - Updated all validation points (Telegram bot `/solve` and `/hive` commands, CLI `hive` and `solve` commands)
+  - Provides user-friendly error messages with corrected URL suggestions
+  - Comprehensive test suite for backslash validation scenarios
+
+  Fixes #923
+
 ## 0.41.3
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/hive-mind",
-  "version": "0.41.3",
+  "version": "0.41.7",
   "description": "AI-powered issue solver and hive mind for collaborative problem solving",
   "main": "src/hive.mjs",
   "type": "module",

package/src/github.lib.mjs

@@ -1107,6 +1107,22 @@ export function parseGitHubUrl(url) {
   if (normalizedUrl.startsWith('http://')) {
     normalizedUrl = normalizedUrl.replace(/^http:\/\//, 'https://');
   }
+
+  // Check for backslashes in the URL path (excluding query params and hash)
+  // According to RFC 3986, backslash is not a valid character in URL paths
+  const urlBeforeQueryAndHash = normalizedUrl.split('?')[0].split('#')[0];
+  if (urlBeforeQueryAndHash.includes('\\')) {
+    // Generate suggested URL by replacing backslashes with forward slashes
+    const suggestedUrl = urlBeforeQueryAndHash.replace(/\\/g, '/');
+    const urlAfterPath = normalizedUrl.substring(urlBeforeQueryAndHash.length);
+
+    return {
+      valid: false,
+      error: 'Invalid character in URL: backslash (\\) is not allowed in URL paths',
+      suggestion: suggestedUrl + urlAfterPath
+    };
+  }
+
   // Parse the URL
   let urlObj;
   try {

package/src/hive.mjs

@@ -337,10 +337,9 @@ if (githubUrl) {
 
   if (!parsedUrl.valid) {
     console.error('Error: Invalid GitHub URL format');
-    if (parsedUrl.error) {
-      console.error(`  ${parsedUrl.error}`);
-    }
-    console.error('Expected: https://github.com/owner or https://github.com/owner/repo');
+    if (parsedUrl.error) console.error(`  ${parsedUrl.error}`);
+    if (parsedUrl.suggestion) console.error(`\n💡 Did you mean: ${parsedUrl.suggestion}`);
+    console.error('\nExpected: https://github.com/owner or https://github.com/owner/repo');
     console.error('You can use any of these formats:');
     console.error('  - https://github.com/owner');
     console.error('  - https://github.com/owner/repo');

package/src/solve.mjs

@@ -875,8 +875,42 @@ try {
       await log('\n❌ USAGE LIMIT REACHED!');
       await log('   The AI tool has reached its usage limit.');
 
-      // Post failure comment to PR if we have one
-      if (prNumber) {
+      // If --attach-logs is enabled and we have a PR, attach logs with usage limit details
+      if (shouldAttachLogs && sessionId && prNumber) {
+        await log('\n📄 Attaching logs to Pull Request...');
+        try {
+          // Build resume command
+          const resumeCommand = `${process.argv[0]} ${process.argv[1]} ${issueUrl} --resume ${sessionId}`;
+          const logUploadSuccess = await attachLogToGitHub({
+            logFile: getLogFile(),
+            targetType: 'pr',
+            targetNumber: prNumber,
+            owner,
+            repo,
+            $,
+            log,
+            sanitizeLogContent,
+            // Mark this as a usage limit case for proper formatting
+            isUsageLimit: true,
+            limitResetTime: global.limitResetTime,
+            toolName: (argv.tool || 'AI tool').toString().toLowerCase() === 'claude' ? 'Claude' :
+                      (argv.tool || 'AI tool').toString().toLowerCase() === 'codex' ? 'Codex' :
+                      (argv.tool || 'AI tool').toString().toLowerCase() === 'opencode' ? 'OpenCode' :
+                      (argv.tool || 'AI tool').toString().toLowerCase() === 'agent' ? 'Agent' : 'AI tool',
+            resumeCommand,
+            sessionId
+          });
+
+          if (logUploadSuccess) {
+            await log('  ✅ Logs uploaded successfully');
+          } else {
+            await log('  ⚠️  Failed to upload logs', { verbose: true });
+          }
+        } catch (uploadError) {
+          await log(`  ⚠️  Error uploading logs: ${uploadError.message}`, { verbose: true });
+        }
+      } else if (prNumber) {
+        // Fallback: Post simple failure comment if logs are not attached
         try {
           const resetTime = global.limitResetTime;
           const failureComment = resetTime
@@ -894,33 +928,70 @@ try {
 
       await safeExit(1, 'Usage limit reached - use --auto-continue-on-limit-reset to wait for reset');
     } else {
-      // auto-continue-on-limit-reset is enabled - post waiting comment
+      // auto-continue-on-limit-reset is enabled - attach logs and/or post waiting comment
       if (prNumber && global.limitResetTime) {
-        try {
-          // Calculate wait time in d:h:m:s format
-          const validation = await import('./solve.validation.lib.mjs');
-          const { calculateWaitTime } = validation;
-          const waitMs = calculateWaitTime(global.limitResetTime);
-
-          const formatWaitTime = (ms) => {
-            const seconds = Math.floor(ms / 1000);
-            const minutes = Math.floor(seconds / 60);
-            const hours = Math.floor(minutes / 60);
-            const days = Math.floor(hours / 24);
-            const s = seconds % 60;
-            const m = minutes % 60;
-            const h = hours % 24;
-            return `${days}:${String(h).padStart(2, '0')}:${String(m).padStart(2, '0')}:${String(s).padStart(2, '0')}`;
-          };
-
-          const waitingComment = `⏳ **Usage Limit Reached - Waiting to Continue**\n\nThe AI tool has reached its usage limit. Auto-continue is enabled with \`--auto-continue-on-limit-reset\`.\n\n**Reset time:** ${global.limitResetTime}\n**Wait time:** ${formatWaitTime(waitMs)} (days:hours:minutes:seconds)\n\nThe session will automatically resume when the limit resets.\n\nSession ID: \`${sessionId}\``;
-
-          const commentResult = await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${waitingComment}`;
-          if (commentResult.code === 0) {
-            await log('   Posted waiting comment to PR');
+        // If --attach-logs is enabled, upload logs with usage limit details
+        if (shouldAttachLogs && sessionId) {
+          await log('\n📄 Attaching logs to Pull Request (auto-continue mode)...');
+          try {
+            // Build resume command
+            const resumeCommand = `${process.argv[0]} ${process.argv[1]} ${issueUrl} --resume ${sessionId}`;
+            const logUploadSuccess = await attachLogToGitHub({
+              logFile: getLogFile(),
+              targetType: 'pr',
+              targetNumber: prNumber,
+              owner,
+              repo,
+              $,
+              log,
+              sanitizeLogContent,
+              // Mark this as a usage limit case for proper formatting
+              isUsageLimit: true,
+              limitResetTime: global.limitResetTime,
+              toolName: (argv.tool || 'AI tool').toString().toLowerCase() === 'claude' ? 'Claude' :
+                        (argv.tool || 'AI tool').toString().toLowerCase() === 'codex' ? 'Codex' :
+                        (argv.tool || 'AI tool').toString().toLowerCase() === 'opencode' ? 'OpenCode' :
+                        (argv.tool || 'AI tool').toString().toLowerCase() === 'agent' ? 'Agent' : 'AI tool',
+              resumeCommand,
+              sessionId
+            });
+
+            if (logUploadSuccess) {
+              await log('  ✅ Logs uploaded successfully');
+            } else {
+              await log('  ⚠️  Failed to upload logs', { verbose: true });
+            }
+          } catch (uploadError) {
+            await log(`  ⚠️  Error uploading logs: ${uploadError.message}`, { verbose: true });
+          }
+        } else {
+          // Fallback: Post simple waiting comment if logs are not attached
+          try {
+            // Calculate wait time in d:h:m:s format
+            const validation = await import('./solve.validation.lib.mjs');
+            const { calculateWaitTime } = validation;
+            const waitMs = calculateWaitTime(global.limitResetTime);
+
+            const formatWaitTime = (ms) => {
+              const seconds = Math.floor(ms / 1000);
+              const minutes = Math.floor(seconds / 60);
+              const hours = Math.floor(minutes / 60);
+              const days = Math.floor(hours / 24);
+              const s = seconds % 60;
+              const m = minutes % 60;
+              const h = hours % 24;
+              return `${days}:${String(h).padStart(2, '0')}:${String(m).padStart(2, '0')}:${String(s).padStart(2, '0')}`;
+            };
+
+            const waitingComment = `⏳ **Usage Limit Reached - Waiting to Continue**\n\nThe AI tool has reached its usage limit. Auto-continue is enabled with \`--auto-continue-on-limit-reset\`.\n\n**Reset time:** ${global.limitResetTime}\n**Wait time:** ${formatWaitTime(waitMs)} (days:hours:minutes:seconds)\n\nThe session will automatically resume when the limit resets.\n\nSession ID: \`${sessionId}\``;
+
+            const commentResult = await $`gh pr comment ${prNumber} --repo ${owner}/${repo} --body ${waitingComment}`;
+            if (commentResult.code === 0) {
+              await log('   Posted waiting comment to PR');
+            }
+          } catch (error) {
+            await log(`   Warning: Could not post waiting comment: ${cleanErrorMessage(error)}`, { verbose: true });
           }
-        } catch (error) {
-          await log(`   Warning: Could not post waiting comment: ${cleanErrorMessage(error)}`, { verbose: true });
         }
       }
     }

package/src/solve.validation.lib.mjs

@@ -66,10 +66,9 @@ export const validateGitHubUrl = (issueUrl) => {
 
   if (!parsedUrl.valid) {
     console.error('Error: Invalid GitHub URL format');
-    if (parsedUrl.error) {
-      console.error(`  ${parsedUrl.error}`);
-    }
-    console.error('  Please provide a valid GitHub issue or pull request URL');
+    if (parsedUrl.error) console.error(`  ${parsedUrl.error}`);
+    if (parsedUrl.suggestion) console.error(`\n💡 Did you mean: ${parsedUrl.suggestion}`);
+    console.error('\n  Please provide a valid GitHub issue or pull request URL');
     console.error('  Examples:');
     console.error('    https://github.com/owner/repo/issues/123 (issue)');
     console.error('    https://github.com/owner/repo/pull/456 (pull request)');

package/src/telegram-bot.mjs

@@ -638,7 +638,8 @@ function validateGitHubUrl(args, options = {}) {
   if (!parsed.valid) {
     return {
       valid: false,
-      error: parsed.error || 'Invalid GitHub URL'
+      error: parsed.error || 'Invalid GitHub URL',
+      suggestion: parsed.suggestion
     };
   }
 
@@ -987,7 +988,12 @@ bot.command(/^solve$/i, async (ctx) => {
 
   const validation = validateGitHubUrl(userArgs);
   if (!validation.valid) {
-    await ctx.reply(`❌ ${validation.error}\n\nExample: \`/solve https://github.com/owner/repo/issues/123\`\n\nOr reply to a message containing a GitHub link with \`/solve\``, { parse_mode: 'Markdown', reply_to_message_id: ctx.message.message_id });
+    let errorMsg = `❌ ${validation.error}`;
+    if (validation.suggestion) {
+      errorMsg += `\n\n💡 Did you mean: \`${validation.suggestion}\``;
+    }
+    errorMsg += '\n\nExample: `/solve https://github.com/owner/repo/issues/123`\n\nOr reply to a message containing a GitHub link with `/solve`';
+    await ctx.reply(errorMsg, { parse_mode: 'Markdown', reply_to_message_id: ctx.message.message_id });
     return;
   }
 
@@ -1136,7 +1142,12 @@ bot.command(/^hive$/i, async (ctx) => {
     exampleUrl: 'https://github.com/owner/repo'
   });
   if (!validation.valid) {
-    await ctx.reply(`❌ ${validation.error}\n\nExample: \`/hive https://github.com/owner/repo\``, { parse_mode: 'Markdown', reply_to_message_id: ctx.message.message_id });
+    let errorMsg = `❌ ${validation.error}`;
+    if (validation.suggestion) {
+      errorMsg += `\n\n💡 Did you mean: \`${validation.suggestion}\``;
+    }
+    errorMsg += '\n\nExample: `/hive https://github.com/owner/repo`';
+    await ctx.reply(errorMsg, { parse_mode: 'Markdown', reply_to_message_id: ctx.message.message_id });
     return;
   }