@link-assistant/agent 0.27.0 → 0.27.1

package/src/config/config.ts

@@ -56,6 +56,20 @@ export interface AgentConfig {
   disableTools: string;
   permissionMode: string;
   permission: string;
+  // Compatibility switches (issue #335): each restores the behaviour that
+  // existed before the upstream reliability fixes, or tunes a new limit.
+  bashShell: string;
+  legacyToolOutput: boolean;
+  legacyEditMatching: boolean;
+  globFollowSymlinks: boolean;
+  grepHidden: boolean;
+  grepTimeoutMs: number;
+  readMaxLines: number;
+  readMaxBytes: number;
+  legacyErrorNames: boolean;
+  legacyTokenUsage: boolean;
+  legacyLoopExit: boolean;
+  mcpConnectTimeout: number;
 }
 
 // Fallback helpers for when config is not yet initialized (early imports/tests)
@@ -68,6 +82,39 @@ function getEnvStr(key: string): string | undefined {
   return process.env[key];
 }
 
+// Boolean env var that defaults to true unless set to "false"/"0".
+function truthyEnvDefaultTrue(key: string): boolean {
+  const value = (process.env[key] ?? '').toLowerCase();
+  return !(value === 'false' || value === '0');
+}
+
+// Non-negative integer env var; falls back when unset or not a number.
+function intEnv(key: string, fallback: number): number {
+  const raw = process.env[key];
+  if (raw === undefined || raw.trim() === '') return fallback;
+  const value = parseInt(raw, 10);
+  return Number.isFinite(value) && value >= 0 ? value : fallback;
+}
+
+/**
+ * Defaults of the compatibility switches added in issue #335. Shared by the
+ * pre-init config, the yargs options and initConfig so they cannot drift.
+ */
+export const COMPAT_DEFAULTS = {
+  bashShell: 'auto',
+  legacyToolOutput: false,
+  legacyEditMatching: false,
+  globFollowSymlinks: false,
+  grepHidden: true,
+  grepTimeoutMs: 30_000,
+  readMaxLines: 2000,
+  readMaxBytes: 50 * 1024,
+  legacyErrorNames: false,
+  legacyTokenUsage: false,
+  legacyLoopExit: false,
+  mcpConnectTimeout: 30_000,
+} as const;
+
 /**
  * Default configuration values, used before initConfig() is called.
  * Falls back to direct env var reads for early-import and test scenarios.
@@ -140,6 +187,31 @@ function defaultConfig(): AgentConfig {
     disableTools: getEnvStr('LINK_ASSISTANT_AGENT_DISABLE_TOOLS') ?? '',
     permissionMode: getEnvStr('LINK_ASSISTANT_AGENT_PERMISSION_MODE') ?? 'auto',
     permission: getEnvStr('LINK_ASSISTANT_AGENT_PERMISSION') ?? '',
+    bashShell:
+      getEnvStr('LINK_ASSISTANT_AGENT_BASH_SHELL') || COMPAT_DEFAULTS.bashShell,
+    legacyToolOutput: truthyEnv('LINK_ASSISTANT_AGENT_LEGACY_TOOL_OUTPUT'),
+    legacyEditMatching: truthyEnv('LINK_ASSISTANT_AGENT_LEGACY_EDIT_MATCHING'),
+    globFollowSymlinks: truthyEnv('LINK_ASSISTANT_AGENT_GLOB_FOLLOW_SYMLINKS'),
+    grepHidden: truthyEnvDefaultTrue('LINK_ASSISTANT_AGENT_GREP_HIDDEN'),
+    grepTimeoutMs: intEnv(
+      'LINK_ASSISTANT_AGENT_GREP_TIMEOUT_MS',
+      COMPAT_DEFAULTS.grepTimeoutMs
+    ),
+    readMaxLines: intEnv(
+      'LINK_ASSISTANT_AGENT_READ_MAX_LINES',
+      COMPAT_DEFAULTS.readMaxLines
+    ),
+    readMaxBytes: intEnv(
+      'LINK_ASSISTANT_AGENT_READ_MAX_BYTES',
+      COMPAT_DEFAULTS.readMaxBytes
+    ),
+    legacyErrorNames: truthyEnv('LINK_ASSISTANT_AGENT_LEGACY_ERROR_NAMES'),
+    legacyTokenUsage: truthyEnv('LINK_ASSISTANT_AGENT_LEGACY_TOKEN_USAGE'),
+    legacyLoopExit: truthyEnv('LINK_ASSISTANT_AGENT_LEGACY_LOOP_EXIT'),
+    mcpConnectTimeout: intEnv(
+      'LINK_ASSISTANT_AGENT_MCP_CONNECT_TIMEOUT',
+      COMPAT_DEFAULTS.mcpConnectTimeout
+    ),
   };
 }
 
@@ -169,111 +241,216 @@ function buildAgentConfigOptions({
   yargs: any;
   getenv: (key: string, defaultValue: any) => any;
 }) {
-  return yargs
-    .option('verbose', {
-      type: 'boolean',
-      description: 'Enable verbose mode to debug API requests',
-      default: getenv('LINK_ASSISTANT_AGENT_VERBOSE', false),
-    })
-    .option('dry-run', {
-      type: 'boolean',
-      description: 'Simulate operations without making actual API calls',
-      default: getenv('LINK_ASSISTANT_AGENT_DRY_RUN', false),
-    })
-    .option('generate-title', {
-      type: 'boolean',
-      description: 'Generate session titles using AI',
-      default: getenv('LINK_ASSISTANT_AGENT_GENERATE_TITLE', false),
-    })
-    .option('output-response-model', {
-      type: 'boolean',
-      description: 'Include model info in step_finish output',
-      default: getenv('LINK_ASSISTANT_AGENT_OUTPUT_RESPONSE_MODEL', true),
-    })
-    .option('summarize-session', {
-      type: 'boolean',
-      description: 'Generate AI session summaries',
-      default: getenv('LINK_ASSISTANT_AGENT_SUMMARIZE_SESSION', true),
-    })
-    .option('retry-on-rate-limits', {
-      type: 'boolean',
-      description: 'Retry API requests when rate limited (HTTP 429)',
-      default: true,
-    })
-    .option('compact-json', {
-      type: 'boolean',
-      description:
-        'Output compact JSON (single line) instead of pretty-printed',
-      default: getenv('LINK_ASSISTANT_AGENT_COMPACT_JSON', false),
-    })
-    .option('retry-timeout', {
-      type: 'number',
-      description: 'Maximum total retry time in seconds for rate limit errors',
-      default: getenv('LINK_ASSISTANT_AGENT_RETRY_TIMEOUT', 604800),
-    })
-    .option('max-retry-delay', {
-      type: 'number',
-      description: 'Maximum delay between retries in seconds',
-      default: getenv('LINK_ASSISTANT_AGENT_MAX_RETRY_DELAY', 1200),
-    })
-    .option('min-retry-interval', {
-      type: 'number',
-      description: 'Minimum interval between retries in seconds',
-      default: getenv('LINK_ASSISTANT_AGENT_MIN_RETRY_INTERVAL', 30),
-    })
-    .option('stream-chunk-timeout-ms', {
-      type: 'number',
-      description: 'Timeout for individual stream chunks in milliseconds',
-      default: getenv('LINK_ASSISTANT_AGENT_STREAM_CHUNK_TIMEOUT_MS', 120000),
-    })
-    .option('stream-step-timeout-ms', {
-      type: 'number',
-      description: 'Timeout for stream steps in milliseconds',
-      default: getenv('LINK_ASSISTANT_AGENT_STREAM_STEP_TIMEOUT_MS', 600000),
-    })
-    .option('mcp-default-tool-call-timeout', {
-      type: 'number',
-      description: 'Default MCP tool call timeout in milliseconds',
-      default: getenv(
-        'LINK_ASSISTANT_AGENT_MCP_DEFAULT_TOOL_CALL_TIMEOUT',
-        120000
-      ),
-    })
-    .option('mcp-max-tool-call-timeout', {
-      type: 'number',
-      description: 'Maximum MCP tool call timeout in milliseconds',
-      default: getenv('LINK_ASSISTANT_AGENT_MCP_MAX_TOOL_CALL_TIMEOUT', 600000),
-    })
-    .option('verify-images-at-read-tool', {
-      type: 'boolean',
-      description: 'Verify images when using the read tool',
-      default: getenv('LINK_ASSISTANT_AGENT_VERIFY_IMAGES_AT_READ_TOOL', true),
-    })
-    .option('read-only', {
-      type: 'boolean',
-      description:
-        'Enforceable read-only / planning mode. Disables all filesystem-mutating and shell tools (bash, edit, write, multiedit, patch).',
-      default: getenv('LINK_ASSISTANT_AGENT_READ_ONLY', false),
-    })
-    .option('disable-tools', {
-      type: 'string',
-      description:
-        'Comma-separated list of tool ids to disable (e.g. "bash,write,edit"). Disabled tools are never exposed to the model and are rejected if invoked via batch.',
-      default: getenv('LINK_ASSISTANT_AGENT_DISABLE_TOOLS', ''),
-    })
-    .option('permission-mode', {
-      type: 'string',
-      choices: ['auto', 'plan', 'readonly', 'ask'],
-      description:
-        'Permission policy for mutating tools. "auto" (default) allows everything; "plan" allows read-only shell and asks before mutations; "readonly" denies all mutations; "ask" asks before every mutating tool. Approvals are driven over JSON (permission_request / permission_response).',
-      default: getenv('LINK_ASSISTANT_AGENT_PERMISSION_MODE', 'auto'),
-    })
-    .option('permission', {
-      type: 'string',
-      description:
-        'OpenCode-compatible permission override as JSON, merged on top of --permission-mode. Example: \'{"edit":"ask","bash":{"git push*":"ask","*":"allow"},"webfetch":"allow"}\'.',
-      default: getenv('LINK_ASSISTANT_AGENT_PERMISSION', ''),
-    });
+  return (
+    yargs
+      .option('verbose', {
+        type: 'boolean',
+        description: 'Enable verbose mode to debug API requests',
+        default: getenv('LINK_ASSISTANT_AGENT_VERBOSE', false),
+      })
+      .option('dry-run', {
+        type: 'boolean',
+        description: 'Simulate operations without making actual API calls',
+        default: getenv('LINK_ASSISTANT_AGENT_DRY_RUN', false),
+      })
+      .option('generate-title', {
+        type: 'boolean',
+        description: 'Generate session titles using AI',
+        default: getenv('LINK_ASSISTANT_AGENT_GENERATE_TITLE', false),
+      })
+      .option('output-response-model', {
+        type: 'boolean',
+        description: 'Include model info in step_finish output',
+        default: getenv('LINK_ASSISTANT_AGENT_OUTPUT_RESPONSE_MODEL', true),
+      })
+      .option('summarize-session', {
+        type: 'boolean',
+        description: 'Generate AI session summaries',
+        default: getenv('LINK_ASSISTANT_AGENT_SUMMARIZE_SESSION', true),
+      })
+      .option('retry-on-rate-limits', {
+        type: 'boolean',
+        description: 'Retry API requests when rate limited (HTTP 429)',
+        default: true,
+      })
+      .option('compact-json', {
+        type: 'boolean',
+        description:
+          'Output compact JSON (single line) instead of pretty-printed',
+        default: getenv('LINK_ASSISTANT_AGENT_COMPACT_JSON', false),
+      })
+      .option('retry-timeout', {
+        type: 'number',
+        description:
+          'Maximum total retry time in seconds for rate limit errors',
+        default: getenv('LINK_ASSISTANT_AGENT_RETRY_TIMEOUT', 604800),
+      })
+      .option('max-retry-delay', {
+        type: 'number',
+        description: 'Maximum delay between retries in seconds',
+        default: getenv('LINK_ASSISTANT_AGENT_MAX_RETRY_DELAY', 1200),
+      })
+      .option('min-retry-interval', {
+        type: 'number',
+        description: 'Minimum interval between retries in seconds',
+        default: getenv('LINK_ASSISTANT_AGENT_MIN_RETRY_INTERVAL', 30),
+      })
+      .option('stream-chunk-timeout-ms', {
+        type: 'number',
+        description: 'Timeout for individual stream chunks in milliseconds',
+        default: getenv('LINK_ASSISTANT_AGENT_STREAM_CHUNK_TIMEOUT_MS', 120000),
+      })
+      .option('stream-step-timeout-ms', {
+        type: 'number',
+        description: 'Timeout for stream steps in milliseconds',
+        default: getenv('LINK_ASSISTANT_AGENT_STREAM_STEP_TIMEOUT_MS', 600000),
+      })
+      .option('mcp-default-tool-call-timeout', {
+        type: 'number',
+        description: 'Default MCP tool call timeout in milliseconds',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_MCP_DEFAULT_TOOL_CALL_TIMEOUT',
+          120000
+        ),
+      })
+      .option('mcp-max-tool-call-timeout', {
+        type: 'number',
+        description: 'Maximum MCP tool call timeout in milliseconds',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_MCP_MAX_TOOL_CALL_TIMEOUT',
+          600000
+        ),
+      })
+      .option('verify-images-at-read-tool', {
+        type: 'boolean',
+        description: 'Verify images when using the read tool',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_VERIFY_IMAGES_AT_READ_TOOL',
+          true
+        ),
+      })
+      .option('read-only', {
+        type: 'boolean',
+        description:
+          'Enforceable read-only / planning mode. Disables all filesystem-mutating and shell tools (bash, edit, write, multiedit, patch).',
+        default: getenv('LINK_ASSISTANT_AGENT_READ_ONLY', false),
+      })
+      .option('disable-tools', {
+        type: 'string',
+        description:
+          'Comma-separated list of tool ids to disable (e.g. "bash,write,edit"). Disabled tools are never exposed to the model and are rejected if invoked via batch.',
+        default: getenv('LINK_ASSISTANT_AGENT_DISABLE_TOOLS', ''),
+      })
+      .option('permission-mode', {
+        type: 'string',
+        choices: ['auto', 'plan', 'readonly', 'ask'],
+        description:
+          'Permission policy for mutating tools. "auto" (default) allows everything; "plan" allows read-only shell and asks before mutations; "readonly" denies all mutations; "ask" asks before every mutating tool. Approvals are driven over JSON (permission_request / permission_response).',
+        default: getenv('LINK_ASSISTANT_AGENT_PERMISSION_MODE', 'auto'),
+      })
+      .option('permission', {
+        type: 'string',
+        description:
+          'OpenCode-compatible permission override as JSON, merged on top of --permission-mode. Example: \'{"edit":"ask","bash":{"git push*":"ask","*":"allow"},"webfetch":"allow"}\'.',
+        default: getenv('LINK_ASSISTANT_AGENT_PERMISSION', ''),
+      })
+      // ─── Compatibility switches (issue #335) ───────────────────────────────
+      .option('bash-shell', {
+        type: 'string',
+        description:
+          'Shell used by the bash tool. "auto" (default) uses $SHELL when it is a POSIX shell (sh, bash, zsh, dash, ksh, mksh, ash), else bash, else /bin/sh; "legacy" uses the platform default shell (/bin/sh) as before; any other value is used as the shell path.',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_BASH_SHELL',
+          COMPAT_DEFAULTS.bashShell
+        ),
+      })
+      .option('legacy-tool-output', {
+        type: 'boolean',
+        description:
+          'Restore the previous tool output formats: empty output from edit/write, head-truncated bash output, and an empty result instead of an error when read starts past the end of a file.',
+        default: getenv('LINK_ASSISTANT_AGENT_LEGACY_TOOL_OUTPUT', false),
+      })
+      .option('legacy-edit-matching', {
+        type: 'boolean',
+        description:
+          'Restore the previous edit matching: an empty oldString overwrites an existing file, and fuzzy block matching uses the old loose thresholds without the size guard.',
+        default: getenv('LINK_ASSISTANT_AGENT_LEGACY_EDIT_MATCHING', false),
+      })
+      .option('glob-follow-symlinks', {
+        type: 'boolean',
+        description:
+          'Follow symlinked directories in glob and ls (previous behaviour).',
+        default: getenv('LINK_ASSISTANT_AGENT_GLOB_FOLLOW_SYMLINKS', false),
+      })
+      .option('grep-hidden', {
+        type: 'boolean',
+        description:
+          'Search hidden files and directories in grep (default true; .git is always skipped). Use --no-grep-hidden for the previous behaviour.',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_GREP_HIDDEN',
+          COMPAT_DEFAULTS.grepHidden
+        ),
+      })
+      .option('grep-timeout-ms', {
+        type: 'number',
+        description:
+          'Timeout for one grep search in milliseconds (0 = no timeout)',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_GREP_TIMEOUT_MS',
+          COMPAT_DEFAULTS.grepTimeoutMs
+        ),
+      })
+      .option('read-max-lines', {
+        type: 'number',
+        description:
+          'Maximum number of lines one read call may return (0 = no cap on the limit parameter)',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_READ_MAX_LINES',
+          COMPAT_DEFAULTS.readMaxLines
+        ),
+      })
+      .option('read-max-bytes', {
+        type: 'number',
+        description:
+          'Maximum bytes of file content one read call may return (0 = no cap)',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_READ_MAX_BYTES',
+          COMPAT_DEFAULTS.readMaxBytes
+        ),
+      })
+      .option('legacy-error-names', {
+        type: 'boolean',
+        description:
+          'Report errors in JSON output under their previous names (ContextOverflowError is reported as APIError).',
+        default: getenv('LINK_ASSISTANT_AGENT_LEGACY_ERROR_NAMES', false),
+      })
+      .option('legacy-token-usage', {
+        type: 'boolean',
+        description:
+          'Report tokens.output including reasoning tokens and compute cost from it, as before.',
+        default: getenv('LINK_ASSISTANT_AGENT_LEGACY_TOKEN_USAGE', false),
+      })
+      .option('legacy-loop-exit', {
+        type: 'boolean',
+        description:
+          'End the turn on any finish reason other than tool-calls/unknown, even if tools ran in that step (previous behaviour).',
+        default: getenv('LINK_ASSISTANT_AGENT_LEGACY_LOOP_EXIT', false),
+      })
+      .option('mcp-connect-timeout', {
+        type: 'number',
+        description:
+          'Default timeout in milliseconds for connecting to and initializing an MCP server (per-server "connect_timeout" overrides it; 0 = no timeout)',
+        default: getenv(
+          'LINK_ASSISTANT_AGENT_MCP_CONNECT_TIMEOUT',
+          COMPAT_DEFAULTS.mcpConnectTimeout
+        ),
+      })
+  );
+}
+
+function nonNegative(value: unknown, fallback: number): number {
+  const n = typeof value === 'string' ? parseInt(value, 10) : value;
+  return typeof n === 'number' && Number.isFinite(n) && n >= 0 ? n : fallback;
 }
 
 /**
@@ -329,6 +506,30 @@ export function initConfig(argv?: string[]): AgentConfig {
     disableTools: parsed.disableTools ?? '',
     permissionMode: parsed.permissionMode ?? 'auto',
     permission: parsed.permission ?? '',
+    bashShell: parsed.bashShell || COMPAT_DEFAULTS.bashShell,
+    legacyToolOutput: parsed.legacyToolOutput ?? false,
+    legacyEditMatching: parsed.legacyEditMatching ?? false,
+    globFollowSymlinks: parsed.globFollowSymlinks ?? false,
+    grepHidden: parsed.grepHidden ?? COMPAT_DEFAULTS.grepHidden,
+    grepTimeoutMs: nonNegative(
+      parsed.grepTimeoutMs,
+      COMPAT_DEFAULTS.grepTimeoutMs
+    ),
+    readMaxLines: nonNegative(
+      parsed.readMaxLines,
+      COMPAT_DEFAULTS.readMaxLines
+    ),
+    readMaxBytes: nonNegative(
+      parsed.readMaxBytes,
+      COMPAT_DEFAULTS.readMaxBytes
+    ),
+    legacyErrorNames: parsed.legacyErrorNames ?? false,
+    legacyTokenUsage: parsed.legacyTokenUsage ?? false,
+    legacyLoopExit: parsed.legacyLoopExit ?? false,
+    mcpConnectTimeout: nonNegative(
+      parsed.mcpConnectTimeout,
+      COMPAT_DEFAULTS.mcpConnectTimeout
+    ),
   });
 
   // Propagate verbose to env var for subprocess resilience (issue #227).

package/src/config/defaults.ts

@@ -15,29 +15,37 @@ export interface DefaultConfigOptions {
   defaultCompactionSafetyMarginPercent?: number | string | null;
 }
 
-/** Default model used when no `--model` CLI argument is provided. */
-export const DEFAULT_MODEL = 'kilo/nemotron-3-super-free';
+/**
+ * Default model used when no `--model` CLI argument is provided.
+ *
+ * Kilo withdrew the free Nemotron 3 Super route; `kilo/nemotron-3-super-free`
+ * is now a deprecated alias for this model (#335).
+ */
+export const DEFAULT_MODEL = 'kilo/nemotron-3-ultra-free';
 
 /** Env var for overriding the default model in test runs and automation. */
 export const DEFAULT_MODEL_ENV = 'LINK_ASSISTANT_AGENT_DEFAULT_MODEL';
 
 /** Default compaction model used when no `--compaction-model` CLI argument is provided. */
-export const DEFAULT_COMPACTION_MODEL = 'kilo/nemotron-3-super-free';
+export const DEFAULT_COMPACTION_MODEL = 'kilo/nemotron-3-ultra-free';
 
 /** Env var for overriding the default compaction model in test runs and automation. */
 export const DEFAULT_COMPACTION_MODEL_ENV =
   'LINK_ASSISTANT_AGENT_DEFAULT_COMPACTION_MODEL';
 
 /**
- * Free Kilo models ordered by context capacity, followed by the session model.
+ * Served free Kilo models, followed by the session model. Both Kilo entries
+ * have a 1M-token context, so the order is the preferred model first, then
+ * the rate-limit fallback.
  * Compaction skips models whose context is too small or which hit a rate limit.
  * Provider prefixes keep default secondary calls away from Zen's restricted tier.
  * The special value "same" uses the model running the session.
  *
  * @see https://github.com/link-assistant/agent/issues/327
+ * @see https://github.com/link-assistant/agent/issues/335
  */
 export const DEFAULT_COMPACTION_MODELS =
-  '(kilo/nemotron-3-super-free kilo/nemotron-3-ultra-free kilo/nemotron-3.5-lightning-free same)';
+  '(kilo/nemotron-3-ultra-free kilo/nemotron-3.5-lightning-free same)';
 
 /** Env var for overriding the default compaction cascade in test runs and automation. */
 export const DEFAULT_COMPACTION_MODELS_ENV =

package/src/config/file-config.ts

@@ -435,6 +435,14 @@ export namespace Config {
         .describe(
           'Timeout in ms for fetching tools from the MCP server. Defaults to 5000 (5 seconds) if not specified.'
         ),
+      connect_timeout: z
+        .number()
+        .int()
+        .nonnegative()
+        .optional()
+        .describe(
+          'Timeout in ms for starting the MCP server and completing the initialize handshake. Defaults to --mcp-connect-timeout / LINK_ASSISTANT_AGENT_MCP_CONNECT_TIMEOUT (30000). 0 disables the bound.'
+        ),
       tool_call_timeout: z
         .number()
         .int()
@@ -475,6 +483,14 @@ export namespace Config {
         .describe(
           'Timeout in ms for fetching tools from the MCP server. Defaults to 5000 (5 seconds) if not specified.'
         ),
+      connect_timeout: z
+        .number()
+        .int()
+        .nonnegative()
+        .optional()
+        .describe(
+          'Timeout in ms for starting the MCP server and completing the initialize handshake. Defaults to --mcp-connect-timeout / LINK_ASSISTANT_AGENT_MCP_CONNECT_TIMEOUT (30000). 0 disables the bound.'
+        ),
       tool_call_timeout: z
         .number()
         .int()

package/src/file/ripgrep.ts

@@ -10,6 +10,7 @@ import { $ } from 'bun';
 import { ZipReader, BlobReader, BlobWriter } from '@zip.js/zip.js';
 import { Log } from '../util/log';
 import { createVerboseFetch } from '../util/verbose-fetch';
+import { config as agentConfig } from '../config/config';
 
 export namespace Ripgrep {
   const log = Log.create({ service: 'ripgrep' });
@@ -217,14 +218,26 @@ export namespace Ripgrep {
     return filepath;
   }
 
-  export async function* files(input: { cwd: string; glob?: string[] }) {
+  export async function* files(input: {
+    cwd: string;
+    glob?: string[];
+    signal?: AbortSignal;
+    follow?: boolean;
+  }) {
+    input.signal?.throwIfAborted();
+
+    // No `--follow` by default: following symlinked directories can walk huge
+    // or cyclic trees (upstream c0e71c4261 #11415). --glob-follow-symlinks /
+    // LINK_ASSISTANT_AGENT_GLOB_FOLLOW_SYMLINKS restores it. `--no-config`
+    // keeps a user's RIPGREP_CONFIG_PATH from changing the output we parse.
     const args = [
       await filepath(),
       '--files',
-      '--follow',
       '--hidden',
+      '--no-config',
       '--glob=!.git/*',
     ];
+    if (input.follow ?? agentConfig.globFollowSymlinks) args.push('--follow');
     if (input.glob) {
       for (const g of input.glob) {
         args.push(`--glob=${g}`);
@@ -233,7 +246,8 @@ export namespace Ripgrep {
 
     // Bun.spawn should throw this, but it incorrectly reports that the executable does not exist.
     // See https://github.com/oven-sh/bun/issues/24012
-    if (!(await fs.stat(input.cwd).catch(() => undefined))?.isDirectory()) {
+    const info = await fs.stat(input.cwd).catch(() => undefined);
+    if (!info) {
       throw Object.assign(
         new Error(`No such file or directory: '${input.cwd}'`),
         {
@@ -243,12 +257,24 @@ export namespace Ripgrep {
         }
       );
     }
+    // upstream f753103e82 (#38890)
+    if (!info.isDirectory()) {
+      throw Object.assign(
+        new Error(`Search path is not a directory: ${input.cwd}`),
+        {
+          code: 'ENOTDIR',
+          errno: -20,
+          path: input.cwd,
+        }
+      );
+    }
 
     const proc = Bun.spawn(args, {
       cwd: input.cwd,
       stdout: 'pipe',
       stderr: 'ignore',
       maxBuffer: 1024 * 1024 * 20,
+      signal: input.signal,
     });
 
     const reader = proc.stdout.getReader();
@@ -257,11 +283,13 @@ export namespace Ripgrep {
 
     try {
       while (true) {
+        input.signal?.throwIfAborted();
         const { done, value } = await reader.read();
         if (done) break;
 
         buffer += decoder.decode(value, { stream: true });
-        const lines = buffer.split('\n');
+        // Handle both Unix (\n) and Windows (\r\n) line endings (upstream 5af35117db)
+        const lines = buffer.split(/\r?\n/);
         buffer = lines.pop() || '';
 
         for (const line of lines) {
@@ -271,7 +299,12 @@ export namespace Ripgrep {
 
       if (buffer) yield buffer;
     } finally {
-      reader.releaseLock();
+      // The consumer may stop early (glob/ls stop at 100 results). Waiting
+      // for rg to exit without draining its stdout deadlocks once the pipe
+      // buffer is full, so cancel the stream and kill rg first (upstream
+      // e5b33f8a5e #10833, 76ee87ead8, 3bda0ce123).
+      await reader.cancel().catch(() => {});
+      if (proc.exitCode === null) proc.kill();
       await proc.exited;
     }
   }