@link-assistant/agent 0.16.8 → 0.16.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@link-assistant/agent",
-  "version": "0.16.8",
+  "version": "0.16.10",
   "description": "A minimal, public domain AI CLI agent compatible with OpenCode's JSON interface. Bun-only runtime.",
   "main": "src/index.js",
   "type": "module",

package/src/cli/output.ts

@@ -62,16 +62,62 @@ export function isCompactJson(): boolean {
 }
 
 /**
- * Format a message as JSON string
+ * Safe JSON replacer that handles cyclic references and non-serializable values.
+ * Returns a replacer function that tracks seen objects to detect cycles.
+ *
+ * @see https://github.com/link-assistant/agent/issues/200
+ */
+function createSafeReplacer(): (key: string, value: unknown) => unknown {
+  const seen = new WeakSet();
+  return (_key: string, value: unknown) => {
+    if (typeof value === 'object' && value !== null) {
+      if (seen.has(value)) {
+        return '[Circular]';
+      }
+      seen.add(value);
+    }
+    // Convert Error objects to plain objects
+    if (value instanceof Error) {
+      return {
+        name: value.name,
+        message: value.message,
+        stack: value.stack,
+        ...(value.cause ? { cause: value.cause } : {}),
+      };
+    }
+    // Handle BigInt (not JSON-serializable by default)
+    if (typeof value === 'bigint') {
+      return value.toString();
+    }
+    return value;
+  };
+}
+
+/**
+ * Format a message as JSON string.
+ * Handles cyclic references and non-serializable values safely.
+ *
  * @param message - The message object to format
  * @param compact - Override the global compact setting
+ * @see https://github.com/link-assistant/agent/issues/200
  */
 export function formatJson(message: OutputMessage, compact?: boolean): string {
-  // Check local, global, and Flag settings for compact mode
   const useCompact = compact ?? isCompactJson();
-  return useCompact
-    ? JSON.stringify(message)
-    : JSON.stringify(message, null, 2);
+  try {
+    return useCompact
+      ? JSON.stringify(message, createSafeReplacer())
+      : JSON.stringify(message, createSafeReplacer(), 2);
+  } catch (_e) {
+    // Last resort fallback - should never happen with safe replacer
+    const fallback: OutputMessage = {
+      type: message.type ?? 'error',
+      message: 'Failed to serialize output',
+      serializationError: _e instanceof Error ? _e.message : String(_e),
+    };
+    return useCompact
+      ? JSON.stringify(fallback)
+      : JSON.stringify(fallback, null, 2);
+  }
 }
 
 /**

package/src/index.js

@@ -54,29 +54,88 @@ try {
 // Track if any errors occurred during execution
 let hasError = false;
 
+// Intercept stderr writes to ensure ALL output is JSON (#200)
+// Bun runtime may print errors in plain text format (e.g., stack traces with source code)
+// This interceptor wraps any non-JSON stderr output in a JSON envelope
+const originalStderrWrite = process.stderr.write.bind(process.stderr);
+process.stderr.write = function (chunk, encoding, callback) {
+  const str = typeof chunk === 'string' ? chunk : chunk.toString();
+  const trimmed = str.trim();
+  if (!trimmed) {
+    return originalStderrWrite(chunk, encoding, callback);
+  }
+
+  // Check if it's already valid JSON
+  if (trimmed.startsWith('{') || trimmed.startsWith('[')) {
+    try {
+      JSON.parse(trimmed);
+      // Already JSON, pass through
+      return originalStderrWrite(chunk, encoding, callback);
+    } catch (_e) {
+      // Not valid JSON, wrap it
+    }
+  }
+
+  // Wrap non-JSON stderr output in JSON envelope
+  const wrapped = `${JSON.stringify({
+    type: 'error',
+    errorType: 'RuntimeError',
+    message: trimmed,
+  })}\n`;
+  return originalStderrWrite(wrapped, encoding, callback);
+};
+
 // Install global error handlers to ensure non-zero exit codes
+// All output is JSON to ensure machine-parsability (#200)
 process.on('uncaughtException', (error) => {
   hasError = true;
-  outputError({
-    errorType: error.name || 'UncaughtException',
-    message: error.message,
-    stack: error.stack,
-  });
+  try {
+    outputError({
+      errorType: error?.name || 'UncaughtException',
+      message: error?.message || String(error),
+      stack: error?.stack,
+      ...(error?.cause ? { cause: String(error.cause) } : {}),
+    });
+  } catch (_serializationError) {
+    // Last resort: write minimal JSON directly to stderr
+    process.stderr.write(
+      `${JSON.stringify({
+        type: 'error',
+        errorType: 'UncaughtException',
+        message: String(error),
+      })}\n`
+    );
+  }
   process.exit(1);
 });
 
 process.on('unhandledRejection', (reason, _promise) => {
   hasError = true;
-  const errorOutput = {
-    errorType: 'UnhandledRejection',
-    message: reason?.message || String(reason),
-    stack: reason?.stack,
-  };
-  // If the error has a data property with a suggestion (e.g., ProviderModelNotFoundError), add it as a hint
-  if (reason?.data?.suggestion) {
-    errorOutput.hint = reason.data.suggestion;
+  try {
+    const errorOutput = {
+      errorType: 'UnhandledRejection',
+      message: reason?.message || String(reason),
+      stack: reason?.stack,
+    };
+    // If the error has a data property with a suggestion (e.g., ProviderModelNotFoundError), add it as a hint
+    if (reason?.data?.suggestion) {
+      errorOutput.hint = reason.data.suggestion;
+    }
+    // Include error data for debugging (#200)
+    if (reason?.data) {
+      errorOutput.data = reason.data;
+    }
+    outputError(errorOutput);
+  } catch (_serializationError) {
+    // Last resort: write minimal JSON directly to stderr
+    process.stderr.write(
+      `${JSON.stringify({
+        type: 'error',
+        errorType: 'UnhandledRejection',
+        message: String(reason),
+      })}\n`
+    );
   }
-  outputError(errorOutput);
   process.exit(1);
 });
 

package/src/provider/models.ts

@@ -83,7 +83,7 @@ export namespace ModelsDev {
    *
    * This prevents ProviderModelNotFoundError when:
    * - User runs agent for the first time (no cache)
-   * - User has outdated cache missing new models like kimi-k2.5-free
+   * - User has outdated cache missing new models like glm-5-free
    *
    * @see https://github.com/link-assistant/agent/issues/175
    */

package/src/provider/provider.ts

@@ -1416,21 +1416,70 @@ export namespace Provider {
       providerID === 'link-assistant' || providerID === 'link-assistant/cache';
 
     // For synthetic providers, we don't need model info from the database
-    const info = isSyntheticProvider ? null : provider.info.models[modelID];
+    let info = isSyntheticProvider ? null : provider.info.models[modelID];
     if (!isSyntheticProvider && !info) {
+      // Model not in provider's known list - try refreshing the cache first (#200)
+      // This handles stale bundled data or expired cache (1-hour TTL)
+      log.info(() => ({
+        message: 'model not in catalog - refreshing models cache',
+        providerID,
+        modelID,
+      }));
+      try {
+        await ModelsDev.refresh();
+        const freshDB = await ModelsDev.get();
+        const freshProvider = freshDB[providerID];
+        if (freshProvider?.models[modelID]) {
+          // Model found after refresh - update provider info and use it
+          provider.info.models[modelID] = freshProvider.models[modelID];
+          info = freshProvider.models[modelID];
+          log.info(() => ({
+            message: 'model found after cache refresh',
+            providerID,
+            modelID,
+          }));
+        }
+      } catch (refreshError) {
+        log.warn(() => ({
+          message: 'cache refresh failed',
+          error:
+            refreshError instanceof Error
+              ? refreshError.message
+              : String(refreshError),
+        }));
+      }
+    }
+
+    if (!isSyntheticProvider && !info) {
+      // Still not found after refresh - create fallback info and try anyway
+      // Provider may support unlisted models
       const availableInProvider = Object.keys(provider.info.models).slice(
         0,
         10
       );
-      const suggestion = `Model "${modelID}" not found in provider "${providerID}". Available models: ${availableInProvider.join(', ')}${Object.keys(provider.info.models).length > 10 ? ` (and ${Object.keys(provider.info.models).length - 10} more)` : ''}.`;
-      log.error(() => ({
-        message: 'model not found in provider',
+      log.warn(() => ({
+        message:
+          'model not in provider catalog after refresh - attempting anyway (may be unlisted)',
         providerID,
         modelID,
         availableModels: availableInProvider,
         totalModels: Object.keys(provider.info.models).length,
       }));
-      throw new ModelNotFoundError({ providerID, modelID, suggestion });
+
+      // Create a minimal fallback model info so SDK loading can proceed
+      // Use sensible defaults - the provider will reject if the model truly doesn't exist
+      info = {
+        id: modelID,
+        name: modelID,
+        release_date: '',
+        attachment: false,
+        reasoning: false,
+        temperature: true,
+        tool_call: true,
+        cost: { input: 0, output: 0 },
+        limit: { context: 128000, output: 16384 },
+        options: {},
+      } as ModelsDev.Model;
     }
 
     try {

package/src/session/prompt.ts

@@ -362,10 +362,24 @@ export namespace SessionPrompt {
 
       let model;
       try {
+        // Log model resolution attempt for debugging (#200)
+        log.info(() => ({
+          message: 'resolving model',
+          providerID: lastUser.model.providerID,
+          modelID: lastUser.model.modelID,
+          sessionID,
+          step,
+        }));
         model = await Provider.getModel(
           lastUser.model.providerID,
           lastUser.model.modelID
         );
+        log.info(() => ({
+          message: 'model resolved successfully',
+          providerID: lastUser.model.providerID,
+          modelID: lastUser.model.modelID,
+          resolvedModelID: model.language?.modelId,
+        }));
       } catch (error) {
         // When an explicit provider is specified, do NOT silently fall back to default
         // This ensures user's explicit choice is respected
@@ -376,6 +390,8 @@ export namespace SessionPrompt {
           providerID: lastUser.model.providerID,
           modelID: lastUser.model.modelID,
           error: error instanceof Error ? error.message : String(error),
+          stack: error instanceof Error ? error.stack : undefined,
+          hint: 'Check that the model exists in the provider. Use --verbose for more details.',
         }));
         // Re-throw the error so it can be handled by the caller
         throw error;