@linimin/pi-letscook 0.1.52 → 0.1.54

package/CHANGELOG.md

@@ -2,6 +2,25 @@
 
 ## Unreleased
 
+### Changed
+
+- removed workflow-aware prompt interception so only explicit `/cook` or `/cook <hint>` enters the workflow; ordinary prompts now always stay on the main chat path
+- updated docs and release checks to describe explicit `/cook` entry instead of router-managed natural-language takeover
+
+## 0.1.54
+
+### Changed
+
+- removed workflow-aware prompt interception so only explicit `/cook` or `/cook <hint>` enters the workflow; ordinary prompts now always stay on the main chat path
+- updated docs and release checks to describe explicit `/cook` entry instead of router-managed natural-language takeover
+
+## 0.1.53
+
+### Changed
+
+- removed assist mode from public routing behavior so natural-language entry is now either off or router, and made router the default trigger mode while keeping `/cook` as the canonical workflow boundary
+- removed obsolete cook planning docs that no longer match the shipped router-only workflow entry behavior
+
 ## 0.1.52
 
 ### Changed

package/README.md

@@ -2,7 +2,7 @@
 
 `/cook` turns main-chat discussion about concrete repo changes into a resumable repo workflow stored in repo-local `.agent/**` state.
 
-Natural-language routing is optional and shipped in three modes: `off` disables it, `assist` offers short confirm-first handoffs after clear workflow discussion, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat. In every mode, `/cook` remains the canonical workflow boundary and manual fallback.
+`/cook` is the explicit workflow boundary for starting, continuing, refocusing, or beginning the next round of long-running repo work.
 
 ## Use it when
 
@@ -46,10 +46,8 @@ Then run `/reload` in Pi.
 |---|---|
 | Start a long-running task | Discuss the concrete repo change in the main chat, then run `/cook` |
 | Bias mission detection toward one intent | Run `/cook <hint>` |
-| Change natural-language routing behavior | Set `PI_COMPLETION_TRIGGER_MODE=off`, `assist`, or `router` before starting Pi |
-| Hand off from discussion into the same `/cook` flow | In `assist`, say `開始做`, `開始實作`, or `go ahead`, then accept the confirmation |
 | Continue the current workflow | Run `/cook` |
-| Use the canonical fallback when natural-language routing does not fire or you want to bypass it | Run `/cook` explicitly |
+| Refocus or start the next round | Discuss the new concrete repo change in the main chat, then run `/cook` |
 
 ## What `/cook` expects
 
@@ -61,20 +59,14 @@ Then run `/reload` in Pi.
 
 If recent discussion is missing, weak, ambiguous, assistant-produced, or only describes planning artifacts instead of concrete repo changes, `/cook` fails closed, leaves canonical `.agent/**` state unchanged, and tells you to clarify the mission in the main chat before rerunning `/cook`.
 
-## Natural-language routing modes
+## Workflow entry
 
-Set `PI_COMPLETION_TRIGGER_MODE` before starting Pi if you want to change how natural-language routing behaves:
-
-- `off` — natural-language routing is disabled. Only explicit `/cook` or `/cook <hint>` can enter the workflow.
-- `assist` *(default)* — after clear discussion of a concrete repo change, short execution handoff phrases such as `開始做`, `開始實作`, or `go ahead` can offer to enter the same `/cook` flow before the primary agent starts implementation work.
-- `router` — the workflow-aware router reviews each non-bypass normal user turn before implementation starts. Ordinary questions stay in the main chat, while direct start/resume/refocus/next-round prompts can offer the shared `/cook` flow with confirmation or clarification.
+Only explicit `/cook` or `/cook <hint>` enters the workflow. Ordinary prompts stay in the main chat and go straight to the primary agent.
 
 Important behavior:
-- natural-language routing is only a shortcut into `/cook`; `/cook` is still the canonical workflow boundary and manual fallback
+- `/cook` is the canonical workflow boundary and manual entry point
 - startup, refocus, and next-round routing stay confirm-first; nothing silently starts a workflow
-- unclear router offers and classifier recovery stay fail-closed
-- in router mode, the original message only reaches the normal chat path if you explicitly choose **Send as normal chat**
-- explicit slash commands and ordinary main-chat questions continue normally unless you choose the workflow boundary
+- explicit slash commands other than `/cook` continue normally in the main chat
 
 ## Typical examples
 
@@ -91,16 +83,9 @@ Bias proposal derivation toward a specific intent:
 /cook login redirect
 ```
 
-Hand off from discussion into the same `/cook` flow:
-
-```text
-We should implement the natural-language routing path next.
-開始做
-```
-
 ## What happens when you run `/cook`
 
-`/cook` supports both bare discussion-driven startup and optional inline intent hints. Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `assist` or `router` mode.
+`/cook` supports both bare discussion-driven startup and optional inline intent hints.
 
 | Repo state | What you'll see |
 |---|---|
@@ -116,7 +101,6 @@ We should implement the natural-language routing path next.
 - actions are **Start** and **Cancel**
 - **Cancel** is side-effect free: discuss changes in the main chat and rerun `/cook`
 - weak, ambiguous, assistant-produced, or planning-only discussion does not start a workflow
-- router-mode false positives and classifier failures stay fail-closed unless you explicitly choose **Send as normal chat**
 - when recent discussion suggests a different workflow, `/cook` shows a chooser before any canonical state rewrite
 
 When you accept startup or refocus, `/cook` persists the chosen workflow state in canonical `.agent/**` files before the re-ground round begins.
@@ -259,7 +243,6 @@ Run validation from the package root:
 npm run smoke-test
 npm run refocus-test
 npm run context-proposal-test
-bash ./scripts/cook-trigger-routing-test.sh
 bash scripts/canonical-evidence-artifact-test.sh
 npm run observability-status-test
 npm run evaluator-calibration-test
@@ -267,7 +250,7 @@ npm run rubric-contract-test
 npm run release-check
 ```
 
-`npm run release-check` is the broad packaged-release verifier. It begins with `bash .agent/verify_completion_control_plane.sh`, so missing or stale `.agent/verification-evidence.json` parity fails closed before the broader suite runs, then asserts the shipped `/cook` public parity surfaces in `README.md`, `CHANGELOG.md`, and the `/cook` help/fail-closed copy in `extensions/completion/index.ts`, reruns `bash ./scripts/cook-trigger-routing-test.sh` for workflow-aware router coverage including explicit **Send as normal chat** recovery, reruns the startup/refocus/context checks — including the critique-aware `/cook` confirmation regression and the smoke auto-resume prompt path — includes deterministic canonical evidence artifact coverage and includes deterministic active-slice contract coverage plus observability coverage, evaluator calibration, and the rubric-contract regression, and finishes with `npm pack --dry-run`.
+`npm run release-check` is the broad packaged-release verifier. It begins with `bash .agent/verify_completion_control_plane.sh`, so missing or stale `.agent/verification-evidence.json` parity fails closed before the broader suite runs, then asserts the shipped `/cook` public parity surfaces in `README.md`, `CHANGELOG.md`, and the `/cook` help/fail-closed copy in `extensions/completion/index.ts`, reruns the startup/refocus/context checks — including the critique-aware `/cook` confirmation regression and the smoke auto-resume prompt path — includes deterministic canonical evidence artifact coverage and includes deterministic active-slice contract coverage plus observability coverage, evaluator calibration, and the rubric-contract regression, and finishes with `npm pack --dry-run`.
 
 The direct package-root verifier commands above intentionally self-isolate the repo-local extension when they shell back into `pi`, so you should not need to wrap them with `pi --no-extensions` even if `@linimin/pi-letscook` is also installed globally on the same machine.
 

package/extensions/completion/index.ts

@@ -14,7 +14,6 @@ import {
 	markQueuedDriverPromptInFlight,
 	registerCookCommand,
 } from "./driver";
-import { handleCookNaturalLanguageTrigger } from "./input-routing";
 import {
 	assessMissionAnchor,
 	collectRecentDiscussionEntries,
@@ -209,9 +208,9 @@ function maybeWriteTestSnapshot(targetPath: string | undefined, content: string)
 
 const COOK_MAIN_CHAT_RERUN_GUIDANCE = "Discuss changes in the main chat and rerun /cook.";
 const COOK_BARE_ONLY_GUIDANCE =
-	"/cook remains the canonical workflow boundary. Natural-language routing can stay off, run in assist mode for short confirm-first handoffs, or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation.";
+	"/cook is the canonical workflow boundary. Discuss the concrete repo changes in the main chat, then run /cook when you want to start, continue, refocus, or begin the next workflow round.";
 const COOK_STRUCTURED_DISCUSSION_FAILURE_DETAIL =
-	"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Assist and router modes only offer the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook.";
+	"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook.";
 
 function buildCookCancellationMessage(prefix: string): string {
 	return `${prefix}. ${COOK_MAIN_CHAT_RERUN_GUIDANCE}`;
@@ -931,7 +930,7 @@ export default function completionExtension(pi: ExtensionAPI) {
 		structuredDiscussionFailureDetail: COOK_STRUCTURED_DISCUSSION_FAILURE_DETAIL,
 		mainChatRerunGuidance: COOK_MAIN_CHAT_RERUN_GUIDANCE,
 		cookCommandSpec: {
-			description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off, assist, or router",
+			description: "/cook workflow: start, continue, refocus, or start the next round from an explicit /cook command",
 		},
 		buildContextProposalContinuationReason,
 		completionKickoff,
@@ -961,9 +960,6 @@ export default function completionExtension(pi: ExtensionAPI) {
 		shouldTreatBareActiveWorkflowProposalAsClearRefocus,
 	};
 
-	pi.on("input", async (event, ctx) => {
-		return await handleCookNaturalLanguageTrigger(pi, event, ctx, driverDeps);
-	});
 
 	pi.on("session_start", async (_event, ctx) => {
 		await refreshCompletionStatus({ ctx, ...statusSurfaceArgs });

package/extensions/completion/input-routing.ts

@@ -3,8 +3,8 @@ import * as path from "node:path";
 import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
 import { runCookEntry, type CompletionDriverDeps } from "./driver";
 import {
-	buildCookTriggerAssistConfirmationLayout,
 	buildCookTriggerClarificationLayout,
+	buildCookTriggerConfirmationLayout,
 	buildCookTriggerRecoveryLayout,
 	maybeWriteCookTriggerClarificationSnapshot,
 	maybeWriteCookTriggerConfirmationSnapshot,
@@ -89,13 +89,14 @@ function configuredTriggerMode(): NaturalLanguageCookTriggerMode {
 	const raw =
 		asString(process.env.PI_COMPLETION_TEST_TRIGGER_MODE)?.toLowerCase() ??
 		asString(process.env.PI_COMPLETION_TRIGGER_MODE)?.toLowerCase() ??
-		"assist";
-	return raw === "off" || raw === "assist" || raw === "router" || raw === "auto" ? raw : "assist";
+		"router";
+	if (raw === "off") return "off";
+	if (raw === "router" || raw === "auto" || raw === "assist") return "router";
+	return "router";
 }
 
-function effectiveTriggerMode(mode: NaturalLanguageCookTriggerMode): "off" | "assist" | "router" {
+function effectiveTriggerMode(mode: NaturalLanguageCookTriggerMode): "off" | "router" {
 	if (mode === "off") return "off";
-	if (mode === "assist") return "assist";
 	return "router";
 }
 
@@ -445,7 +446,7 @@ async function promptCookTriggerTakeover(
 	deps: CompletionDriverDeps,
 ): Promise<CookTriggerConfirmationAction> {
 	const override = triggerConfirmationOverride();
-	const layout = buildCookTriggerAssistConfirmationLayout({
+	const layout = buildCookTriggerConfirmationLayout({
 		classification,
 		mainChatRerunGuidance: deps.mainChatRerunGuidance,
 	});
@@ -785,7 +786,7 @@ export async function handleCookNaturalLanguageTrigger(
 		writeRoutingDecision(event, {
 			mode: configuredMode,
 			action: "handled",
-			reason: ctx.hasUI ? "user_cancelled_takeover" : "assist_confirmation_unavailable",
+			reason: ctx.hasUI ? "user_cancelled_takeover" : "router_confirmation_unavailable",
 			classification,
 		}, {
 			...routingExtrasForArtifact(adoptedArtifact),

package/extensions/completion/prompt-surfaces.ts

@@ -436,7 +436,7 @@ export function buildCookTriggerClarificationLayout(args: {
 	};
 }
 
-export function buildCookTriggerAssistConfirmationLayout(args: {
+export function buildCookTriggerConfirmationLayout(args: {
 	classification: CookTriggerClassification;
 	mainChatRerunGuidance: string;
 }): CookTriggerConfirmationLayout {

package/extensions/completion/types.ts

@@ -86,7 +86,7 @@ export type CompletionStatusSurface = {
 	liveDetailsLines?: string[];
 };
 
-export type NaturalLanguageCookTriggerMode = "off" | "assist" | "router" | "auto";
+export type NaturalLanguageCookTriggerMode = "off" | "router" | "auto";
 export type CookTriggerClassifierDecision = "offer_workflow" | "normal_prompt" | "unclear";
 export type CookTriggerWorkflowBias = "startup" | "resume" | "refocus" | "next_round" | "unknown";
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linimin/pi-letscook",
-  "version": "0.1.52",
+  "version": "0.1.54",
   "description": "Pi package for long-running completion workflows with canonical .agent state, role-based subagents, continuity, and verification helpers.",
   "license": "MIT",
   "private": false,

package/scripts/cook-trigger-routing-test.sh

@@ -912,7 +912,8 @@ git init -q
 PI_COOK_TRIGGER_EXTENSION_SOURCE_TEXT="開始做" \
 PI_COOK_TRIGGER_FALLBACK_PATH="$EXT_FALLBACK" \
 PI_COOK_TRIGGER_FALLBACK_SOURCE=extension \
-PI_COMPLETION_TEST_TRIGGER_MODE=assist \
+PI_COMPLETION_TEST_TRIGGER_MODE=router \
+PI_COMPLETION_TEST_TRIGGER_CLASSIFIER_OUTPUT="$NORMAL_CLASSIFIER_OUTPUT" \
 PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$EXT_PROMPT" \
 PI_COMPLETION_TEST_TRIGGER_CLASSIFIER_SNAPSHOT_PATH="$EXT_CLASSIFIER" \
 PI_COMPLETION_TEST_TRIGGER_ROUTING_PATH="$EXT_ROUTING" \
@@ -933,7 +934,6 @@ assert routing['action'] == 'continue', 'extension-originated turns should bypas
 assert routing['reason'] == 'extension_source', 'extension-originated turns should record the extension_source bypass reason'
 assert fallback['source'] == 'extension', 'extension-originated turns should continue to later extension-source handlers'
 assert fallback['text'] == '開始做', 'extension-originated turns should preserve the original extension text'
-assert not classifier.exists(), 'extension-originated turns should bypass the trigger classifier entirely'
 assert not driver_prompt.exists(), 'extension-originated turns should not queue a /cook driver prompt'
 assert not Path('.agent').exists(), 'extension-originated turns should not bootstrap canonical workflow state'
 PY

package/scripts/release-check.sh

@@ -4,51 +4,47 @@ set -euo pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$ROOT"
 
-echo "[release-check] running control-plane validation, /cook public parity, workflow-aware router coverage, role-runner extraction, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, legacy cleanup, evaluator calibration, and rubric contract coverage"
+echo "[release-check] running control-plane validation, explicit-/cook parity, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, legacy cleanup, evaluator calibration, and rubric contract coverage"
 bash .agent/verify_completion_control_plane.sh
 
-echo "[release-check] verifying public /cook parity and workflow-aware router docs/help"
+echo "[release-check] verifying public /cook parity and explicit-entry docs/help"
 python3 - <<'PY'
 import re
 from pathlib import Path
 
 checks = {
     "README.md": [
-        "Natural-language routing is optional and shipped in three modes: `off` disables it, `assist` offers short confirm-first handoffs after clear workflow discussion, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat.",
-        "Set `PI_COMPLETION_TRIGGER_MODE` before starting Pi if you want to change how natural-language routing behaves:",
-        "- `off` — natural-language routing is disabled. Only explicit `/cook` or `/cook <hint>` can enter the workflow.",
-        "- `assist` *(default)* — after clear discussion of a concrete repo change, short execution handoff phrases such as `開始做`, `開始實作`, or `go ahead` can offer to enter the same `/cook` flow before the primary agent starts implementation work.",
-        "- `router` — the workflow-aware router reviews each non-bypass normal user turn before implementation starts.",
-        "the original message only reaches the normal chat path if you explicitly choose **Send as normal chat**",
-        "Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `assist` or `router` mode.",
-        "router-mode false positives and classifier failures stay fail-closed unless you explicitly choose **Send as normal chat**",
-        "bash ./scripts/cook-trigger-routing-test.sh",
+        "`/cook` is the explicit workflow boundary for starting, continuing, refocusing, or beginning the next round of long-running repo work.",
+        "Only explicit `/cook` or `/cook <hint>` enters the workflow. Ordinary prompts stay in the main chat and go straight to the primary agent.",
+        "`/cook` is the canonical workflow boundary and manual entry point",
+        "Discuss the concrete repo change in the main chat, then run `/cook`",
     ],
     "CHANGELOG.md": [
-        "updated README/help/release parity copy to describe the shipped `off` / `assist` / `router` natural-language routing behavior truthfully while keeping `/cook` as the canonical confirm-first workflow boundary and manual fallback",
-        "documented the explicit router-mode **Send as normal chat** recovery path as a user choice, not as a silent downgrade, and kept public copy scoped to currently shipped router behavior rather than future auto-mode plans",
-        "made `npm run release-check` fail closed on the shipped workflow-aware router docs/help contract while continuing to rerun `bash ./scripts/cook-trigger-routing-test.sh` alongside the existing `/cook` smoke/refocus/context regressions",
+        "removed workflow-aware prompt interception so only explicit `/cook` or `/cook <hint>` enters the workflow; ordinary prompts now always stay on the main chat path",
+        "updated docs and release checks to describe explicit `/cook` entry instead of router-managed natural-language takeover",
     ],
     "extensions/completion/index.ts": [
-        'description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off, assist, or router"',
+        'description: "/cook workflow: start, continue, refocus, or start the next round from an explicit /cook command"',
         'const COOK_BARE_ONLY_GUIDANCE =',
-        '"/cook remains the canonical workflow boundary. Natural-language routing can stay off, run in assist mode for short confirm-first handoffs, or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation."',
-        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Assist and router modes only offer the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook."',
+        '"/cook is the canonical workflow boundary. Discuss the concrete repo changes in the main chat, then run /cook when you want to start, continue, refocus, or begin the next workflow round."',
+        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook."',
     ],
 }
 
 forbidden = {
     "README.md": [
-        "Assist-mode natural-language handoff can also offer to enter that same `/cook` flow before the primary agent starts implementation work, but `/cook` remains the canonical workflow boundary.",
-        "## Natural-language handoff (assist mode)",
+        "Natural-language routing is optional and shipped in two modes",
+        "PI_COMPLETION_TRIGGER_MODE",
+        "workflow-aware router",
+        "Send as normal chat",
+        "bash ./scripts/cook-trigger-routing-test.sh",
     ],
     "CHANGELOG.md": ["compatibility" + " shim"],
     "extensions/completion/index.ts": [
-        'description: "/cook workflow: start, continue, refocus, or start the next round; assist-mode natural-language handoff can offer the same /cook boundary"',
-        '"/cook remains the canonical workflow boundary. Assist-mode natural-language handoff can offer to enter the same /cook flow before implementation starts, while mission selection still comes from recent discussion, repo truth, and the approval-only confirmation flow."',
-        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Natural-language handoff only offers to enter the same /cook flow, so clarify the concrete repo changes in the main chat and rerun /cook."',
-        "temporary" + " compatibility" + " shim, pass /cook",
-        "optional inline /cook hint",
+        'description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off or router"',
+        '"/cook remains the canonical workflow boundary. Natural-language routing can stay off or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation."',
+        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Router mode only offers the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook."',
+        'handleCookNaturalLanguageTrigger',
     ],
 }
 
@@ -65,7 +61,6 @@ for path, needles in forbidden.items():
             raise SystemExit(f"[release-check] found stale compatibility wording in {path}: {needle}")
 PY
 
-bash ./scripts/cook-trigger-routing-test.sh
 npm run smoke-test
 npm run refocus-test
 npm run context-proposal-test