@linimin/pi-letscook 0.1.52 → 0.1.53

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Unreleased
 
+## 0.1.53
+
+### Changed
+
+- removed assist mode from public routing behavior so natural-language entry is now either off or router, and made router the default trigger mode while keeping `/cook` as the canonical workflow boundary
+- removed obsolete cook planning docs that no longer match the shipped router-only workflow entry behavior
+
 ## 0.1.52
 
 ### Changed

package/README.md

@@ -2,7 +2,7 @@
 
 `/cook` turns main-chat discussion about concrete repo changes into a resumable repo workflow stored in repo-local `.agent/**` state.
 
-Natural-language routing is optional and shipped in three modes: `off` disables it, `assist` offers short confirm-first handoffs after clear workflow discussion, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat. In every mode, `/cook` remains the canonical workflow boundary and manual fallback.
+Natural-language routing is optional and shipped in two modes: `off` disables it, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat. In every mode, `/cook` remains the canonical workflow boundary and manual fallback.
 
 ## Use it when
 
@@ -46,8 +46,8 @@ Then run `/reload` in Pi.
 |---|---|
 | Start a long-running task | Discuss the concrete repo change in the main chat, then run `/cook` |
 | Bias mission detection toward one intent | Run `/cook <hint>` |
-| Change natural-language routing behavior | Set `PI_COMPLETION_TRIGGER_MODE=off`, `assist`, or `router` before starting Pi |
-| Hand off from discussion into the same `/cook` flow | In `assist`, say `開始做`, `開始實作`, or `go ahead`, then accept the confirmation |
+| Change natural-language routing behavior | Set `PI_COMPLETION_TRIGGER_MODE=off` or `router` before starting Pi |
+| Hand off from discussion into the same `/cook` flow | In `router`, say `開始做`, `開始實作`, or `go ahead`, then accept the confirmation |
 | Continue the current workflow | Run `/cook` |
 | Use the canonical fallback when natural-language routing does not fire or you want to bypass it | Run `/cook` explicitly |
 
@@ -66,8 +66,7 @@ If recent discussion is missing, weak, ambiguous, assistant-produced, or only de
 Set `PI_COMPLETION_TRIGGER_MODE` before starting Pi if you want to change how natural-language routing behaves:
 
 - `off` — natural-language routing is disabled. Only explicit `/cook` or `/cook <hint>` can enter the workflow.
-- `assist` *(default)* — after clear discussion of a concrete repo change, short execution handoff phrases such as `開始做`, `開始實作`, or `go ahead` can offer to enter the same `/cook` flow before the primary agent starts implementation work.
-- `router` — the workflow-aware router reviews each non-bypass normal user turn before implementation starts. Ordinary questions stay in the main chat, while direct start/resume/refocus/next-round prompts can offer the shared `/cook` flow with confirmation or clarification.
+- `router` *(default)* — the workflow-aware router reviews each non-bypass normal user turn before implementation starts. Ordinary questions stay in the main chat, while direct start/resume/refocus/next-round prompts can offer the shared `/cook` flow with confirmation or clarification. Short execution handoff phrases such as `開始做`, `開始實作`, or `go ahead` are covered by the same router path.
 
 Important behavior:
 - natural-language routing is only a shortcut into `/cook`; `/cook` is still the canonical workflow boundary and manual fallback
@@ -100,7 +99,7 @@ We should implement the natural-language routing path next.
 
 ## What happens when you run `/cook`
 
-`/cook` supports both bare discussion-driven startup and optional inline intent hints. Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `assist` or `router` mode.
+`/cook` supports both bare discussion-driven startup and optional inline intent hints. Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `router` mode.
 
 | Repo state | What you'll see |
 |---|---|

package/extensions/completion/index.ts

@@ -209,9 +209,9 @@ function maybeWriteTestSnapshot(targetPath: string | undefined, content: string)
 
 const COOK_MAIN_CHAT_RERUN_GUIDANCE = "Discuss changes in the main chat and rerun /cook.";
 const COOK_BARE_ONLY_GUIDANCE =
-	"/cook remains the canonical workflow boundary. Natural-language routing can stay off, run in assist mode for short confirm-first handoffs, or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation.";
+	"/cook remains the canonical workflow boundary. Natural-language routing can stay off or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation.";
 const COOK_STRUCTURED_DISCUSSION_FAILURE_DETAIL =
-	"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Assist and router modes only offer the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook.";
+	"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Router mode only offers the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook.";
 
 function buildCookCancellationMessage(prefix: string): string {
 	return `${prefix}. ${COOK_MAIN_CHAT_RERUN_GUIDANCE}`;
@@ -931,7 +931,7 @@ export default function completionExtension(pi: ExtensionAPI) {
 		structuredDiscussionFailureDetail: COOK_STRUCTURED_DISCUSSION_FAILURE_DETAIL,
 		mainChatRerunGuidance: COOK_MAIN_CHAT_RERUN_GUIDANCE,
 		cookCommandSpec: {
-			description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off, assist, or router",
+			description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off or router",
 		},
 		buildContextProposalContinuationReason,
 		completionKickoff,

package/extensions/completion/input-routing.ts

@@ -3,8 +3,8 @@ import * as path from "node:path";
 import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
 import { runCookEntry, type CompletionDriverDeps } from "./driver";
 import {
-	buildCookTriggerAssistConfirmationLayout,
 	buildCookTriggerClarificationLayout,
+	buildCookTriggerConfirmationLayout,
 	buildCookTriggerRecoveryLayout,
 	maybeWriteCookTriggerClarificationSnapshot,
 	maybeWriteCookTriggerConfirmationSnapshot,
@@ -89,13 +89,14 @@ function configuredTriggerMode(): NaturalLanguageCookTriggerMode {
 	const raw =
 		asString(process.env.PI_COMPLETION_TEST_TRIGGER_MODE)?.toLowerCase() ??
 		asString(process.env.PI_COMPLETION_TRIGGER_MODE)?.toLowerCase() ??
-		"assist";
-	return raw === "off" || raw === "assist" || raw === "router" || raw === "auto" ? raw : "assist";
+		"router";
+	if (raw === "off") return "off";
+	if (raw === "router" || raw === "auto" || raw === "assist") return "router";
+	return "router";
 }
 
-function effectiveTriggerMode(mode: NaturalLanguageCookTriggerMode): "off" | "assist" | "router" {
+function effectiveTriggerMode(mode: NaturalLanguageCookTriggerMode): "off" | "router" {
 	if (mode === "off") return "off";
-	if (mode === "assist") return "assist";
 	return "router";
 }
 
@@ -445,7 +446,7 @@ async function promptCookTriggerTakeover(
 	deps: CompletionDriverDeps,
 ): Promise<CookTriggerConfirmationAction> {
 	const override = triggerConfirmationOverride();
-	const layout = buildCookTriggerAssistConfirmationLayout({
+	const layout = buildCookTriggerConfirmationLayout({
 		classification,
 		mainChatRerunGuidance: deps.mainChatRerunGuidance,
 	});
@@ -785,7 +786,7 @@ export async function handleCookNaturalLanguageTrigger(
 		writeRoutingDecision(event, {
 			mode: configuredMode,
 			action: "handled",
-			reason: ctx.hasUI ? "user_cancelled_takeover" : "assist_confirmation_unavailable",
+			reason: ctx.hasUI ? "user_cancelled_takeover" : "router_confirmation_unavailable",
 			classification,
 		}, {
 			...routingExtrasForArtifact(adoptedArtifact),

package/extensions/completion/prompt-surfaces.ts

@@ -436,7 +436,7 @@ export function buildCookTriggerClarificationLayout(args: {
 	};
 }
 
-export function buildCookTriggerAssistConfirmationLayout(args: {
+export function buildCookTriggerConfirmationLayout(args: {
 	classification: CookTriggerClassification;
 	mainChatRerunGuidance: string;
 }): CookTriggerConfirmationLayout {

package/extensions/completion/types.ts

@@ -86,7 +86,7 @@ export type CompletionStatusSurface = {
 	liveDetailsLines?: string[];
 };
 
-export type NaturalLanguageCookTriggerMode = "off" | "assist" | "router" | "auto";
+export type NaturalLanguageCookTriggerMode = "off" | "router" | "auto";
 export type CookTriggerClassifierDecision = "offer_workflow" | "normal_prompt" | "unclear";
 export type CookTriggerWorkflowBias = "startup" | "resume" | "refocus" | "next_round" | "unknown";
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linimin/pi-letscook",
-  "version": "0.1.52",
+  "version": "0.1.53",
   "description": "Pi package for long-running completion workflows with canonical .agent state, role-based subagents, continuity, and verification helpers.",
   "license": "MIT",
   "private": false,

package/scripts/cook-trigger-routing-test.sh

@@ -912,7 +912,8 @@ git init -q
 PI_COOK_TRIGGER_EXTENSION_SOURCE_TEXT="開始做" \
 PI_COOK_TRIGGER_FALLBACK_PATH="$EXT_FALLBACK" \
 PI_COOK_TRIGGER_FALLBACK_SOURCE=extension \
-PI_COMPLETION_TEST_TRIGGER_MODE=assist \
+PI_COMPLETION_TEST_TRIGGER_MODE=router \
+PI_COMPLETION_TEST_TRIGGER_CLASSIFIER_OUTPUT="$NORMAL_CLASSIFIER_OUTPUT" \
 PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$EXT_PROMPT" \
 PI_COMPLETION_TEST_TRIGGER_CLASSIFIER_SNAPSHOT_PATH="$EXT_CLASSIFIER" \
 PI_COMPLETION_TEST_TRIGGER_ROUTING_PATH="$EXT_ROUTING" \
@@ -933,7 +934,6 @@ assert routing['action'] == 'continue', 'extension-originated turns should bypas
 assert routing['reason'] == 'extension_source', 'extension-originated turns should record the extension_source bypass reason'
 assert fallback['source'] == 'extension', 'extension-originated turns should continue to later extension-source handlers'
 assert fallback['text'] == '開始做', 'extension-originated turns should preserve the original extension text'
-assert not classifier.exists(), 'extension-originated turns should bypass the trigger classifier entirely'
 assert not driver_prompt.exists(), 'extension-originated turns should not queue a /cook driver prompt'
 assert not Path('.agent').exists(), 'extension-originated turns should not bootstrap canonical workflow state'
 PY

package/scripts/release-check.sh

@@ -14,26 +14,25 @@ from pathlib import Path
 
 checks = {
     "README.md": [
-        "Natural-language routing is optional and shipped in three modes: `off` disables it, `assist` offers short confirm-first handoffs after clear workflow discussion, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat.",
+        "Natural-language routing is optional and shipped in two modes: `off` disables it, and `router` reviews each non-bypass user turn before implementation starts while leaving ordinary questions in the main chat.",
         "Set `PI_COMPLETION_TRIGGER_MODE` before starting Pi if you want to change how natural-language routing behaves:",
         "- `off` — natural-language routing is disabled. Only explicit `/cook` or `/cook <hint>` can enter the workflow.",
-        "- `assist` *(default)* — after clear discussion of a concrete repo change, short execution handoff phrases such as `開始做`, `開始實作`, or `go ahead` can offer to enter the same `/cook` flow before the primary agent starts implementation work.",
-        "- `router` — the workflow-aware router reviews each non-bypass normal user turn before implementation starts.",
+        "- `router` *(default)* — the workflow-aware router reviews each non-bypass normal user turn before implementation starts.",
         "the original message only reaches the normal chat path if you explicitly choose **Send as normal chat**",
-        "Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `assist` or `router` mode.",
+        "Explicit `/cook` is always the canonical fallback, even when natural-language routing is enabled in `router` mode.",
         "router-mode false positives and classifier failures stay fail-closed unless you explicitly choose **Send as normal chat**",
         "bash ./scripts/cook-trigger-routing-test.sh",
     ],
     "CHANGELOG.md": [
-        "updated README/help/release parity copy to describe the shipped `off` / `assist` / `router` natural-language routing behavior truthfully while keeping `/cook` as the canonical confirm-first workflow boundary and manual fallback",
+        "removed assist mode from public routing behavior so natural-language entry is now either off or router, and made router the default trigger mode while keeping `/cook` as the canonical workflow boundary",
         "documented the explicit router-mode **Send as normal chat** recovery path as a user choice, not as a silent downgrade, and kept public copy scoped to currently shipped router behavior rather than future auto-mode plans",
         "made `npm run release-check` fail closed on the shipped workflow-aware router docs/help contract while continuing to rerun `bash ./scripts/cook-trigger-routing-test.sh` alongside the existing `/cook` smoke/refocus/context regressions",
     ],
     "extensions/completion/index.ts": [
-        'description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off, assist, or router"',
+        'description: "/cook workflow: start, continue, refocus, or start the next round; /cook stays canonical while natural-language routing can be off or router"',
         'const COOK_BARE_ONLY_GUIDANCE =',
-        '"/cook remains the canonical workflow boundary. Natural-language routing can stay off, run in assist mode for short confirm-first handoffs, or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation."',
-        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Assist and router modes only offer the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook."',
+        '"/cook remains the canonical workflow boundary. Natural-language routing can stay off or run in router mode to review each non-bypass user turn before implementation starts, but the shared /cook flow still owns mission selection and confirmation."',
+        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Router mode only offers the same /cook flow, and router recovery only replays to normal chat when you explicitly choose Send as normal chat, so clarify the concrete repo changes in the main chat and rerun /cook."',
     ],
 }
 
@@ -41,12 +40,16 @@ forbidden = {
     "README.md": [
         "Assist-mode natural-language handoff can also offer to enter that same `/cook` flow before the primary agent starts implementation work, but `/cook` remains the canonical workflow boundary.",
         "## Natural-language handoff (assist mode)",
+        "`assist`",
     ],
     "CHANGELOG.md": ["compatibility" + " shim"],
     "extensions/completion/index.ts": [
         'description: "/cook workflow: start, continue, refocus, or start the next round; assist-mode natural-language handoff can offer the same /cook boundary"',
         '"/cook remains the canonical workflow boundary. Assist-mode natural-language handoff can offer to enter the same /cook flow before implementation starts, while mission selection still comes from recent discussion, repo truth, and the approval-only confirmation flow."',
         '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Natural-language handoff only offers to enter the same /cook flow, so clarify the concrete repo changes in the main chat and rerun /cook."',
+        'assist, or router',
+        'Assist and router modes only offer the same /cook flow',
+        'run in assist mode',
         "temporary" + " compatibility" + " shim, pass /cook",
         "optional inline /cook hint",
     ],