@linimin/pi-letscook 0.1.44 → 0.1.46

package/scripts/active-slice-contract-test.sh

@@ -75,11 +75,12 @@ assertIncludes('README.md', 'Deterministic active-slice contract regression now
 assertIncludes('README.md', 'includes deterministic active-slice contract coverage plus observability coverage');
 assertIncludes('scripts/release-check.sh', 'bash ./scripts/active-slice-contract-test.sh');
 assertIncludes('.agent/verify_completion_stop.sh', 'npm run release-check >/dev/null');
-assertIncludes('extensions/completion/index.ts', "const planMirrorFields = ['locked_notes', 'must_fix_findings', 'implementation_surfaces', 'verification_commands', 'basis_commit', 'remaining_contract_ids_before', 'release_blocker_count_before', 'high_value_gap_count_before'];");
-assertIncludes('extensions/completion/index.ts', 'Selected/in-progress/committed/done .agent/active-slice.json is the canonical implementation contract.');
-assertIncludes('extensions/completion/index.ts', 'Active slice contract drift: ${activeContractDrift}');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyControlPlaneScript(');
+assertIncludes('extensions/completion/state-store.ts', 'return fs.readFileSync(trackedScriptPath, "utf8");');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Selected/in-progress/committed/done .agent/active-slice.json is the canonical implementation contract.');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Active slice contract drift: ${args.activeContractDrift}');
 assertIncludes('extensions/completion/index.ts', 'Canonical active-slice contract drift is currently: ${activeContractDrift}');
-assertIncludes('extensions/completion/index.ts', '`active_slice_contract_drift_fields: ${activeContractDrift}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`active_slice_contract_drift_fields: ${args.activeSliceContractDrift}`');
 assertIncludes('extensions/completion/index.ts', 'treat .agent/active-slice.json as the canonical implementation contract');
 assertIncludes('.agent/verify_completion_control_plane.sh', "const planMirrorFields = ['locked_notes', 'must_fix_findings', 'implementation_surfaces', 'verification_commands', 'basis_commit', 'remaining_contract_ids_before', 'release_blocker_count_before', 'high_value_gap_count_before'];");
 assertIncludes('.agent/verify_completion_control_plane.sh', 'slice_id must match a slice in .agent/plan.json when status carries an exact handoff');

package/scripts/canonical-evidence-artifact-test.sh

@@ -3,7 +3,7 @@ set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 pi() {
-  command pi --no-extensions "$@"
+  env -u PI_COMPLETION_ROLE command pi --no-extensions "$@"
 }
 TMPDIR="$(mktemp -d)"
 CURRENT_EVIDENCE_BACKUP=""
@@ -96,11 +96,11 @@ assertSectionIncludes('skills/completion-protocol/references/completion.md', '##
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Canonical Inputs', '- `.agent/verification-evidence.json`');
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Compaction And Recovery', '- `.agent/verification-evidence.json`');
 assertSectionIncludes('skills/completion-protocol/references/completion.md', '## Compaction And Recovery', '`completion-implementer` must also re-read canonical `.agent/state.json`, `.agent/plan.json`, `.agent/active-slice.json`, and `.agent/verification-evidence.json` before resuming work.');
-assertIncludes('extensions/completion/index.ts', 'Verification evidence artifact: ${evidence.path}');
-assertIncludes('extensions/completion/index.ts', 'Verification evidence summary: ${evidence.summary}');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Verification evidence artifact: ${args.evidence.path} (${args.evidence.status})');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Verification evidence summary: ${args.evidence.summary}');
 assertIncludes('extensions/completion/index.ts', 'Canonical verification evidence artifact is currently: ${evidence.path} (${evidence.status})');
-assertIncludes('extensions/completion/index.ts', '`- verification_evidence_path: ${evidence.path}`');
-assertIncludes('extensions/completion/index.ts', '`- verification_evidence_summary: ${evidence.summary}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- verification_evidence_path: ${evidence.path}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- verification_evidence_summary: ${evidence.summary}`');
 assertIncludes('extensions/completion/index.ts', 'Consume .agent/verification-evidence.json instead of temp-only verification summaries when it is populated.');
 assertIncludes('scripts/release-check.sh', 'bash .agent/verify_completion_control_plane.sh');
 assertIncludes('scripts/release-check.sh', 'bash ./scripts/canonical-evidence-artifact-test.sh');
@@ -377,6 +377,7 @@ PY
 bash .agent/verify_completion_control_plane.sh >/dev/null
 bash .agent/verify_completion_stop.sh >/dev/null
 
+rm -f "$SYSTEM_REMINDER"
 PI_COMPLETION_TEST_SYSTEM_REMINDER_PATH="$SYSTEM_REMINDER" \
 pi -e "$PKG_ROOT" -p "Summarize the completion reminder briefly." \
   >"$TMPDIR/pi-canonical-evidence-reminder.out" 2>"$TMPDIR/pi-canonical-evidence-reminder.err"
@@ -385,11 +386,8 @@ python3 - "$SYSTEM_REMINDER" <<'PY'
 import sys
 from pathlib import Path
 
-text = Path(sys.argv[1]).read_text()
-assert 'Canonical truth lives in .agent/state.json, .agent/plan.json, .agent/active-slice.json, .agent/slice-history.jsonl, .agent/stop-check-history.jsonl, and .agent/verification-evidence.json.' in text, text
-assert 'Verification evidence artifact: .agent/verification-evidence.json (present)' in text, text
-assert 'Verification evidence summary:' in text, text
-assert 'selected_slice' in text, text
+reminder = Path(sys.argv[1])
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject completion reminder solely from selected-slice canonical state'
 PY
 
 python3 - <<'PY'
@@ -435,13 +433,8 @@ python3 - "$SYSTEM_REMINDER" <<'PY'
 import sys
 from pathlib import Path
 
-text = Path(sys.argv[1]).read_text()
-assert 'A previous completion workflow exists for this repo, but it is closed.' in text, text
-assert 'Treat the previous completion workflow as historical context only.' in text, text
-assert 'Do not resume, reground, refocus, reopen, or otherwise restart completion workflow from this context unless the user explicitly runs /cook.' in text, text
-assert 'For ordinary user requests, respond normally and ignore prior completion-protocol instructions that were only relevant to the finished workflow.' in text, text
-assert 'Only /cook may reactivate workflow routing for the next round.' in text, text
-assert 'Completion workflow detected.' not in text, text
+reminder = Path(sys.argv[1])
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject closed-workflow boundary routing before /cook reactivation'
 PY
 
 echo "canonical evidence artifact test passed: $TMPDIR"

package/scripts/context-proposal-test.sh

@@ -836,8 +836,8 @@ assert plan['plan_basis'] == 'user_refocus', 'plan_basis should reset to user_re
 assert active['status'] == 'idle', 'active-slice should reset to idle for the next workflow round'
 PY
 
-# Active workflow: inline /cook hint should flow through routing plus final proposal confirmation
-# and still leave canonical state unchanged when the final proposal is cancelled.
+# Active workflow: /cook <text> should be rejected before routing or proposal confirmation
+# and still leave canonical state unchanged.
 ACTIVE_INLINE_REJECTION_ROUTING="$TMPDIR/context-proposal-active-inline-arg-routing.json"
 ACTIVE_INLINE_REJECTION_PROPOSAL="$TMPDIR/context-proposal-active-inline-arg-proposal.json"
 ACTIVE_INLINE_REJECTION_CHOOSER="$TMPDIR/context-proposal-active-inline-arg-chooser.json"
@@ -886,15 +886,16 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 
-assert routing.exists(), 'active inline /cook hint should run active-workflow routing'
-assert proposal.exists(), 'active inline /cook hint should open final proposal confirmation after refocus is chosen'
-assert chooser.exists(), 'active inline /cook hint should open the existing-workflow chooser'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'active /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'active /cook <text> rejection should not run active-workflow routing'
+assert not proposal.exists(), 'active /cook <text> rejection should not open proposal confirmation'
+assert not chooser.exists(), 'active /cook <text> rejection should not open the existing-workflow chooser'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'active inline /cook hint should leave canonical files unchanged when confirmation is cancelled'
+assert before == after, 'active /cook <text> rejection should leave canonical files unchanged'
 PY
 
-# Completed workflow: inline /cook hint should also drive the next-round proposal and leave
-# canonical state unchanged when the proposal is cancelled.
+# Completed workflow: /cook <text> should be rejected before any next-round proposal is derived
+# and still leave canonical state unchanged.
 mark_done
 
 DONE_INLINE_REJECTION_ROUTING="$TMPDIR/context-proposal-done-inline-arg-routing.json"
@@ -944,13 +945,14 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 state_before = json.loads(before['state.json'])
-assert state_before['current_phase'] == 'done', 'done inline /cook rejection should start from a completed workflow'
-assert state_before['project_done'] is True, 'done inline /cook rejection should start from project_done=true'
-assert not routing.exists(), 'done inline /cook args should not run active/done workflow routing'
-assert proposal.exists(), 'done inline /cook hint should open next-round proposal confirmation'
-assert not chooser.exists(), 'done inline /cook args should not open the chooser flow'
+assert state_before['current_phase'] == 'done', 'done /cook <text> rejection should start from a completed workflow'
+assert state_before['project_done'] is True, 'done /cook <text> rejection should start from project_done=true'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'done /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'done /cook <text> rejection should not run active/done workflow routing'
+assert not proposal.exists(), 'done /cook <text> rejection should not open next-round proposal confirmation'
+assert not chooser.exists(), 'done /cook <text> rejection should not open the chooser flow'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'done inline /cook hint cancel should leave canonical files unchanged'
+assert before == after, 'done /cook <text> rejection should leave canonical files unchanged'
 PY
 
 # Completed workflow again: /cook with no goal should be able to use model-assisted
@@ -1086,4 +1088,9 @@ assert 'Discuss changes in the main chat and rerun /cook.' in output, 'cancel co
 assert not Path('.agent').exists(), 'cancel action should not write canonical workflow state'
 PY
 
+grep -q 'export async function deriveCookContextProposalFromRecentDiscussion' "$PKG_ROOT/extensions/completion/proposal.ts"
+grep -q 'export function parseContextProposalAnalystOutput' "$PKG_ROOT/extensions/completion/proposal.ts"
+grep -q 'export function buildContextProposalConfirmationLayout' "$PKG_ROOT/extensions/completion/prompt-surfaces.ts"
+grep -q 'export function buildEvaluationRoleContextLines' "$PKG_ROOT/extensions/completion/prompt-surfaces.ts"
+
 echo "context proposal test passed: $ROOT"

package/scripts/legacy-cleanup-test.sh

@@ -0,0 +1,107 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing expected legacy-cleanup ownership text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale monolith ownership text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/state-store.ts', 'export async function scaffoldCompletionFiles(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildAgentReadme(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyStopScript(');
+assertIncludes('extensions/completion/state-store.ts', 'export function buildVerifyControlPlaneScript(');
+assertIncludes('extensions/completion/state-store.ts', 'export function currentTaskType(');
+assertIncludes('extensions/completion/state-store.ts', 'export function currentEvaluationProfile(');
+
+assertIncludes('extensions/completion/status-surface.ts', 'export function nowMs(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function formatElapsed(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function createLiveRoleActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function cloneLiveRoleActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function applyLiveRoleEvent(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function pushRecentActivity(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function truncateInline(');
+
+assertIncludes('extensions/completion/proposal.ts', 'export function normalizeMissionAnchorText(');
+assertIncludes('extensions/completion/proposal.ts', 'export function isWeakMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function deriveMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function assessMissionAnchor(');
+assertIncludes('extensions/completion/proposal.ts', 'export function stripCodeBlocks(');
+assertIncludes('extensions/completion/proposal.ts', 'export function missionAnchorsStrictlyEquivalent(');
+assertIncludes('extensions/completion/proposal.ts', 'export function missionAnchorsLikelyEquivalent(');
+assertIncludes('extensions/completion/proposal.ts', 'export function collectRecentDiscussionEntries(');
+assertIncludes('extensions/completion/proposal.ts', 'export function serializeRecentDiscussionEntries(');
+assertIncludes('extensions/completion/proposal.ts', 'export function extractJsonObjectFromText(');
+
+assertIncludes('extensions/completion/role-runner.ts', 'export async function analyzeContextProposalWithAgent(');
+assertIncludes('extensions/completion/role-runner.ts', 'class StartupAnalystOverlay extends Container');
+assertIncludes('extensions/completion/role-runner.ts', 'async function runContextProposalAnalystSubprocess(');
+
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'export function buildSystemReminder(');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'export function buildResumeCapsule(');
+
+assertIncludes('extensions/completion/index.ts', 'scaffoldCompletionFiles as scaffoldCompletionFilesOnDisk');
+assertIncludes('extensions/completion/index.ts', 'return await scaffoldCompletionFilesOnDisk(root, missionAnchor, {');
+assertIncludes('extensions/completion/index.ts', 'applyLiveRoleEvent,');
+assertIncludes('extensions/completion/index.ts', 'cloneLiveRoleActivity,');
+assertIncludes('extensions/completion/index.ts', 'createLiveRoleActivity,');
+assertIncludes('extensions/completion/index.ts', 'formatElapsed,');
+assertIncludes('extensions/completion/index.ts', 'nowMs,');
+
+assertNotIncludes('extensions/completion/index.ts', 'async function detectVerifierCommand(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildAgentReadme(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildMission(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildVerifyStopScript(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildVerifyControlPlaneScript(');
+assertNotIncludes('extensions/completion/index.ts', 'async function ensureGitignore(');
+assertNotIncludes('extensions/completion/index.ts', 'function currentTaskType(');
+assertNotIncludes('extensions/completion/index.ts', 'function currentEvaluationProfile(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatCount(');
+assertNotIncludes('extensions/completion/index.ts', 'function completionRemainingSummary(');
+assertNotIncludes('extensions/completion/index.ts', 'function envNumber(');
+assertNotIncludes('extensions/completion/index.ts', 'function nowMs(');
+assertNotIncludes('extensions/completion/index.ts', 'type LiveActivitySignal = {');
+assertNotIncludes('extensions/completion/index.ts', 'function cloneLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function createLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'type RoleMessage = {');
+assertNotIncludes('extensions/completion/index.ts', 'function applyLiveRoleEvent(');
+assertNotIncludes('extensions/completion/index.ts', 'function maybeInjectTestLiveRoleActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function maybeReplayTestLiveRoleEvents(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatElapsed(');
+assertNotIncludes('extensions/completion/index.ts', 'function truncateInline(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatToolActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function pushRecentActivity(');
+assertNotIncludes('extensions/completion/index.ts', 'function parseStructuredProgress(');
+assertNotIncludes('extensions/completion/index.ts', 'function lastAssistantText(');
+assertNotIncludes('extensions/completion/index.ts', 'function normalizeMissionAnchorText(');
+assertNotIncludes('extensions/completion/index.ts', 'function isWeakMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function assessMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function stripCodeBlocks(');
+assertNotIncludes('extensions/completion/index.ts', 'function missionAnchorsStrictlyEquivalent(');
+assertNotIncludes('extensions/completion/index.ts', 'function missionAnchorsLikelyEquivalent(');
+assertNotIncludes('extensions/completion/index.ts', 'function collectRecentDiscussionEntries(');
+assertNotIncludes('extensions/completion/index.ts', 'function serializeRecentDiscussionEntries(');
+assertNotIncludes('extensions/completion/index.ts', 'function extractJsonObjectFromText(');
+assertNotIncludes('extensions/completion/index.ts', 'function contextProposalAnalystModelArg(');
+assertNotIncludes('extensions/completion/index.ts', 'async function runContextProposalAnalystSubprocess(');
+assertNotIncludes('extensions/completion/index.ts', 'async function analyzeContextProposalWithAgent(');
+assertNotIncludes('extensions/completion/index.ts', 'function deriveMissionAnchor(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildSystemReminder(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildResumeCapsule(');
+NODE
+
+echo "legacy cleanup test passed: $ROOT"

package/scripts/observability-status-test.sh

@@ -237,4 +237,43 @@ PI_COMPLETION_TEST_ROLE_EVENT_STREAM_JSON="$LIVE_ROLE_EVENT_STREAM_JSON" \
 pi -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-status-stalled.out" 2>"$TMPDIR/pi-completion-status-stalled.err"
 assert_status_json "$STALLED_JSON" stalled
 
+cd "$PKG_ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing required status/policy extraction text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale inline status/policy text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/status-surface.ts', 'export async function refreshCompletionStatus(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function buildCompletionStatusSurface(');
+assertIncludes('extensions/completion/status-surface.ts', 'export function buildInlineRunningLines(');
+assertIncludes('extensions/completion/policy-guards.ts', 'export function toolCallBlockReason(');
+assertIncludes('extensions/completion/state-store.ts', 'export function completionRootKey(');
+assertIncludes('extensions/completion/index.ts', 'import { toolCallBlockReason } from "./policy-guards";');
+assertIncludes('extensions/completion/index.ts', 'buildInlineRunningLines');
+assertIncludes('extensions/completion/index.ts', 'formatInlineRunningText');
+assertIncludes('extensions/completion/index.ts', 'refreshCompletionStatus');
+assertIncludes('extensions/completion/index.ts', 'const reason = toolCallBlockReason({');
+assertIncludes('extensions/completion/index.ts', 'await refreshCompletionStatus({ ctx, ...statusSurfaceArgs });');
+assertNotIncludes('extensions/completion/index.ts', 'function buildCompletionStatusSurface(');
+assertNotIncludes('extensions/completion/index.ts', 'async function writeCompletionStatusProbe(');
+assertNotIncludes('extensions/completion/index.ts', 'function isAllowedControlPlanePath(');
+assertNotIncludes('extensions/completion/index.ts', 'function isMutatingBash(');
+assertNotIncludes('extensions/completion/index.ts', 'async function refreshStatus(');
+assertNotIncludes('extensions/completion/index.ts', 'function buildInlineRunningLines(');
+assertNotIncludes('extensions/completion/index.ts', 'function formatInlineRunningText(');
+NODE
+
 echo "observability status test passed: $TMPDIR"

package/scripts/refocus-test.sh

@@ -131,13 +131,13 @@ tracked = [
     Path('.agent/verification-evidence.json'),
 ]
 current_state = json.loads(before['state.json'])
-assert current_state['mission_anchor'] == initial_mission, 'active inline /cook args should start from the current mission anchor'
-assert 'Cancelled existing workflow confirmation.' in output, 'active inline /cook hint cancel should surface chooser cancellation'
-assert routing.exists(), 'active inline /cook hint should run active-workflow routing'
-assert not proposal.exists(), 'active inline /cook hint cancel at chooser should not open final proposal confirmation'
-assert chooser.exists(), 'active inline /cook hint should open the existing-workflow chooser'
+assert current_state['mission_anchor'] == initial_mission, 'active /cook <text> rejection should start from the current mission anchor'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'active /cook <text> rejection should explain the bare-only contract'
+assert not routing.exists(), 'active /cook <text> rejection should not run active-workflow routing'
+assert not proposal.exists(), 'active /cook <text> rejection should not open final proposal confirmation'
+assert not chooser.exists(), 'active /cook <text> rejection should not open the existing-workflow chooser'
 after = {path.name: path.read_text() for path in tracked}
-assert before == after, 'active inline /cook hint cancel should leave canonical files unchanged'
+assert before == after, 'active /cook <text> rejection should leave canonical files unchanged'
 PY
 
 SESSION_INITIAL_REFOCUS="$TMPDIR/session-initial-bare-refocus.jsonl"

package/scripts/release-check.sh

@@ -4,7 +4,7 @@ set -euo pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$ROOT"
 
-echo "[release-check] running control-plane validation, bare /cook parity, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, evaluator calibration, and rubric contract coverage"
+echo "[release-check] running control-plane validation, bare /cook parity, role-runner extraction, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, legacy cleanup, evaluator calibration, and rubric contract coverage"
 bash .agent/verify_completion_control_plane.sh
 
 echo "[release-check] verifying public /cook parity"
@@ -14,9 +14,9 @@ from pathlib import Path
 
 checks = {
     "README.md": [
-        "Bare `/cook` and `/cook <hint>` are the supported workflow entrypoints.",
-        "If the recent context is fuzzy, `/cook <hint>` can provide a short high-priority user hint for the proposal analyst",
-        "clarify the mission in the main chat before rerunning `/cook`",
+        "Bare `/cook` is the only supported workflow entrypoint.",
+        "`/cook <text>` is no longer supported; put mission text in the main chat, then rerun bare `/cook`.",
+        "clarify the mission in the main chat before rerunning bare `/cook`",
         "Matching or unclear discussion resumes from canonical `.agent/**` state.",
         "approval-only Start/Cancel gate",
         "Start new workflow from recent discussion",
@@ -24,27 +24,26 @@ checks = {
         "README/CHANGELOG updates still count as concrete repo changes",
         "assistant-produced summaries and plan/spec/design-doc/proposal-only artifacts do not",
         "Assistant/summary artifacts or plan/spec/design-doc/proposal-only context do not refocus the workflow.",
+        "`/cook <text>` is rejected without running proposal routing or rewriting workflow state.",
     ],
     "CHANGELOG.md": [
-        "bare `/cook` as the only supported workflow entrypoint",
-        "clarify the mission before rerunning bare `/cook`",
-        "packaged parity now fails closed on the bare-only contract",
-        "that old inline-argument path is no longer supported now that bare `/cook` is the only public entrypoint",
-        "README/CHANGELOG/docs-only deliverables as concrete repo-change missions",
-        "ignore assistant/branch/compaction summary artifacts for startup/refocus readiness",
-        "plan/spec/design-doc/proposal-only context without rewriting canonical state",
+        "removed inline `/cook <text>` argument support so bare `/cook` is now the only supported workflow entrypoint",
+        "packaged release parity fail closed when command arguments are passed instead of discussion driving proposal derivation",
+        "historically allowed `/cook <hint>` as an analyst-only high-priority prompt",
+        "that inline-argument path has since been removed so bare `/cook` is now the only supported entrypoint",
     ],
     "extensions/completion/index.ts": [
-        'description: "Discussion-driven /cook workflow: start, continue, refocus, or start the next round"',
-        "If an inline /cook hint is present, treat it as a high-priority user hint that may focus the mission, but do not ignore conflicting discussion or skip missing details.",
-        "/cook failed closed because recent discussion and any optional inline /cook hint did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook.",
+        'description: "Bare /cook workflow: start, continue, refocus, or start the next round"',
+        'const COOK_BARE_ONLY_GUIDANCE =',
+        '"/cook only supports the bare /cook entrypoint. Move mission text into the main chat, then rerun /cook."',
+        '"/cook failed closed because recent discussion did not produce a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun /cook."',
     ],
 }
 
 forbidden = {
-    "README.md": ["compatibility" + " shim"],
+    "README.md": ["compatibility" + " shim", "/cook <hint>", "optional inline /cook hint"],
     "CHANGELOG.md": ["compatibility" + " shim"],
-    "extensions/completion/index.ts": ["temporary" + " compatibility" + " shim, pass /cook"],
+    "extensions/completion/index.ts": ["temporary" + " compatibility" + " shim, pass /cook", "inline /cook hint", "optional inline /cook hint"],
 }
 
 for path, needles in checks.items():
@@ -63,9 +62,11 @@ PY
 npm run smoke-test
 npm run refocus-test
 npm run context-proposal-test
+bash ./scripts/role-runner-contract-test.sh
 bash ./scripts/canonical-evidence-artifact-test.sh
 bash ./scripts/active-slice-contract-test.sh
 npm run observability-status-test
+bash ./scripts/legacy-cleanup-test.sh
 npm run evaluator-calibration-test
 npm run rubric-contract-test
 npm pack --dry-run >/dev/null

package/scripts/role-runner-contract-test.sh

@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+cd "$ROOT"
+
+node <<'NODE'
+const fs = require('node:fs');
+
+const read = (file) => fs.readFileSync(file, 'utf8');
+const assertIncludes = (file, snippet) => {
+  const text = read(file);
+  if (!text.includes(snippet)) {
+    throw new Error(`${file} is missing required role-runner extraction text: ${snippet}`);
+  }
+};
+const assertNotIncludes = (file, snippet) => {
+  const text = read(file);
+  if (text.includes(snippet)) {
+    throw new Error(`${file} still contains stale inline role-runner text: ${snippet}`);
+  }
+};
+
+assertIncludes('extensions/completion/role-runner.ts', 'import { completionRootKey, findCompletionRoot, findRepoRoot, loadCompletionDataForReminder } from "./state-store";');
+assertIncludes('extensions/completion/role-runner.ts', 'import { parseReportFields, transcribeRoleOutput, type TranscriptionResult } from "./transcription";');
+assertIncludes('extensions/completion/role-runner.ts', 'const agent = await loadAgentDefinition(params.root, params.role);');
+assertIncludes('extensions/completion/role-runner.ts', 'await loadCompletionDataForReminder(params.root);');
+assertIncludes('extensions/completion/role-runner.ts', 'const systemPromptTemp = await writeTempFile(params.root, "pi-completion-role-", agent.systemPrompt);');
+assertIncludes('extensions/completion/role-runner.ts', 'const reportFields = parseReportFields(output);');
+assertIncludes('extensions/completion/role-runner.ts', 'const transcription = exitCode === 0 ? await transcribeRoleOutput(params.role, params.root, output, reportFields) : undefined;');
+assertIncludes('extensions/completion/role-runner.ts', 'env: { ...process.env, PI_COMPLETION_ROLE: params.role },');
+assertIncludes('extensions/completion/role-runner.ts', 'async function runContextProposalAnalystSubprocess(');
+assertIncludes('extensions/completion/role-runner.ts', 'export async function analyzeContextProposalWithAgent(');
+assertIncludes('extensions/completion/index.ts', 'import { analyzeContextProposalWithAgent, runCompletionRole } from "./role-runner";');
+assertIncludes('extensions/completion/index.ts', 'const result = await runCompletionRole({');
+assertIncludes('extensions/completion/index.ts', 'await analyzeContextProposalWithAgent({');
+assertNotIncludes('extensions/completion/index.ts', 'const systemPromptTemp = await writeTempFile(runCwd, "pi-cook-proposal-analyst-", CONTEXT_PROPOSAL_ANALYST_SYSTEM_PROMPT);');
+assertNotIncludes('extensions/completion/index.ts', 'const invocation = getPiInvocation(args);');
+assertNotIncludes('extensions/completion/index.ts', 'async function loadAgentDefinition(');
+assertNotIncludes('extensions/completion/index.ts', 'async function writeTempFile(');
+assertNotIncludes('extensions/completion/index.ts', 'function getPiInvocation(');
+NODE
+
+echo "role-runner contract test passed"

package/scripts/rubric-contract-test.sh

@@ -77,13 +77,15 @@ assertIncludes('CHANGELOG.md', 'added canonical `task_type: completion-workflow`
 assertIncludes('CHANGELOG.md', 'threaded canonical `evaluation_profile` plus the active-slice implementation contract into reviewer/auditor/stop-judge reminder and dispatch surfaces');
 assertIncludes('CHANGELOG.md', 'made reviewer/auditor/stop-judge transcription fail closed on malformed rubric-bearing outputs while still accepting valid reports');
 assertIncludes('extensions/completion/index.ts', 'Canonical routing profile:\\n- task_type: ${taskType}\\n- evaluation_profile: ${evaluationProfile}');
-assertIncludes('extensions/completion/index.ts', '`Task type: ${currentTaskType(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`Evaluation profile: ${currentEvaluationProfile(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`task_type: ${currentTaskType(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', '`evaluation_profile: ${currentEvaluationProfile(snapshot) ?? "(missing)"}`');
-assertIncludes('extensions/completion/index.ts', 'Canonical evaluation handoff for ${role}:');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`Task type: ${args.taskType ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`Evaluation profile: ${args.evaluationProfile ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- task_type: ${deps.currentTaskType(snapshot) ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', '`- evaluation_profile: ${deps.currentEvaluationProfile(snapshot) ?? "(missing)"}`');
+assertIncludes('extensions/completion/prompt-surfaces.ts', 'Canonical evaluation handoff for ${role}:');
 assertIncludes('extensions/completion/index.ts', 'buildEvaluationRoleReminderText(snapshot, nextRole)');
-assertIncludes('extensions/completion/index.ts', 'roleReporting.transcribeCanonicalRoleReport');
+assertIncludes('extensions/completion/index.ts', 'import { parseFirstNumber, parseYesNo } from "./transcription";');
+assertIncludes('extensions/completion/role-runner.ts', 'import { parseReportFields, transcribeRoleOutput, type TranscriptionResult } from "./transcription";');
+assertIncludes('extensions/completion/transcription.ts', 'roleReporting.transcribeCanonicalRoleReport');
 assertIncludes('extensions/completion/role-reporting.js', 'Missing Rubric heading for ${role}.');
 assertIncludes('extensions/completion/role-reporting.js', 'Reviewer output cannot mark \'Acceptable as-is: yes\' when any rubric line is fail.');
 assertIncludes('extensions/completion/role-reporting.js', 'Auditor output must answer \'Tracked and unignored worktree is clean\' with yes or no.');

package/scripts/smoke-test.sh

@@ -3,7 +3,7 @@ set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 pi() {
-  command pi --no-extensions "$@"
+  env -u PI_COMPLETION_ROLE command pi --no-extensions "$@"
 }
 TMPDIR="$(mktemp -d)"
 trap 'rm -rf "$TMPDIR"' EXIT
@@ -50,8 +50,10 @@ PY
 ROOT="$TMPDIR/repo"
 KICKOFF_PROMPT="$TMPDIR/kickoff-prompt.txt"
 RESUME_PROMPT="$TMPDIR/resume-prompt.txt"
+ORDINARY_SYSTEM_REMINDER="$TMPDIR/ordinary-system-reminder.txt"
 UNCLEAR_ROUTING_SNAPSHOT="$TMPDIR/active-unclear-routing.json"
 UNCLEAR_CHOOSER_SNAPSHOT="$TMPDIR/unexpected-existing-workflow-chooser.json"
+ORDINARY_AUTO_RESUME_PROMPT="$TMPDIR/ordinary-auto-resume-prompt.txt"
 AUTO_RESUME_PROMPT="$TMPDIR/auto-resume-prompt.txt"
 INLINE_REJECTION_ROUTING_SNAPSHOT="$TMPDIR/inline-arg-routing.json"
 INLINE_REJECTION_PROPOSAL_SNAPSHOT="$TMPDIR/inline-arg-proposal.json"
@@ -82,11 +84,11 @@ routing = Path(sys.argv[3])
 proposal = Path(sys.argv[4])
 chooser = Path(sys.argv[5])
 
-assert not Path('.agent').exists(), 'startup inline /cook hint cancel should leave canonical state untouched'
-assert not routing.exists(), 'startup inline /cook hint should not open active-workflow routing'
-assert proposal.exists(), 'startup inline /cook hint should still prepare a proposal for confirmation'
-assert not chooser.exists(), 'startup inline /cook hint should not open the chooser flow during startup'
-assert 'Cancelled recent-discussion workflow proposal.' in output, 'startup inline /cook hint cancel should surface the proposal cancellation message'
+assert not Path('.agent').exists(), 'startup /cook <text> rejection should leave canonical state untouched'
+assert not routing.exists(), 'startup /cook <text> rejection should not open active-workflow routing'
+assert not proposal.exists(), 'startup /cook <text> rejection should not prepare a proposal snapshot'
+assert not chooser.exists(), 'startup /cook <text> rejection should not open the chooser flow'
+assert '/cook only supports the bare /cook entrypoint.' in output, 'startup /cook <text> rejection should explain the bare-only contract'
 PY
 
 write_session "$BOOTSTRAP_SESSION" "$ROOT" "$BOOTSTRAP_DISCUSSION"
@@ -139,6 +141,27 @@ assert f'- task_type: {expected_task_type}' in kickoff, 'kickoff prompt missing
 assert f'- evaluation_profile: {expected_eval_profile}' in kickoff, 'kickoff prompt missing canonical evaluation_profile'
 PY
 
+rm -f "$ORDINARY_SYSTEM_REMINDER" "$ORDINARY_AUTO_RESUME_PROMPT"
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+PI_COMPLETION_TEST_SYSTEM_REMINDER_PATH="$ORDINARY_SYSTEM_REMINDER" \
+PI_COMPLETION_TEST_AUTO_CONTINUE_ON_SESSION_START=1 \
+PI_COMPLETION_TEST_AUTO_CONTINUE_PROMPT_PATH="$ORDINARY_AUTO_RESUME_PROMPT" \
+pi -e "$PKG_ROOT" -p "Summarize the repo briefly." \
+  >"$TMPDIR/pi-completion-smoke-ordinary.out" 2>"$TMPDIR/pi-completion-smoke-ordinary.err"
+
+python3 - "$TMPDIR/pi-completion-smoke-ordinary.out" "$TMPDIR/pi-completion-smoke-ordinary.err" "$ORDINARY_SYSTEM_REMINDER" "$ORDINARY_AUTO_RESUME_PROMPT" <<'PY'
+import sys
+from pathlib import Path
+
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+reminder = Path(sys.argv[3])
+auto_resume = Path(sys.argv[4])
+
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject completion reminder solely from canonical state'
+assert not auto_resume.exists(), 'ordinary non-/cook turn should not queue auto-resume before /cook activation'
+assert 'Skipped completion workflow auto-resume prompt (test mode)' not in output, 'ordinary non-/cook turn should not attempt auto-resume'
+PY
+
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
 PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$RESUME_PROMPT" \
 PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$UNCLEAR_ROUTING_SNAPSHOT" \