@linimin/pi-letscook 0.1.43 → 0.1.45

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 ## Unreleased
 
+## 0.1.44
+
+### Fixed
+
+- inject a done-workflow boundary prompt into ordinary primary-agent turns so finished completion state is treated as historical context only and the agent must not resume/reground/refocus the workflow unless the user explicitly reruns `/cook`
+
 ## 0.1.43
 
 ### Fixed

package/extensions/completion/index.ts

@@ -223,6 +223,7 @@ class StartupAnalystOverlay extends Container {
 }
 
 const liveRoleActivityByRoot = new Map<string, LiveRoleActivity>();
+const activatedCompletionRoutingRoots = new Set<string>();
 const LIVE_ROLE_WAITING_MS = 15_000;
 const LIVE_ROLE_STALLED_MS = 45_000;
 const LIVE_ROLE_HEARTBEAT_MS = 5_000;
@@ -562,8 +563,34 @@ function isWorkflowDone(snapshot: CompletionStateSnapshot | undefined): boolean
 	return asString(snapshot?.state?.continuation_policy) === "done";
 }
 
+function activateCompletionRoutingForRoot(root: string | undefined): void {
+	if (!root) return;
+	activatedCompletionRoutingRoots.add(path.resolve(root));
+}
+
+function hasCompletionRoutingActivation(snapshot: CompletionStateSnapshot | undefined): boolean {
+	if (!snapshot) return false;
+	if (roleFromEnv()) return true;
+	return activatedCompletionRoutingRoots.has(path.resolve(snapshot.files.root));
+}
+
 function shouldInjectCompletionWorkflowContext(snapshot: CompletionStateSnapshot | undefined): boolean {
-	return Boolean(snapshot) && !isWorkflowDone(snapshot);
+	return hasCompletionRoutingActivation(snapshot);
+}
+
+function buildDoneWorkflowBoundaryReminder(snapshot: CompletionStateSnapshot): string {
+	const missionAnchor = asString(snapshot.state?.mission_anchor) ?? asString(snapshot.plan?.mission_anchor) ?? "(unknown)";
+	const continuationReason = asString(snapshot.state?.continuation_reason) ?? "(unknown)";
+	return [
+		"A previous completion workflow exists for this repo, but it is closed.",
+		`Mission anchor: ${missionAnchor}`,
+		`Continuation policy: ${asString(snapshot.state?.continuation_policy) ?? "unknown"}`,
+		`Continuation reason: ${continuationReason}`,
+		"Treat the previous completion workflow as historical context only.",
+		"Do not resume, reground, refocus, reopen, or otherwise restart completion workflow from this context unless the user explicitly runs /cook.",
+		"For ordinary user requests, respond normally and ignore prior completion-protocol instructions that were only relevant to the finished workflow.",
+		"Only /cook may reactivate workflow routing for the next round.",
+	].join(" ");
 }
 
 function extractTextFromMessageContent(content: unknown): string {
@@ -1918,6 +1945,7 @@ async function autoContinueWorkflowIfNeeded(pi: ExtensionAPI, ctx: { cwd: string
 		clearDriverContinuationTracker(rootKey);
 		return;
 	}
+	if (!hasCompletionRoutingActivation(snapshot)) return;
 	const fingerprint = completionContinuationFingerprint(snapshot);
 	if (!fingerprint) {
 		clearDriverContinuationTracker(rootKey);
@@ -2087,6 +2115,7 @@ async function resumeActiveWorkflowFromCanonicalState(
 	ctx: { cwd: string; hasUI: boolean; ui: any },
 	snapshot: CompletionStateSnapshot,
 ): Promise<void> {
+	activateCompletionRoutingForRoot(snapshot.files.root);
 	const mission = currentMissionAnchor(snapshot);
 	pi.setSessionName(`completion: ${mission.slice(0, 60)}`);
 	const resumePrompt = completionResumePrompt(
@@ -3738,18 +3767,22 @@ export default function completionExtension(pi: ExtensionAPI) {
 			if (fingerprint) markQueuedDriverPromptInFlight(rootKey, fingerprint);
 		}
 		if (!loaded || !shouldInjectCompletionWorkflowContext(loaded.snapshot)) return;
-		const markerText = await readText(loaded.snapshot.files.compactionMarkerPath);
-		let marker: JsonRecord | undefined;
-		if (markerText) {
-			try {
-				const parsed = JSON.parse(markerText);
-				marker = isRecord(parsed) ? parsed : undefined;
-			} catch {
-				marker = undefined;
+		const additions = isWorkflowDone(loaded.snapshot)
+			? [buildDoneWorkflowBoundaryReminder(loaded.snapshot)]
+			: [buildSystemReminder(loaded.snapshot, loaded.sliceHistory, loaded.stopHistory)];
+		if (!isWorkflowDone(loaded.snapshot)) {
+			const markerText = await readText(loaded.snapshot.files.compactionMarkerPath);
+			let marker: JsonRecord | undefined;
+			if (markerText) {
+				try {
+					const parsed = JSON.parse(markerText);
+					marker = isRecord(parsed) ? parsed : undefined;
+				} catch {
+					marker = undefined;
+				}
 			}
+			if (marker) additions.push(buildPostCompactionDriverInstructions(loaded.snapshot, marker));
 		}
-		const additions = [buildSystemReminder(loaded.snapshot, loaded.sliceHistory, loaded.stopHistory)];
-		if (marker) additions.push(buildPostCompactionDriverInstructions(loaded.snapshot, marker));
 		maybeWriteTestSnapshot(completionTestSystemReminderPath(), additions.join("\n\n"));
 		const systemPrompt = getSystemPromptSafe(ctx);
 		if (!systemPrompt) return;
@@ -3760,7 +3793,7 @@ export default function completionExtension(pi: ExtensionAPI) {
 
 	pi.on("session_before_compact", async (event, ctx) => {
 		const loaded = await loadCompletionDataForReminder(getCtxCwd(ctx));
-		if (!loaded || !shouldInjectCompletionWorkflowContext(loaded.snapshot)) return;
+		if (!loaded || isWorkflowDone(loaded.snapshot)) return;
 		const { preparation } = event;
 		const summary = buildResumeCapsule(loaded.snapshot, loaded.sliceHistory, loaded.stopHistory);
 		await fsp.mkdir(loaded.snapshot.files.tmpDir, { recursive: true });
@@ -4211,6 +4244,7 @@ export default function completionExtension(pi: ExtensionAPI) {
 				}
 			}
 			kickoffMissionAnchor = kickoffMissionAnchor ?? currentMissionAnchor(snapshot);
+			activateCompletionRoutingForRoot(snapshot.files.root);
 			pi.setSessionName(`completion: ${kickoffMissionAnchor.slice(0, 60)}`);
 			const kickoffPrompt = completionKickoff(
 				goal,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linimin/pi-letscook",
-  "version": "0.1.43",
+  "version": "0.1.45",
   "description": "Pi package for long-running completion workflows with canonical .agent state, role-based subagents, continuity, and verification helpers.",
   "license": "MIT",
   "private": false,

package/scripts/canonical-evidence-artifact-test.sh

@@ -3,7 +3,7 @@ set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 pi() {
-  command pi --no-extensions "$@"
+  env -u PI_COMPLETION_ROLE command pi --no-extensions "$@"
 }
 TMPDIR="$(mktemp -d)"
 CURRENT_EVIDENCE_BACKUP=""
@@ -377,6 +377,7 @@ PY
 bash .agent/verify_completion_control_plane.sh >/dev/null
 bash .agent/verify_completion_stop.sh >/dev/null
 
+rm -f "$SYSTEM_REMINDER"
 PI_COMPLETION_TEST_SYSTEM_REMINDER_PATH="$SYSTEM_REMINDER" \
 pi -e "$PKG_ROOT" -p "Summarize the completion reminder briefly." \
   >"$TMPDIR/pi-canonical-evidence-reminder.out" 2>"$TMPDIR/pi-canonical-evidence-reminder.err"
@@ -385,11 +386,8 @@ python3 - "$SYSTEM_REMINDER" <<'PY'
 import sys
 from pathlib import Path
 
-text = Path(sys.argv[1]).read_text()
-assert 'Canonical truth lives in .agent/state.json, .agent/plan.json, .agent/active-slice.json, .agent/slice-history.jsonl, .agent/stop-check-history.jsonl, and .agent/verification-evidence.json.' in text, text
-assert 'Verification evidence artifact: .agent/verification-evidence.json (present)' in text, text
-assert 'Verification evidence summary:' in text, text
-assert 'selected_slice' in text, text
+reminder = Path(sys.argv[1])
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject completion reminder solely from selected-slice canonical state'
 PY
 
 python3 - <<'PY'
@@ -431,9 +429,12 @@ PI_COMPLETION_TEST_SYSTEM_REMINDER_PATH="$SYSTEM_REMINDER" \
 pi -e "$PKG_ROOT" -p "Summarize the latest release briefly." \
   >"$TMPDIR/pi-canonical-evidence-done-reminder.out" 2>"$TMPDIR/pi-canonical-evidence-done-reminder.err"
 
-[[ ! -f "$SYSTEM_REMINDER" ]] || {
-  echo "expected no completion reminder snapshot when continuation_policy is done" >&2
-  exit 1
-}
+python3 - "$SYSTEM_REMINDER" <<'PY'
+import sys
+from pathlib import Path
+
+reminder = Path(sys.argv[1])
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject closed-workflow boundary routing before /cook reactivation'
+PY
 
 echo "canonical evidence artifact test passed: $TMPDIR"

package/scripts/smoke-test.sh

@@ -3,7 +3,7 @@ set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 pi() {
-  command pi --no-extensions "$@"
+  env -u PI_COMPLETION_ROLE command pi --no-extensions "$@"
 }
 TMPDIR="$(mktemp -d)"
 trap 'rm -rf "$TMPDIR"' EXIT
@@ -50,8 +50,10 @@ PY
 ROOT="$TMPDIR/repo"
 KICKOFF_PROMPT="$TMPDIR/kickoff-prompt.txt"
 RESUME_PROMPT="$TMPDIR/resume-prompt.txt"
+ORDINARY_SYSTEM_REMINDER="$TMPDIR/ordinary-system-reminder.txt"
 UNCLEAR_ROUTING_SNAPSHOT="$TMPDIR/active-unclear-routing.json"
 UNCLEAR_CHOOSER_SNAPSHOT="$TMPDIR/unexpected-existing-workflow-chooser.json"
+ORDINARY_AUTO_RESUME_PROMPT="$TMPDIR/ordinary-auto-resume-prompt.txt"
 AUTO_RESUME_PROMPT="$TMPDIR/auto-resume-prompt.txt"
 INLINE_REJECTION_ROUTING_SNAPSHOT="$TMPDIR/inline-arg-routing.json"
 INLINE_REJECTION_PROPOSAL_SNAPSHOT="$TMPDIR/inline-arg-proposal.json"
@@ -139,6 +141,27 @@ assert f'- task_type: {expected_task_type}' in kickoff, 'kickoff prompt missing
 assert f'- evaluation_profile: {expected_eval_profile}' in kickoff, 'kickoff prompt missing canonical evaluation_profile'
 PY
 
+rm -f "$ORDINARY_SYSTEM_REMINDER" "$ORDINARY_AUTO_RESUME_PROMPT"
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+PI_COMPLETION_TEST_SYSTEM_REMINDER_PATH="$ORDINARY_SYSTEM_REMINDER" \
+PI_COMPLETION_TEST_AUTO_CONTINUE_ON_SESSION_START=1 \
+PI_COMPLETION_TEST_AUTO_CONTINUE_PROMPT_PATH="$ORDINARY_AUTO_RESUME_PROMPT" \
+pi -e "$PKG_ROOT" -p "Summarize the repo briefly." \
+  >"$TMPDIR/pi-completion-smoke-ordinary.out" 2>"$TMPDIR/pi-completion-smoke-ordinary.err"
+
+python3 - "$TMPDIR/pi-completion-smoke-ordinary.out" "$TMPDIR/pi-completion-smoke-ordinary.err" "$ORDINARY_SYSTEM_REMINDER" "$ORDINARY_AUTO_RESUME_PROMPT" <<'PY'
+import sys
+from pathlib import Path
+
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+reminder = Path(sys.argv[3])
+auto_resume = Path(sys.argv[4])
+
+assert not reminder.exists(), 'ordinary non-/cook turn should not inject completion reminder solely from canonical state'
+assert not auto_resume.exists(), 'ordinary non-/cook turn should not queue auto-resume before /cook activation'
+assert 'Skipped completion workflow auto-resume prompt (test mode)' not in output, 'ordinary non-/cook turn should not attempt auto-resume'
+PY
+
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
 PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$RESUME_PROMPT" \
 PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$UNCLEAR_ROUTING_SNAPSHOT" \