@linimin/pi-letscook 0.1.37 → 0.1.40

package/scripts/observability-status-test.sh

@@ -2,6 +2,9 @@
 set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+pi() {
+  command pi --no-extensions "$@"
+}
 TMPDIR="$(mktemp -d)"
 trap 'rm -rf "$TMPDIR"' EXIT
 

package/scripts/refocus-test.sh

@@ -2,6 +2,9 @@
 set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+pi() {
+  command pi --no-extensions "$@"
+}
 TMPDIR="$(mktemp -d)"
 trap 'rm -rf "$TMPDIR"' EXIT
 
@@ -47,7 +50,13 @@ PY
 cd "$TMPDIR"
 git init -q
 
-pi -e "$PKG_ROOT" -p "/cook smoke-test mission" >"$TMPDIR/pi-completion-refocus-bootstrap.out" 2>"$TMPDIR/pi-completion-refocus-bootstrap.err" &
+BOOTSTRAP_SESSION="$TMPDIR/session-bootstrap.jsonl"
+BOOTSTRAP_DISCUSSION=$'Mission: Smoke-test mission.\nScope:\n- Bootstrap a completion workflow for the refocus regression fixture.\nConstraints:\n- Use supported bare /cook discussion flow only.\nAcceptance:\n- Materialize canonical state for active-workflow refocus tests.'
+write_session "$BOOTSTRAP_SESSION" "$TMPDIR" "$BOOTSTRAP_DISCUSSION"
+
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+pi --session "$BOOTSTRAP_SESSION" -e "$PKG_ROOT" -p "/cook" >"$TMPDIR/pi-completion-refocus-bootstrap.out" 2>"$TMPDIR/pi-completion-refocus-bootstrap.err" &
 PI_PID=$!
 for _ in $(seq 1 60); do
   if [[ -f .agent/profile.json && -f .agent/state.json && -f .agent/plan.json && -f .agent/active-slice.json ]]; then
@@ -73,45 +82,78 @@ print(state['mission_anchor'])
 PY
 )"
 
-CHOOSER_SNAPSHOT="$TMPDIR/existing-workflow-chooser.json"
+INLINE_REJECTION_ROUTING="$TMPDIR/inline-arg-routing.json"
+INLINE_REJECTION_PROPOSAL="$TMPDIR/inline-arg-proposal.json"
+INLINE_REJECTION_CHOOSER="$TMPDIR/inline-arg-chooser.json"
+INLINE_REJECTION_BASELINE="$TMPDIR/inline-arg-before.json"
+python3 - "$INLINE_REJECTION_BASELINE" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+tracked = [
+    Path('.agent/mission.md'),
+    Path('.agent/profile.json'),
+    Path('.agent/state.json'),
+    Path('.agent/plan.json'),
+    Path('.agent/active-slice.json'),
+    Path('.agent/verification-evidence.json'),
+]
+Path(sys.argv[1]).write_text(json.dumps({path.name: path.read_text() for path in tracked}, indent=2) + '\n')
+PY
+
 PI_COMPLETION_EXISTING_WORKFLOW_ACTION=cancel \
-PI_COMPLETION_TEST_EXISTING_WORKFLOW_CHOOSER_PATH="$CHOOSER_SNAPSHOT" \
+PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$INLINE_REJECTION_ROUTING" \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$INLINE_REJECTION_PROPOSAL" \
+PI_COMPLETION_TEST_EXISTING_WORKFLOW_CHOOSER_PATH="$INLINE_REJECTION_CHOOSER" \
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
 pi -e "$PKG_ROOT" -p "/cook replacement mission that should stay in the main chat" \
-  >"$TMPDIR/pi-completion-refocus-cancel.out" 2>"$TMPDIR/pi-completion-refocus-cancel.err"
+  >"$TMPDIR/pi-completion-refocus-inline-arg.out" 2>"$TMPDIR/pi-completion-refocus-inline-arg.err"
 
-python3 - "$CHOOSER_SNAPSHOT" "$TMPDIR/pi-completion-refocus-cancel.out" "$TMPDIR/pi-completion-refocus-cancel.err" "$INITIAL_MISSION" <<'PY'
+python3 - "$TMPDIR/pi-completion-refocus-inline-arg.out" "$TMPDIR/pi-completion-refocus-inline-arg.err" "$INLINE_REJECTION_ROUTING" "$INLINE_REJECTION_PROPOSAL" "$INLINE_REJECTION_CHOOSER" "$INITIAL_MISSION" "$INLINE_REJECTION_BASELINE" <<'PY'
 import json
 import sys
 from pathlib import Path
 
-chooser = json.loads(Path(sys.argv[1]).read_text())
-output = Path(sys.argv[2]).read_text() + Path(sys.argv[3]).read_text()
-initial_mission = sys.argv[4]
-state = json.loads(Path('.agent/state.json').read_text())
-plan = json.loads(Path('.agent/plan.json').read_text())
-active = json.loads(Path('.agent/active-slice.json').read_text())
-
-assert state['mission_anchor'] == initial_mission, 'cancelled chooser should keep the current mission anchor'
-assert plan['mission_anchor'] == initial_mission, 'cancelled chooser should keep plan.json unchanged'
-assert active['mission_anchor'] == initial_mission, 'cancelled chooser should keep active-slice.json unchanged'
-assert chooser['title'].startswith('Existing completion workflow found'), 'chooser snapshot should describe the existing-workflow prompt'
-assert chooser['choices'][0].startswith('Continue current workflow'), 'chooser should keep the continue option'
-assert chooser['choices'][1].startswith('Abandon current workflow and start this new one'), 'chooser should keep the explicit-goal refocus option'
-assert 'Start/Cancel confirmation' in chooser['choices'][1], 'chooser should mention the approval-only replacement confirmation'
-assert chooser['choices'][2].startswith('Cancel'), 'chooser should keep the cancel option'
-assert 'Discuss changes in the main chat and rerun /cook.' in chooser['choices'][2], 'chooser cancel copy should redirect users back to the main chat and rerun /cook'
-assert 'Discuss changes in the main chat and rerun /cook.' in output, 'chooser cancel output should redirect users back to the main chat and rerun /cook'
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+routing = Path(sys.argv[3])
+proposal = Path(sys.argv[4])
+chooser = Path(sys.argv[5])
+initial_mission = sys.argv[6]
+before = json.loads(Path(sys.argv[7]).read_text())
+tracked = [
+    Path('.agent/mission.md'),
+    Path('.agent/profile.json'),
+    Path('.agent/state.json'),
+    Path('.agent/plan.json'),
+    Path('.agent/active-slice.json'),
+    Path('.agent/verification-evidence.json'),
+]
+current_state = json.loads(before['state.json'])
+assert current_state['mission_anchor'] == initial_mission, 'active inline /cook args should start from the current mission anchor'
+assert 'Inline /cook arguments are no longer supported.' in output, 'active inline /cook args should explain the hard rejection'
+assert 'Clarify the mission in the main chat and rerun bare /cook.' in output, 'active inline /cook args should redirect users back to main chat plus bare /cook'
+assert not routing.exists(), 'active inline /cook args should not run active-workflow routing'
+assert not proposal.exists(), 'active inline /cook args should not open proposal confirmation'
+assert not chooser.exists(), 'active inline /cook args should not open the existing-workflow chooser'
+after = {path.name: path.read_text() for path in tracked}
+assert before == after, 'active inline /cook args should leave canonical files unchanged'
 PY
 
-EXPLICIT_ROUTING_SNAPSHOT="$TMPDIR/explicit-goal-routing.json"
+SESSION_INITIAL_REFOCUS="$TMPDIR/session-initial-bare-refocus.jsonl"
+INITIAL_REFOCUS_DISCUSSION=$'Mission: Remove completion status line, keep widget.\nScope:\n- Replace the initial smoke-test workflow with the widget mission.\nConstraints:\n- Keep the approval-only Start/Cancel refocus gate.\nAcceptance:\n- Rewrite canonical state only after the replacement mission is approved.'
+INITIAL_REFOCUS_ROUTING="$TMPDIR/initial-bare-refocus-routing.json"
+write_session "$SESSION_INITIAL_REFOCUS" "$TMPDIR" "$INITIAL_REFOCUS_DISCUSSION"
+
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
 PI_COMPLETION_EXISTING_WORKFLOW_ACTION=refocus \
-PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$EXPLICIT_ROUTING_SNAPSHOT" \
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$INITIAL_REFOCUS_ROUTING" \
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
-pi -e "$PKG_ROOT" -p "/cook Remove completion status line, keep widget" \
+pi --session "$SESSION_INITIAL_REFOCUS" -e "$PKG_ROOT" -p "/cook" \
   >"$TMPDIR/pi-completion-refocus.out" 2>"$TMPDIR/pi-completion-refocus.err"
 
-python3 - "$EXPLICIT_ROUTING_SNAPSHOT" <<'PY'
+python3 - "$INITIAL_REFOCUS_ROUTING" <<'PY'
 import json
 import sys
 from pathlib import Path
@@ -144,10 +186,12 @@ assert state['next_mandatory_role'] == 'completion-regrounder', 'next_mandatory_
 assert state['continuation_reason'].startswith('User refocused workflow via /cook:'), 'continuation_reason should record the refocus'
 assert plan['plan_basis'] == 'user_refocus', 'plan.json plan_basis should be user_refocus after refocus'
 assert active['status'] == 'idle', 'active-slice.json status should reset to idle after refocus'
-assert routing['mode'] == 'explicit', 'explicit /cook <goal> should use explicit active-workflow routing mode'
-assert routing['action'] == 'refocus', 'explicit /cook <goal> should classify as refocus when the mission changes'
-assert routing['reason'] == 'explicit_goal', 'explicit /cook <goal> should record the explicit-goal routing reason'
-assert routing['proposedMissionAnchor'] == new_anchor, 'explicit routing snapshot should expose the replacement mission anchor'
+assert routing['mode'] == 'bare', 'supported refocus should use bare active-workflow routing mode'
+assert 'explicitGoal' not in routing, 'supported bare refocus should not expose removed explicit-goal shim fields'
+assert 'explicitGoalProvided' not in routing, 'supported bare refocus should not expose removed explicit-goal shim fields'
+assert routing['action'] == 'refocus', 'supported bare /cook should classify as refocus when the mission changes'
+assert routing['reason'] == 'clear_refocus', 'supported bare /cook should record the clear-refocus routing reason'
+assert routing['proposedMissionAnchor'] == new_anchor, 'bare refocus routing snapshot should expose the replacement mission anchor'
 PY
 
 UPDATED_MISSION="$(python3 - <<'PY'
@@ -159,7 +203,7 @@ PY
 )"
 
 if [[ "$INITIAL_MISSION" == "$UPDATED_MISSION" ]]; then
-  echo "expected mission anchor to change during explicit refocus" >&2
+  echo "expected mission anchor to change during supported bare refocus" >&2
   exit 1
 fi
 
@@ -198,6 +242,8 @@ assert state['mission_anchor'] == updated_mission, 'chooser cancel should keep t
 assert plan['mission_anchor'] == updated_mission, 'chooser cancel should keep plan.json unchanged'
 assert active['mission_anchor'] == updated_mission, 'chooser cancel should keep active-slice.json unchanged'
 assert routing['mode'] == 'bare', 'bare /cook should snapshot bare active-workflow routing mode'
+assert 'explicitGoal' not in routing, 'bare chooser routing should not expose removed explicit-goal shim fields'
+assert 'explicitGoalProvided' not in routing, 'bare chooser routing should not expose removed explicit-goal shim fields'
 assert routing['action'] == 'refocus', 'clear structured discussion should classify active bare /cook as refocus'
 assert routing['reason'] == 'clear_refocus', 'clear structured discussion should record the clear-refocus routing reason'
 assert routing['currentMissionAnchor'] == updated_mission, 'clear-refocus routing should keep the current mission anchor until the user approves replacement'
@@ -280,6 +326,8 @@ active = json.loads(Path('.agent/active-slice.json').read_text())
 
 assert proposal['mission'] == new_anchor, 'accepted bare refocus should preserve the replacement proposal mission'
 assert routing['mode'] == 'bare', 'accepted bare refocus should keep bare routing mode'
+assert 'explicitGoal' not in routing, 'accepted bare refocus should not expose removed explicit-goal shim fields'
+assert 'explicitGoalProvided' not in routing, 'accepted bare refocus should not expose removed explicit-goal shim fields'
 assert routing['action'] == 'refocus', 'accepted bare refocus should keep the clear-refocus classification'
 assert routing['reason'] == 'clear_refocus', 'accepted bare refocus should keep the clear-refocus reason'
 assert routing['currentMissionAnchor'] == 'Remove completion status line, keep widget.', 'accepted bare refocus should expose the original mission until Start is accepted'

package/scripts/release-check.sh

@@ -4,40 +4,74 @@ set -euo pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
 cd "$ROOT"
 
-echo "[release-check] running control-plane validation, public /cook parity, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, evaluator calibration, and rubric contract coverage"
+echo "[release-check] running control-plane validation, bare /cook parity, startup/refocus/context regressions, canonical evidence artifact, active-slice contract, observability, evaluator calibration, and rubric contract coverage"
 bash .agent/verify_completion_control_plane.sh
 
-echo "[release-check] verifying public /cook single-command parity"
+echo "[release-check] verifying public bare /cook parity"
 python3 - <<'PY'
+import re
 from pathlib import Path
 
 checks = {
     "README.md": [
-        "Bare `/cook` is now the primary workflow entrypoint.",
-        "`/cook <text>` is still supported as a temporary compatibility shim",
+        "Bare `/cook` is the only supported workflow entrypoint.",
+        "clarify the mission in the main chat before rerunning bare `/cook`",
         "Matching or unclear discussion resumes from canonical `.agent/**` state.",
         "approval-only Start/Cancel gate",
         "Start new workflow from recent discussion",
         "fails closed instead of guessing",
+        "README/CHANGELOG updates still count as concrete repo changes",
+        "assistant-produced summaries and plan/spec/design-doc/proposal-only artifacts do not",
+        "Assistant/summary artifacts or plan/spec/design-doc/proposal-only context do not refocus the workflow.",
     ],
     "CHANGELOG.md": [
-        "single public discussion-first workflow command",
-        "temporary compatibility shim",
-        "approval-only Start/Cancel gate",
-        "fail-closed ambiguous-discussion behavior",
-        "release-gated public-parity assertions",
+        "bare `/cook` as the only supported workflow entrypoint",
+        "clarify the mission before rerunning bare `/cook`",
+        "packaged parity now fails closed on the bare-only contract",
+        "that old inline-argument path is no longer supported now that bare `/cook` is the only public entrypoint",
+        "README/CHANGELOG/docs-only deliverables as concrete repo-change missions",
+        "ignore assistant/branch/compaction summary artifacts for startup/refocus readiness",
+        "plan/spec/design-doc/proposal-only context without rewriting canonical state",
     ],
     "extensions/completion/index.ts": [
         'description: "Discussion-driven /cook workflow: start, continue, refocus, or start the next round"',
-        "temporary compatibility shim, pass /cook <text>",
+        "Inline /cook arguments are no longer supported. Clarify the mission in the main chat and rerun bare /cook.",
+        "Bare /cook failed closed because recent discussion did not contain a clear execution-ready Mission/Scope/Constraints/Acceptance proposal for concrete repo changes. Clarify the concrete repo changes in the main chat and rerun bare /cook.",
     ],
 }
 
+forbidden = {
+    "README.md": ["compatibility" + " shim"],
+    "CHANGELOG.md": ["compatibility" + " shim"],
+    "extensions/completion/index.ts": ["temporary" + " compatibility" + " shim, pass /cook"],
+}
+
+public_doc_paths = [
+    Path("README.md"),
+    Path("CHANGELOG.md"),
+    Path("PUBLISHING.md"),
+]
+inline_cook_pattern = re.compile(r"/cook\s*<[^>]+>")
+
 for path, needles in checks.items():
     text = Path(path).read_text()
     for needle in needles:
         if needle not in text:
-            raise SystemExit(f"[release-check] missing expected public /cook parity text in {path}: {needle}")
+            raise SystemExit(f"[release-check] missing expected bare /cook parity text in {path}: {needle}")
+
+for path, needles in forbidden.items():
+    text = Path(path).read_text()
+    for needle in needles:
+        if needle in text:
+            raise SystemExit(f"[release-check] found stale compatibility wording in {path}: {needle}")
+
+for path in public_doc_paths:
+    text = path.read_text()
+    match = inline_cook_pattern.search(text)
+    if match:
+        raise SystemExit(
+            f"[release-check] found unsupported inline /cook syntax in {path}: {match.group(0)}"
+        )
 PY
 
 npm run smoke-test

package/scripts/smoke-test.sh

@@ -2,23 +2,98 @@
 set -euo pipefail
 
 PKG_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
+pi() {
+  command pi --no-extensions "$@"
+}
 TMPDIR="$(mktemp -d)"
 trap 'rm -rf "$TMPDIR"' EXIT
 
+write_session() {
+  local session_path="$1"
+  local cwd="$2"
+  local text="$3"
+  python3 - "$session_path" "$cwd" "$text" <<'PY'
+import json
+import sys
+from pathlib import Path
+
+session_path = Path(sys.argv[1])
+cwd = sys.argv[2]
+text = sys.argv[3]
+session_path.parent.mkdir(parents=True, exist_ok=True)
+entries = [
+    {
+        "type": "session",
+        "version": 3,
+        "id": "11111111-1111-4111-8111-111111111111",
+        "timestamp": "2026-01-01T00:00:00.000Z",
+        "cwd": cwd,
+    },
+    {
+        "type": "message",
+        "id": "a1b2c3d4",
+        "parentId": None,
+        "timestamp": "2026-01-01T00:00:01.000Z",
+        "message": {
+            "role": "user",
+            "content": text,
+            "timestamp": 1767225601000,
+        },
+    },
+]
+with session_path.open('w', encoding='utf-8') as fh:
+    for entry in entries:
+        fh.write(json.dumps(entry, ensure_ascii=False) + "\n")
+PY
+}
+
 ROOT="$TMPDIR/repo"
 KICKOFF_PROMPT="$TMPDIR/kickoff-prompt.txt"
 RESUME_PROMPT="$TMPDIR/resume-prompt.txt"
 UNCLEAR_ROUTING_SNAPSHOT="$TMPDIR/active-unclear-routing.json"
 UNCLEAR_CHOOSER_SNAPSHOT="$TMPDIR/unexpected-existing-workflow-chooser.json"
 AUTO_RESUME_PROMPT="$TMPDIR/auto-resume-prompt.txt"
+INLINE_REJECTION_ROUTING_SNAPSHOT="$TMPDIR/inline-arg-routing.json"
+INLINE_REJECTION_PROPOSAL_SNAPSHOT="$TMPDIR/inline-arg-proposal.json"
+INLINE_REJECTION_CHOOSER_SNAPSHOT="$TMPDIR/inline-arg-chooser.json"
+BOOTSTRAP_SESSION="$TMPDIR/session-smoke-bootstrap.jsonl"
+BOOTSTRAP_DISCUSSION=$'Mission: Exercise smoke-test bootstrap.\nScope:\n- Materialize the canonical completion control-plane files.\n- Keep the smoke test on supported bare /cook behavior.\nConstraints:\n- Do not rely on inline /cook arguments.\nAcceptance:\n- Scaffold canonical files and kickoff prompts for the smoke fixture.'
 
 mkdir -p "$ROOT"
 cd "$ROOT"
 git init -q
 
 PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
-PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$KICKOFF_PROMPT" \
+PI_COMPLETION_TEST_ACTIVE_WORKFLOW_ROUTING_PATH="$INLINE_REJECTION_ROUTING_SNAPSHOT" \
+PI_COMPLETION_TEST_CONTEXT_PROPOSAL_PATH="$INLINE_REJECTION_PROPOSAL_SNAPSHOT" \
+PI_COMPLETION_TEST_EXISTING_WORKFLOW_CHOOSER_PATH="$INLINE_REJECTION_CHOOSER_SNAPSHOT" \
 pi -e "$PKG_ROOT" -p "/cook smoke-test mission" \
+  >"$TMPDIR/pi-completion-smoke-inline-arg.out" 2>"$TMPDIR/pi-completion-smoke-inline-arg.err"
+
+python3 - "$TMPDIR/pi-completion-smoke-inline-arg.out" "$TMPDIR/pi-completion-smoke-inline-arg.err" "$INLINE_REJECTION_ROUTING_SNAPSHOT" "$INLINE_REJECTION_PROPOSAL_SNAPSHOT" "$INLINE_REJECTION_CHOOSER_SNAPSHOT" <<'PY'
+import sys
+from pathlib import Path
+
+output = Path(sys.argv[1]).read_text() + Path(sys.argv[2]).read_text()
+routing = Path(sys.argv[3])
+proposal = Path(sys.argv[4])
+chooser = Path(sys.argv[5])
+
+assert not Path('.agent').exists(), 'startup inline /cook args should fail closed without creating canonical state'
+assert not routing.exists(), 'startup inline /cook args should not open active-workflow routing'
+assert not proposal.exists(), 'startup inline /cook args should not open the proposal confirmation flow'
+assert not chooser.exists(), 'startup inline /cook args should not open the chooser flow'
+assert 'Inline /cook arguments are no longer supported.' in output, 'startup inline /cook args should explain the hard rejection'
+assert 'Clarify the mission in the main chat and rerun bare /cook.' in output, 'startup inline /cook args should redirect users back to main chat plus bare /cook'
+PY
+
+write_session "$BOOTSTRAP_SESSION" "$ROOT" "$BOOTSTRAP_DISCUSSION"
+
+PI_COMPLETION_CONTEXT_PROPOSAL_ACTION=accept \
+PI_COMPLETION_DISABLE_CONTEXT_PROPOSAL_ANALYST=1 \
+PI_COMPLETION_SKIP_DRIVER_KICKOFF=1 \
+PI_COMPLETION_TEST_DRIVER_PROMPT_PATH="$KICKOFF_PROMPT" \
+pi --session "$BOOTSTRAP_SESSION" -e "$PKG_ROOT" -p "/cook" \
   >"$TMPDIR/pi-completion-smoke-bootstrap.out" 2>"$TMPDIR/pi-completion-smoke-bootstrap.err"
 
 for file in .agent/profile.json .agent/state.json .agent/plan.json .agent/active-slice.json .agent/verification-evidence.json; do