@liiift-studio/sanity-visitor-insights 0.63.0 → 0.64.0

package/dist/index.js

@@ -2074,38 +2074,62 @@ function OverviewPanel({ data, previous, onBrush }) {
               source: "GA4",
               complete: true,
               unit: "percent",
-              // Fixed, not scaled to its own best day — otherwise a site at a flat 20%
-              // draws a full-height line and reads as healthy.
-              domain: [0, 1],
+              // Fixed at the bottom, open at the top.
+              //
+              // The lower bound is fixed so a site at a flat 20% cannot scale itself
+              // to full height and read as healthy. The UPPER bound is not clamped,
+              // because over-counting is a real fault with its own interpretation
+              // branch — and the card further down this very file refuses the same
+              // clamp in prose, saying `Math.min(1, …)` rendered a tag reporting
+              // 250% of reality as a flat 100% under the heading "How much GA4 is
+              // seeing", i.e. perfect. One quantity, two opposite policies, one
+              // file: the row drew a double-firing tag as a healthy flat line while
+              // the sentence beside it called the over-count out.
+              domain: [0, Math.max(1, ...(data.crossSource ?? []).map((d) => d.vercelPageviews !== null && d.ga4Pageviews !== null && d.vercelPageviews > 0 ? d.ga4Pageviews / d.vercelPageviews : 0))],
               points: (data.crossSource ?? []).map((d) => ({
                 date: d.date,
-                value: d.vercelPageviews !== null && d.ga4Pageviews !== null && d.vercelPageviews > 0 ? Math.min(1, d.ga4Pageviews / d.vercelPageviews) : null
+                value: d.vercelPageviews !== null && d.ga4Pageviews !== null && d.vercelPageviews > 0 ? d.ga4Pageviews / d.vercelPageviews : null
               })),
               // The most valuable ghost in the chart: a collapse reads as a step away
               // from last period's flat line, whether or not the detector fired.
               comparison: (previous?.crossSource ?? []).map((d) => ({
                 date: d.date,
-                value: d.vercelPageviews !== null && d.ga4Pageviews !== null && d.vercelPageviews > 0 ? Math.min(1, d.ga4Pageviews / d.vercelPageviews) : null
+                value: d.vercelPageviews !== null && d.ga4Pageviews !== null && d.vercelPageviews > 0 ? d.ga4Pageviews / d.vercelPageviews : null
               }))
             }] : [],
-            ...data.crossSource?.some((d) => d.revenue !== null) ? [{
-              key: "revenue",
-              label: "Revenue",
-              source: "Sanity",
-              complete: true,
-              unit: "money",
-              // A sale is an event on a date, not a level that varies day to day.
-              mark: "events",
-              points: (data.crossSource ?? []).map((d) => ({ date: d.date, value: d.revenue }))
-            }] : [{
+            // ORDERS ALWAYS, revenue only when it covers every order.
+            //
+            // This used to draw revenue whenever ANY day had a revenue figure, and
+            // otherwise orders — never both. Combined with the server filling a day's
+            // revenue as `revenueByDate[date] ?? 0`, that meant a day carrying a real
+            // order with no recorded amount arrived as a measured ZERO, and the row drew
+            // a zero-tick on it: the mark whose own comment says "measured, and it was
+            // nothing".
+            //
+            // At Darden 11 of 69 orders carry an amount, so the flagship chart was
+            // asserting that no sale happened on 58 days that had sales — the package's
+            // founding distinction inverted inside its most prominent encoding. Orders
+            // are exact and complete whatever the amounts say, so they are the row that
+            // is always honest.
+            {
               key: "orders",
               label: "Orders",
               source: "Sanity",
               complete: true,
               unit: "count",
+              // A sale is an event on a date, not a level that varies day to day.
               mark: "events",
               points: (data.crossSource ?? []).map((d) => ({ date: d.date, value: d.orders }))
-            }]
+            },
+            ...revenueCoversEveryOrder(data) ? [{
+              key: "revenue",
+              label: "Revenue",
+              source: "Sanity",
+              complete: true,
+              unit: "money",
+              mark: "events",
+              points: (data.crossSource ?? []).map((d) => ({ date: d.date, value: d.revenue }))
+            }] : []
           ]
         }
       ),
@@ -2679,6 +2703,12 @@ function SegmentTable({ segments, dimension }) {
     ] }) })
   ] });
 }
+function revenueCoversEveryOrder(data) {
+  const counted = metricSortValue(data.orders);
+  const withTotal = finiteOrNull(data.ordersWithTotal);
+  if (counted === null || withTotal === null) return false;
+  return counted === withTotal;
+}
 function JourneyPanel({ data }) {
   const segments = data.segments ?? [];
   const allSteps = data.steps ?? [];