@lightsage/mcp 0.4.17 → 0.4.19

package/test/tracker.test.js

@@ -313,11 +313,93 @@ test("OAuth sessions follow the user, not the token", async () => {
 });
 
 
-test("only failed calls and catalog tool results are stored", async () => {
+test("only failed calls, catalog tool results and feedback confirmations are stored", async () => {
   const { shouldStoreResponse } = await import("../lib/tracker.js");
   assert.equal(shouldStoreResponse({ toolName: "list_tools", isError: false }), true);
   assert.equal(shouldStoreResponse({ toolName: "describe_tool_input", isError: false }), true);
   assert.equal(shouldStoreResponse({ toolName: "execute_tool", isError: false }), false);
   assert.equal(shouldStoreResponse({ toolName: "get_profile", isError: false }), false);
   assert.equal(shouldStoreResponse({ toolName: "execute_tool", isError: true }), true);
+  assert.equal(shouldStoreResponse({ toolName: "send_feedback", isError: false }), true);
+});
+
+async function connectedClient(url, apiKey) {
+  const client = new Client({ name: "feedback-test", version: "1.0.0" });
+  await client.connect(
+    new StreamableHTTPClientTransport(url, {
+      fetch: realFetch,
+      requestInit: { headers: { "lightsage-api-key-auth": apiKey } },
+    }),
+  );
+  return client;
+}
+
+test("a recorded caller can send feedback, and MCP Analytics keeps its input and output", async () => {
+  await withServer(async (url) => {
+    const client = await connectedClient(new URL(url), "ls_feedback_key");
+    try {
+      const { tools } = await client.listTools();
+      const tool = tools.find((t) => t.name === "send_feedback");
+      assert.ok(tool, "send_feedback is listed");
+      assert.equal(tool.annotations.readOnlyHint, false);
+      assert.equal(tool.annotations.destructiveHint, false);
+      assert.deepEqual(tool.inputSchema.required, ["feedback"]);
+      assert.equal(tool.inputSchema.additionalProperties, false);
+
+      const before = sentEvents().length;
+      const result = await client.callTool({
+        name: "send_feedback",
+        arguments: { feedback: "  list_tools missed the visibility tools  " },
+      });
+      assert.ok(!result.isError);
+      assert.equal(result.content[0].text, "Feedback received. Thank you!");
+
+      const call = sentEvents().slice(before).find((e) =>
+        e.event === "$mcp_tool_call" && e.tool_name === "send_feedback"
+      );
+      assert.equal(call.parameters.feedback, "  list_tools missed the visibility tools  ");
+      assert.equal(call.response.content[0].text, "Feedback received. Thank you!");
+      assert.ok(!JSON.stringify(call).includes("ls_feedback_key"));
+    } finally {
+      await client.close();
+    }
+  });
+});
+
+test("feedback must be text within the limit, with no other fields", async () => {
+  const { MAX_FEEDBACK_LENGTH } = await import("../lib/feedback.js");
+  await withServer(async (url) => {
+    const client = await connectedClient(new URL(url), "ls_feedback_key");
+    try {
+      for (const args of [
+        {},
+        { feedback: "   " },
+        { feedback: "x".repeat(MAX_FEEDBACK_LENGTH + 1) },
+        { feedback: "ok", email: "a@example.com" },
+      ]) {
+        const result = await client.callTool({ name: "send_feedback", arguments: args });
+        assert.equal(result.isError, true, JSON.stringify(args).slice(0, 60));
+      }
+      const result = await client.callTool({
+        name: "send_feedback",
+        arguments: { feedback: "x".repeat(MAX_FEEDBACK_LENGTH) },
+      });
+      assert.ok(!result.isError);
+    } finally {
+      await client.close();
+    }
+  });
+});
+
+test("callers who are not recorded are not offered the feedback tool", async () => {
+  await withServer(async (url) => {
+    const client = await connectedClient(new URL(url), "ls_bad_unrecorded");
+    try {
+      const { tools } = await client.listTools();
+      assert.ok(tools.length > 0);
+      assert.ok(!tools.some((t) => t.name === "send_feedback"));
+    } finally {
+      await client.close();
+    }
+  });
 });