@lightningjs/blits 1.27.1 → 1.29.0

package/.github/workflows/comment-lint-results.yml

@@ -8,144 +8,118 @@ on:
 
 jobs:
   comment-lint-results:
-    # Only run this job if the previous workflow failed (indicating lint errors)
     if: github.event.workflow_run.conclusion == 'failure'
     runs-on: ubuntu-latest
     permissions:
       pull-requests: write
 
     steps:
-    - name: Download Lint Results
-      id: download
-      uses: actions/github-script@v6
-      with:
-        script: |
-          try {
-            core.info('Downloading lint results artifact');
-
-            const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              run_id: ${{ github.event.workflow_run.id }}
-            });
-
-            const matchArtifact = artifacts.data.artifacts.find(artifact => artifact.name === "lint-results");
-            if (!matchArtifact) {
-              core.setFailed('No lint results artifact found');
-              return false;
-            }
-
-            core.info(`Found artifact id: ${matchArtifact.id}`);
-
-            const download = await github.rest.actions.downloadArtifact({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              artifact_id: matchArtifact.id,
-              archive_format: 'zip'
-            });
+      - name: Download Lint Results
+        id: download
+        uses: actions/github-script@v6
+        with:
+          result-encoding: string
+          script: |
 
-            const fs = require('fs');
             try {
-              fs.writeFileSync('lint-results.zip', Buffer.from(download.data));
-              core.info('Successfully downloaded and saved artifact');
-              return true;
-            } catch (error) {
-              core.setFailed(`Failed to write artifact: ${error.message}`);
-              return false;
-            }
-          } catch (error) {
-            core.setFailed(`Failed to download artifact: ${error.message}`);
-            return false;
-          }
-        result-encoding: string
-
-    - name: Extract Lint Results
-      if: steps.download.outputs.result == 'true'
-      id: extract
-      run: |
-        mkdir -p lint-results
-        unzip -o lint-results.zip -d lint-results
-
-        if [ -f lint-results/errors.md ]; then
-          # Use GitHub's EOF syntax for multiline content
-          echo "LINT_ERRORS<<EOF" >> $GITHUB_ENV
-          cat lint-results/errors.md >> $GITHUB_ENV
-          echo "EOF" >> $GITHUB_ENV
-          echo "HAS_ERRORS=true" >> $GITHUB_OUTPUT
-        else
-          echo "HAS_ERRORS=false" >> $GITHUB_OUTPUT
-        fi
-
-    - name: Find PR Number
-      if: steps.extract.outputs.HAS_ERRORS == 'true'
-      id: find-pr
-      uses: actions/github-script@v6
-      with:
-        script: |
-          try {
-            core.info('Finding associated PR');
-
-            const { owner, repo } = context.repo;
-            const run_id = ${{ github.event.workflow_run.id }};
-
-            // Get the triggering workflow run
-            const run = await github.rest.actions.getWorkflowRun({
-              owner,
-              repo,
-              run_id
-            });
-
-            // Find associated PR - first try the event payload
-            if (run.data.pull_requests && run.data.pull_requests.length > 0) {
-              core.info(`Found PR directly from run data: #${run.data.pull_requests[0].number}`);
-              return run.data.pull_requests[0].number;
-            }
-
-            // Fallback to searching by head SHA
-            core.info(`Searching for PR using head SHA: ${run.data.head_sha}`);
-            const pulls = await github.rest.pulls.list({
-              owner,
-              repo,
-              state: 'open',
-              head: `${owner}:${run.data.head_branch}`
-            });
-
-            if (pulls.data.length > 0) {
-              core.info(`Found PR by branch: #${pulls.data[0].number}`);
-              return pulls.data[0].number;
+              core.info('Downloading lint-results artifact');
+              const runId = context.payload.workflow_run.id;
+
+              const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                run_id: runId
+              });
+
+              const art = artifacts.data.artifacts.find(a => a.name === "lint-results");
+              if (!art) {
+                core.setFailed('No lint-results artifact found');
+                return 'false';
+              }
+
+              core.info(`Found artifact id ${art.id}, downloading…`);
+              const dl = await github.rest.actions.downloadArtifact({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                artifact_id: art.id,
+                archive_format: 'zip'
+              });
+
+              require('fs').writeFileSync('lint-results.zip', Buffer.from(dl.data));
+              core.info('Downloaded and saved lint-results.zip');
+              return 'true';
+
+            } catch (err) {
+              core.setFailed(`Download failed: ${err.message}`);
+              return 'false';
             }
 
-            core.info('No PR found for this workflow run');
-            return null;
-          } catch (error) {
-            core.setFailed(`Failed to find PR: ${error.message}`);
-            return null;
-          }
-        result-encoding: string
-
-    - name: Post Lint Results as PR Comment
-      if: steps.find-pr.outputs.result != 'null' && steps.find-pr.outputs.result != ''
-      uses: actions/github-script@v6
-      with:
-        script: |
-          try {
-            const pr_number = parseInt(${{ steps.find-pr.outputs.result }});
-
-            if (isNaN(pr_number)) {
-              core.warning('Invalid PR number');
-              return;
-            }
-
-            core.info(`Posting comment to PR #${pr_number}`);
-
-            await github.rest.issues.createComment({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: pr_number,
-              body: process.env.LINT_ERRORS
-            });
-
-            core.info(`Successfully posted lint errors comment to PR #${pr_number}`);
-          } catch (error) {
-            core.setFailed(`Failed to post comment: ${error.message}`);
-          }
+      - name: Extract Lint Results
+        if: steps.download.outputs.result == 'true'
+        id: extract
+        run: |
+          mkdir -p extracted
+          unzip -o lint-results.zip -d extracted
+
+          # Read PR information
+          if [ -f extracted/pr_number.txt ]; then
+            echo "PR_NUMBER=$(cat extracted/pr_number.txt)" >> $GITHUB_ENV
+          else
+            echo "PR_NUMBER=0" >> $GITHUB_ENV
+          fi
+
+          if [ -f extracted/errors.md ] || [ -f extracted/lint-results/errors.md ]; then
+            if [ -f extracted/errors.md ]; then
+              # Handle flat structure
+              echo "LINT_ERRORS<<EOF" >> $GITHUB_ENV
+              cat extracted/errors.md >> $GITHUB_ENV
+              echo "EOF" >> $GITHUB_ENV
+            else
+              # Handle nested structure
+              echo "LINT_ERRORS<<EOF" >> $GITHUB_ENV
+              cat extracted/lint-results/errors.md >> $GITHUB_ENV
+              echo "EOF" >> $GITHUB_ENV
+            fi
+            echo "HAS_ERRORS=true" >> $GITHUB_OUTPUT
+          else
+            echo "HAS_ERRORS=false" >> $GITHUB_OUTPUT
+          fi
+
+      - name: Post Lint Results as PR Comment
+        if: steps.extract.outputs.HAS_ERRORS == 'true'
+        uses: actions/github-script@v6
+        with:
+          script: |
+            try {
+              // First check if PR number was passed from the lint workflow
+              let prNumber = parseInt(process.env.PR_NUMBER);
+
+              // Fallback to the workflow_run PR data if available
+              if (!prNumber || isNaN(prNumber) || prNumber === 0) {
+                const pulls = context.payload.workflow_run.pull_requests;
+                core.info(`Looking for PR information in workflow_run: Found ${pulls.length} PR(s)`);
+
+                if (pulls.length === 0) {
+                  core.warning('No pull request information found. Skipping comment.');
+                  return;
+                }
+
+                prNumber = pulls[0].number;
+              }
+
+              core.info(`Posting lint errors comment to PR #${prNumber}`);
+
+              const body = process.env.LINT_ERRORS;
+
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: prNumber,
+                body
+              });
+
+              core.info('Lint errors comment posted successfully');
+            } catch (err) {
+              core.error('Failed to post lint comment:', err);
+              core.setFailed(err.message);
+            }

package/.github/workflows/comment-test-results.yml

@@ -3,8 +3,7 @@ name: Comment Test Results
 on:
   workflow_run:
     workflows: ["Run Blits Tests"]
-    types:
-      - completed
+    types: [completed]
 
 jobs:
   comment-test-results:
@@ -13,102 +12,98 @@ jobs:
       pull-requests: write
 
     steps:
-    - name: Download Test Results
-      uses: actions/github-script@v6
-      with:
-        script: |
-          const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            run_id: ${{ github.event.workflow_run.id }}
-          });
-
-          const matchArtifact = artifacts.data.artifacts.find(artifact => artifact.name === "test-results");
-          if (!matchArtifact) {
-            core.setFailed('No test results artifact found');
-            return;
-          }
-
-          const download = await github.rest.actions.downloadArtifact({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            artifact_id: matchArtifact.id,
-            archive_format: 'zip'
-          });
-
-          const fs = require('fs');
-          fs.writeFileSync('test-results.zip', Buffer.from(download.data));
-
-    - name: Extract Test Results
-      run: |
-        mkdir -p test-results
-        unzip -o test-results.zip -d test-results
-
-        TIMESTAMP=$(cat test-results/timestamp.txt)
-        SUMMARY=$(cat test-results/summary.txt)
-        FAILED=$(cat test-results/failed.txt)
-
-        echo "TIMESTAMP=$TIMESTAMP" >> $GITHUB_ENV
-        echo "SUMMARY=$SUMMARY" >> $GITHUB_ENV
-        echo "FAILED=$FAILED" >> $GITHUB_ENV
-
-        # Check if error.txt exists and read it if it does
-        if [ -f test-results/error.txt ]; then
-          # Store raw error output in a file for the next step
-          cat test-results/error.txt > raw_error.txt
-        fi
-
-    - name: Find PR Number
-      id: find-pr
-      uses: actions/github-script@v6
-      with:
-        script: |
-          const { owner, repo } = context.repo;
-          const run_id = ${{ github.event.workflow_run.id }};
-
-          // Get the triggering workflow run
-          const run = await github.rest.actions.getWorkflowRun({
-            owner,
-            repo,
-            run_id
-          });
-
-          // Find associated PR
-          const pulls = await github.rest.pulls.list({
-            owner,
-            repo,
-            state: 'open',
-            head: run.data.head_sha
-          });
-
-          if (pulls.data.length > 0) {
-            return pulls.data[0].number;
-          }
-
-          console.log('No PR found');
-          return null;
-        result-encoding: string
-
-    - name: Post Test Results as PR Comment
-      if: steps.find-pr.outputs.result != 'null'
-      uses: actions/github-script@v6
-      with:
-        script: |
-          const fs = require('fs');
-          const pr_number = parseInt(${{ steps.find-pr.outputs.result }});
-          const status = process.env.FAILED === 'true' ? '❌ FAILED' : '✅ PASSED';
-
-          let commentBody = `#### Test Results: ${status}\n**Run at:** ${process.env.TIMESTAMP}\n\n**Summary:**\n${process.env.SUMMARY}`;
-
-          // Add error output if it exists
-          if (fs.existsSync('raw_error.txt')) {
-            const errorOutput = fs.readFileSync('raw_error.txt', 'utf8');
-            commentBody += '\n\n**Error Output:**\n```\n' + errorOutput + '\n```';
-          }
-
-          github.rest.issues.createComment({
-            owner: context.repo.owner,
-            repo: context.repo.repo,
-            issue_number: pr_number,
-            body: commentBody
-          });
+      - name: Download Test Results
+        uses: actions/github-script@v6
+        with:
+          script: |
+            const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              run_id: ${{ github.event.workflow_run.id }}
+            });
+            const art = artifacts.data.artifacts.find(a => a.name === "test-results");
+            if (!art) {
+              core.setFailed('No test-results artifact found');
+              return;
+            }
+            const dl = await github.rest.actions.downloadArtifact({
+              owner: context.repo.owner,
+              repo: context.repo.repo,
+              artifact_id: art.id,
+              archive_format: 'zip'
+            });
+            require('fs').writeFileSync('test-results.zip', Buffer.from(dl.data));
+
+      - name: Extract Test Results
+        run: |
+
+          mkdir -p extracted
+          unzip -o test-results.zip -d extracted
+
+          # Set environment variables from the extracted files
+          echo "TIMESTAMP=$(cat extracted/timestamp.txt)" >> $GITHUB_ENV
+          echo "SUMMARY=$(cat extracted/summary.txt)" >> $GITHUB_ENV
+          echo "FAILED=$(cat extracted/failed.txt)" >> $GITHUB_ENV
+
+          # Read PR information
+          if [ -f extracted/pr_number.txt ]; then
+            echo "PR_NUMBER=$(cat extracted/pr_number.txt)" >> $GITHUB_ENV
+          else
+            echo "PR_NUMBER=0" >> $GITHUB_ENV
+          fi
+
+
+          # Copy error file if it exists
+          if [ -f extracted/error.txt ]; then
+            cp extracted/error.txt raw_error.txt
+          fi
+
+      - name: Post Test Results as PR Comment
+        uses: actions/github-script@v6
+        with:
+          script: |
+            const fs = require('fs');
+
+            try {
+              // First check if PR number was passed from the test workflow
+              let prNumber = parseInt(process.env.PR_NUMBER);
+
+              // Fallback to the workflow_run PR data if available
+              if (!prNumber || isNaN(prNumber) || prNumber === 0) {
+                const pulls = context.payload.workflow_run.pull_requests;
+                console.log(`Looking for PR information in workflow_run: Found ${pulls.length} PR(s).`);
+
+                if (pulls.length === 0) {
+                  console.warn('No pull request information found. Skipping comment.');
+                  return;
+                }
+
+                prNumber = pulls[0].number;
+              }
+
+              console.log(`Posting comment to PR #${prNumber}`);
+
+              const status = process.env.FAILED === 'true' ? '❌ FAILED' : '✅ PASSED';
+              let commentBody = `#### Test Results: ${status}\n`
+                              + `**Run at:** ${process.env.TIMESTAMP}\n\n`
+                              + `**Summary:**\n${process.env.SUMMARY}`;
+
+              if (fs.existsSync('raw_error.txt')) {
+                commentBody += '\n\n**Error Output:**\n```\n'
+                             + fs.readFileSync('raw_error.txt', 'utf8')
+                             + '\n```';
+              }
+
+              await github.rest.issues.createComment({
+                owner: context.repo.owner,
+                repo: context.repo.repo,
+                issue_number: prNumber,
+                body: commentBody
+              });
+
+              console.log(`Successfully posted comment to PR #${prNumber}`);
+
+            } catch (err) {
+              console.error('🛑 Failed to post test results comment:', err);
+              core.setFailed(`Comment step failed: ${err.message}`);
+            }

package/.github/workflows/run-blits-tests.yml

@@ -21,6 +21,12 @@ jobs:
       with:
         node-version: 20.16.0
 
+    - name: Save PR Information
+      run: |
+        echo '${{ github.event.pull_request.number }}' > ./pr_number.txt
+        echo '${{ github.event.pull_request.head.repo.full_name }}' > ./pr_repo.txt
+        echo '${{ github.event.pull_request.head.ref }}' > ./pr_branch.txt
+
     - name: Install Dependencies
       run: npm install
 
@@ -91,18 +97,14 @@ jobs:
            * Outputs results and saves result files
            */
           function outputResults(results) {
-            // Create test results directory and files
             try {
-              fs.mkdirSync('./test-results', { recursive: true });
-
-              // Write results files
-              fs.writeFileSync('./test-results/timestamp.txt', results.timestamp);
-              fs.writeFileSync('./test-results/summary.txt', results.summary);
-              fs.writeFileSync('./test-results/failed.txt', results.testsFailed.toString());
+              fs.writeFileSync('./timestamp.txt', results.timestamp);
+              fs.writeFileSync('./summary.txt', results.summary);
+              fs.writeFileSync('./failed.txt', results.testsFailed.toString());
 
               // Save error output if it exists
               if (results.error) {
-                fs.writeFileSync('./test-results/error.txt', results.error);
+                fs.writeFileSync('./error.txt', results.error);
               }
             } catch (err) {
               console.error('Error saving test results:', err);
@@ -124,7 +126,15 @@ jobs:
       uses: actions/upload-artifact@v4
       with:
         name: test-results
-        path: ./test-results/
+        path: |
+
+          ./timestamp.txt
+          ./summary.txt
+          ./failed.txt
+          ./error.txt
+          ./pr_number.txt
+          ./pr_repo.txt
+          ./pr_branch.txt
 
     # Fail the workflow if tests failed
     - name: Check Test Status

package/.github/workflows/run-lint.yml

@@ -19,6 +19,12 @@ jobs:
         # Needed to compare changes against base branch
         fetch-depth: 0
 
+    - name: Save PR Information
+      run: |
+        echo '${{ github.event.pull_request.number }}' > ./pr_number.txt
+        echo '${{ github.event.pull_request.head.repo.full_name }}' > ./pr_repo.txt
+        echo '${{ github.event.pull_request.head.ref }}' > ./pr_branch.txt
+
     - name: Set up Node.js
       uses: actions/setup-node@v3
       with:
@@ -110,7 +116,11 @@ jobs:
       uses: actions/upload-artifact@v4
       with:
         name: lint-results
-        path: ./lint-results/
+        path: |
+          ./lint-results/
+          ./pr_number.txt
+          ./pr_repo.txt
+          ./pr_branch.txt
 
     # Fail the workflow if linting errors found
     - name: Check Lint Status

package/CHANGELOG.md

@@ -1,5 +1,20 @@
 # Changelog
 
+_22 may 2025_
+
+## v1.29.0
+
+- Fixed memory leaks
+- Added componentId in warning when modifying props directly for easier debugging
+
+_15 apr 2025_
+
+## v1.28.0
+
+- Added graceful handling of announcer when speechSynthesis API is not available
+- Renamed `beforeAll` method on router to `beforeEach` (as specified in the type definitions)
+- Fixed detection of correct PR to comment for github workflows
+
 _15 apr 2025_
 
 ## v1.27.1

package/docs/built-in/for-loop.md

@@ -168,3 +168,37 @@ Generally it's not recommended to access and interact directly with Elements in
 The `ref`-attribute can be used in combination with the `for`-attribute as well.
 
 Setting the _ref_ in a for loop context, can be done by either passing a string (i.e. `myitem`) and as Elements get generated in the for loop, the `index` value will be appended to it (i.e. `myitem0`, `myitem1`, etc.). Alternatively you can make the attribute interpolated and define the value for each item yourself (i.e. `:ref="'item' + $item.id"`).
+
+## Using the range attribute
+
+Sometimes you may only need to render a portion of an array rather than all the items.
+
+To do this you can use the `range` variable to specify a subset of items to render. You should specify a `from` and `to` value (`from` is inclusive, and `to` is exclusive) inside the `range` variable (i.e. `range="{from: 0, to: 2}"`).  You can also make the variable reactive, and use moving pointers to dynamically render your items.
+
+This works differently to using the `show` directive on the items, as the items will be destroyed once they are outside the range, and created again when they fall back in it.
+
+```js
+export default Blits.Component('ForLoop', {
+  template: `
+    <Element>
+      <Element :for="(item, index) in $items" :range="{from: $selected - 1, to: $selected + 2}" w="100" h="100" color="lime" :x="$index * 150" />
+    </Element>
+  `,
+  state() {
+    return {
+      selected: 0,
+      items: ['Item 1', 'Item 2', 'Item 3', 'Item 4', 'Item 5', 'Item 6', 'Item 7']
+    }
+  },
+  input: {
+    left() {
+      this.selected = Math.max(0, this.selected - 1)
+    },
+    right() {
+      this.selected = Math.min(this.items.length, this.selected + 1)
+    }
+  }
+})
+```
+
+In the example above, there are 7 items in the array, but we only render the items immediately before and after the selected item at any time.

package/index.d.ts

@@ -23,7 +23,7 @@ import {type ShaderEffect as RendererShaderEffect, type WebGlCoreShader, type Re
 declare module '@lightningjs/blits' {
 
 
-  export interface AnnouncerUtterance extends Promise {
+  export interface AnnouncerUtterance extends Promise<T> {
     /**
      * Removes a specific message from the announcement queue,
      * to make sure it isn't spoke out.
@@ -481,7 +481,7 @@ declare module '@lightningjs/blits' {
   }
 
   export interface RouterHooks {
-    beforeEach?: (to: Route, from: Route) => string | Route | Promise<string | Route>;
+    beforeEach?: (to: Route, from: Route) => string | Route | Promise<string | Route> | void;
   }
 
   export interface RouterConfig {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/blits",
-  "version": "1.27.1",
+  "version": "1.29.0",
   "description": "Blits: The Lightning 3 App Development Framework",
   "bin": "bin/index.js",
   "exports": {

package/src/announcer/speechSynthesis.js

@@ -15,6 +15,8 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
+import { Log } from '../lib/log.js'
+
 const syn = window.speechSynthesis
 
 const isAndroid = /android/i.test((window.navigator || {}).userAgent || '')
@@ -82,14 +84,21 @@ const speak = (options) => {
 
 export default {
   speak(options) {
-    if (!initialized) {
-      initialize()
+    if (syn !== undefined) {
+      if (initialized === false) {
+        initialize()
+      }
+      return speak(options)
+    } else {
+      Log.error('speechSynthesis web API not available')
+      return Promise.reject({ error: 'unavailable' })
     }
-    return speak(options)
   },
   cancel() {
-    syn.cancel()
-    clear()
+    if (syn !== undefined) {
+      syn.cancel()
+      clear()
+    }
   },
   // @todo
   // getVoices() {

package/src/component/base/methods.js

@@ -57,10 +57,36 @@ export default {
       this.$clearIntervals()
       eventListeners.removeListeners(this)
       deleteChildren(this[symbols.children])
+      this[symbols.children].length = 0
       removeGlobalEffects(this[symbols.effects])
       this[symbols.state] = {}
       this[symbols.props] = {}
+      this[symbols.computed] = null
+      this.lifecycle = null
       this[symbols.effects].length = 0
+      this.parent = null
+      this.rootParent = null
+      this[symbols.wrapper] = null
+      this[symbols.originalState] = null
+      this[symbols.slots].length = 0
+
+      delete this[symbols.computed]
+      delete this.lifecycle
+      delete this[symbols.effects]
+      delete this.parent
+      delete this.rootParent
+      delete this[symbols.wrapper]
+      delete this[symbols.originalState]
+      delete this[symbols.children]
+      delete this[symbols.slots]
+      delete this.componentId
+      delete this[symbols.id]
+      delete this.ref
+
+      this[symbols.holder].destroy()
+      this[symbols.holder] = null
+      delete this[symbols.holder]
+
       Log.debug(`Destroyed component ${this.componentId}`)
     },
     writable: false,

package/src/component/setup/props.js

@@ -52,7 +52,9 @@ export default (component, props = []) => {
         return value
       },
       set(v) {
-        Log.warn(`Warning! Avoid mutating props directly (${prop.key})`)
+        Log.warn(
+          `Warning! Avoid mutating props directly (prop "${prop.key}" in component "${this.componentId}")`
+        )
         this[symbols.props][prop.key] = v
       },
     })

package/src/component/setup/props.test.js

@@ -223,7 +223,7 @@ test('Setting prop value directly', (assert) => {
   assert.equal(componentInstance[symbols.props].property, 'bar', 'Should be possible to mutate the property')
   let logs = capture()
   assert.equal(logs.length, 1)
-  assert.equal(logs[0].args.pop(), 'Warning! Avoid mutating props directly (property)', 'Should log warning message')
+  assert.equal(logs[0].args.pop(), `Warning! Avoid mutating props directly (prop "${props[0].key}" in component "${componentInstance.componentId}")`, 'Should log warning message')
 
   assert.end()
 })

package/src/components/FPScounter.js

@@ -1492,18 +1492,19 @@ export default () =>
         let totalFps = 0
         let fpsUpdateCounter = 0
 
-        renderer.on('fpsUpdate', (rM, { fps }) => {
-          minFps = Math.min(fps, minFps)
-          maxFps = Math.max(fps, maxFps)
-          totalFps += fps
-          fpsUpdateCounter++
-          avgFps = Math.round(totalFps / fpsUpdateCounter)
-
-          this.fps = fps.toString().padStart(3, '0')
-          this.avgFps = avgFps.toString().padStart(3, '0')
-          this.minFps = minFps.toString().padStart(3, '0')
-          this.maxFps = maxFps.toString().padStart(3, '0')
-        })
+        // This leaks - might be L3 SubTexture issue
+        // renderer.on('fpsUpdate', (rM, { fps }) => {
+        //   minFps = Math.min(fps, minFps)
+        //   maxFps = Math.max(fps, maxFps)
+        //   totalFps += fps
+        //   fpsUpdateCounter++
+        //   avgFps = Math.round(totalFps / fpsUpdateCounter)
+
+        //   this.fps = fps.toString().padStart(3, '0')
+        //   this.avgFps = avgFps.toString().padStart(3, '0')
+        //   this.minFps = minFps.toString().padStart(3, '0')
+        //   this.maxFps = maxFps.toString().padStart(3, '0')
+        // })
       },
     },
   })

package/src/components/FPScounter.orig.js

@@ -103,18 +103,19 @@ export default () =>
         let totalFps = 0
         let fpsUpdateCounter = 0
 
-        renderer.on('fpsUpdate', (rM, { fps }) => {
-          minFps = Math.min(fps, minFps)
-          maxFps = Math.max(fps, maxFps)
-          totalFps += fps
-          fpsUpdateCounter++
-          avgFps = Math.round(totalFps / fpsUpdateCounter)
+        // This leaks - might be L3 SubTexture issue
+        // renderer.on('fpsUpdate', (rM, { fps }) => {
+        //   minFps = Math.min(fps, minFps)
+        //   maxFps = Math.max(fps, maxFps)
+        //   totalFps += fps
+        //   fpsUpdateCounter++
+        //   avgFps = Math.round(totalFps / fpsUpdateCounter)
 
-          this.fps = fps.toString().padStart(3, '0')
-          this.avgFps = avgFps.toString().padStart(3, '0')
-          this.minFps = minFps.toString().padStart(3, '0')
-          this.maxFps = maxFps.toString().padStart(3, '0')
-        })
+        //   this.fps = fps.toString().padStart(3, '0')
+        //   this.avgFps = avgFps.toString().padStart(3, '0')
+        //   this.minFps = minFps.toString().padStart(3, '0')
+        //   this.maxFps = maxFps.toString().padStart(3, '0')
+        // })
       },
     },
   })

package/src/engines/L3/element.js

@@ -620,6 +620,8 @@ const Element = {
     f.start()
   },
   destroy() {
+    if (this.node === null) return
+
     Log.debug('Deleting  Node', this.nodeId)
     this.node.destroy()
 
@@ -632,6 +634,9 @@ const Element = {
         if (transition.f !== undefined) transition.f.stop()
       }
     }
+
+    // remove node reference
+    this.node = null
   },
   get nodeId() {
     return this.node && this.node.id

package/src/router/router.js

@@ -134,7 +134,7 @@ export const navigate = async function () {
   Announcer.clear()
   state.navigating = true
   if (this.parent[symbols.routes]) {
-    let previousRoute = currentRoute ? Object.assign({}, currentRoute) : undefined
+    let previousRoute = currentRoute //? Object.assign({}, currentRoute) : undefined
     const { hash, path, queryParams } = getHash()
     let route = matchHash(path, this.parent[symbols.routes])
 
@@ -148,8 +148,8 @@ export const navigate = async function () {
       let beforeEachResult
       if (this.parent[symbols.routerHooks]) {
         const hooks = this.parent[symbols.routerHooks]
-        if (hooks.beforeAll) {
-          beforeEachResult = await hooks.beforeAll(route, previousRoute)
+        if (hooks.beforeEach) {
+          beforeEachResult = await hooks.beforeEach(route, previousRoute)
           if (isString(beforeEachResult)) {
             to(beforeEachResult)
             return
@@ -290,8 +290,6 @@ export const navigate = async function () {
         if (oldView) {
           removeView(previousRoute, oldView, route.transition.out)
         }
-
-        previousRoute = undefined
       }
 
       state.path = route.path
@@ -358,16 +356,16 @@ const removeView = async (route, view, transition) => {
 
 const setOrAnimate = (node, transition, shouldAnimate = true) => {
   return new Promise((resolve) => {
-    if (shouldAnimate) {
+    if (shouldAnimate === true) {
       // resolve the promise in the transition end-callback
       // ("extending" end callback when one is already specified)
-      const existingEndCallback = transition.end
-      transition.end = existingEndCallback
-        ? (...args) => {
-            existingEndCallback(...args)
-            resolve()
-          }
-        : resolve
+      let existingEndCallback = transition.end
+      transition.end = (...args) => {
+        existingEndCallback && existingEndCallback(args)
+        // null the callback to enable memory cleanup
+        existingEndCallback = null
+        resolve()
+      }
       node.set(transition.prop, { transition })
     } else {
       node.set(transition.prop, transition.value)