@lightningjs/blits 1.20.0 → 1.20.1

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## v1.20.1
+
+_14 feb 2025_
+
+- Added error message when root element in template contains a `:for`-attribute
+- Added workaround fix for shader caching issue
+- Upgraded to renderer v2.12.1
+
 ## v1.20.0
 
 _12 feb 2025_

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lightningjs/blits",
-  "version": "1.20.0",
+  "version": "1.20.1",
   "description": "Blits: The Lightning 3 App Development Framework",
   "bin": "bin/index.js",
   "exports": {
@@ -52,7 +52,7 @@
   },
   "dependencies": {
     "@lightningjs/msdf-generator": "^1.1.1",
-    "@lightningjs/renderer": "^2.12.0"
+    "@lightningjs/renderer": "^2.12.1"
   },
   "repository": {
     "type": "git",

package/src/engines/L3/element.js

@@ -22,6 +22,9 @@ import { Log } from '../../lib/log.js'
 import symbols from '../../lib/symbols.js'
 import Settings from '../../settings.js'
 
+// temporary counter to work around shader caching issues
+let counter = 0
+
 const createPaddingObject = (padding, direction) => {
   if (padding === undefined) {
     return { start: 0, end: 0, oppositeStart: 0, oppositeEnd: 0 }
@@ -330,14 +333,21 @@ const propsTransformer = {
     if (this.element.node === undefined) {
       this.props['shader'] = renderer.createShader('DynamicShader', {
         effects: v.map((effect) => {
-          return renderer.createEffect(effect.type, effect.props, effect.type)
+          // temporary add counter to work around shader caching issues
+          return renderer.createEffect(
+            effect.type,
+            effect.props,
+            effect.type + this.element.counter
+          )
         }),
       })
     } else {
       for (let i = 0; i < v.length; i++) {
-        const target = this.element.node.shader.props[v[i].type]
+        // temporary add counter to work around shader caching issues
+        const target = this.element.node.shader.props[v[i].type + this.element.counter]
         const props = Object.keys(v[i].props)
 
+        if (target == undefined) continue
         for (let j = 0; j < props.length; j++) {
           target[props[j]] = v[i].props[props[j]]
         }
@@ -642,5 +652,6 @@ export default (config, component) => {
     scheduledTransitions: {},
     config,
     component,
+    counter: counter++,
   })
 }

package/src/lib/templateparser/parser.js

@@ -239,6 +239,7 @@ export default (template = '', componentName, parentComponent, filePath = null)
     #2: There must be exactly one top-level element (an element at level 0). This element may either be a self-closing
         element or an opening tag followed by a closing tag. If more than one top-level element is encountered, an error
         should be thrown.
+        But the top-level element can not have :for attribute.
   */
   const format = (parsedData) => {
     let stack = []
@@ -254,6 +255,10 @@ export default (template = '', componentName, parentComponent, filePath = null)
         if (rootElementDefined) {
           throw TemplateStructureError('MultipleTopLevelTags', element)
         }
+        // Check for :for attribute on root level element
+        if (element[':for'] !== undefined) {
+          throw TemplateStructureError('ForAttributeOnRootElement', element)
+        }
         rootElementDefined = true
       }
 

package/src/lib/templateparser/parser.test.js

@@ -1388,3 +1388,24 @@ test('Parse template with color and effects attributes and parsing should conver
   )
   assert.end()
 })
+
+test('Parse template with :for attribute on root element and parsing should fail', (assert) => {
+  const template = `
+  <Element :for="item in $items">
+    <Text content="$item.name" />
+  </Element>
+  `
+
+  try {
+    parser(template)
+    assert.fail('Parser should throw TemplateStructureError:ForAttributeOnRootElement')
+  } catch (error) {
+    assert.equal(error.name, 'TemplateStructureError', 'Parser should throw TemplateStructureError')
+    assert.ok(
+      error.message.startsWith('ForAttributeOnRootElement'),
+      'Parser should throw TemplateStructureError:ForAttributeOnRootElement'
+    )
+  }
+
+  assert.end()
+})